[PATCH] Reopen libao device handles when audio parameters change.

[Hynek Hanke]

On 1.9.2010 10:12, Christopher Brannon wrote:
> static int?
>> probably we even could use ao_sample_format instead?
>>      
> I'll change this when I resend.
>    

Hi Chris,

this would be my only small concern with this patch. I'd still like to 
include
it in 0.7.1 Beta version. Should I use the patch as is or are you planning
to resubmit an updated version during during Thursday?

> Functions aren't just good for reuse.  IMHO, separating code into
> smaller functions aids readability.

Yes.

As for resampling, if the audio system can do resampling, it is definitely
its task, not ours. The audio system needs to resample all incomming data
to a common frequency anyway for the purpose of mixing them together.
So one cannot actually do much more than let it know what is the frequency
of the data we are sending. Your approach is fully correct I think.

Best regards,
Hynek Hanke