[PATCH 4/4] create a library of common routines

[Andrei Kholodnyi]

Hi William,

your first 3 patches look good to me, however I didn't yet tested
whether they apply cleanly.

Concerning your patch #4.
would it possible to split it in three patches as you have described
in your comments?

patch #1
> Move the code in the intl/ subdirectory to src/common and convert it
> into a convenience library so that it can be linked with the modules and
> server.

patch #2
> Move the include files from intl/ to include/ so that they can be easily
> included by the server and modules.

patch #3
> Rename intl/fdset.h to include/speechd_types.h since this better
> describes the contents of the file. ?These types are to be shared
> between the server and modules.

also there are 5 occurences of fdset and 5 occurences of intl in
speech-dispatcher.texi and you modified only one and two respectively.

Thanks,
Andrei.

> ?doc/speech-dispatcher.texi ? ?| ? ?4 +-
> --- a/doc/speech-dispatcher.texi
> +++ b/doc/speech-dispatcher.texi
> @@ -2648,7 +2648,7 @@ corresponding SSIP commands, except that they are 
> written with small
> ?letters. @xref{Top,,Parameter Setting Commands,ssip, SSIP
> ?Documentation}. ?The conversion between these string values and the
> ?corresponding C enum variables can be easily done using
> - at file{intl/fdsetconv.c}.
> + at file{src/common/fdsetconv.c}.
>
> ?Not all of these parameters must be set and the value of the string
> ?arguments can also be @code{NULL}. If some of the parameters aren't
> @@ -3055,7 +3055,7 @@ differently, if the synthesizer supports it).
>
> ?Each output module should take care of setting the output device to
> ?the parameters from msg_settings (defined in module_utils.h) (See
> -SPDMsgSettings in @file{intl/fdset.h}). However, it is not an error if
> +SPDMsgSettings in @file{module_utils.h}). However, it is not an error if
> ?some of these values are ignored. At least rate, pitch and language
> ?should be set correctly.