speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Rework the do_list_voices function, and fix a memory leak.


From: Andrei Kholodnyi
Subject: [PATCH] Rework the do_list_voices function, and fix a memory leak.
Date: Thu, 16 Sep 2010 13:04:45 +0200

> Possibly, but every voice must have a name. ?Otherwise, one cannot
> select it. ?I'd say that (voices[i]->name == NULL) is an error
> condition which should never occur.

It could occur.
I can intentionally put such list of voices to do e.g., a DOS attack
on speech-dispatcher.

I think we probably need to put a following check
if (voices[i]->name == NULL) {
   print error;
   skip voice;
}

you are right that voice shall have a name.
now, since modules can be added dynamically during runtime and we even
don't know what these modules could be,
it is a reasonable check here.

if you decide to do this change, could you also fix a debug message
DBG("Voice prepared to  sens to speechd");



reply via email to

[Prev in Thread] Current Thread [Next in Thread]