speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 4/7] replace EVoiceType with SPDVoiceType


From: Christopher Brannon
Subject: [PATCH 4/7] replace EVoiceType with SPDVoiceType
Date: Thu, 04 Nov 2010 13:22:53 +0000

Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:

> There is a small problem...
> it is possible to set in the module  either voice or synthesis_voice or both.
> now what setting has a preference?
> At the moment it is resolved in a way that in each synth module we have e.g.
>       UPDATE_PARAMETER(voice, espeak_set_voice);
>       UPDATE_STRING_PARAMETER(synthesis_voice, espeak_set_synthesis_voice);
*SNIP*
> It looks like we need to move UPDATE statements to the module_utils
> and not rely on synth implementation.

Yes, this seems good to me.  We need to be consistent.

> Do we what that synth_voice has a preference over voice settings?
> I think this is a behavior now and we want probably stick with it

This makes the most sense to me.
It would be nice if we could do away with "synthesis voice" entirely,
but we can't.  I'd say that if a client specifies an explicit synthesis
voice, then this overrides any other voice selection.
Thoughts?

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101104/99ef468b/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]