[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/3] add cancel long message test
From: |
Christopher Brannon |
Subject: |
[PATCH 1/3] add cancel long message test |
Date: |
Thu, 11 Nov 2010 11:43:15 +0000 |
Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:
> test produces a long message and then cancels it after 5 secs.
> test waits for the SPD_EVENT_CANCEL to verify it was cancelled.
Hi Andrei,
I like these. Here are my comments.
1. There's a typo in an error message. The message says that we can't
set the data mode to SSML, when in fact, we're trying to set it to
text. I can fix this before pushing.
2. If you want to use the text from the long_message test in multiple
tests, it should be put in its own file.
Perhaps teststrings.c, with a corresponding teststrings.h?
Let me know what you think.
-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101111/8de291e4/attachment.pgp>