[PATCH 2/2] remove output_modules_list

[Christopher Brannon]

Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:

> output_modules_list kept ouput module names
> and was duplicated with output_modules hash table.
> Now everywhere output_modules is used instead

Hi Andrei,
I like this patch!
There's only one area where I can find fault.
In the current code, the output modules list has the same order of
modules as given in the config file.
For example, suppose that the config file looks like this.

AddModule "espeak" # Remaining parameters of AddModule not shown here.
AddModule "pico"
AddModule "festival"
AddModule "flite"
...

Our list will look like:
["espeak", "pico", "festival", "flite"].
This affects the order in which modules are tried in case one of them
fails.  When the list of module names is generated from the keys of the
hash table, ordering is lost.
Here's my question, mainly directed to you and Hynek.
Is this ordering important?  Do we want to preserve it?

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101113/1afa85ca/attachment.pgp>