[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/3] move loading of modules out of the AddModule call back
From: |
Christopher Brannon |
Subject: |
[PATCH 2/3] move loading of modules out of the AddModule call back |
Date: |
Fri, 19 Nov 2010 11:40:53 +0000 |
Andrei Kholodnyi <andrei.kholodnyi at gmail.com> writes:
> On Thu, Nov 18, 2010 at 12:40 PM, Trevor Saunders
> <trev.saunders at gmail.com> wrote:
>> We know use the AddModule call back to create a list of modules we wnat
>> to try and load. ?Then after parsing the config file we try to load all
>> the modules.
*SNIP lots of diff*
> I do not see any reason to make changes here. it should continue to
> load modules as before
Hi Andrei and Trevor,
As it stands right now, the task of loading modules is intertwined with
the task of parsing the configuration file. Parsing has side-effects.
I haven't looked too closely at this patch, but if I understand it
correctly, the parser no longer loads modules. To me, this seems like a
clean separation of the two tasks.
Thoughts?
-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101119/01623475/attachment.pgp>
- rfc module autodetection patch set, Trevor Saunders, 2010/11/18
- [PATCH 1/3] output_modules should be declared in a c file not a header, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back,
Christopher Brannon <=
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei . Kholodnyi, 2010/11/19
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/26
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/27
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/28
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/28
[PATCH 3/3] add an initial module detection algorithm, Trevor Saunders, 2010/11/18
rfc module autodetection patch set, Christopher Brannon, 2010/11/18