[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/3] move loading of modules out of the AddModule call back
From: |
Andrei Kholodnyi |
Subject: |
[PATCH 2/3] move loading of modules out of the AddModule call back |
Date: |
Sun, 28 Nov 2010 22:28:48 +0100 |
> Hi Andrei,
> The first patch does not account for rereading of the configuration
> file. ?Start speech-dispatcher, play around a little bit, and send it a
> SIGHUP. ?It will (probably) segfault.
yes, that's true, thanks for catching it up.
> I refactored this patch once again, and I'll send the new one once I'm
> happy with it. ?The list is kept private in module.c, and it can only be
> manipulated by two functions: module_add_load_request and
> module_load_requested_modules.
I'm fine with your version
> Since this is a significant change by me, I'm not sure whether
> either of us can review it. ?Will it be the responsibility of one of the
> other four reviewers?
good idea. William or Hynek could review it.
- rfc module autodetection patch set, Trevor Saunders, 2010/11/18
- [PATCH 1/3] output_modules should be declared in a c file not a header, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Trevor Saunders, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/18
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/19
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei . Kholodnyi, 2010/11/19
- [PATCH 2/3] move loading of modules out of the AddModule call back, Andrei Kholodnyi, 2010/11/26
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/27
- [PATCH 2/3] move loading of modules out of the AddModule call back, Christopher Brannon, 2010/11/28
- [PATCH 2/3] move loading of modules out of the AddModule call back,
Andrei Kholodnyi <=
[PATCH 3/3] add an initial module detection algorithm, Trevor Saunders, 2010/11/18
rfc module autodetection patch set, Christopher Brannon, 2010/11/18