[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] add an initial module detection algorithm
From: |
Andrei Kholodnyi |
Subject: |
[PATCH] add an initial module detection algorithm |
Date: |
Mon, 29 Nov 2010 16:09:27 +0100 |
Hi Chris,
I have one remark.
I'm not sure about detect_output_modules naming versus implemented
functionality.
if function is called "detect_output_modules"
I'd say it shall return a list of modules which have been detected or
some status, e.g. the number of detected modules?
void does not tell me much about the result
and I need to drop a look inside it to understand what this function is doing.
Besides that it does also adding modules to module_add_load_request
which is not obvious from the naming.
Probably this function shall be called differently?
Andrei.