speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/1] add --with-audio-output-method=<name> option


From: Bohdan R . Rau
Subject: [PATCH 1/1] add --with-audio-output-method=<name> option
Date: Wed, 01 Dec 2010 14:56:22 +0100

On Wed, 1 Dec 2010 13:56:46 +0100, Andrei Kholodnyi
<andrei.kholodnyi at gmail.com> wrote:
[...]
> At the moment I did it simple: pulse is always default,

For me it should be: First of compiled-in pulse, alsa or oss  should be
default.

-DDEFAULT_AUDIO_METHOD="something" should be used only when we explicitely
define with-audio-output-method. If not, we can't assume the pulse is
default, but default method should be one of really compiled.

I don't think it's task for configure script - the script should only give
informations like "default method was defined" (by
with-audio-output-method) and put some informations in config.h (which
audio outputs are available).

As I said I'm not very familiar with autotools, but for me it's possible
to put some AF_DEFINE macros into configure script, and then choice default
method directly in C code (using #ifdef).

On my system two audio output modules will be compiled by default (when
I'll use "configure" without parameters) - alsa and oss. Configure script
will properly detect absence of pulseaudio and won't try to compile pulse
module. So - why the "pulse" is still default?

ethanak
-- 
http://milena.polip.com/ - Pa pa, Ivonko!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]