[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Add a socket audio plugin
From: |
Trevor Saunders |
Subject: |
[PATCH] Add a socket audio plugin |
Date: |
Sun, 5 Dec 2010 02:57:04 -0500 |
On Sun, Dec 05, 2010 at 01:41:59AM -0600, William Hubbs wrote:
> Hi Trevor,
>
> I have some concerns about this patch.
>
> It was not set up with options for enabling/disabling it in
> configure.ac like all of the other plugins,and there is no reason not
> to that I can think of. If that is set up correctly, you do not need to
> touch static_plugins.c.in at all.
I don't really care either way. I can't see a reason not to build it,
especially because it can't be more than a couple k of compiled code.
However I don't really have a problem with figuring out how that part of
the build system works and using it.
> Also, I did not see any additions to speechd.conf to document this audio
> playback method.
Well, I don't think it'll be a common thing you want to have configured
as the default, but I gues I could add some comments. I think we do
want some documentation in doc/ and maybe an interface that clients can
use.
Trev
>
> Thanks,
>
> William
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101205/3153dc58/attachment.pgp>