speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] determine availability of audio plugins by using config.h


From: Andrei Kholodnyi
Subject: [PATCH] determine availability of audio plugins by using config.h
Date: Sun, 5 Dec 2010 20:48:17 +0100

On Sun, Dec 5, 2010 at 7:33 PM, William Hubbs <w.d.hubbs at gmail.com> wrote:
> Yes, I agree that it adds #ifdefs in the c code, but I don't see a
> problem with having them in this case. This keeps us from
> generating a .c file in the configure step and limits what the configure
> step touches to config.h and the makefiles, which brings us in line with
> how the autotools are supposed to work imho.
>
> Would you please re-consider your position on this patch?

It took me quite time to get rid of all 1001
#ifdef MY_FAVORITE_AUDIO_METHOD
in the source code and make it independent on this stuff.

I agree that a generating of c file from configure is not the best way.
You are more than welcome to invent something better
e.g. discovery of audio plugins similar to what Trev did.
The only requirement: it shall be universal,
i.e. no source code modifications while adding a new audio backend.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]