[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] rework default audio output method
From: |
William Hubbs |
Subject: |
[PATCH] rework default audio output method |
Date: |
Thu, 9 Dec 2010 12:31:31 -0600 |
Hi Andrei,
On Thu, Dec 09, 2010 at 07:01:00PM +0100, Andrei Kholodnyi wrote:
> Do you plan to consider Bohdan's remark - consistency check for
> available versus entered as a configure option default plugin?
This is an issue that exists in the current code. To see that, do the
following on the master branch:
autoreconf -i
./configure --with-audio-output-method=junk
You will see that this configures successfully.
Since were planning on moving to plugins, this is not an error
condition, because once we make that transition someone may have an
audio plugin that they want to use as the default which we do not have
in the tree.
If we want to handle that a different way, that should be a separate
RFC, since this is not the issue my patch claims to address.
All my patch is doing is changing the name of the argument to indicate more
clearly that this is a default and removing the need to use the cut
command to select it from the static audio plugins list.
William
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101209/fe9b4a40/attachment.pgp>