[PATCH 1/1] Add module_semaphore_free() to destroy semaphore...

[Trevor Saunders]

On Wed, Dec 07, 2011 at 07:35:56PM +0400, sub wrote:
> Add module_semaphore_free() to destroy semaphore, and release allocated 
> memory (see module_semaphore_init()).

 instead of all this you should just get rid of the dynamic allocation
 in the first place.

> Add  module_semaphore_count_get() to get a value of the semaphores counter.

1 that's not what it does (and if it did it would be useless and wrong),
2 what it does while not broken is at best only slightly useful.

> --- a/src/modules/module_utils.c
> +++ b/src/modules/module_utils.c
> @@ -57,7 +58,7 @@ do_message(SPDMessageType msgtype)
>          cur_line = NULL;
>          n = 0;
>          ret = spd_getline(&cur_line, &n, stdin);
> -        nlines++;
> +        ++nlines;

1, not related 2, bad

Trev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20111207/e0630fda/attachment.pgp>