wrong GenericExecuteSynth command in espeak-mbrola-generic config file

[Samuel Thibault]

Hello,

We got a report from a Debian user about the mbrola generic config file,
see below.  Could you please apply his changes upstream?

Samuel

----- Forwarded message from Mau <mavoga at gmail.com> -----

From: Mau <address@hidden>
To: address@hidden
To: submit at bugs.debian.org
Subject: Bug#665382: [speech-dispatcher] wrong GenericExecuteSynth command in 
espeak-mbrola-generic config file
Reply-To: Mau <mavoga at gmail.com>, 665382 at bugs.debian.org
Date: Fri, 23 Mar 2012 17:36:02 +0100

Package: speech-dispatcher
Version: 0.7.1-6.1
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

After enabling the corresponding line in speechd.conf, the
espeak-mbrola-generic module produces no sound at all.


The GenericExecuteSynth command in espeak-mbrola-generic.conf seems wrong
because:

- the data espeak outputs without the --pho option is not a valid input for
  mbrola;

- the $VOLUME variable contains a float value suitable for mbrola, while
  espeak -a parameter expects an integer; moreover, the -a parameter has no
  effect at all when espeak produces phoneme data, and can be dropped at
  all since the volume will be determined by mbrola's -v parameter;

- without the --stdin parameter, espeak will take the text from stdin, but
  will treat each line as a separate sentence;

- without the -q parameter espeak will try to access audio devices and
  produce audio output by itself;

- the espeak -p parameter can alter the sound output produced by mbrola and
  can be set to the value contained in the $PITCH env variable.


The attached patch seems to fix all the above issues.

Thanks


Mau


--- System information. ---
Architecture: amd64
Kernel: Linux 3.2.0-12.dmz.1-liquorix-amd64

Debian Release: wheezy/sid
990 testing-proposed-updates ftp.de.debian.org
990 testing security.debian.org
990 testing ftp.de.debian.org
500 unstable liquorix.net
500 unstable ftp.de.debian.org
500 stable security.debian.org
500 stable ftp.de.debian.org
500 proposed-updates ftp.de.debian.org
1 experimental ftp.de.debian.org

--- Package information. ---
Depends (Version) | Installed
==============================-+-=============
adduser | 3.113+nmu1
lsb-base (>= 3.0-10) | 3.2+Debian31
dpkg (>= 1.15.4) | 1.16.1.2
OR install-info | 4.13a.dfsg.1-8
libao4 (>= 1.1.0) | 1.1.0-1.1
libasound2 (>= 1.0.16) | 1.0.25-2
libaudio2 | 1.9.3-4
libc6 (>= 2.3.2) | 2.13-27
libdotconf1.0 | 1.0.13-3
libespeak1 (>= 1.30) | 1.46.02-1
libflite1 | 1.4-release-4
libglib2.0-0 (>= 2.24.0) | 2.30.2-6
libpulse0 (>= 0.99.1) | 1.1-3
libspeechd2 | 0.7.1-6.1


Recommends (Version) | Installed
=========================-+-===========
pulseaudio | 1.1-3


Suggests (Version) | Installed
============================================-+-==============
speech-dispatcher-festival (= 0.7.1-6.1) | 0.7.1-6.1
speech-dispatcher-doc-cs (= 0.7.1-6.1) |
libttspico-utils | 1.0+git20110131-1






--- espeak-mbrola-generic.conf.orig     2011-04-27 12:01:16.000000000 +0200
+++ espeak-mbrola-generic.conf  2012-03-21 17:25:44.066763025 +0100
@@ -18,7 +18,7 @@
 # can modify this value, see other parameters).
 # The command can be split into more lines, if necessary, using '\'.
 GenericExecuteSynth \
-"echo \'$DATA\' | espeak -v mb-$VOICE $PUNCT -s $RATE -a $VOLUME | mbrola -v 
$VOLUME -e /usr/share/mbrola/$VOICE/$VOICE - -.au | $PLAY_COMMAND
+"echo \'$DATA\' | espeak -v mb-$VOICE -s $RATE -p $PITCH $PUNCT -q --stdin 
--pho | mbrola -v $VOLUME -e /usr/share/mbrola/$VOICE/$VOICE - -.au | 
$PLAY_COMMAND
 
 # The following three items control punctuation levels None, Some, and All.
 # Each of these values will be substituted into the $PUNCT variable depending


----- End forwarded message -----