[PATCH 0/8] Hussain Jasim's pitch range feature addition.

[Trevor Saunders]

On Fri, Oct 24, 2014 at 02:44:37PM -0400, Luke Yelavich wrote:
> I've just finished hand editing Hussain Jasim's patches from his git repo, 
> found at git://github.com/ringulreith/speechd.git. The code builds at least, 
> although I have not yet tested it.
> 
> In hand-editing these, it is possible I dropped a hunk that I shouldn't have, 
> and likely I left a hunk in that was an accidental reversion that I meant to 
> remove. If folks could please have a look, that would be much appreciated. I 
> am posting these patches to the list so they can get a proper review.

I took a quick look at the more significant patches and they seemed
reasonable though not particularly fun reading.

My only issue is that I'm not sure it makes sense to add support to
change settings in config files.  I know its been done for settings
previously, but I'm of the opinion we should remove that support.  We
should pick reasonable built in defaults and then allow clients to
handle changing from that.
 
> I am not entirely sure if this is something we should include, see another 
> incoming reply from me to the original pull request, but its worth 
> considering nonetheless.

People want this right? what exactly is your alternative?

I'd rather see modules able to expose arbitrary settings to clients, but
I'm not sure I think its reasonable to make someone implement that to
get this feature.

Trev

> 
> Thanks
> 
> Luke
> 
> 
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20141025/23360008/attachment.pgp>