[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] adjoin instead of push for adding to *screen-mode-li
From: |
John Li |
Subject: |
Re: [STUMP] [PATCH] adjoin instead of push for adding to *screen-mode-line-formatters* |
Date: |
Mon, 7 Jul 2008 09:47:52 -0400 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jul 07, 2008 at 02:53:59PM +0200, Julian Stecklina wrote:
> John Li <address@hidden> writes:
>
> > - (setq *bat-state* nil)
> > + (setf *bat-state* nil)
> [...]
> > - (setq *bat-remain-time* (multiple-value-bind (h m)
> > + (setf *bat-remain-time* (multiple-value-bind (h m)
>
> Why did you change SETQ to SETF?
Because Shawn likes it that way.
Exhibit #1:
<sabetts> the bottom line is always use setf and dont even bother
worrying about the rest
Exhibit #2:
<male> If you grep the stumpwm sources for setq, you might find one or two ;-)
<sabetts> damn really?
<sabetts> son of a!
Exhibit #3:
<sabetts> it's no different from using setq
<sabetts> bad style.
Since I changed a few small whitespace issues, I decided to change
setq as well.
-John