swftools-common
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Swftools-common] bug in swfextract.c


From: Chris
Subject: Re: [Swftools-common] bug in swfextract.c
Date: Mon, 15 Nov 2010 18:48:56 +0100

On Mon, 15 Nov 2010 15:14:49 +0100
"Gerard H. Pille" <address@hidden> wrote:
 
> In swfextract.c there is an  "if(pos)"  which should in fact be "if(pos>=0)", 
>   since findjpegboundary returns -1 when no boundary is found.  -1 is true, 
> so when no boundery is found, the image is destroyed by the memmove.
> 

Obviously the context matters, and I haven't checked that yet, however..
shouldn't findjpegboundary return 0 ( False ) if no boundary is found,
and -1 ( True ) if it is?

Also, if we are actually dealing with Boolean results, why (pos>=0) ??

Regards,

                                          
Chris
-- 
<address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]