[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Texmacs-dev] Review Request: Use blanks, escaped char, inline comme

From: TeXmacs
Subject: Re: [Texmacs-dev] Review Request: Use blanks, escaped char, inline comment and number to simplify code
Date: Sat, 4 Jan 2020 02:29:43 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

Hi Darcy,

First of all, a very happy new year!

Thanks for your parsing patch.  It seems like a good idea indeed to
have a more systematic way to parse programming languages.
I quickly went through your code and noticed a few things:

  - You often use the list<...> template when you really should be
    using the array<...> template (which is more efficient for arrays ;^)

  - You may simplify some lines such as

+        if (blanks_parser.parse (s, pos)) {
+          break;
+        }


+        if (blanks_parser.parse (s, pos)) break;

    As a general rule, I am happy to see that you adhered quite well to
    my coding style.  This makes it much easier for me to read your code ;^)

Do you want me to apply the patch before version 2.1, or do you prefer
me to wait a bit?  I just got good news from my employer that I will
be allowed to auto-edit my book on TeXmacs.  I still have to go through
some legal business, but TeXmacs 2.1 is definitely approaching fast now.

One other thing that we have to address at a certain point is coloring schemes.
There is quite a lot of ad hoc coloring going on in TeXmacs (syntax 
but also the color of the cursor, selections, the surroundings of the window, 
It would be nice to make all this stylable and make it part of the 
for themes that I have been starting to design.

Best wishes, --Joris

reply via email to

[Prev in Thread] Current Thread [Next in Thread]