[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Changeset c8a874736ed; storing random registers

From: KHMan
Subject: Re: [Tinycc-devel] Changeset c8a874736ed; storing random registers
Date: Tue, 04 Dec 2007 09:25:00 +0800
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070802 SeaMonkey/1.1.4

Joshua Phillips wrote:
> Changeset c8a874736ed2 initializes "vstack = vtop" instead of "vstack = vtop 
> - 
> 1"
> vtop should always point to the top of the vstack, so when the stack is 
> empty, 
> vtop == vstack - 1. With Landley's fix, vstack[0] is left uninitialized, and 
> when save_reg is called, it stores a register (usually eax, if vstack is 
> zeroed) onto the stack for no reason at all.
> For now I've backed out the relevant changeset; the long long problem (in 
> changeset c8a...) should be fixed another way.

Committed to branch "incoming", thanks.

Kein-Hong Man (esq.)
Kuala Lumpur, Malaysia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]