Re: [Tinycc-devel] found a resource leak in tcc-0.9.25/tccpe.c

[grischka]

Martin Ettl wrote:
> Hello,
>
> i have checked the sources of tcc-0.9.25
> with the static code analysis tool cppcheck. It found a resource leak in file 
> tccpe.c at line 887.
>
> Take a look at the source:
>
> ST_FN void pe_build_exports(struct pe_info *pe)
> {
> ....
>     FILE *op;
> ...
>     op=fopen(...);
> #887
> };
>
> Indeed, there is a missing flcose(op).
>
> I have fixed the leak and attached the file to this mail.

Thanks. Committed to
http://repo.or.cz/w/tinycc.git/commitdiff/cbd7f29e

Please consider sending patches or pushing to our "mob" branch
directly, next time ;)

--- grischka

> Best regards
>
> Martin