[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Tinycc-devel] [PATCH v3] forbid invalid comparison of struct

From: Hitoshi Mitake
Subject: [Tinycc-devel] [PATCH v3] forbid invalid comparison of struct
Date: Mon, 5 Nov 2012 22:01:20 +0900

Hi tcc folks.

I found a trivial bug of tcc. Current tcc permits comparison of
structs and comparison between struct and other typed values. This
patch can fix the bug.

I'm new to tcc. Sorry if this patch contains wrong part.
I'd like to hear your comments.

v2: fix on the bug of mod branch
v3: fix the silly bug of v2

 tccgen.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tccgen.c b/tccgen.c
index 4e58ef0..f183913 100644
--- a/tccgen.c
+++ b/tccgen.c
@@ -1700,6 +1700,8 @@ ST_FUNC void gen_op(int op)
             (t2 & (VT_BTYPE | VT_UNSIGNED)) == (VT_LLONG | VT_UNSIGNED))
             t |= VT_UNSIGNED;
         goto std_op;
+    } else if (bt1 == VT_STRUCT || bt2 == VT_STRUCT) {
+        tcc_error("comparison of struct");
     } else {
         /* integer operations */
         t = VT_INT;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]