[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Annoying new warning

From: Christian Jullien
Subject: Re: [Tinycc-devel] Annoying new warning
Date: Tue, 2 May 2017 07:21:45 +0200

So do you agree if I push this patch which works in all cases (even with
dead code :o)

address@hidden:~/tinycc/lib $ git diff
diff --git a/lib/libtcc1.c b/lib/libtcc1.c
index 9195489..0738272 100644
--- a/lib/libtcc1.c
+++ b/lib/libtcc1.c
@@ -581,6 +581,9 @@ unsigned long long __fixunsxfdi (long double a1)
     register int exp;
     register unsigned long long l;

+    dl1.l.upper = 0;
+    dl1.l.lower = 0;
     dl1.ld = a1;

     if (dl1.l.lower == 0 && dl1.l.upper == 0)

-----Original Message-----
From: Tinycc-devel [mailto:address@hidden
On Behalf Of Michael Matz
Sent: mardi 2 mai 2017 02:01
To: address@hidden
Subject: Re: [Tinycc-devel] Annoying new warning


On Mon, 1 May 2017, Daniel Glöckner wrote:

> On Sat, Apr 29, 2017 at 07:55:18PM +0200, Michael Matz wrote:
>> ARMs long double
>> type simply is double itself, and hence these functions are unused on 
>> ARM.  Well, they would be if there wouldn't be strange code in 
>> arm-gen.c that makes use of xfdi conversions when VFP is enabled.
>> That makes no sense, also with VFP there's only support for IEEE 
>> double, not for extended double.
> Since LDOUBLE_SIZE == 8 on VFP, those code lines will only be used with

And there they won't either because LDOUBLE_SIZE is also 8 for !VFP. 
That's what I meant with "strange" I guess, it's dead code :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]