[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] tiny bit of lint

From: grischka
Subject: Re: [Tinycc-devel] tiny bit of lint
Date: Mon, 08 May 2017 19:27:08 +0200
User-agent: Thunderbird (Windows/20090812)

Larry Doolittle wrote:
I committed (to mob) one patch that should count as progress.
Commit message:
    Remove some unused-parameter lint
Mark TCCState parameter as unused in tcc_undefine_symbol(), tcc_add_symbol(),
    tcc_print_stats(), asm_get_local_label_name(), use_section1(), 
    tcc_tool_ar(), tcc_tool_impdef(), and tcc_tool_cross().
    Also mark it unused in tcc_add_bcheck() unless CONFIG_TCC_BCHECK.
    Remove it entirely in ld_next().

I'm open to comments.

  - Larry

In my book that counts as visual clutter with no practical benefit.
The opposite of "tinycc avoids the unnecessary".  Suggesting particular
care that feels alien in contrast to what the code really cares about.

--- grischka

reply via email to

[Prev in Thread] Current Thread [Next in Thread]