[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it
From: |
Kyryl Melekhin |
Subject: |
Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it? |
Date: |
Sat, 12 Sep 2020 08:44:48 +0000 |
About formatting, what's the preferred vim setting you use? I looked
through the code and couldn't figure out what it was, it seemed so
inconsistent so I just thought you guys don't care about that.
сб, 12 сент. 2020 г. в 05:55, grischka <grishka@gmx.de>:
>
> avih via Tinycc-devel wrote:
> >
> > While force-pushing is usually possible, I'd argue that at the tcc repo
> > (and generally elsewhere too, but to each his own practices) no one
> > should force push except maybe maintainers and maybe other regular
> > contributors which 100% know what they're doing when force-pushing.
>
> So I did put on my "maintainer hat" in this case.
>
> Pursuer2's patch "misplaced parenthese around ..." is now on top of
> mob as it was before his pushes. Kyryl's patch "fix float to u64..."
> still has bugs (<< vs >>) and adds bad formatting unnecessarily.
>
> To all:
>
> In the future, please use git cherry-pick or git rebase to put
> your patches on top of the current public mob branch, first.
>
> And as always:
> * test before you push.
>
> * don't add tabs and use 4 spaces to indent. (Don't use emacs or
> configure appropriately its automatisms.).
>
> * don't change lines that you did not change.
>
> Thanks,
>
> --- gr
>
> >
> > I.e. if you want something reverted at the mob repo, please ask here
> > at the mailing list and one of the regulars will judge how to handle
> > the request, IMHO.
> >
> > - avih
>
> _______________________________________________
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
Re: [Tinycc-devel] It seem I pull code in wrong way. How can I revert it?, Pursuer, 2020/09/12