[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: defadvice file-expand-wildcards ad-do-it value

From: Michael Albinus
Subject: Re: defadvice file-expand-wildcards ad-do-it value
Date: Sat, 24 Oct 2009 21:46:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

Kevin Ryde <address@hidden> writes:

> Doing a bit of a grep I noticed the defadvice tramp puts on
> file-expand-wildcards may use the value from ad-do-it.
> I believe that value can't be relied on, that it should look at
> ad-return-value since ad-do-it is only whatever the next innermost
> advice evaluates to, which can be anything.

Thanks, I'll check it.

> Perhaps along the lines below, except untested as I'm not smart enough
> to reach the affected code.

Hmm, this is very old code. I'll check first, whether this is still

> Incidentally, the ad-unadvise in tramp-unload-hook probably should
> confine itself to the particular piece of advice added, so as not to
> affect anyone else's advices on file-expand-wildcards (in the unlikely
> event there are any others!).

That's true as well. Something like ad-remove-advice would be more

Best regards, Michael.

PS: Could you, please, prepare a Changelog entry?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]