[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: defadvice file-expand-wildcards ad-do-it value

From: Kevin Ryde
Subject: Re: defadvice file-expand-wildcards ad-do-it value
Date: Sun, 15 Nov 2009 11:04:35 +1100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Michael Albinus <address@hidden> writes:
> (Somehow, I failed to read your second diff. Sorry for that)

The third part too below?  I don't think the defadvice should change the
return value for non-tramp names.

Actually "(list name)" seems doubtful in the tramp cases too.  If
there's no matches I think the return should be nil, not the pattern.
But I say that without trying it, and without knowing if it's a hack to
keep the pattern for later action ...

2009-11-15  Kevin Ryde  <address@hidden>

        * tramp.el (defadvice file-expand-wildcards): For non-tramp names
        don't change the return to (list name), leave per the original.

--- tramp.el.~2.748.~   2009-11-15 10:51:30.000000000 +1100
+++ tramp.el    2009-11-15 10:55:28.000000000 +1100
@@ -8376,9 +8376,7 @@
                  (setq ad-return-value (list name))))
            (setq ad-return-value (list name)))
        ;; If it is not a Tramp file, just run the original function.
-       ad-do-it
-       (unless ad-return-value
-         (setq ad-return-value (list name))))))
+       ad-do-it)))
    (lambda ()

reply via email to

[Prev in Thread] Current Thread [Next in Thread]