Re: [Varnamproject-discuss] Code review and blog update

[Navaneeth K N]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello Kevin,

I did first round of code review. I have some minor suggestions, but
overall, great work!

I have created an issue[1] to track the activities that we are doing to
merge the changes into varnam's main repository. I will test the code,
run my own regression test suites and feed large volume of data to make
sure everything works good. Then we can deploy it into production.

Awesome work!

[1]: https://github.com/varnamproject/libvarnam/issues/52

On 7/31/14 1:08 AM, Kevin Martin wrote:
> The code rewrite is almost complete (except for some tests). I've discussed
> all the changes I've made in the rewrite in the blog update [1]. I've made
> a new commit here[2]. Please review
> 
> 
> 
> 
> [1]
> http://kevincoder.wordpress.com/2014/07/31/gsoc-memory-heap-corruption-and-code-rewrite/
> 
> [2]
> https://github.com/lonesword/libvarnam/commit/ea4acac4c777243a6e42ec3809e98e3e5cf20fe7
> 

- -- 
Cheers,
Navaneeth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJT4OFiAAoJEHFACYSL7h6kVUYIALst9NhiBxCM6WGqKVJMxNRb
vv7OJmjvAP28Qxbz+srLKp3WGcCPHNGDlPjSHOx/0/Yo68nFgmPnahqbZaVWu91n
4mLVBlj4i1qrs3NwCE+CYEIJ+N8KcSQGH145TZwf9nVQV9Cb56CK7ah7tGRe56g0
01jcaRWgk7otprrJABQqAG5j8x+l/9z4UsaG+gQz9/3r0tRVTFh6B2ST3UTXSGz8
Jc5rmiUdr5aXMdZp4UXrQ98Mh/4mFKmHEjfi1gS9WGldDmuvofB003PmWgUoINQT
2WvneQ+CLR0fEELxLhPOfDPX6VE+mEq/a9zctb92AIW4nnFsEossri9z+xpP+m8=
=oYDx
-----END PGP SIGNATURE-----