wesnoth-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Wesnoth-patches] [patch #4138] Don't let user campaigns' defined macros


From: Isaac Dupree
Subject: [Wesnoth-patches] [patch #4138] Don't let user campaigns' defined macros leak into other user campaigns.
Date: Fri, 1 Jul 2005 17:50:52 +0000
User-agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.8) Gecko/20050427 Camino/0.8.4

URL:
  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4138>

                 Summary: Don't let user campaigns' defined macros leak into
other user campaigns.
                 Project: Battle for Wesnoth
            Submitted by: invisibleph
            Submitted on: Fri 07/01/2005 at 17:50
                Category: None
                Priority: 6
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open

    _______________________________________________________

Details:

It can break things when another badly-organized campaign defines some macros.
There is no reason to let them leak across in an implementation-defined manner
(file order in a directory). Besides, this would allow "#define Campaign_Name"
or something similar in my campaign template, and voila! the new designer only
has to change that one thing: other campaigns won't mind because they would
not be affected, given this patch. (Actually I'm not sure how well that
particular idea for the campaign template would work, given the current
brokenness of the preprocessor in certain places, but the main reason still
stands.)





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 07/01/2005 at 17:50  Name: isolate-defines-game.cpp.diff  Size: 412B
  By: invisibleph

<http://savannah.nongnu.org/patch/download.php?item_id=4138&item_file_id=4780>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4138>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]