Re: wget | Discard "Authentication" and "Cookie" header (!42)

[@rockdaboot]

Merge request https://gitlab.com/gnuwget/wget/-/merge_requests/42 was reviewed 
by Tim Rühsen

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802432

 > + */
 > +static inline int
 > +unredirectable_headerline(char *line)

No need for an inline function.

```suggestion:-1+0
static bool
unredirectable_headerline(const char *line)
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802470

 > +        { 14, "Authorization:" },
 > +    { 7, "Cookie:" },
 > +    { 0, NULL }

```suggestion:-1+0
        { 7, "Cookie:" }
```suggestion:-1+0
        { 7, "Cookie:" },
        { 0, NULL }
``````

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802480

 > +    { 0, NULL }
 > +    };
 > +    int i;

```suggestion:-0+0
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802493

 > +     * Note: According to RFC 2616, Field names are case-insensitive.
 > +     */
 > +    for (i = 0; field_name[i].name != NULL; i++)

```suggestion:-0+0
    for (unsigned i = 0; field_name[i].name; i++)
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802506

 > +    for (i = 0; field_name[i].name != NULL; i++)
 > +        if (strncasecmp(line, field_name[i].name, field_name[i].len) == 0)
 > +        return 1;

```suggestion:-0+0
            return true;
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802519

 > +        return 1;
 > +
 > +    return 0;

```suggestion:-0+0
    return false;
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802530

 >  gethttp (const struct url *u, struct url *original_url, struct http_stat 
 > *hs,
 > -         int *dt, struct url *proxy, struct iri *iri, int count)
 > +         int *dt, struct url *proxy, struct iri *iri, int count, int 
 > location_changed)

```suggestion:-0+0
         int *dt, struct url *proxy, struct iri *iri, int count, bool 
location_changed)
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802539

 >             char **local_file, const char *referer, int *dt, struct url 
 > *proxy,
 > -           struct iri *iri)
 > +           struct iri *iri, int location_changed)

```suggestion:-0+0
           struct iri *iri, bool location_changed)
```

--
  
Tim Rühsen started a new discussion on src/http.h: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802545

 >  uerr_t http_loop (const struct url *, struct url *, char **, char **, const 
 > char *,
 > -                  int *, struct url *, struct iri *);
 > +                  int *, struct url *, struct iri *, int);

```suggestion:-0+0
                  int *, struct url *, struct iri *, bool);
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2259802553

 > +    static struct {
 > +        size_t len;
 > +    char *name;

```suggestion:-0+0
        const char *name;
```


-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42
You're receiving this email because of your account on gitlab.com.