wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget | Discard "Authentication" and "Cookie" header (!42)


From: @rockdaboot
Subject: Re: wget | Discard "Authentication" and "Cookie" header (!42)
Date: Fri, 20 Dec 2024 16:16:45 +0000


Merge request https://gitlab.com/gnuwget/wget/-/merge_requests/42 was reviewed 
by Tim Rühsen

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2269754947

 > +unredirectable_headerline(char *line)
 > +{
 > +  static struct {

```suggestion:-0+0
  static const struct {
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2269754958

 > +    { 14, "Authorization:" },
 > +    { 7, "Cookie:" },
 > +    { 0, NULL }

```suggestion:-1+0
    { 7, "Cookie:" }
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2269754962

 > +   * Note: According to RFC 2616, Field names are case-insensitive.
 > +   */
 > +  for (unsigned i = 0; field_name[i].name; i++)

```suggestion:-0+0
  for (unsigned i = 0; i < countof(field_name); i++)
```

--
  
Tim Rühsen started a new discussion on src/http.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42#note_2269754966

 > +   */
 > +  for (unsigned i = 0; field_name[i].name; i++)
 > +    if (strncasecmp(line, field_name[i].name, field_name[i].len) == 0)

```suggestion:-0+0
    if (c_strncasecmp(line, field_name[i].name, field_name[i].len) == 0)
```


-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/42
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]