[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XForms] xforms-1.0.94pre17/lib/counter.c::525: possible bad if test
|
From: |
Jens Thoms Toerring |
|
Subject: |
Re: [XForms] xforms-1.0.94pre17/lib/counter.c::525: possible bad if test ? |
|
Date: |
Thu, 31 Oct 2013 12:51:12 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi David,
On Thu, Oct 31, 2013 at 08:00:39AM +0000, David Binderman wrote:
> I just compiled xforms-1.0.94pre17 with extra Linux gcc compiler flag
> -Wlogical-op
>
> It said
>
> counter.c:525:5: warning: logical 'and' of mutually exclusive tests is always
> false [-Wlogical-op]
>
> Source code is
>
> if ( ob->bw == FL_BOUND_WIDTH && ob->bw == 3 )
>
> Suggest code rework.
Thanks, that's been in there for at least a decade;-) Just
fixed it by removing that and the following line.
Best regards, Jens
--
\ Jens Thoms Toerring ________ address@hidden
\_______________________________ http://toerring.de