Re: xlog use-after-free

[Andy Stewart]

On 1/8/21 1:48 PM, Chris K2CR wrote:
> Hello, all.
>
> I've been experiencing crashes in xlog as packaged with debian.  I tried the
> latest CVS as well, but the behavior didn't change.  Some crashes have been
> reproducible.
>
> I ran xlog with valgrind and tracked it down to a use-after-free scenario in
> the gtk open dialog.  Please see the attached diff, which solves the crash
> for me and generated a (mostly) clean valgrind output.
>
> Without this patch, lp->type was being assigned even though lp was just
> freed in the call to log_file_close().
>
> Thank you and 73
> -Chris K2CR

Hi Chris,

I think it is cool that you took the time to run valgrind on the xlog 
executable - thanks!

The version of xlog packaged with Debian is 2.0.14 and that is ancient. 
Version 2.0.19 can be downloaded here:

http://download.savannah.nongnu.org/releases/xlog/

Latest CVS will eventually become version 2.0.20 and I'm actively working on it 
now.  Let me look at your patch and weave it into my latest version.

BTW, is there a way that I can reliably repeat the crash scenario?

Thanks(!!), and 73,

Andy

--
Andy Stewart (KB1OIQ)
Vice President: PART of Westford, MA (WB1GOF)