From MAILER-DAEMON Wed Jan 01 15:05:09 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VyS2P-0006SX-2v for mharc-bug-coreutils@gnu.org; Wed, 01 Jan 2014 15:05:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyRzU-0005eX-DZ for bug-coreutils@gnu.org; Wed, 01 Jan 2014 15:02:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyRzP-0005aN-Sb for bug-coreutils@gnu.org; Wed, 01 Jan 2014 15:02:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:42460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyRzP-0005aJ-Of for bug-coreutils@gnu.org; Wed, 01 Jan 2014 15:02:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VyRzP-0006Cx-9f for bug-coreutils@gnu.org; Wed, 01 Jan 2014 15:02:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16304: Upcoming clang-3.4 apparently miscompiles coreutils. Resent-From: Bill Wendling Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 01 Jan 2014 20:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16304 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Andrew Trick Received: via spool by 16304-submit@debbugs.gnu.org id=B16304.138860651923853 (code B ref 16304); Wed, 01 Jan 2014 20:02:03 +0000 Received: (at 16304) by debbugs.gnu.org; 1 Jan 2014 20:01:59 +0000 Received: from localhost ([127.0.0.1]:56479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyRzK-0006Ce-Uw for submit@debbugs.gnu.org; Wed, 01 Jan 2014 15:01:59 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:43586) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyC49-0002Kw-Dl for 16304@debbugs.gnu.org; Tue, 31 Dec 2013 22:01:54 -0500 Received: by mail-pa0-f43.google.com with SMTP id bj1so13284260pad.30 for <16304@debbugs.gnu.org>; Tue, 31 Dec 2013 19:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1xrBL7PqLu34hjN5fkt76p83S7qA1mbqptpaxtMSSc4=; b=FHkkGlx/8A3tOoOyu343HYWcCPVpGYU0qUDmfOlRdpNCLFHk8EZ50mjrsO05LfPwic p8pQMWr0xMOMOWpj2s3om1M8raxxHR2SGodW4lAoU3yHIQGGJfFPMePHvdyAAypnMXQo UnCM0InRpw914qvTmH/m/IcpPk3fOgwGsSaGw2+7RxGKukf+02o8aJYmubVOWlNM4q3L 1Dz8xDBoExV+e6h2Ga2MTlc9SnME1ZLfelefSQcKWV0JmeGSrM/sPCD2IB3yVjuEUD0W LKquxVQql706j1OfdWbECDDl88sGcYjSHgVHuVvknZiJlQ6AvT/yTk1bm+RPvFs7fzO2 143g== X-Received: by 10.66.138.40 with SMTP id qn8mr14312568pab.154.1388545312392; Tue, 31 Dec 2013 19:01:52 -0800 (PST) Received: from [172.19.240.32] ([172.19.240.32]) by mx.google.com with ESMTPSA id iu7sm91628043pbc.45.2013.12.31.19.01.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 31 Dec 2013 19:01:51 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) From: Bill Wendling In-Reply-To: Date: Tue, 31 Dec 2013 19:01:48 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <51956339-E8CC-4696-9B35-5E8A64869C9B@gmail.com> References: <20131230123219.GB392@x4> <52C1BFAF.8050807@draigBrady.com> <20131230214705.GC392@x4> <20131231193902.GA391@x4> X-Mailer: Apple Mail (2.1822) X-Mailman-Approved-At: Wed, 01 Jan 2014 15:01:56 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 01 Jan 2014 15:05:07 -0500 Cc: =?UTF-8?Q?P=C3=A1draig?= Brady , Markus Trippelsdorf , 16304@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2014 20:02:13 -0000 It really is too late now. The release has been put to bed, as it were. = We=92re now waiting for Chris to announce it. -bw On Dec 31, 2013, at 11:46 AM, Andrew Trick wrote: > My previous reply didn=92t have Bill=92s correct email. >=20 > On Dec 31, 2013, at 11:42 AM, Andrew Trick wrote: >=20 >>=20 >> On Dec 31, 2013, at 11:39 AM, Markus Trippelsdorf = wrote: >>=20 >>> On 2013.12.31 at 11:12 -0800, Andrew Trick wrote: >>>>=20 >>>> On Dec 30, 2013, at 1:47 PM, Markus Trippelsdorf = wrote: >>>>=20 >>>>> On 2013.12.30 at 18:47 +0000, P=E1draig Brady wrote: >>>>>> On 12/30/2013 12:32 PM, Markus Trippelsdorf wrote: >>>>>>> coreutils-8.22 build with clang-3.4 doesn't copy permissions = correctly: >>>>>>>=20 >>>>>>> markus@x4 tmp % touch test1 >>>>>>> markus@x4 tmp % chmod 600 test1 >>>>>>> markus@x4 tmp % ls -al test1 >>>>>>> -rw------- 1 markus markus 0 Dec 30 13:25 test1 >>>>>>> markus@x4 tmp % /var/tmp/coreutils-8.22/src/cp test1 test2 >>>>>>> markus@x4 tmp % ls -al test2 >>>>>>> ---------- 1 markus markus 0 Dec 30 13:25 test2 >>>>>>> markus@x4 tmp % >>>>>>=20 >>>>>> Ouch. >>>>>>=20 >>>>>> Note as part of the 8.22 release process >>>>>> I did verify that `make check` passed with >>>>>> clang-3.3-3.fc20.x86_64 >>>>>>=20 >>>>>> I've again verified that clang-3.3 passes your test above. >>>>>>=20 >>>>>> Can you pinpoint the erroneous code? >>>>>> It does seem like a clang regression TBH. >>>>>=20 >>>>> Started with LLVM r192750 (Enable MI Sched for x86). >>>>> I've opened a LLVM bug here: >>>>> http://llvm.org/bugs/show_bug.cgi?id=3D18346 >>>>>=20 >>>>> (I will try to come up with a testcase after the holidays) >>>>=20 >>>> To determine whether a bug exists in MI scheduler pass (or = downstream) you can do this: >>>> -mllvm -enable-misched=3Dfalse. >>>>=20 >>>> Duncan committed a post-3.4 fix, r197503, for a varargs bug exposed = by >>>> changes to the SD scheduling policy. >>>=20 >>> Yes, r197503 fixes the issue. Would be nice to get the fix applied >>> before 3.4 gets released... >>=20 >> Yep, it would be nice. But the fix was considered too late 2 weeks = ago, so it=92s even less likely now. I don=92t think there=92s any way = to rerun validation at this point. I=92m copying Bill who is the = authority. >>=20 >> -Andy >=20 From MAILER-DAEMON Wed Jan 01 18:59:12 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VyVgu-0005vb-RJ for mharc-bug-coreutils@gnu.org; Wed, 01 Jan 2014 18:59:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyVeu-0005q1-EH for bug-coreutils@gnu.org; Wed, 01 Jan 2014 18:57:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyVep-0001jC-30 for bug-coreutils@gnu.org; Wed, 01 Jan 2014 18:57:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:42757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyVeo-0001j7-Ue for bug-coreutils@gnu.org; Wed, 01 Jan 2014 18:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VyVeo-00044F-GZ for bug-coreutils@gnu.org; Wed, 01 Jan 2014 18:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16321: [cp] Feature request: create relative symlinks with "cp -r -s" like "ln -r" Resent-From: Kai Herlemann Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 01 Jan 2014 23:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16321 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16321@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138862057015524 (code B ref -1); Wed, 01 Jan 2014 23:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jan 2014 23:56:10 +0000 Received: from localhost ([127.0.0.1]:56775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyVdx-00042I-3Y for submit@debbugs.gnu.org; Wed, 01 Jan 2014 18:56:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51716) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VySzG-0007tE-QB for submit@debbugs.gnu.org; Wed, 01 Jan 2014 16:05:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VySzB-0002yw-0l for submit@debbugs.gnu.org; Wed, 01 Jan 2014 16:05:58 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:46047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VySzA-0002yo-Tl for submit@debbugs.gnu.org; Wed, 01 Jan 2014 16:05:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VySz5-0000Q3-FA for bug-coreutils@gnu.org; Wed, 01 Jan 2014 16:05:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VySz0-0002x5-40 for bug-coreutils@gnu.org; Wed, 01 Jan 2014 16:05:47 -0500 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:37955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VySyz-0002wz-Sd for bug-coreutils@gnu.org; Wed, 01 Jan 2014 16:05:42 -0500 Received: by mail-ea0-f178.google.com with SMTP id d10so5947036eaj.37 for ; Wed, 01 Jan 2014 13:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=1Vb0wugiU5U8/KDZkX8zSaghX5rGUYigdRvucCPSYg0=; b=Xv3ss+Tq8xxaIu8SVqjjZQ0asAHsjCyThs5t+f0RIi0MMsUb39NiLkq0MjU5tRtptM +qAK8MlSdf5AENCfwRNq1QcPX12nRNdInaCp5+MqHbg1CalzhO2iUsTx/qXYRaKFPGky HCAYdTA3+WcP/4Zelkw9KoXEkQETaFFghYB4FhcJpaxD1i6ZiPWyLLA56Kz7Jq3fpVoi sw35OtTcVCAY0ScQ6bmnDB73o3mf6mDDTdxL0Ma6HyZ/xkCV93FvgPYizFHq8mC1xoo2 Hrp8Z2i+t3KD0wYIkGzJKiaMIHTL7lilvwmFm6+0GZNzse1MxbeczITV2H3FVyIWEJfF OW6A== X-Received: by 10.15.86.75 with SMTP id h51mr12416424eez.44.1388610341136; Wed, 01 Jan 2014 13:05:41 -0800 (PST) Received: from [192.168.1.3] ([2.161.115.29]) by mx.google.com with ESMTPSA id 44sm130213751eek.5.2014.01.01.13.05.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 Jan 2014 13:05:39 -0800 (PST) Message-ID: <52C48319.5040005@googlemail.com> Date: Wed, 01 Jan 2014 22:05:29 +0100 From: Kai Herlemann User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Wed, 01 Jan 2014 18:56:07 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 01 Jan 2014 18:59:12 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2014 23:57:14 -0000 Hello, at first, there's a possibility to create relative symlinks with "ln -s -r". Secondly, "cp -r -s" creates only symlinks instead of copying them. I'd like to request that "cp -r -s" gets also that possibility to create relative symlinks like "ln -s -r". That may be very good if you want to 1) copy many different files to a portable storage device like an memory stick, 2) create two different file structures (in my case: sort after the source of music and after the singers) and don't want to copying them two at once. In cases like that, the absolute file path isn't the same, and therefore, only a relative symlink will work. Thanks, and happy new year! Kai From MAILER-DAEMON Fri Jan 03 11:38:29 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz7lV-00022f-NI for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:38:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz7eS-0007eo-G8 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:31:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz7eJ-0005ea-1t for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:31:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz7eI-0005eW-QM for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz7eI-0001GE-3P for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16329@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13887666124769 (code B ref -1); Fri, 03 Jan 2014 16:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2014 16:30:12 +0000 Received: from localhost ([127.0.0.1]:60108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz7dR-0001En-SY for submit@debbugs.gnu.org; Fri, 03 Jan 2014 11:30:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34223) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz71x-00008w-Rm for submit@debbugs.gnu.org; Fri, 03 Jan 2014 10:51:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz71n-0002cF-TC for submit@debbugs.gnu.org; Fri, 03 Jan 2014 10:51:25 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:38704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz71n-0002cA-Pt for submit@debbugs.gnu.org; Fri, 03 Jan 2014 10:51:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz71g-0002CV-FY for bug-coreutils@gnu.org; Fri, 03 Jan 2014 10:51:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz71W-0002aT-QZ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 10:51:08 -0500 Received: from f412.i.mail.ru ([185.5.136.83]:47852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz71W-0002ZS-EO for bug-coreutils@gnu.org; Fri, 03 Jan 2014 10:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail2; h=Content-Type:Message-ID:Reply-To:Date:Mime-Version:Subject:To:From; bh=9S0iX2XdF5rQcvCvaeZen0qp+gQG1+0eThSCsRJS4h4=; b=uYiTNGSLesb4p5E975d0Fq5qrU7WbF1V4Q0nRwN7whFY46/VJF2ozM+skK+q7KKtS12VgxicEYqwgen6I7aOL9YE5ihSwFJKLYpOHARa1bvohIg1iBolFZBkht6+PkiHml2UdmZg7T+R6me3sbFl24KOmcuFKgKuKvio1YzOdls=; Received: from mail by f412.i.mail.ru with local (envelope-from ) id 1Vz71U-0000Uy-3Y for bug-coreutils@gnu.org; Fri, 03 Jan 2014 19:50:56 +0400 Received: from [109.172.69.18] by e.mail.ru with HTTP; Fri, 03 Jan 2014 19:50:56 +0400 From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [109.172.69.18] Date: Fri, 03 Jan 2014 19:50:56 +0400 X-Priority: 3 (Normal) Message-ID: <1388764256.577663010@f412.i.mail.ru> Content-Type: multipart/mixed; boundary="----KJhk3qQW-Hg2xURz7Ft3ME4nl:1388764256" X-Mras: Ok X-Spam: undefined X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 03 Jan 2014 11:30:06 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 03 Jan 2014 11:38:28 -0500 X-BeenThere: bug-coreutils@gnu.org Reply-To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 16:31:22 -0000 ------KJhk3qQW-Hg2xURz7Ft3ME4nl:1388764256 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGksCgpJZiBvbmUgcnVucyBgaGVhZCAtLWxpbmVzPS0wIHNvbWVmaWxlJywgaGUnbGwgc29tZXRp bWVzIGdldCBubyBvdXRwdXQgaW5zdGVhZCBvZiBmdWxsIGZpbGUgY29udGVudHMgYXMKZXhwZWN0 ZWQgYWZ0ZXIgcmVhZGluZyB0aGUgbWFudWFsOgoKLW4sIC0tbGluZXM9Wy1dSwogICAgICAgIHBy aW50IHRoZSBmaXJzdCBLIGxpbmVzIGluc3RlYWQgb2YgdGhlIGZpcnN0IDEwOyB3aXRoIHRoZSBs ZWFk4oCQCiAgICAgICAgaW5nIGAtJywgcHJpbnQgYWxsIGJ1dCB0aGUgbGFzdCBLIGxpbmVzIG9m IGVhY2ggZmlsZQoKSXQgZGVwZW5kcyBvbiB3aGV0aGVyIHRoZSBmaWxlIGhhcyBhIHRyYWlsaW5n IG5ld2xpbmUuCgpGb3IgZXhhbXBsZToKCiQgcHJpbnRmICcxXG4yXG4zJyA+IHRlc3QxCiQgcHJp bnRmICc0XG41XG4nID4gdGVzdDIKJCBoZWFkIC1uIC0wIHRlc3QqCj09PiB0ZXN0MSA8PT0KCj09 PiB0ZXN0MiA8PT0KNAo1CiQgdGFpbCAtbiArMCB0ZXN0KiAgICMgSnVzdCBmb3IgY29tcGFyaXNv bgo9PT4gdGVzdDEgPD09CjEKMgozCj09PiB0ZXN0MiA8PT0KNAo1CiQgCgpJJ20gdXNpbmcgRGVi aWFuIEdOVS9MaW51eCA3IHdoZWV6eSBhbmQgY29yZXV0aWxzLTguMTM7IEkndmUgYWxzbyB0ZXN0 ZWQgY29yZXV0aWxzLTguMjIsIGFuZCBpdCBoYXMgdGhlCnNhbWUgaXNzdWUuCgpBIHByb3Bvc2Vk IHBhdGNoIGZpeGluZyB0aGUgYnVnIGlzIGF0dGFjaGVkLiBJdCBtYWtlcyBoZWFkIGJlaGF2ZSBl eGFjdGx5IGxpa2UgYHRhaWwgLW4gKzAnIG9uIHNhbWUgZmlsZXMuCgotLSAK0JDQu9C10LrRgdC1 0Lkg0KjQuNC70LjQvQ== ------KJhk3qQW-Hg2xURz7Ft3ME4nl:1388764256 Content-Type: application/x-patch; name="=?UTF-8?B?aGVhZF9ubGluZXNfZml4LnBhdGNo?=" Content-Disposition: attachment Content-Transfer-Encoding: base64 LS0tIGNvcmV1dGlscy04LjIyLm9yaWcvc3JjL2hlYWQuYwkyMDEzLTEyLTA0IDE0OjQ4OjMwLjAw MDAwMDAwMCArMDAwMAorKysgY29yZXV0aWxzLTguMjIvc3JjL2hlYWQuYwkyMDE0LTAxLTAzIDE0 OjQ5OjQ0LjM0NDI3Mjg5NSArMDAwMApAQCAtNjM2LDggKzYzNiwxMSBAQAogICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KIAorICAvKiBuX2xpbmVzID09IDAgY2FzZSBuZWVkcyBzcGVjaWFsIHRy ZWF0bWVudC4gKi8KKyAgY29uc3QgYm9vbCBhbGxfbGluZXMgPSAhbl9saW5lczsKKwogICAvKiBD b3VudCB0aGUgaW5jb21wbGV0ZSBsaW5lIG9uIGZpbGVzIHRoYXQgZG9uJ3QgZW5kIHdpdGggYSBu ZXdsaW5lLiAgKi8KLSAgaWYgKGJ5dGVzX3JlYWQgJiYgYnVmZmVyW2J5dGVzX3JlYWQgLSAxXSAh PSAnXG4nKQorICBpZiAobl9saW5lcyAmJiBieXRlc19yZWFkICYmIGJ1ZmZlcltieXRlc19yZWFk IC0gMV0gIT0gJ1xuJykKICAgICAtLW5fbGluZXM7CiAKICAgd2hpbGUgKDEpCkBAIC02NDcsMTEg KzY1MCwxNiBAQAogICAgICAgc2l6ZV90IG4gPSBieXRlc19yZWFkOwogICAgICAgd2hpbGUgKG4p CiAgICAgICAgIHsKLSAgICAgICAgICBjaGFyIGNvbnN0ICpubDsKLSAgICAgICAgICBubCA9IG1l bXJjaHIgKGJ1ZmZlciwgJ1xuJywgbik7Ci0gICAgICAgICAgaWYgKG5sID09IE5VTEwpCi0gICAg ICAgICAgICBicmVhazsKLSAgICAgICAgICBuID0gbmwgLSBidWZmZXI7CisgICAgICAgICAgaWYg KGFsbF9saW5lcykKKyAgICAgICAgICAgIG4gLT0gbiA/IDEgOiAwOworICAgICAgICAgIGVsc2UK KyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgY2hhciBjb25zdCAqbmw7CisgICAgICAgICAg ICAgIG5sID0gbWVtcmNociAoYnVmZmVyLCAnXG4nLCBuKTsKKyAgICAgICAgICAgICAgaWYgKG5s ID09IE5VTEwpCisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgIG4gPSBubCAt IGJ1ZmZlcjsKKyAgICAgICAgICAgIH0KICAgICAgICAgICBpZiAobl9saW5lcy0tID09IDApCiAg ICAgICAgICAgICB7CiAgICAgICAgICAgICAgIC8qIEZvdW5kIGl0LiAgKi8K ------KJhk3qQW-Hg2xURz7Ft3ME4nl:1388764256-- From MAILER-DAEMON Fri Jan 03 11:46:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz7t3-0005wF-1f for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:46:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz7su-0005n1-U7 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz7so-000201-TV for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:46:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz7so-0001zx-PZ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz7so-0001gl-Gr for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.13887675136397 (code B ref 16329); Fri, 03 Jan 2014 16:46:02 +0000 Received: (at 16329) by debbugs.gnu.org; 3 Jan 2014 16:45:13 +0000 Received: from localhost ([127.0.0.1]:60145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz7s0-0001f6-Gp for submit@debbugs.gnu.org; Fri, 03 Jan 2014 11:45:12 -0500 Received: from mail3.vodafone.ie ([213.233.128.45]:54935) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz7rx-0001ev-Vf for 16329@debbugs.gnu.org; Fri, 03 Jan 2014 11:45:10 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAL7oxlJtTev4/2dsb2JhbAANS4cWpHiODYMHgSODGQEBAQQjDwFGEAkCDQsCAgUWCwICCQMCAQIBRQYNAQcBAYgFjViaeXaZYBeBKY0yMweCb4FIAQOfA45V Received: from unknown (HELO [192.168.1.79]) ([109.77.235.248]) by mail3.vodafone.ie with ESMTP; 03 Jan 2014 16:45:07 +0000 Message-ID: <52C6E913.2040300@draigBrady.com> Date: Fri, 03 Jan 2014 16:45:07 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> In-Reply-To: <1388764256.577663010@f412.i.mail.ru> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16329@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 16:46:15 -0000 On 01/03/2014 03:50 PM, Алексей Шилин wrote: > Hi, > > If one runs `head --lines=-0 somefile', he'll sometimes get no output instead of full file contents as > expected after reading the manual: > > -n, --lines=[-]K > print the first K lines instead of the first 10; with the lead‐ > ing `-', print all but the last K lines of each file > > It depends on whether the file has a trailing newline. > > For example: > > $ printf '1\n2\n3' > test1 > $ printf '4\n5\n' > test2 > $ head -n -0 test* > ==> test1 <== > > ==> test2 <== > 4 > 5 > $ tail -n +0 test* # Just for comparison > ==> test1 <== > 1 > 2 > 3 > ==> test2 <== > 4 > 5 > $ > > I'm using Debian GNU/Linux 7 wheezy and coreutils-8.13; I've also tested coreutils-8.22, and it has the > same issue. > > A proposed patch fixing the bug is attached. It makes head behave exactly like `tail -n +0' on same files. > Thanks for the clear reproducer and patch. I'll probably apply this in your name with a test. thanks! Pádraig. From MAILER-DAEMON Fri Jan 03 11:58:12 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz84a-0001yr-Bd for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:58:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz84V-0001sA-7k for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:58:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz84Q-0005t6-BV for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:58:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz84Q-0005t2-7k for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz84P-000229-QK for bug-coreutils@gnu.org; Fri, 03 Jan 2014 11:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= , 16329@debbugs.gnu.org Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.13887682527773 (code B ref 16329); Fri, 03 Jan 2014 16:58:01 +0000 Received: (at 16329) by debbugs.gnu.org; 3 Jan 2014 16:57:32 +0000 Received: from localhost ([127.0.0.1]:60188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz83v-00021J-Q5 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 11:57:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29557) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz83s-000218-Ki for 16329@debbugs.gnu.org; Fri, 03 Jan 2014 11:57:30 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s03GvQMs030153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Jan 2014 11:57:27 -0500 Received: from [10.3.113.90] (ovpn-113-90.phx2.redhat.com [10.3.113.90]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s03GvP76021581; Fri, 3 Jan 2014 11:57:26 -0500 Message-ID: <52C6EBF5.9000407@redhat.com> Date: Fri, 03 Jan 2014 09:57:25 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> In-Reply-To: <1388764256.577663010@f412.i.mail.ru> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="58RBRn4fgqB6sAdAEFl0veHjWCti1l4lP" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 16:58:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --58RBRn4fgqB6sAdAEFl0veHjWCti1l4lP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/03/2014 08:50 AM, =D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9 =D0=A8= =D0=B8=D0=BB=D0=B8=D0=BD wrote: > Hi, >=20 > If one runs `head --lines=3D-0 somefile', he'll sometimes get no output= instead of full file contents as > expected after reading the manual: >=20 > -n, --lines=3D[-]K > print the first K lines instead of the first 10; with the lead=E2= =80=90 > ing `-', print all but the last K lines of each file >=20 > It depends on whether the file has a trailing newline. Per POSIX, 'head' is only required to operate on "text files" http://pubs.opengroup.org/onlinepubs/9699919799/utilities/head.html and a "text file" must either be empty or have a trailing newline: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#t= ag_03_397 So this is not necessarily a bug. That said, since POSIX doesn't specify what we should do, we are free to make it behave differently. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --58RBRn4fgqB6sAdAEFl0veHjWCti1l4lP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSxuv1AAoJEKeha0olJ0NqfYQH/3j1s1dlVdU7bNkykP/jLrBY IF5DdVqgMqikQBG60iazi6ungKWg37ZY3gTv8YbSFpZ0mFt1LK7UbmoJzKYjIxKM Yu5jFR9CrbAsjEmGZhyuB+szg89lZvANiyprtyoHQfL53DvMOpHO5c93zlOkttu/ H32t9aTPWbzxyv0F+/Bm+Kf3ECCA53zWv0gwlmx058gUhXzfXFs6JuY/jVEyDyQV IDjPfchCuTckX0DOLKzB6RiXfqk6OnqzK34H3AGlgBKex/TrLfkSP299EAzhGHj+ nx5GsC6E7kPeOJDRhCs9NFrtu/Z/wRN3lUBce1Nof8rX11v3k+ZJ4Pg5QwDGaa0= =RMGE -----END PGP SIGNATURE----- --58RBRn4fgqB6sAdAEFl0veHjWCti1l4lP-- From MAILER-DAEMON Fri Jan 03 12:03:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz89R-0005A7-Sp for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:03:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz89L-00059v-At for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:03:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz89G-0007MW-RO for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:03:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz89G-0007MP-Os for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz89G-0003IS-1N for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.138876857112651 (code B ref 16329); Fri, 03 Jan 2014 17:03:01 +0000 Received: (at 16329) by debbugs.gnu.org; 3 Jan 2014 17:02:51 +0000 Received: from localhost ([127.0.0.1]:60201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz894-0003Hv-RL for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:02:51 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:12925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz892-0003Hk-Ux for 16329@debbugs.gnu.org; Fri, 03 Jan 2014 12:02:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAF7sxlJtTev4/2dsb2JhbAANS4NDg1O1PU+BI4MZAQEBBCMPAUYQCQINAQoCAgUWCwICCQMCAQIBRQYNAQcBAYgFCI1Bmnl2mWEXgSmNZQeCb4FIAQOZR4U8jlU Received: from unknown (HELO [192.168.1.79]) ([109.77.235.248]) by mail3.vodafone.ie with ESMTP; 03 Jan 2014 17:02:47 +0000 Message-ID: <52C6ED37.5070703@draigBrady.com> Date: Fri, 03 Jan 2014 17:02:47 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> <52C6EBF5.9000407@redhat.com> In-Reply-To: <52C6EBF5.9000407@redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16329@debbugs.gnu.org, =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 17:03:12 -0000 On 01/03/2014 04:57 PM, Eric Blake wrote: > On 01/03/2014 08:50 AM, Алексей Шилин wrote: >> Hi, >> >> If one runs `head --lines=-0 somefile', he'll sometimes get no output instead of full file contents as >> expected after reading the manual: >> >> -n, --lines=[-]K >> print the first K lines instead of the first 10; with the lead‐ >> ing `-', print all but the last K lines of each file >> >> It depends on whether the file has a trailing newline. > > Per POSIX, 'head' is only required to operate on "text files" > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/head.html > and a "text file" must either be empty or have a trailing newline: > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_397 > > So this is not necessarily a bug. That said, since POSIX doesn't > specify what we should do, we are free to make it behave differently. BTW I still don't think POSIX is specifying that text files without a trailing newline are not text files. It states that text files can have zero or more lines, implying that the trailing new line is optional. thanks, Pádraig. From MAILER-DAEMON Fri Jan 03 12:11:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz8HB-0007rA-0J for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:11:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8H4-0007jq-VB for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:11:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8H0-0001FZ-PU for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:11:06 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8H0-0001FV-MA for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz8H0-0003V4-79 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.138876901613384 (code B ref 16329); Fri, 03 Jan 2014 17:11:02 +0000 Received: (at 16329) by debbugs.gnu.org; 3 Jan 2014 17:10:16 +0000 Received: from localhost ([127.0.0.1]:60212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8GG-0003To-2z for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:10:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3110) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8GC-0003Td-Fw for 16329@debbugs.gnu.org; Fri, 03 Jan 2014 12:10:14 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s03HAA1s030395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Jan 2014 12:10:11 -0500 Received: from [10.3.113.90] (ovpn-113-90.phx2.redhat.com [10.3.113.90]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s03HAAPw013795; Fri, 3 Jan 2014 12:10:10 -0500 Message-ID: <52C6EEF1.1060503@redhat.com> Date: Fri, 03 Jan 2014 10:10:09 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> <52C6EBF5.9000407@redhat.com> <52C6ED37.5070703@draigBrady.com> In-Reply-To: <52C6ED37.5070703@draigBrady.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d916BSR2bLwD1U57EbMtFIHQTNsWjMntU" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16329@debbugs.gnu.org, =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 17:11:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d916BSR2bLwD1U57EbMtFIHQTNsWjMntU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/03/2014 10:02 AM, P=C3=A1draig Brady wrote: >>> It depends on whether the file has a trailing newline. >> >> Per POSIX, 'head' is only required to operate on "text files" >> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/head.html >> and a "text file" must either be empty or have a trailing newline: >> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.htm= l#tag_03_397 >> >> So this is not necessarily a bug. That said, since POSIX doesn't >> specify what we should do, we are free to make it behave differently. >=20 > BTW I still don't think POSIX is specifying that text files without > a trailing newline are not text files. >=20 > It states that text files can have zero or more lines, Where "lines" is also a well-defined POSIX term: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#t= ag_03_206 > implying that the trailing new line is optional. Wrong. The trailing newline character is mandatory in text files. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --d916BSR2bLwD1U57EbMtFIHQTNsWjMntU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSxu7xAAoJEKeha0olJ0NqpxMH/jsRu5VPokXGzkaH6iZAzhrM uadEFsc4SEZL+2ooASUiGcWvKeY51oVEAt9Z13Z0Ns0hbEh0ETidk2BU7i45nkup OwX8mViEiZ9zOxbBOxUaBP80vs01APQwrsGU6tBCQv19wo2MWxVNhHDAd50WQntR HcqJjXqd5vBxZMdI9h9minA0CcrMu0nbSEG8JSmPLb69J+zGLQOFSCZ4xVUs5qWm h4gRzm3wFdfA/SrKxYD//iUgSV94CW12Go8pdj2/mgmOCEnHu5nuDzN8QFmaZaPN /wvRCvdFemmYIEtEezBrGtwABviK4D4J4jqPBMCv747N3Cw7JXy34qjp5Nonpuk= =l57A -----END PGP SIGNATURE----- --d916BSR2bLwD1U57EbMtFIHQTNsWjMntU-- From MAILER-DAEMON Fri Jan 03 12:46:21 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vz8pB-00042R-DW for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:46:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8p2-0003oV-Pz for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:46:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8os-0003h9-Ho for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:46:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8os-0003h1-Dy for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz8or-0004V3-RX for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16329@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138877112217237 (code B ref -1); Fri, 03 Jan 2014 17:46:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2014 17:45:22 +0000 Received: from localhost ([127.0.0.1]:60272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8oD-0004Tv-F0 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:45:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8o9-0004Tk-9l for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:45:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8o2-0003Nz-Ea for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:45:16 -0500 Received: from lists.gnu.org ([208.118.235.17]:39157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8o2-00038s-AU for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:45:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8do-0007h2-GP for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:34:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8dj-0000Cv-2u for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:34:36 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:58857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8di-0000CK-TQ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 12:34:31 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 8C737A60008 for ; Fri, 3 Jan 2014 09:34:29 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j+680uBnEwhy for ; Fri, 3 Jan 2014 09:34:28 -0800 (PST) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id BDA5EA60003 for ; Fri, 3 Jan 2014 09:34:28 -0800 (PST) Message-ID: <52C6F4A4.6080503@cs.ucla.edu> Date: Fri, 03 Jan 2014 09:34:28 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> <52C6EBF5.9000407@redhat.com> <52C6ED37.5070703@draigBrady.com> In-Reply-To: <52C6ED37.5070703@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 17:46:19 -0000 P=C3=A1draig Brady wrote: > It states that text files can have zero or more lines, > implying that the trailing new line is optional. I think Eric's right here; if the file is nonempty, a trailing newline is required. I'm old enough to remember when text files were not allowed to be empty (!). Totally bizarre, but that's the way POSIX was until 2008. Before that, every text file had to end with a newline byte. See: http://pubs.opengroup.org/onlinepubs/000095399/basedefs/xbd_chap03.html#t= ag_03_392 From MAILER-DAEMON Fri Jan 03 15:44:41 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzBbl-000880-0s for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 15:44:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzBYL-0006jU-Uh for bug-coreutils@gnu.org; Fri, 03 Jan 2014 15:41:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzBYE-0000vd-KF for bug-coreutils@gnu.org; Fri, 03 Jan 2014 15:41:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzBYE-0000vZ-Bm for bug-coreutils@gnu.org; Fri, 03 Jan 2014 15:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzBYD-0000sX-J5 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 15:41:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: Acknowledgement (`head --lines=-0' prints nothing if no newline at the EOF) Resent-From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 03 Jan 2014 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16329@debbugs.gnu.org Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.13887816333325 (code B ref 16329); Fri, 03 Jan 2014 20:41:01 +0000 Received: (at 16329) by debbugs.gnu.org; 3 Jan 2014 20:40:33 +0000 Received: from localhost ([127.0.0.1]:60480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzBXk-0000rY-5P for submit@debbugs.gnu.org; Fri, 03 Jan 2014 15:40:32 -0500 Received: from f346.i.mail.ru ([217.69.140.242]:47911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzBXg-0000rM-T7 for 16329@debbugs.gnu.org; Fri, 03 Jan 2014 15:40:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail2; h=References:In-Reply-To:Content-Type:Message-ID:Reply-To:Date:Mime-Version:Subject:To:From; bh=44iyNNa/uUL0KXEu1ihAyz2XxRSrb9zujU2gTSNMJYk=; b=gJyCTE0ZkatyT26eY8GGppQLQl1chKqk0EhIPAcxz3em72mlhN+fl3FgENa7+GC4rZzc6Q8FS+xmnPmPUZhKA6xoLXNIyaz7SnPLayJONLXtJrTUqigY3Kwfk4LTjUuFrozMZnR7h2V3cTGDqgahiwE+XmhYzJhljkHIbPers7k=; Received: from mail by f346.i.mail.ru with local (envelope-from ) id 1VzBXf-0002C5-A4 for 16329@debbugs.gnu.org; Sat, 04 Jan 2014 00:40:27 +0400 Received: from [109.172.69.18] by e.mail.ru with HTTP; Sat, 04 Jan 2014 00:40:27 +0400 From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [109.172.69.18] Date: Sat, 04 Jan 2014 00:40:27 +0400 X-Priority: 3 (Normal) Message-ID: <1388781627.45947684@f346.i.mail.ru> Content-Type: multipart/mixed; boundary="----0pGvb3Lo-AD616WfjPAuj6Y0S:1388781627" X-Mras: Ok X-Spam: undefined In-Reply-To: References: <1388764256.577663010@f412.i.mail.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 03 Jan 2014 15:44:39 -0500 X-BeenThere: bug-coreutils@gnu.org Reply-To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 20:41:17 -0000 ------0pGvb3Lo-AD616WfjPAuj6Y0S:1388781627 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 TG9va3MgbGlrZSBJIHdhcyBvdmVybHkgY2F1dGlvdXMgYWJvdXQgZGVjcmVtZW50aW5nIGFuIHVu c2lnbmVkLi4uCgpzaXplX3QgbiA9IGJ5dGVzX3JlYWQ7CndoaWxlIChuKQogIHsKICAgIGlmIChh bGxfbGluZXMpCiAgICAgIG4gLT0gbiA/IDEgOiAwOyAgICAgICAgLy8gLi4uaGVyZS4KICAgIGVs c2UKCkFzIGl0IGlzIHVuZGVyIGB3aGlsZSAobiknIHN0YXRlbWVudCwgbiBpcyBhbHdheXMgdHJ1 ZSBoZXJlLCBhbmQgdGh1cyB0aGUgdGVybmFyeSBvcGVyYXRvciwgdGhvdWdoIG1ha2VzIG5vCmhh cm0sIGlzIG5lZWRsZXNzLCBhbmQgdGhlIHdob2xlIGxpbmUgY2FuIGJlIHJlcGxhY2VkIHdpdGgg anVzdCBgbi0tOycuIFNvcnJ5IGZvciB0aGF0LgoKVGhlIGZpeGVkIHZlcnNpb24gb2YgdGhlIG9y aWdpbmFsIHBhdGNoIGlzIGF0dGFjaGVkLgoKLS0gCtCQ0LvQtdC60YHQtdC5INCo0LjQu9C40L0K ------0pGvb3Lo-AD616WfjPAuj6Y0S:1388781627 Content-Type: application/x-patch; name="=?UTF-8?B?aGVhZF9ubGluZXNfZml4Mi5wYXRjaA==?=" Content-Disposition: attachment Content-Transfer-Encoding: base64 LS0tIGNvcmV1dGlscy04LjIyLm9yaWcvc3JjL2hlYWQuYwkyMDEzLTEyLTA0IDE0OjQ4OjMwLjAw MDAwMDAwMCArMDAwMAorKysgY29yZXV0aWxzLTguMjIvc3JjL2hlYWQuYwkyMDE0LTAxLTAzIDIw OjEyOjA3LjU3Mjg2MzY1MiArMDAwMApAQCAtNjM2LDggKzYzNiwxMSBAQAogICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KIAorICAvKiBuX2xpbmVzID09IDAgY2FzZSBuZWVkcyBzcGVjaWFsIHRy ZWF0bWVudC4gKi8KKyAgY29uc3QgYm9vbCBhbGxfbGluZXMgPSAhbl9saW5lczsKKwogICAvKiBD b3VudCB0aGUgaW5jb21wbGV0ZSBsaW5lIG9uIGZpbGVzIHRoYXQgZG9uJ3QgZW5kIHdpdGggYSBu ZXdsaW5lLiAgKi8KLSAgaWYgKGJ5dGVzX3JlYWQgJiYgYnVmZmVyW2J5dGVzX3JlYWQgLSAxXSAh PSAnXG4nKQorICBpZiAobl9saW5lcyAmJiBieXRlc19yZWFkICYmIGJ1ZmZlcltieXRlc19yZWFk IC0gMV0gIT0gJ1xuJykKICAgICAtLW5fbGluZXM7CiAKICAgd2hpbGUgKDEpCkBAIC02NDcsMTEg KzY1MCwxNiBAQAogICAgICAgc2l6ZV90IG4gPSBieXRlc19yZWFkOwogICAgICAgd2hpbGUgKG4p CiAgICAgICAgIHsKLSAgICAgICAgICBjaGFyIGNvbnN0ICpubDsKLSAgICAgICAgICBubCA9IG1l bXJjaHIgKGJ1ZmZlciwgJ1xuJywgbik7Ci0gICAgICAgICAgaWYgKG5sID09IE5VTEwpCi0gICAg ICAgICAgICBicmVhazsKLSAgICAgICAgICBuID0gbmwgLSBidWZmZXI7CisgICAgICAgICAgaWYg KGFsbF9saW5lcykKKyAgICAgICAgICAgIG4tLTsKKyAgICAgICAgICBlbHNlCisgICAgICAgICAg ICB7CisgICAgICAgICAgICAgIGNoYXIgY29uc3QgKm5sOworICAgICAgICAgICAgICBubCA9IG1l bXJjaHIgKGJ1ZmZlciwgJ1xuJywgbik7CisgICAgICAgICAgICAgIGlmIChubCA9PSBOVUxMKQor ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICBuID0gbmwgLSBidWZmZXI7Cisg ICAgICAgICAgICB9CiAgICAgICAgICAgaWYgKG5fbGluZXMtLSA9PSAwKQogICAgICAgICAgICAg ewogICAgICAgICAgICAgICAvKiBGb3VuZCBpdC4gICovCg== ------0pGvb3Lo-AD616WfjPAuj6Y0S:1388781627-- From MAILER-DAEMON Fri Jan 03 20:38:21 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzGBx-0001qq-0b for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:38:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzFFf-0008CS-H7 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 19:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzFFa-0007DY-8G for bug-coreutils@gnu.org; Fri, 03 Jan 2014 19:38:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46785) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzFFa-0007DT-4v for bug-coreutils@gnu.org; Fri, 03 Jan 2014 19:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzFFZ-0000Ge-UQ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 19:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Nicolas Iooss Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 00:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16335@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1388795827943 (code B ref -1); Sat, 04 Jan 2014 00:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2014 00:37:07 +0000 Received: from localhost ([127.0.0.1]:60803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzFEg-0000F8-G7 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 19:37:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35313) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzCvO-0003RT-Qx for submit@debbugs.gnu.org; Fri, 03 Jan 2014 17:09:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzCvJ-0008UK-68 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 17:09:02 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:49729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzCvJ-0008UF-2U for submit@debbugs.gnu.org; Fri, 03 Jan 2014 17:08:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzCvE-0007OW-3e for bug-coreutils@gnu.org; Fri, 03 Jan 2014 17:08:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzCv9-0008T3-8r for bug-coreutils@gnu.org; Fri, 03 Jan 2014 17:08:52 -0500 Received: from mx1.polytechnique.org ([129.104.30.34]:42692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzCv9-0008Sr-1r for bug-coreutils@gnu.org; Fri, 03 Jan 2014 17:08:47 -0500 Received: from [10.5.5.101] (11.147.102.84.rev.sfr.net [84.102.147.11]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 1451914091336 for ; Fri, 3 Jan 2014 23:08:44 +0100 (CET) Message-ID: <52C734EA.9040701@m4x.org> Date: Fri, 03 Jan 2014 23:08:42 +0100 From: Nicolas Iooss Organization: M4X User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------040106080205060909030506" X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Fri Jan 3 23:08:44 2014 +0100 (CET)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 03 Jan 2014 19:37:05 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 03 Jan 2014 20:38:18 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 00:38:12 -0000 This is a multi-part message in MIME format. --------------040106080205060909030506 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello, After upgrading to coreutils 8.22 I can no longer build packages which uses "cp -a" to copy files due to a segmentation fault happening in libselinux. I've tried to reproduce this bug with few commands, in a directory which doesn't have any default context: $ mkdir /tmp/foobar $ matchpathcon /tmp/foobar <> $ touch /tmp/foobar/a $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b /usr/bin/fakeroot: line 181: 9207 Segmentation fault Without fakeroot there is no segmentation fault. Even if the message says "/usr/bin/fakeroot", a coredump has been created for cp. I've analyzed this dump using gdb and after some debugging, I found out that restorecon_private (from src/selinux.c) was calling lsetfilecon with a NULL security context which was obtained by getfscreatecon (case "local = true" in the code [1]). This causes a null pointer dereference in libselinux and so a SIGSEGV. I've reported this bug to libselinux maintainers [2] and got the reply that calling lsetfilecon with a NULL security context was like calling strlen with a NULL string and that this was a problem in caller's code [3]. Hence I propose the attached patch to fix the segmentation fault. Could you please accept it? When you reply, please Cc me as I'm not subscribed. Thanks, Nicolas Iooss ----------- System configuration during my tests: * distro: ArchLinux which SELinux packages * CPU arch: x86_64 * SELinux in permissive mode * coreutils 8.22 * libselinux 2.2.1 * fakeroot 1.20 [1] http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/selinux.c;hb=v8.22#l191 [2] http://marc.info/?l=selinux&m=138763485330568&w=2 [3] http://marc.info/?l=selinux&m=138842015508829&w=2 --------------040106080205060909030506 Content-Type: text/x-patch; name="0001-Fix-segmentation-fault-in-restorecon_private.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-segmentation-fault-in-restorecon_private.patch" >From 2d9940379927d2536675a7970f16767e4d209f27 Mon Sep 17 00:00:00 2001 From: Nicolas Iooss Date: Fri, 3 Jan 2014 22:47:17 +0100 Subject: [PATCH] Fix segmentation fault in restorecon_private --- src/selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/selinux.c b/src/selinux.c index cd38a81..e4deba3 100644 --- a/src/selinux.c +++ b/src/selinux.c @@ -190,7 +190,7 @@ restorecon_private (char const *path, bool local) if (local) { - if (getfscreatecon (&tcon) < 0) + if (getfscreatecon (&tcon) < 0 || tcon == NULL) return rc; rc = lsetfilecon (path, tcon); freecon (tcon); -- 1.8.5.2 --------------040106080205060909030506-- From MAILER-DAEMON Fri Jan 03 20:43:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzGGh-0002if-6N for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:43:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzGGb-0002iM-L9 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:43:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzGGV-0005VG-Jh for bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:43:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzGGV-0005VC-Fv for bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:43:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzGGU-00022R-Nk for bug-coreutils@gnu.org; Fri, 03 Jan 2014 20:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 01:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Nicolas Iooss Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.13887997367769 (code B ref 16335); Sat, 04 Jan 2014 01:43:02 +0000 Received: (at 16335) by debbugs.gnu.org; 4 Jan 2014 01:42:16 +0000 Received: from localhost ([127.0.0.1]:60873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzGFh-00021D-PW for submit@debbugs.gnu.org; Fri, 03 Jan 2014 20:42:15 -0500 Received: from mail4.vodafone.ie ([213.233.128.170]:7522) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzGFZ-00020n-Bm for 16335@debbugs.gnu.org; Fri, 03 Jan 2014 20:42:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAJxmx1JtTev4/2dsb2JhbAANS4NDuXmBIoMZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAUIqEeaZBeOTEIHhDcEmUeFPI5VgWo Received: from unknown (HELO [192.168.1.79]) ([109.77.235.248]) by mail3.vodafone.ie with ESMTP; 04 Jan 2014 01:42:02 +0000 Message-ID: <52C766E9.5020202@draigBrady.com> Date: Sat, 04 Jan 2014 01:42:01 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> In-Reply-To: <52C734EA.9040701@m4x.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 01:43:14 -0000 On 01/03/2014 10:08 PM, Nicolas Iooss wrote: > Hello, > > After upgrading to coreutils 8.22 I can no longer build packages which > uses "cp -a" to copy files due to a segmentation fault happening in > libselinux. > > I've tried to reproduce this bug with few commands, in a directory which > doesn't have any default context: > > $ mkdir /tmp/foobar > $ matchpathcon > /tmp/foobar <> > $ touch /tmp/foobar/a > $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b > $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b > /usr/bin/fakeroot: line 181: 9207 Segmentation fault > > Without fakeroot there is no segmentation fault. > > Even if the message says "/usr/bin/fakeroot", a coredump has been > created for cp. I've analyzed this dump using gdb and after some > debugging, I found out that restorecon_private (from src/selinux.c) was > calling lsetfilecon with a NULL security context which was obtained by > getfscreatecon (case "local = true" in the code [1]). This causes a null > pointer dereference in libselinux and so a SIGSEGV. > > I've reported this bug to libselinux maintainers [2] and got the reply > that calling lsetfilecon with a NULL security context was like calling > strlen with a NULL string and that this was a problem in caller's code [3]. > > Hence I propose the attached patch to fix the segmentation fault. Could > you please accept it? > > When you reply, please Cc me as I'm not subscribed. > > Thanks, > > Nicolas Iooss > > ----------- > > System configuration during my tests: > > * distro: ArchLinux which SELinux packages > * CPU arch: x86_64 > * SELinux in permissive mode > * coreutils 8.22 > * libselinux 2.2.1 > * fakeroot 1.20 > > [1] > http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/selinux.c;hb=v8.22#l191 > [2] http://marc.info/?l=selinux&m=138763485330568&w=2 > [3] http://marc.info/?l=selinux&m=138842015508829&w=2 Thanks for the very thorough analysis and patch. The patch looks correct as getfscreatecon() is documented to return a NULL context in some cases. I'll see if I can add a robust test and will apply this in your name. thanks, Pdraig. From MAILER-DAEMON Fri Jan 03 22:04:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzHX3-0002bT-3z for mharc-bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:04:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHWw-0002bB-Vi for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:04:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzHWs-0007K2-J8 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:04:06 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHWs-0007Ju-GJ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzHWs-0004EM-2n for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 03:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Nicolas Iooss Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138880459216179 (code B ref 16335); Sat, 04 Jan 2014 03:04:01 +0000 Received: (at 16335) by debbugs.gnu.org; 4 Jan 2014 03:03:12 +0000 Received: from localhost ([127.0.0.1]:60925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzHW4-0004Cs-4p for submit@debbugs.gnu.org; Fri, 03 Jan 2014 22:03:12 -0500 Received: from mail4.vodafone.ie ([213.233.128.170]:56104) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzHW1-0004Cj-C1 for 16335@debbugs.gnu.org; Fri, 03 Jan 2014 22:03:10 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAGp5x1JtTev4/2dsb2JhbAANS4NDuXqBIoMZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAUIqE2aZBeOTEIHhDcEmUeFPI5VgWo Received: from unknown (HELO [192.168.1.79]) ([109.77.235.248]) by mail3.vodafone.ie with ESMTP; 04 Jan 2014 03:03:07 +0000 Message-ID: <52C779EA.2040202@draigBrady.com> Date: Sat, 04 Jan 2014 03:03:06 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> In-Reply-To: <52C766E9.5020202@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 03:04:11 -0000 On 01/04/2014 01:42 AM, Pdraig Brady wrote: > On 01/03/2014 10:08 PM, Nicolas Iooss wrote: >> Hello, >> >> After upgrading to coreutils 8.22 I can no longer build packages which >> uses "cp -a" to copy files due to a segmentation fault happening in >> libselinux. >> >> I've tried to reproduce this bug with few commands, in a directory which >> doesn't have any default context: >> >> $ mkdir /tmp/foobar >> $ matchpathcon >> /tmp/foobar <> >> $ touch /tmp/foobar/a >> $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b >> $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b >> /usr/bin/fakeroot: line 181: 9207 Segmentation fault >> >> Without fakeroot there is no segmentation fault. >> >> Even if the message says "/usr/bin/fakeroot", a coredump has been >> created for cp. I've analyzed this dump using gdb and after some >> debugging, I found out that restorecon_private (from src/selinux.c) was >> calling lsetfilecon with a NULL security context which was obtained by >> getfscreatecon (case "local = true" in the code [1]). This causes a null >> pointer dereference in libselinux and so a SIGSEGV. >> >> I've reported this bug to libselinux maintainers [2] and got the reply >> that calling lsetfilecon with a NULL security context was like calling >> strlen with a NULL string and that this was a problem in caller's code [3]. >> >> Hence I propose the attached patch to fix the segmentation fault. Could >> you please accept it? >> >> When you reply, please Cc me as I'm not subscribed. >> >> Thanks, >> >> Nicolas Iooss >> >> ----------- >> >> System configuration during my tests: >> >> * distro: ArchLinux which SELinux packages >> * CPU arch: x86_64 >> * SELinux in permissive mode >> * coreutils 8.22 >> * libselinux 2.2.1 >> * fakeroot 1.20 >> >> [1] >> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/selinux.c;hb=v8.22#l191 >> [2] http://marc.info/?l=selinux&m=138763485330568&w=2 >> [3] http://marc.info/?l=selinux&m=138842015508829&w=2 > > Thanks for the very thorough analysis and patch. > The patch looks correct as getfscreatecon() is > documented to return a NULL context in some cases. > I'll see if I can add a robust test and will apply > this in your name. Actually what's errno set to with tcon is NULL. If if was 0 you might get the classic "error success" message if using the --preserve=context option rather than -a for example. I.E. the following might be more appropriate. Note neither Fedora 15 or 20 here produce a NULL value with fakeroot. thanks, Pdraig. diff --git a/src/selinux.c b/src/selinux.c index cd38a81..016db16 100644 --- a/src/selinux.c +++ b/src/selinux.c @@ -192,6 +192,11 @@ restorecon_private (char const *path, bool local) { if (getfscreatecon (&tcon) < 0) return rc; + if (!tcon) + { + errno = ENODATA; + return rc; + } rc = lsetfilecon (path, tcon); freecon (tcon); return rc; From MAILER-DAEMON Sat Jan 04 00:28:51 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzJn0-0001hC-Qq for mharc-bug-coreutils@gnu.org; Sat, 04 Jan 2014 00:28:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHmT-0005JK-8L for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:20:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzHmM-0002VP-M0 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:20:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:46931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHmM-0002US-J3 for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzHmL-0004fJ-TM for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16336: bug report tail with hfsplus filesystem Resent-From: Pieter van Voorst Vader Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 03:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16336@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138880557717881 (code B ref -1); Sat, 04 Jan 2014 03:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2014 03:19:37 +0000 Received: from localhost ([127.0.0.1]:60950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzHlx-0004eK-CS for submit@debbugs.gnu.org; Fri, 03 Jan 2014 22:19:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50172) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzHYi-0004HP-4m for submit@debbugs.gnu.org; Fri, 03 Jan 2014 22:05:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzHYb-0007mf-F5 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 22:05:55 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:41447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHYb-0007ma-Bl for submit@debbugs.gnu.org; Fri, 03 Jan 2014 22:05:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHYV-00036F-GJ for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:05:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzHYP-0007mC-FO for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:05:43 -0500 Received: from mail-ee0-f47.google.com ([74.125.83.47]:63547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzHYP-0007m4-9r for bug-coreutils@gnu.org; Fri, 03 Jan 2014 22:05:37 -0500 Received: by mail-ee0-f47.google.com with SMTP id e51so5920756eek.20 for ; Fri, 03 Jan 2014 19:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=sokgYJQ7hYwz+rH23FKH+6q0RTh2bDvvFthvEG02KOk=; b=fk8MVZLvzZyhfW4/ffJxf42Kg2rCX+NrPl0gWsVwUSZ9EuZhRoF9PrHx4N+WI92txV RAstnhFlZC3OonI7RAG0IYM2JcKbIsUwcfaTC3u5OioTsdr6QVwoxnm66wFRglak9Xz+ 8Tt2PNm8jfEcvw7H/42xRqCk9RBvxVi8PMEo7PK7PjHi2kpuP4n2rj9sHzf9FAkj8uLJ YmWb/tFZ4xBv6RCs8v3mWntANN6XkydE1w48lT+bxBju3pqQQl7pWq/3aSsqxUGfuQYN hKkO6vfa3LQio8EgzmTs0pU4B4lM1zyY/PDKMP2IZYckBVt4TbIwXzhByg6KADP+hVxv QwMg== X-Received: by 10.14.99.129 with SMTP id x1mr5163808eef.89.1388804701199; Fri, 03 Jan 2014 19:05:01 -0800 (PST) Received: from [192.168.178.43] (5357E65C.cm-6-8d.dynamic.ziggo.nl. [83.87.230.92]) by mx.google.com with ESMTPSA id b41sm149891856eef.16.2014.01.03.19.04.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 03 Jan 2014 19:04:59 -0800 (PST) From: Pieter van Voorst Vader Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Message-Id: Date: Sat, 4 Jan 2014 04:04:58 +0100 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) X-Mailer: Apple Mail (2.1510) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 03 Jan 2014 22:19:35 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 04 Jan 2014 00:28:49 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 03:20:15 -0000 Hi bug-coreutils, got this bug in tail for a hfsplus filesystem on ubuntu 13.10 tail: unrecognized file system type 0x0000482b for =91serviio.log=92. = please report this to bug-coreutils@gnu.org. reverting to polling with kind regards, Pieter= From MAILER-DAEMON Sat Jan 04 01:02:14 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzKJK-0008Md-QE for mharc-bug-coreutils@gnu.org; Sat, 04 Jan 2014 01:02:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzKJD-0008L1-N9 for bug-coreutils@gnu.org; Sat, 04 Jan 2014 01:02:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzKJ8-00034b-VA for bug-coreutils@gnu.org; Sat, 04 Jan 2014 01:02:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:47092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzKJ8-00034X-Ra for bug-coreutils@gnu.org; Sat, 04 Jan 2014 01:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzKJ8-0001xx-AH for bug-coreutils@gnu.org; Sat, 04 Jan 2014 01:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16336: bug report tail with hfsplus filesystem Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Pieter van Voorst Vader Received: via spool by 16336-submit@debbugs.gnu.org id=B16336.13888152827497 (code B ref 16336); Sat, 04 Jan 2014 06:02:02 +0000 Received: (at 16336) by debbugs.gnu.org; 4 Jan 2014 06:01:22 +0000 Received: from localhost ([127.0.0.1]:32878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzKIT-0001wq-G1 for submit@debbugs.gnu.org; Sat, 04 Jan 2014 01:01:21 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:54227) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzKIP-0001wf-44 for 16336@debbugs.gnu.org; Sat, 04 Jan 2014 01:01:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAPOix1JtTKTr/2dsb2JhbAANS71AgSKDGQEBAQQyAUYQCw0LCSUPAkYGDQEFAgEBiAWoZJpiF48OB4Q3AQOfA45V Received: from unknown (HELO [192.168.1.79]) ([109.76.164.235]) by mail1.vodafone.ie with ESMTP; 04 Jan 2014 06:01:15 +0000 Message-ID: <52C7A39C.90507@draigBrady.com> Date: Sat, 04 Jan 2014 06:01:00 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16336@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 06:02:12 -0000 On 01/04/2014 03:04 AM, Pieter van Voorst Vader wrote: > Hi bug-coreutils, > got this bug in tail for a hfsplus filesystem on ubuntu 13.10 > > tail: unrecognized file system type 0x0000482b for serviio.log. please report this to bug-coreutils@gnu.org. reverting to polling Cool thanks, we'll add this, probably identified as HFS+ A little searching also suggests adding 0x4858 for HFSX might be useful also. cheers, Pdraig. From MAILER-DAEMON Sat Jan 04 06:33:46 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzPUA-0007oz-55 for mharc-bug-coreutils@gnu.org; Sat, 04 Jan 2014 06:33:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzP0V-0001U6-Jf for bug-coreutils@gnu.org; Sat, 04 Jan 2014 06:03:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzP0Q-0007QE-N7 for bug-coreutils@gnu.org; Sat, 04 Jan 2014 06:03:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:47299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzP0Q-0007QA-Jn for bug-coreutils@gnu.org; Sat, 04 Jan 2014 06:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzP0Q-00021O-0i for bug-coreutils@gnu.org; Sat, 04 Jan 2014 06:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Nicolas Iooss Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 11:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16335@debbugs.gnu.org Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.13888333417709 (code B ref 16335); Sat, 04 Jan 2014 11:03:01 +0000 Received: (at 16335) by debbugs.gnu.org; 4 Jan 2014 11:02:21 +0000 Received: from localhost ([127.0.0.1]:33085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzOzl-00020H-50 for submit@debbugs.gnu.org; Sat, 04 Jan 2014 06:02:21 -0500 Received: from mx1.polytechnique.org ([129.104.30.34]:34409) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzOzi-000206-0y for 16335@debbugs.gnu.org; Sat, 04 Jan 2014 06:02:19 -0500 Received: from [10.5.5.101] (11.147.102.84.rev.sfr.net [84.102.147.11]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 0A39E1406E70A for <16335@debbugs.gnu.org>; Sat, 4 Jan 2014 12:02:15 +0100 (CET) Message-ID: <52C7EA36.8020302@m4x.org> Date: Sat, 04 Jan 2014 12:02:14 +0100 From: Nicolas Iooss Organization: M4X User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> In-Reply-To: <52C779EA.2040202@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Sat Jan 4 12:02:16 2014 +0100 (CET)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 04 Jan 2014 06:33:41 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 11:03:12 -0000 On 04/01/2014 04:03, Pdraig Brady wrote : > On 01/04/2014 01:42 AM, Pdraig Brady wrote: >> On 01/03/2014 10:08 PM, Nicolas Iooss wrote: >>> Hello, >>> >>> After upgrading to coreutils 8.22 I can no longer build packages which >>> uses "cp -a" to copy files due to a segmentation fault happening in >>> libselinux. >>> >>> I've tried to reproduce this bug with few commands, in a directory which >>> doesn't have any default context: >>> >>> $ mkdir /tmp/foobar >>> $ matchpathcon >>> /tmp/foobar <> >>> $ touch /tmp/foobar/a >>> $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b >>> $ fakeroot cp -a /tmp/foobar/a /tmp/foobar/b >>> /usr/bin/fakeroot: line 181: 9207 Segmentation fault >>> >>> Without fakeroot there is no segmentation fault. >>> >>> Even if the message says "/usr/bin/fakeroot", a coredump has been >>> created for cp. I've analyzed this dump using gdb and after some >>> debugging, I found out that restorecon_private (from src/selinux.c) was >>> calling lsetfilecon with a NULL security context which was obtained by >>> getfscreatecon (case "local = true" in the code [1]). This causes a null >>> pointer dereference in libselinux and so a SIGSEGV. >>> >>> I've reported this bug to libselinux maintainers [2] and got the reply >>> that calling lsetfilecon with a NULL security context was like calling >>> strlen with a NULL string and that this was a problem in caller's code [3]. >>> >>> Hence I propose the attached patch to fix the segmentation fault. Could >>> you please accept it? >>> >>> When you reply, please Cc me as I'm not subscribed. >>> >>> Thanks, >>> >>> Nicolas Iooss >>> >>> ----------- >>> >>> System configuration during my tests: >>> >>> * distro: ArchLinux which SELinux packages >>> * CPU arch: x86_64 >>> * SELinux in permissive mode >>> * coreutils 8.22 >>> * libselinux 2.2.1 >>> * fakeroot 1.20 >>> >>> [1] >>> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/selinux.c;hb=v8.22#l191 >>> [2] http://marc.info/?l=selinux&m=138763485330568&w=2 >>> [3] http://marc.info/?l=selinux&m=138842015508829&w=2 >> >> Thanks for the very thorough analysis and patch. >> The patch looks correct as getfscreatecon() is >> documented to return a NULL context in some cases. >> I'll see if I can add a robust test and will apply >> this in your name. Thanks for your quick reply. > > Actually what's errno set to with tcon is NULL. > If if was 0 you might get the classic "error success" message > if using the --preserve=context option rather than -a for example. According to libselinux code [4], when "fscreate" attribute is empty, getfscreatecon sets the security context to NULL and returns 0 without setting errno. Hence if it remains zero, set_file_security_ctx from src/copy.c will report the "error success" message. > > I.E. the following might be more appropriate. I agree. With your patch I get this (as expected): $ fakeroot cp --preserve=context a b cp: failed to get security context of 'a': No data available > Note neither Fedora 15 or 20 here produce a NULL value with fakeroot. On my system, fakeroot (version 1.20) doesn't seem to support xattr: $ fakeroot getfattr -m - -d /tmp/foobar/a $ getfattr -m - -d /tmp/foobar/a getfattr: Suppression des / en tte des chemins absolus # file: tmp/foobar/a security.selinux="unconfined_u:object_r:user_tmp_t:s0" > > thanks, > Pdraig. > > diff --git a/src/selinux.c b/src/selinux.c > index cd38a81..016db16 100644 > --- a/src/selinux.c > +++ b/src/selinux.c > @@ -192,6 +192,11 @@ restorecon_private (char const *path, bool local) > { > if (getfscreatecon (&tcon) < 0) > return rc; > + if (!tcon) > + { > + errno = ENODATA; > + return rc; > + } > rc = lsetfilecon (path, tcon); > freecon (tcon); > return rc; > Nicolas [4] http://userspace.selinuxproject.org/trac/browser/libselinux/src/procattr.c?rev=edc2e99687b050d5be21a78a66d038aa1fc068d9#L176 From MAILER-DAEMON Sat Jan 04 13:05:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VzVb2-0006Bl-Vu for mharc-bug-coreutils@gnu.org; Sat, 04 Jan 2014 13:05:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzVPJ-00046B-7u for bug-coreutils@gnu.org; Sat, 04 Jan 2014 12:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzVPC-0007XJ-PG for bug-coreutils@gnu.org; Sat, 04 Jan 2014 12:53:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzVPC-0007X2-EH for bug-coreutils@gnu.org; Sat, 04 Jan 2014 12:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzVPC-0007MC-7S for bug-coreutils@gnu.org; Sat, 04 Jan 2014 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16329: Re[2]: bug#16329: `head --lines=-0' prints nothing if no newline at the EOF Resent-From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 04 Jan 2014 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake Received: via spool by 16329-submit@debbugs.gnu.org id=B16329.138885797028257 (code B ref 16329); Sat, 04 Jan 2014 17:53:02 +0000 Received: (at 16329) by debbugs.gnu.org; 4 Jan 2014 17:52:50 +0000 Received: from localhost ([127.0.0.1]:34139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzVOz-0007Lg-Jx for submit@debbugs.gnu.org; Sat, 04 Jan 2014 12:52:49 -0500 Received: from f433.i.mail.ru ([185.5.136.104]:45664) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzVOw-0007LU-Ke for 16329@debbugs.gnu.org; Sat, 04 Jan 2014 12:52:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail2; h=References:In-Reply-To:Content-Transfer-Encoding:Content-Type:Message-ID:Reply-To:Date:Mime-Version:Subject:Cc:To:From; bh=h3Qzzf+acyNaRYjmrK0UP3UZbXnOWlZZzs0NbyRbz3g=; b=TBTveHllpPKgwfujp/FIjt4cf+En5YtPSnvYCjD3ScfxUEHwPHAm2FW12mAv+7GDra7pvB37mSdu3h9ACS6RXy5ZMWmJWAuE9OjIS7HBNIFPLirTl5jddGwhIQV9N9xEOspeZMDBlxenGsWza2SPRjRW+oVvoeB09xfWbLFInOo=; Received: from mail by f433.i.mail.ru with local (envelope-from ) id 1VzVOu-0006Uq-53; Sat, 04 Jan 2014 21:52:44 +0400 Received: from [109.172.69.18] by e.mail.ru with HTTP; Sat, 04 Jan 2014 21:52:44 +0400 From: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [109.172.69.18] Date: Sat, 04 Jan 2014 21:52:44 +0400 X-Priority: 3 (Normal) Message-ID: <1388857964.843477226@f433.i.mail.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Mras: Ok X-Spam: undefined In-Reply-To: <52C6EBF5.9000407@redhat.com> References: <1388764256.577663010@f412.i.mail.ru> <52C6EBF5.9000407@redhat.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 04 Jan 2014 13:05:15 -0500 Cc: 16329@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org Reply-To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2014 17:53:14 -0000 0J/Rj9GC0L3QuNGG0LAsICAzINGP0L3QstCw0YDRjyAyMDE0LCA5OjU3IC0wNzowMCDQvtGCIEVy aWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPjoKPlBlciBQT1NJWCwgJ2hlYWQnIGlzIG9ubHkg cmVxdWlyZWQgdG8gb3BlcmF0ZSBvbiAidGV4dCBmaWxlcyIKPmh0dHA6Ly9wdWJzLm9wZW5ncm91 cC5vcmcvb25saW5lcHVicy85Njk5OTE5Nzk5L3V0aWxpdGllcy9oZWFkLmh0bWwKPmFuZCBhICJ0 ZXh0IGZpbGUiIG11c3QgZWl0aGVyIGJlIGVtcHR5IG9yIGhhdmUgYSB0cmFpbGluZyBuZXdsaW5l Ogo+aHR0cDovL3B1YnMub3Blbmdyb3VwLm9yZy9vbmxpbmVwdWJzLzk2OTk5MTk3OTkvYmFzZWRl ZnMvVjFfY2hhcDAzLmh0bWwjdGFnXzAzXzM5Nwo+Cj5TbyB0aGlzIGlzIG5vdCBuZWNlc3Nhcmls eSBhIGJ1Zy4KCldoaWxlIEkgZ2VuZXJhbGx5IGFncmVlLCB0aGF0IGN1cnJlbnQgYGhlYWQnIGlt cGxlbWVudGF0aW9uIGRvZXNuJ3QgdmlvbGF0ZSB0aGUgc3RhbmRhcmQsIEkgc3RpbGwgY29uc2lk ZXIKaXQgYSBidWcsIGJlY2F1c2U6CgogKiBgaGVhZCAtbiAtTiBmaWxlbmFtZScgd29ya3MgdGhl IHNhbWUgd2F5IG9uIGZpbGVzIGJvdGggd2l0aCBhbmQgd2l0aG91dCB0cmFpbGluZyBuZXdsaW5l IGZvciBhbGwgTgogICBleGNlcHQgTiA9PSAwLiBGb3IgZXhhbXBsZToKCiAgICQgcHJpbnRmICcx XG4yXG4zJyA+IHRlc3QKICAgJCBoZWFkIC1uIC0xIHRlc3QKICAgMQogICAyCiAgICQgaGVhZCAt biAtMCB0ZXN0CiAgICQgCgogICBJbiBmYWN0LCBgaGVhZCcgd2FzIHdyaXR0ZW4gZXhwbGljaXRs eSB0byBjb25zaWRlciB0aGF0IHRyYWlsaW5nIG5ld2xpbmUgaXMgbm90IGFsd2F5cyBwcmVzZW50 IFsxXS4KCiAgIFRoZSBvbmx5IHJlYXNvbiBOID09IDAgY2FzZSB3b3JrcyBkaWZmZXJlbnRseSBp cyB0aGF0IHRoZSBgbl9saW5lcycgdmFyaWFibGUsIGJlaW5nIHVuc2lnbmVkIGFuZCBlcXVhbAog ICB0byAwLCBpcyBkZWNyZW1lbnRlZCBbMl0sIGFuZCwgYXMgYSByZXN1bHQgb2YgYW4gaW50ZWdl ciB1bmRlcmZsb3csIGdldHMgYSB2ZXJ5IGJpZyAoVUlOVDY0X01BWCkKICAgdmFsdWUsIHdoaWNo IGluIHR1cm4sIGhhdmluZyBpbiBtaW5kIHRoZSAnYWxsIGJ1dCB0aGUgbGFzdCBLIGxpbmVzJyBt ZWFuaW5nLCBsZWFkcyB0byBlbXB0eSBvdXRwdXQuCgogICBJIGd1ZXNzLCBpdCdzIGhpZ2hseSB1 bmxpa2VseSB0byBiZSB0aGUgaW50ZW5kZWQgYmVoYXZpb3IuCgogKiBgdGFpbCAtbiArMCBmaWxl bmFtZScgaGFzIHRoZSB2ZXJ5IHNhbWUgbWVhbmluZyBhY2NvcmRpbmcgdG8gaXRzJyBtYW51YWws IGFuZCBpdCB3b3JrcyBqdXN0IGZpbmU6CgogICAkIHRhaWwgLW4gKzAgdGVzdDsgZWNobwogICAx CiAgIDIKICAgMwogICAkIAoKVG8gc3VtIHVwLCBjdXJyZW50IGBoZWFkJyBiZWhhdmlvciBpcyBs aWtlbHkgdW5pbnRlbmRlZCwgaW5jb25zaXN0ZW50IGFuZCBjb25mdXNpbmcuIFRoYXQncyB3aHkg SSBzdGlsbApjb25zaWRlciBpdCBhIGJ1ZywgbWF5YmUgb2YgYSBsZXNzZXIgcHJpb3JpdHkuCgpb MV0gaHR0cDovL2dpdC5zYXZhbm5haC5nbnUub3JnL2dpdHdlYi8/cD1jb3JldXRpbHMuZ2l0O2E9 YmxvYjtmPXNyYy9oZWFkLmM7aD1kZGFhOTkwNmI0MWVjYzIwZmJiNjdmODdmYWI0MzMwNGM5Y2Ni Njc0O2hiPUhFQUQjbDYzOQpbMl0gaHR0cDovL2dpdC5zYXZhbm5haC5nbnUub3JnL2dpdHdlYi8/ cD1jb3JldXRpbHMuZ2l0O2E9YmxvYjtmPXNyYy9oZWFkLmM7aD1kZGFhOTkwNmI0MWVjYzIwZmJi NjdmODdmYWI0MzMwNGM5Y2NiNjc0O2hiPUhFQUQjbDY0MQoKLS0gCtCQ0LvQtdC60YHQtdC5INCo 0LjQu9C40L0K From MAILER-DAEMON Tue Jan 07 12:05:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0a5b-0002Mp-HB for mharc-bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:05:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Zp5-0005Jh-Qh for bug-coreutils@gnu.org; Tue, 07 Jan 2014 11:48:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Zoz-0006Jt-M1 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 11:48:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:55438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Zoz-0006Jp-If for bug-coreutils@gnu.org; Tue, 07 Jan 2014 11:48:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0Zoz-0008PP-8o for bug-coreutils@gnu.org; Tue, 07 Jan 2014 11:48:05 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16386: maybe a small Bug in date? Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 07 Jan 2014 16:48:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16386 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16386@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.138911327732264 (code B ref -1); Tue, 07 Jan 2014 16:48:05 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2014 16:47:57 +0000 Received: from localhost ([127.0.0.1]:41218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0Zop-0008OG-3l for submit@debbugs.gnu.org; Tue, 07 Jan 2014 11:47:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0YjT-0006S5-Ro for submit@debbugs.gnu.org; Tue, 07 Jan 2014 10:38:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0YjO-0008Oq-BU for submit@debbugs.gnu.org; Tue, 07 Jan 2014 10:38:19 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:60596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0YjO-0008Om-9F for submit@debbugs.gnu.org; Tue, 07 Jan 2014 10:38:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0YjJ-0002iK-5h for bug-coreutils@gnu.org; Tue, 07 Jan 2014 10:38:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0YjD-0008LE-Pq for bug-coreutils@gnu.org; Tue, 07 Jan 2014 10:38:09 -0500 Received: from mx-relay02-haj2.antispameurope.com ([83.246.65.202]:35242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0YjD-0008JZ-CV for bug-coreutils@gnu.org; Tue, 07 Jan 2014 10:38:03 -0500 Received: from green-2.mvv.de ([212.65.8.62]) by mx-gate02-haj2.antispameurope.com; Tue, 07 Jan 2014 16:37:55 +0100 Received: from green-2.mvv.de (localhost [127.0.0.1]) by green-2.mvv.de (Postfix) with ESMTP id 4CC995605D for ; Tue, 7 Jan 2014 16:37:53 +0100 (CET) Received: from MA-EX14.konzern.mvvcorp.de (unknown [172.24.16.44]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by green-2.mvv.de (Postfix) with ESMTPS id 3C23456055 for ; Tue, 7 Jan 2014 16:37:53 +0100 (CET) Received: from MA-EX21.KONZERN.MVVCORP.DE (172.24.12.221) by MA-EX14.konzern.mvvcorp.de (172.24.16.44) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 7 Jan 2014 16:37:53 +0100 Received: from MA-EX16.KONZERN.MVVCORP.DE ([fe80::583d:904f:23f3:c4b4]) by MA-EX21.konzern.mvvcorp.de ([169.254.1.112]) with mapi id 14.02.0347.000; Tue, 7 Jan 2014 16:37:53 +0100 From: Thread-Topic: maybe a small Bug in date? Thread-Index: Ac8Lvmxd3CrQbphpQV+3QG1cWVTfkA== Date: Tue, 7 Jan 2014 15:37:51 +0000 Message-ID: <00AD31776C34314B9930069C208ABAE32245745D@MA-EX16.konzern.mvvcorp.de> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [172.20.20.16] Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0009_01CF0BC6.CE722150" MIME-Version: 1.0 X-cloud-security-sender: thomas.dohl@soluvia.de X-cloud-security-recipient: bug-coreutils@gnu.org X-cloud-security-crypt: load encryption module X-cloud-security-Virusscan: CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-gate02-haj2 with 00EBC6EC004 X-cloud-security-connect: green-2.mvv.de[212.65.8.62], TLS=, IP=212.65.8.62 X-cloud-security: scantime:.7773 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Tue, 07 Jan 2014 11:47:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Tue, 07 Jan 2014 12:05:12 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 16:48:17 -0000 ------=_NextPart_000_0009_01CF0BC6.CE722150 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello, could this be a bug in date? date --version date (GNU coreutils) 8.4 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie. bug report: ------------------------------------------------------ OK: date -> Tue Jan 7 16:27:06 CET 2014 OK: date +%V_%Y -d "last wednesday" -> 01_2014 OK: date +%V_%Y -d "last wednesday +1 week" -> 02_2014 ... OK: date +%V_%Y -d "last wednesday +51 week" -> 52_2014 WRONG: date +%V_%Y -d "last wednesday +52 week" -> 01_2014 This should be 01_2015: ^^^^ OK: date +%V_%Y -d "last wednesday +53 week" -> 02_2015 OK: date +%V_%Y -d "last wednesday +54 week" -> 03_2015 ... My system: uname -a Linux ... 2.6.32-431.1.2.0.1.el6.x86_64 #1 SMP Fri Dec 13 13:06:13 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux less /etc/redhat-release CentOS release 6.5 (Final) Thanks and best regards. Thomas Dohl Mit freundlichen Gr=FC=DFen, Soluvia=A0IT-Services GmbH Netz & Security / Rechenzentrum & Infrastruktur Thomas Dohl Telefon: +49 (0)621-290-3839 Fax:=A0=A0=A0=A0=A0 +49 (0)621-290-2677 E-Mail:=A0 thomas.dohl@soluvia.de Internet: www.soluvia-it-services.de Soluvia IT-Services GmbH . Uhlenkrog 32=A0. 24113 Kiel B=FCro Mannheim: Luisenring 49, 68159 Mannheim Handelsregister-Nr. HRB 7458Ki, Sitz und Amtsgericht: Kiel Gesch=E4ftsf=FChrer: Dr. Dirk Bevers, Dr. Simon Kalvoda Diese E-Mail k=F6nnte vertrauliche und/oder rechtlich gesch=FCtzte = Informationen enthalten. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrt=FCmlich erhalten haben, informieren Sie bitte sofort den Absender = und vernichten Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail ist nicht gestattet. ------=_NextPart_000_0009_01CF0BC6.CE722150 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIU/zCCBl0w ggRFoAMCAQICAwIFQDANBgkqhkiG9w0BAQUFADBUMRQwEgYDVQQKEwtDQWNlcnQgSW5jLjEeMBwG A1UECxMVaHR0cDovL3d3dy5DQWNlcnQub3JnMRwwGgYDVQQDExNDQWNlcnQgQ2xhc3MgMyBSb290 MB4XDTEzMDcyNjA3Mjk1NFoXDTE1MDcyNjA3Mjk1NFowPTEUMBIGA1UEAxMLVGhvbWFzIERvaGwx JTAjBgkqhkiG9w0BCQEWFnRob21hcy5kb2hsQHNvbHV2aWEuZGUwggIiMA0GCSqGSIb3DQEBAQUA A4ICDwAwggIKAoICAQDrtOzxigwnQNsI2pxfAugrRkQhyUZZwLbMQMaencxUsX+qlTKQJ1LboGYs BysMG6S/gBHyg5f2CxyUVh1/qlvU/WVRcWmb/fWil8GqeLr2mrv8mRPH/UhbR+oKTC+61UbN/NA8 g2jiM+7gY8bRrbldfDBfKMkOwqkvpnSzFfUUiIDpDIAP55nO3OAlt4WDgghh+8aNkfH7JlwTMeEb Nt+loR8uu5Dsa/PogxVox0lg+0h4pdMu99f0wr2kHgZ0torafoDRoEJ2RxvBiwc5DLejGeh35TuU blTEvtC+XdpHzN4/4/4R1CHgrvH0fJHAVWehU6P4rZ/iYCQ09jHOnqJfGqlIKaHVbE1f/zUdqkEK dq+T9PCyhTtLt6Ux8Fj/3DlznKzQSMtiOycE69/ZG3ET9rD3/8j5xz13PdnT0eKBA8wAYY+Klyu3 AFwFLm0/hfh/0QXzncHfC5IXjmyNWy/0Hwgn6/vWgUnO30A6IouSHKvnOpI6okhFEmF3fLT6YYgv ZddvzUuusQhxg8J3K0X4De2h0jwX464h1GbXhEEh6l7ZqrkfLbbQFd3j4s2uEotkEeGaUnrA8jCM YDxD4/aij3Jnn46bPlq6YG0QsehPIXcFjfnbHe7lbE2u/2HB/XeffBz7hr+pxnrjWxqwwzS9f4iB 6Nn1upixcAjG/XZzYwIDAQABo4IBTTCCAUkwDAYDVR0TAQH/BAIwADBWBglghkgBhvhCAQ0ESRZH VG8gZ2V0IHlvdXIgb3duIGNlcnRpZmljYXRlIGZvciBGUkVFIGhlYWQgb3ZlciB0byBodHRwOi8v d3d3LkNBY2VydC5vcmcwDgYDVR0PAQH/BAQDAgOoMEAGA1UdJQQ5MDcGCCsGAQUFBwMEBggrBgEF BQcDAgYKKwYBBAGCNwoDBAYKKwYBBAGCNwoDAwYJYIZIAYb4QgQBMDIGCCsGAQUFBwEBBCYwJDAi BggrBgEFBQcwAYYWaHR0cDovL29jc3AuY2FjZXJ0Lm9yZzA4BgNVHR8EMTAvMC2gK6AphidodHRw Oi8vY3JsLmNhY2VydC5vcmcvY2xhc3MzLXJldm9rZS5jcmwwIQYDVR0RBBowGIEWdGhvbWFzLmRv aGxAc29sdXZpYS5kZTANBgkqhkiG9w0BAQUFAAOCAgEAH8GNZo1i19q92hYFmaCrZN/ntmbvY4lm HC2CXqUaBE99KjgRG+eQ8u40dENe0DJ8QX3tvnTckveHVsBSqBxgOeidmXdwU00xYJXm0VupzQWe J7lgj9GF9tyqRwFOeZDqxp4kZY+TuRyxWSTLGdUJwdgmfWZRMvLVU92vqHDgq8Hs34Cz33B3xyKC UTAc24EnKFDz2p0vmAIjeqoDkxrbZq1CFfgxpix8VxHKYCgfa74Y6ky7TfuqdiCAkyOxuvUtsx2k 8BuYEsT7D/wYMbt2BpYsZ5FWsHPtlgtVwUdknJtXUkbPYmOrdr6790Y3BxCvICvON7GX/YEfjiQX kjQ9CYu0Jf6W5o3ehFKHJCs3yiw5Fgc6QPYDgs5WPkzGwNjZ89mLGG0UJRr3c72kJszMIluaR/X2 BthpyzLYn/jIOOK1EtelGY6rt+zV8odbuZCqmzP3aF+yl22Pj7KpnyjgQ7vyYEMrEQp29Hn3Hoa4 +Sbs6CPj+WbkQYbpaLlHW0XdNuzN+/YPxGs+ClpXYJ35afkC0HXp81EO0exdO8/dKEidaHBrCkmT mNkbNAVhgy5aZEN66wALUXc9pDsQjzGs0oKd62r0hR3zSDVnE6C/qHSyA73ySM4InQw5nmYaTfhB VLVHUa/4D8ZVft5/TAnZPzos+/5zEyPaMuqhDhJ4PU4wggc9MIIFJaADAgECAgEAMA0GCSqGSIb3 DQEBBAUAMHkxEDAOBgNVBAoTB1Jvb3QgQ0ExHjAcBgNVBAsTFWh0dHA6Ly93d3cuY2FjZXJ0Lm9y ZzEiMCAGA1UEAxMZQ0EgQ2VydCBTaWduaW5nIEF1dGhvcml0eTEhMB8GCSqGSIb3DQEJARYSc3Vw cG9ydEBjYWNlcnQub3JnMB4XDTAzMDMzMDEyMjk0OVoXDTMzMDMyOTEyMjk0OVoweTEQMA4GA1UE ChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBD ZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcw ggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQDOIsDiRn3sNigHUJbyoDNAjEvxO2Y/MeVr Ajbb1nz28YiPTnc2BUGV+QnwEs9GhnNgt25+6MBYZK7NsK1FFwxj+mcK6NbSvz7nmMTwTPrgA7s1 XWwh3p4g2brNZjI3cvr3CPXHzVjJjucOXuo+/hyhFAoVbIaEW2RmKnqpS1N59Yiie+4vCmErjbJ+ TValE+zq2pKerERBHlhgZQVm+MBEvcuU90J+C/dlaJhRBfDzBZEEHRsXguzIV7vDa3qI8bByzCVb IJHsFgISjzLpFxhI0McFLgIwQrglnAVrP6o6p+tTSPfo0rYHmNwbxjR/f8kcgnoFWCsIW/M4oqsX XWbJmNeeEIui0t10mvdxDHJg381vmDOdljR2PiR6krAOlR5v5qBFOEeq10HtSrcS9tcbg4oPLtgJ tlnXqgT/0pN9aC7di0urWLovjeqVp6DDVIml+9uLUSKdssO+Eb4skYaLlnitINOKLxo/xtBRZYch sRkBZX9FHIf1fNBBTE8pmCH9Mx91DARR+hl329QUHO6Bwx31mLdpBpEi3QBQzIExrBIHezjaaFvm K9R+yV+t6OtyTPMB5Usgv5qmV8qRAAGLoXUhN7VjDWc+Rk9wIGfOxdZZ2wLg8NLLzbpit5BB6N0g 5Cm8ZClCyCLceJr/Q+yYGwlRS1pawnHxxMtzqeWhCwIDAQABo4IBzjCCAcowHQYDVR0OBBYEFBa1 MhvUx/Pg5o7zvdKwOu6yORjRMIGjBgNVHSMEgZswgZiAFBa1MhvUx/Pg5o7zvdKwOu6yORjRoX2k ezB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAg BgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRA Y2FjZXJ0Lm9yZ4IBADAPBgNVHRMBAf8EBTADAQH/MDIGA1UdHwQrMCkwJ6AloCOGIWh0dHBzOi8v d3d3LmNhY2VydC5vcmcvcmV2b2tlLmNybDAwBglghkgBhvhCAQQEIxYhaHR0cHM6Ly93d3cuY2Fj ZXJ0Lm9yZy9yZXZva2UuY3JsMDQGCWCGSAGG+EIBCAQnFiVodHRwOi8vd3d3LmNhY2VydC5vcmcv aW5kZXgucGhwP2lkPTEwMFYGCWCGSAGG+EIBDQRJFkdUbyBnZXQgeW91ciBvd24gY2VydGlmaWNh dGUgZm9yIEZSRUUgaGVhZCBvdmVyIHRvIGh0dHA6Ly93d3cuY2FjZXJ0Lm9yZzANBgkqhkiG9w0B AQQFAAOCAgEAKMfunIICulyAEso1Ch2Bb4lqmczyaA9/p+GNWJU+vfIGw5BarLVg9plDAaOIcJyd Yp2kh69nWA0wNjvmrUjTy3QChnE+4isDaPE0YkBGO1PqKPSs+2aVU4pNXf072WDXynlpO7FlkqbG gYJcnM3rTQGKpd8RVaoVyh83wIKYcGHbanyWo44uVD5PIamQ79yCv9zoRa1NkHMIPJRlsASZdn/i vMJqFaqXBDck2B6UTm0OUb7WxI/Klm33Q9/oMGUnO3u7Q0NjxEP3suxozOEZjiL7mOF7Wj4BNzuL CLCi85VOGsubzZqx27Jw8C1K29iw429FSDMS//48MipU98T3ivCII8JH/mR6ccDRHqZjsAd+pC/T AY/cnyu2xgipD5NIJfwS/Z9C3PPEPvZXsNfdadEGdzQKS9LKoP8cxozJFr7EzDI3aHNfCPtR90lT NgUKlQJM8nkaEPbYOnWc8x3xog1wZ4Ybsxb1L+Wk63mG+T0LwnMLpZmsb/xnuOUvC6YYJI170Ug1 KRhArJNg4ZaGULR6WdiPIQufz4KRxju/a9wHkbmXViOqtmyUxkgGPOTOTqrk9i8J3FNvLvx06zpj mcKmrIm8p7JEoA2KEONs8iTL+pufcEcu3hSL1LIgCZaiZPEkHNyhNZwVstS8VS59BvWcDlX0WtaT 2natJXNMxUMwggdZMIIFQaADAgECAgMKQYowDQYJKoZIhvcNAQELBQAweTEQMA4GA1UEChMHUm9v dCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYDVQQDExlDQSBDZXJ0IFNp Z25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNhY2VydC5vcmcwHhcNMTEw NTIzMTc0ODAyWhcNMjEwNTIwMTc0ODAyWjBUMRQwEgYDVQQKEwtDQWNlcnQgSW5jLjEeMBwGA1UE CxMVaHR0cDovL3d3dy5DQWNlcnQub3JnMRwwGgYDVQQDExNDQWNlcnQgQ2xhc3MgMyBSb290MIIC IjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEAq0k1EUh80iZ+U5TPQ6ndKNdCKovzh3gZWHwP ntqJfeH763KQDXShlmSrn6AkmXPa4lV2xxd79QSsRrjDvn9kjRBsJPNhnMDykPpR5vVpAWPDD1bi SkLP4kSMJSioxXkJfUa5ivPp8zQpCEXkHJ/LlAQcgagUs5hlxEPsToKNCdG9qluNktDs3pDFfwrC 4+vmMVpedD6XM1nowwM9YDO/99FvR8TN7mKDUm4uCJqk2RUYkaaFkkewrkjrbbch7IUaaHI1q//w EF3A9JSnatU7kn5MkAV+k8Esi6SOYnQVcW4LcQPqrxU4mtTSBXJvjPkr61pyJfk5RuNyGz4Ew2Qn IhAqik9YpwOtvrQuE+1dqkjX1X3UKntc+kYEUOTMDkJbjO3b8s/8lpPg2xE2VGI0OI8MYJs7l1Y4 rfPSW4ugW+pOlrh819WghnBA05Ept6I8rfWMu88akorkNHvA2Gxf6QrCw6cgmlrfLF1SXLpH1Zvv JChwOCAv1X8pwLJBA2iSzOCczJdLRe86EAqrcDqYlXCtNbHqhSukHIAhMamuYHqAJkgAuAHAk2NV IpE8Vuev2zol848xVOomi4FZ+aHRUxHFe50D9nQR4G2xLD8shpGZcZqmd4s0YNEUtCysna+MENOf xGr4bxP8c1n3ZkJ0Horj+NzSb5icy0eYlUAF++kCAwEAAaOCAg0wggIJMB0GA1UdDgQWBBR1qHFg TIgT8HjZiXe1bcWJ37yxejCBowYDVR0jBIGbMIGYgBQWtTIb1Mfz4OaO873SsDrusjkY0aF9pHsw eTEQMA4GA1UEChMHUm9vdCBDQTEeMBwGA1UECxMVaHR0cDovL3d3dy5jYWNlcnQub3JnMSIwIAYD VQQDExlDQSBDZXJ0IFNpZ25pbmcgQXV0aG9yaXR5MSEwHwYJKoZIhvcNAQkBFhJzdXBwb3J0QGNh Y2VydC5vcmeCAQAwDwYDVR0TAQH/BAUwAwEB/zBdBggrBgEFBQcBAQRRME8wIwYIKwYBBQUHMAGG F2h0dHA6Ly9vY3NwLkNBY2VydC5vcmcvMCgGCCsGAQUFBzAChhxodHRwOi8vd3d3LkNBY2VydC5v cmcvY2EuY3J0MEoGA1UdIARDMEEwPwYIKwYBBAGBkEowMzAxBggrBgEFBQcCARYlaHR0cDovL3d3 dy5DQWNlcnQub3JnL2luZGV4LnBocD9pZD0xMDA0BglghkgBhvhCAQgEJxYlaHR0cDovL3d3dy5D QWNlcnQub3JnL2luZGV4LnBocD9pZD0xMDBQBglghkgBhvhCAQ0EQxZBVG8gZ2V0IHlvdXIgb3du IGNlcnRpZmljYXRlIGZvciBGUkVFLCBnbyB0byBodHRwOi8vd3d3LkNBY2VydC5vcmcwDQYJKoZI hvcNAQELBQADggIBACkoha5EqbmvpHkT8KijK5dg81zu4y/B9uJmoBGuNjc6dhUEU+pC9fnqwBXY poLZ5GGucgspXJBD6EGy4XfbAhNEeEdVr1j8zJj2RbnRIPjYIQf+bapz1LPGB+kJhcw78ra+LBwl 1XGMObUu6r4Ygbqwk7gP4+bXJowxWnIDhFLmpvUzIkUKyAsNirg2b5AJoau919VOLnGi1K76p1Qr 6zWNWrdUiC/udJ/tSBbKDUjQlNOspKL2JN+S473rQ0CRbhwYjla0ghLzqZOf1LycrZx17lqXG5Xn dC0cD7Asl5/7qTM5eucDOpKOIvaMDeTZfg12GPcB+e+WlqJVc8A8cbQdGlZDt8MKjXL84hAJC0HO jJSg+QP9cXNLilcz5Y50fhUBAObMShznf5UZLcWlDIu7te2Fs1zT37i58srHDQEUrHBYxYyNM9Sd ZqMaUJUj/EjgBkMS2c2nhjkvNnKjgBDk4fPRy1sawOSAmnwTcwZP26NrJAq6sxy8Sni75eN1OKVI p6Ier3bUXvc4hlZaic7Ww6d5slKgxvGFtCWM8j+WsxDZjWxXO59vhjoYgiI2yLCRONsqoZOqhD/1 J2Wuc9XI1dN36kudx0G7x8DjoD/kfaSNc+YSS9+hc3NzOoDo1cuOL8vqE6fWQYus+jyJ1yT1TrTg YZK38zeYxL6Wo7eKMYIEazCCBGcCAQEwWzBUMRQwEgYDVQQKEwtDQWNlcnQgSW5jLjEeMBwGA1UE CxMVaHR0cDovL3d3dy5DQWNlcnQub3JnMRwwGgYDVQQDExNDQWNlcnQgQ2xhc3MgMyBSb290AgMC BUAwCQYFKw4DAhoFAKCCAeUwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUx DxcNMTQwMTA3MTUzNzUxWjAjBgkqhkiG9w0BCQQxFgQU1LuHAWU4XazeG2uQI0hzPGFhBlYwagYJ KwYBBAGCNxAEMV0wWzBUMRQwEgYDVQQKEwtDQWNlcnQgSW5jLjEeMBwGA1UECxMVaHR0cDovL3d3 dy5DQWNlcnQub3JnMRwwGgYDVQQDExNDQWNlcnQgQ2xhc3MgMyBSb290AgMCBUAwbAYLKoZIhvcN AQkQAgsxXaBbMFQxFDASBgNVBAoTC0NBY2VydCBJbmMuMR4wHAYDVQQLExVodHRwOi8vd3d3LkNB Y2VydC5vcmcxHDAaBgNVBAMTE0NBY2VydCBDbGFzcyAzIFJvb3QCAwIFQDCBqwYJKoZIhvcNAQkP MYGdMIGaMAsGCWCGSAFlAwQBKjALBglghkgBZQMEARYwCgYIKoZIhvcNAwcwCwYJYIZIAWUDBAEC MA4GCCqGSIb3DQMCAgIAgDAHBgUrDgMCBzANBggqhkiG9w0DAgIBQDANBggqhkiG9w0DAgIBKDAH BgUrDgMCGjALBglghkgBZQMEAgMwCwYJYIZIAWUDBAICMAsGCWCGSAFlAwQCATANBgkqhkiG9w0B AQEFAASCAgAttBOsP/Fw56GGhwiixSrCERDWXmf6n0PHsMiOnxdx6iPHMlpzRLF1kTHdbFaEWfv4 5+5WWwLhVXdCnIkVBMMrAlSoxUhk1ZMJbcZcurEMBD5aR1eWzx2PwfnAX3nBCotAireGqTsM0uP9 Ac1Y8/ZBM1+YeIhTn37OLfs7tBX2wNkmiJAnBKFYmyDOj234wgOJk4quik9P8CXOs6MLg7F4pKWa 4kG4VFM8s08zHFjRVS5Hf8pF5wuodzgaKQdxdQu7DApd+NuAr1vU75kXT618rOzgTJBxXVloBSOr FDzCMgKET4oxuupJJA5P7HtD9g/6GRaYS6FuULr5ahJa0UpoOhiOPCYrpT5NZoI8+ZPVpHBBTyU7 oN4I4ATHYMcGWhkU32D6p1RKFM6NaAUBZxdCD2R39crbmAyYrhnC2AgHeJh9mbruE+1n4LpzK4/n zWTXjYy79vBioSmpjtEcmjZ75JnX0vJ1gImDb91zfOYBZKG1U5Iv1t5NTVIM6DqDMNPU/Y3Vmjar RQosS9rfyKqC8VqSFGDDBnvGC0/V7k57GU45g8jVTsOEm5ZNeHl5Qq9YQ80l36moDtGL2ol8ARKf eU869ImdkFmzXC7dpGl/+vu33ZwEEAynmwAT1DpSOUnohh0dJ6k+QzKZA0B8JC7YJ0z3Rqcq6N4e Cs5EDirlsQAAAAAAAA== ------=_NextPart_000_0009_01CF0BC6.CE722150-- From MAILER-DAEMON Tue Jan 07 12:12:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0aCL-0007Ft-PR for mharc-bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:12:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0aCG-00078m-F1 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0aCB-00085w-Ji for bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:12:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:55484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0aCB-00085s-H7 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:12:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0aCB-0000gq-B1 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 12:12:03 -0500 Subject: bug#16386: maybe a small Bug in date? Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Tue, 07 Jan 2014 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16386 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: notabug To: thomas.dohl@soluvia.de, 16386-done@debbugs.gnu.org Mail-Followup-To: 16386@debbugs.gnu.org, eblake@redhat.com, thomas.dohl@soluvia.de Received: via spool by 16386-done@debbugs.gnu.org id=D16386.13891146642539 (code D ref 16386); Tue, 07 Jan 2014 17:12:02 +0000 Received: (at 16386-done) by debbugs.gnu.org; 7 Jan 2014 17:11:04 +0000 Received: from localhost ([127.0.0.1]:41262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0aBD-0000es-Fc for submit@debbugs.gnu.org; Tue, 07 Jan 2014 12:11:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31992) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0aBA-0000eN-AX; Tue, 07 Jan 2014 12:11:01 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s07HAwgI003124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Jan 2014 12:10:59 -0500 Received: from [10.3.113.2] ([10.3.113.2]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s07HAwuu026410; Tue, 7 Jan 2014 12:10:58 -0500 Message-ID: <52CC3522.1090508@redhat.com> Date: Tue, 07 Jan 2014 10:10:58 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <00AD31776C34314B9930069C208ABAE32245745D@MA-EX16.konzern.mvvcorp.de> In-Reply-To: <00AD31776C34314B9930069C208ABAE32245745D@MA-EX16.konzern.mvvcorp.de> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qMu61KFRGTRUwBC1ts1fP3WW42xlBvELB" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 17:12:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qMu61KFRGTRUwBC1ts1fP3WW42xlBvELB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable tag 16386 notabug thanks On 01/07/2014 08:37 AM, thomas.dohl@soluvia.de wrote: > Hello, >=20 > could this be a bug in date? Thanks for the report. However, this is not a bug in date, but a misunderstanding on your part, covered in our FAQ. https://www.gnu.org/software/coreutils/faq/coreutils-faq.html#The-date-co= mmand-is-not-working-right_002e >=20 > OK: date +%V_%Y -d "last wednesday" -> 01_2014 Do not mix %V and %Y. %V goes with %G, %Y goes with %U or %W. > OK: date +%V_%Y -d "last wednesday +1 week" -> 02_2014 > ... > OK: date +%V_%Y -d "last wednesday +51 week" -> 52_2014 > WRONG: date +%V_%Y -d "last wednesday +52 week" -> 01_2014 > This should be 01_2015: ^^^^ No, you are using the wrong format string. When you mix two different formats that use different notions of when a year rolls over, you are bound to get confusing results. But those results are correct, once you re-read the documentation of what those format strings represent. > Diese E-Mail k=C3=B6nnte vertrauliche und/oder rechtlich gesch=C3=BCtzt= e Informationen This disclaimer is unenforceable on a publicly-archived mailing list. It is considered poor email etiquette to open source lists to use your employer's email if they are going to tack on garbage. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qMu61KFRGTRUwBC1ts1fP3WW42xlBvELB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSzDUiAAoJEKeha0olJ0NqlGoH/AujZlzZB3ZmWg26mBaGhTsc SbyWugcyW7bsKhtgmufDWIqvH84knZygaDpLyf5TW1/iQtNul+5b0pCpXtVkKy4u wIC7FFxYSuL3XYRsNkhMmEBNrwWyyiUf1GUQL/H7y1rGHH7eXIEQS+VYtCz2hjFF d3rwTYT7QLZErDFi/j3E4Ctdbtraj17PEJXIH/iMsG/CpnvXW+XHZumzM+9U94DF 3N4FqGrjCVoXJLjDrnBmXT6pf3Uqte0aYSO1apd4QdtFEGm6/coCfLet16GnfpbU LDEq9kIJDrIdczwSm9vsy2eOX5YafSpG1IzioVB8cQXZrb7a1AtVdYJLwx89OWk= =ziZl -----END PGP SIGNATURE----- --qMu61KFRGTRUwBC1ts1fP3WW42xlBvELB-- From MAILER-DAEMON Tue Jan 07 16:56:36 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0edX-0004bM-VK for mharc-bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:56:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmp-0003wi-PJ for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:02:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dmk-0003ev-L3 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:02:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:55759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmk-0003ec-Iq for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0dmj-0002sE-Q9 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16396: 'echo --help' does not work, but manual says it should Resent-From: Rena Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 07 Jan 2014 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16396 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16396@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138912848210971 (code B ref -1); Tue, 07 Jan 2014 21:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2014 21:01:22 +0000 Received: from localhost ([127.0.0.1]:41545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0dm5-0002qs-HE for submit@debbugs.gnu.org; Tue, 07 Jan 2014 16:01:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43649) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0dbc-0002Y8-Fd for submit@debbugs.gnu.org; Tue, 07 Jan 2014 15:50:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dbb-0000Pb-FX for submit@debbugs.gnu.org; Tue, 07 Jan 2014 15:50:32 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:60868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dbb-0000PX-Bb for submit@debbugs.gnu.org; Tue, 07 Jan 2014 15:50:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dba-0007h3-3s for bug-coreutils@gnu.org; Tue, 07 Jan 2014 15:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dbZ-0000P7-BR for bug-coreutils@gnu.org; Tue, 07 Jan 2014 15:50:30 -0500 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:39511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dbY-0000No-S6 for bug-coreutils@gnu.org; Tue, 07 Jan 2014 15:50:28 -0500 Received: by mail-qc0-f175.google.com with SMTP id n7so651124qcx.6 for ; Tue, 07 Jan 2014 12:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=FauZLjrvct663+9zApF64/noPGoKd9xT83fliiNiMkg=; b=SndE2uj6npsrsv4kHuVrgksgeX3nrWIyaPSFg4UUUIZZuB4BaM0pNpJbEF2d0d75LG TvJ9m+a4KSKW56bmIK5Z0yihj6qPstd239ToUd+dSucuiQgtFh9pY1NTFbMpvI4fV7i7 Vzceavl2DEJMWISnkmhDE4FttZy0CF4rGjpc6h06MKSp7ZWojv/e5gl/FhUfN2yjMnQH Rr1BgR8wcknhtnyWcNWzCsK/KqjckKFQnkfldgJ4oJu3gH0W3l7hEzu9yzNamn+ov7h7 sXGLmO2AGrAIf4jAyI91vSMXFEc3/EWCx2hRmJeNU18NQ3QTDVkHMICt7n5Xbo+DgrGP 2mZQ== X-Received: by 10.49.35.112 with SMTP id g16mr201242839qej.13.1389127826095; Tue, 07 Jan 2014 12:50:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.170.198 with HTTP; Tue, 7 Jan 2014 12:50:06 -0800 (PST) From: Rena Date: Tue, 7 Jan 2014 15:50:06 -0500 Message-ID: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Tue, 07 Jan 2014 16:01:20 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Tue, 07 Jan 2014 16:56:34 -0500 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 21:02:09 -0000 $ uname -a Linux guilmon 3.11.0-13-generic #20-Ubuntu SMP Wed Oct 23 07:38:26 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux $ man echo [...] --help display this help and exit --version output version information and exit [...] $ echo --help --help $ echo --version --version One of these is wrong... -- Sent from my Game Boy. From MAILER-DAEMON Tue Jan 07 17:32:58 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0fCk-00062x-Mf for mharc-bug-coreutils@gnu.org; Tue, 07 Jan 2014 17:32:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dom-0005UH-NR for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:04:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dog-0004J5-Of for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:04:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:55765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dog-0004J0-Gs for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0dog-0002vm-5E for bug-coreutils@gnu.org; Tue, 07 Jan 2014 16:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16396: derp References: In-Reply-To: Resent-From: Rena Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 07 Jan 2014 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16396 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16396@debbugs.gnu.org Received: via spool by 16396-submit@debbugs.gnu.org id=B16396.138912861111214 (code B ref 16396); Tue, 07 Jan 2014 21:04:02 +0000 Received: (at 16396) by debbugs.gnu.org; 7 Jan 2014 21:03:31 +0000 Received: from localhost ([127.0.0.1]:41550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0doA-0002uo-KO for submit@debbugs.gnu.org; Tue, 07 Jan 2014 16:03:30 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:41508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0do8-0002uf-Kx for 16396@debbugs.gnu.org; Tue, 07 Jan 2014 16:03:29 -0500 Received: by mail-qc0-f179.google.com with SMTP id i8so705430qcq.10 for <16396@debbugs.gnu.org>; Tue, 07 Jan 2014 13:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=QJjBsNHBw+mQ2ab5f28F9bYJXq0cFoP022LQTpk+VI8=; b=e8gZtdKj+Jng3AydCQ5o+fSRt6h32rpUz9xHTGPrU9sgRRCekqvDOTnYp78Xvo8zUr e4bYN8RInsM8wjQ5Os/z9uiXbnPYCfJfioRiM3jXMAvITZh7ci2Plwq/q0oE47FDPIA2 s+RR5hPuaZvXTPq49RMDkYuWbwXPHCL32t0j73GyEBencGjl82wWREOu/9IM1M/5Kshe zoM/ijsARj8jxvJ+HHI/h8s7su9ykU9UIXXeKy5uVpFRsOVqJqHLa38iqnwbkHHTRkd0 uBMrYge4hiqYbNjIn4cgI4NbUa6DP6ioAFzUdYJRO4JC6eu04k0MBgoP60IIt0/qulNK ISVA== X-Received: by 10.224.130.70 with SMTP id r6mr155584462qas.84.1389128607968; Tue, 07 Jan 2014 13:03:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.96.170.198 with HTTP; Tue, 7 Jan 2014 13:03:07 -0800 (PST) From: Rena Date: Tue, 7 Jan 2014 16:03:07 -0500 Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 22:32:56 -0000 Nevermind, I'm a dummy and forgot bash has its own `echo` built in. -- Sent from my Game Boy. From MAILER-DAEMON Tue Jan 07 18:06:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0fiy-0003Ek-3E for mharc-bug-coreutils@gnu.org; Tue, 07 Jan 2014 18:06:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0fiq-00034O-2a for bug-coreutils@gnu.org; Tue, 07 Jan 2014 18:06:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0fil-0008AG-2f for bug-coreutils@gnu.org; Tue, 07 Jan 2014 18:06:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:55861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0fik-0008A8-On for bug-coreutils@gnu.org; Tue, 07 Jan 2014 18:06:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0fik-0007am-Ge for bug-coreutils@gnu.org; Tue, 07 Jan 2014 18:06:02 -0500 Subject: bug#16396: 'echo --help' does not work, but manual says it should Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Tue, 07 Jan 2014 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16396 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: notabug To: Rena , 16396-done@debbugs.gnu.org Mail-Followup-To: 16396@debbugs.gnu.org, eblake@redhat.com, hyperhacker@gmail.com Received: via spool by 16396-done@debbugs.gnu.org id=D16396.138913595629144 (code D ref 16396); Tue, 07 Jan 2014 23:06:02 +0000 Received: (at 16396-done) by debbugs.gnu.org; 7 Jan 2014 23:05:56 +0000 Received: from localhost ([127.0.0.1]:41641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fid-0007Zz-Qz for submit@debbugs.gnu.org; Tue, 07 Jan 2014 18:05:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39547) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fib-0007Zl-Fy; Tue, 07 Jan 2014 18:05:54 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s07N5qZ2020369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Jan 2014 18:05:52 -0500 Received: from [10.3.113.2] ([10.3.113.2]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s07N5ppA025439; Tue, 7 Jan 2014 18:05:51 -0500 Message-ID: <52CC884F.1010503@redhat.com> Date: Tue, 07 Jan 2014 16:05:51 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uUS2tKSUe7VxeR3b7eivPVNwka2olGV3o" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 23:06:13 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uUS2tKSUe7VxeR3b7eivPVNwka2olGV3o Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable tag 16396 notabug thanks On 01/07/2014 01:50 PM, Rena wrote: > $ uname -a > Linux guilmon 3.11.0-13-generic #20-Ubuntu SMP Wed Oct 23 07:38:26 UTC = 2013 > x86_64 x86_64 x86_64 GNU/Linux >=20 > $ man echo > [...] > --help display this help and exit >=20 > --version > output version information and exit > [...] You elided this part of the man page... NOTE: your shell may have its own version of echo, which usually super=E2=80=90 sedes the version described here. Please refer to your shell's docu=E2=80=90 mentation for details about the options it supports. But as your followup mentions that you figured that out, I'm closing this bug. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uUS2tKSUe7VxeR3b7eivPVNwka2olGV3o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSzIhPAAoJEKeha0olJ0Nq+BcH/2Nr4CKrLVvt6FKPE7WkTcVz 0P7Jxp6uTeMh9qO42pQfyRko4EWwTDNhmRkm2ylQ6IeCHPS02z5hrVtOF5dxoZmD 8CvIUCNitfkNdZIoKxm3AFoS0oh89GDbIhIifabFnZCzpi4BGLQhuV2R2HeQ5Y4H mlEL7chw22giTiD3Wnvf2D+pguNtamDUxxMPEx6CDElbtnWLYSKYkemAe3zuUFYB ira9Pd0MU3alRP5jCpOneuSeiuONl6P+HFEMRhDmatqDQq+d1SzzWWuliv8zN40P uWzdxMoL1qj3oGrBlqpui9HS08zDjGb+nZc1b67T+i9bOzEVdA9H9i79pskXitA= =KDgU -----END PGP SIGNATURE----- --uUS2tKSUe7VxeR3b7eivPVNwka2olGV3o-- From MAILER-DAEMON Fri Jan 10 12:00:59 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W1fS7-0004fE-Hi for mharc-bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:00:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1fQN-0003J6-Lo for bug-coreutils@gnu.org; Fri, 10 Jan 2014 11:59:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1fQF-00034h-7o for bug-coreutils@gnu.org; Fri, 10 Jan 2014 11:59:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:59633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1fQF-00034b-5K for bug-coreutils@gnu.org; Fri, 10 Jan 2014 11:59:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W1fQE-00061c-FR for bug-coreutils@gnu.org; Fri, 10 Jan 2014 11:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16409: Some amusing results with dd Resent-From: bugs@m8y.org Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 10 Jan 2014 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16409 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16409@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138937311523110 (code B ref -1); Fri, 10 Jan 2014 16:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jan 2014 16:58:35 +0000 Received: from localhost ([127.0.0.1]:45419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1fPj-00060a-IJ for submit@debbugs.gnu.org; Fri, 10 Jan 2014 11:58:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33293) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1eRB-0003tx-L4 for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:55:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1eR2-0000Xj-SO for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:55:57 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:52431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eR2-0000Xd-P1 for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:55:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eQw-0002sc-JS for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:55:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1eQq-0000WG-K7 for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:55:42 -0500 Received: from c-68-50-78-21.hsd1.md.comcast.net ([68.50.78.21]:36806 helo=mail.m8y.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eQq-0000Vx-A4 for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:55:36 -0500 Received: by mail.m8y.org (Postfix, from userid 1000) id 1218A1680007; Fri, 10 Jan 2014 10:20:17 -0500 (EST) Date: Fri, 10 Jan 2014 10:20:17 -0500 (EST) From: bugs@m8y.org Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="655616-307055673-1389367217=:22975" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 10 Jan 2014 11:58:29 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 10 Jan 2014 12:00:57 -0500 Cc: Paul Rubin , David MacKenzie X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 16:59:20 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --655616-307055673-1389367217=:22975 Content-Type: TEXT/PLAIN; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: QUOTED-PRINTABLE So. I'd encountered: dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1M count=3D0 seek=3D4096 In a man page on creating disc images. Which seemed rather clever. dd and lseek create a file of the appropriate = size,=20 that takes up no space at all until you actually write to it, say, shred = -n 1 -z ubuntunew.img So. I thought it'd be a neat way to test the limits of dd. The dd man page says: N and BYTES may be followed by the following multiplicative suffixe= s: c =3D1, w =3D2, b =3D512, kB =3D1000, K =3D1024, MB =3D1000*1000, M = =3D1024*1024, xM =3DM GB =3D1000*1000*1000, G =3D1024*1024*1024, and so on for T, P, E, Z= , Y. What does testing say? dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1Y count=3D0 seek=3D1 dd: invalid number =A11Y=A2 dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1Z count=3D0 seek=3D1 dd: invalid number =A11Z=A2 dd has no idea what these suffixes are, apparently, regardless of what the = man page says. dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1E count=3D0 seek=3D1 dd: failed to truncate to 1152921504606846976 bytes in output file =A1= ubuntunew.img=A2: File too large dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1P count=3D0 seek=3D1 dd: failed to truncate to 1125899906842624 bytes in output file =A1ubu= ntunew.img=A2: File too large dd apparently cannot actually create files with sizes that can't be fit in = a 64 bit number? I'm not sure if that's a dd limitation or this 3.11 kernel and ext4 filesys= tem. dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1T count=3D0 seek=3D1 dd: memory exhausted by input buffer of size 1099511627776 bytes (1.0 = TiB) This one is at first glance perfectly understandable. The buffer size is an= abusrd 1 terabyte.=20 On the other hand, given the convenience of this count=3D0 use case for cre= ating a quick "large" image with no actual disc space,=20 there's no reason that dd should be attempting to allocate *any* memory.=20 Just skip malloc if count is 0. Allow people to use bs as a convenience f= or counting in that case. dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1G count=3D0 seek=3D$((1024*= 16)) dd: failed to truncate to 17592186044416 bytes in output file =A1ubunt= unew.img=A2: File too large Apparently 16 terabyte files, also too big... dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1G count=3D0 seek=3D$((1024*= 15)) 0+0 records in 0+0 records out 0 bytes (0 B) copied, 0.000125941 s, 0.0 kB/s 15 terabytes is just fine though. Well, I thought this was interesting, anyway. Is any of this an actual prob= lem in terms of future proofing? Apologies for any disturbance. --655616-307055673-1389367217=:22975-- From MAILER-DAEMON Fri Jan 10 12:14:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W1fey-0003EB-6k for mharc-bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:14:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1feq-00030r-Ru for bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:14:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1fek-0007RP-Mu for bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:14:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:59642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1fek-0007RL-IV for bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W1fek-0006Yi-9m for bug-coreutils@gnu.org; Fri, 10 Jan 2014 12:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16409: Some amusing results with dd Resent-From: bugs@m8y.org Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 10 Jan 2014 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16409 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16409@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138937401625154 (code B ref -1); Fri, 10 Jan 2014 17:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jan 2014 17:13:36 +0000 Received: from localhost ([127.0.0.1]:45428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1feJ-0006Xd-Md for submit@debbugs.gnu.org; Fri, 10 Jan 2014 12:13:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60165) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1eJn-0003hl-U3 for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:48:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1eJh-0006x1-Gd for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:48:19 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:49280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eJh-0006ww-D2 for submit@debbugs.gnu.org; Fri, 10 Jan 2014 10:48:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eJc-000056-2L for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:48:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1eJW-0006uT-UA for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:48:08 -0500 Received: from c-68-50-78-21.hsd1.md.comcast.net ([68.50.78.21]:36780 helo=mail.m8y.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1eJW-0006tN-QD for bug-coreutils@gnu.org; Fri, 10 Jan 2014 10:48:02 -0500 Received: by mail.m8y.org (Postfix, from userid 1000) id 216FD1680009; Fri, 10 Jan 2014 10:47:56 -0500 (EST) Date: Fri, 10 Jan 2014 10:47:56 -0500 (EST) From: bugs@m8y.org In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="655616-830362957-1389368876=:22975" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 10 Jan 2014 12:13:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: Paul Rubin , David MacKenzie X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 17:14:15 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --655616-830362957-1389368876=:22975 Content-Type: TEXT/PLAIN; charset=iso-8859-7; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Fri, 10 Jan 2014, bugs@m8y.org wrote: > dd has no idea what these suffixes are, apparently, regardless of what th= e=20 > man page says. > > dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1E count=3D0 seek=3D1 > dd: failed to truncate to 1152921504606846976 bytes in output file > =A1ubuntunew.img=A2: File too large > dd if=3D/dev/zero of=3Dubuntunew.img bs=3D1P count=3D0 seek=3D1 > dd: failed to truncate to 1125899906842624 bytes in output file > =A1ubuntunew.img=A2: File too large > > dd apparently cannot actually create files with sizes that can't be fit i= n a=20 > 64 bit number? > I'm not sure if that's a dd limitation or this 3.11 kernel and ext4=20 > filesystem. JUST RTFS'd and dd is using off_t which I'm guessing based on the 16/15T th= ing below is totally not=20 anything to do w/ dd. 0xFFFFFFFFFFF for some reason. The unrecognised prefixes thing, and the memory exhaustion, might maybe pos= sibly be interesting? --655616-830362957-1389368876=:22975-- From MAILER-DAEMON Fri Jan 10 13:23:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W1gjk-0005P7-Ft for mharc-bug-coreutils@gnu.org; Fri, 10 Jan 2014 13:23:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1gjc-0005Nt-Uf for bug-coreutils@gnu.org; Fri, 10 Jan 2014 13:23:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1gjX-0003PZ-4J for bug-coreutils@gnu.org; Fri, 10 Jan 2014 13:23:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:59700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1gjX-0003PO-1L for bug-coreutils@gnu.org; Fri, 10 Jan 2014 13:23:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W1gjW-0000YK-H8 for bug-coreutils@gnu.org; Fri, 10 Jan 2014 13:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16409: Some amusing results with dd Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 10 Jan 2014 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16409 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: bugs@m8y.org Received: via spool by 16409-submit@debbugs.gnu.org id=B16409.13893781792109 (code B ref 16409); Fri, 10 Jan 2014 18:23:02 +0000 Received: (at 16409) by debbugs.gnu.org; 10 Jan 2014 18:22:59 +0000 Received: from localhost ([127.0.0.1]:45484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1gjP-0000Xr-0B for submit@debbugs.gnu.org; Fri, 10 Jan 2014 13:22:59 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:54764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1gjI-0000XX-OB; Fri, 10 Jan 2014 13:22:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAEI60FJtThai/2dsb2JhbAANTINDg1S2VoEegxoBAQQjDwFGEAsNDQIFFgsCAgkDAgECAUUTAQcBAYgFCKcgdppzF4EpjV8HFoJZgUgBA58DjlY Received: from unknown (HELO [192.168.1.79]) ([109.78.22.162]) by mail3.vodafone.ie with ESMTP; 10 Jan 2014 18:22:47 +0000 Message-ID: <52D03A76.2010902@draigBrady.com> Date: Fri, 10 Jan 2014 18:22:46 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: Paul Rubin , 16409@debbugs.gnu.org, David MacKenzie X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 18:23:14 -0000 tag 16409 notabug close 16409 stop You're hitting various type and system limits. In general it's best to keep bs=1 and increase the seek size to get this functionality portably. Newer versions of GNU dd though will handle the count=0 case better and not alloc since: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=8901e010f Note also the truncate command which is a more direct means to get this functionality. thanks, Pádraig. From MAILER-DAEMON Mon Jan 13 09:51:11 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2ir9-0002Bu-RG for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:51:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ir4-00026P-DN for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:51:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2ir0-0001RG-MO for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:51:06 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:34651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ir0-0001RC-J6 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2ir0-0007KN-F4 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:51:02 -0500 Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Nicolas Iooss Mail-Followup-To: 16335@debbugs.gnu.org, P@draigBrady.com, nicolas.iooss@m4x.org Received: via spool by 16335-done@debbugs.gnu.org id=D16335.138962462728109 (code D ref 16335); Mon, 13 Jan 2014 14:51:01 +0000 Received: (at 16335-done) by debbugs.gnu.org; 13 Jan 2014 14:50:27 +0000 Received: from localhost ([127.0.0.1]:48670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2iqQ-0007JH-2I for submit@debbugs.gnu.org; Mon, 13 Jan 2014 09:50:26 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:49691) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2iqN-0007J2-7r for 16335-done@debbugs.gnu.org; Mon, 13 Jan 2014 09:50:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqMBAPj701JtTCfK/2dsb2JhbAANTYNDULlzgSeDGQEBAQR5EAsNBAMBAgoWDwkDAgECAT0IBg0BAQQCAQEFEYdvA6kWm3QXjnYRBwmELgSQM4kUhTyFcYhl Received: from unknown (HELO [192.168.1.79]) ([109.76.39.202]) by mail1.vodafone.ie with ESMTP; 13 Jan 2014 14:50:21 +0000 Message-ID: <52D3FD25.3020704@draigBrady.com> Date: Mon, 13 Jan 2014 14:50:13 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> In-Reply-To: <52C7EA36.8020302@m4x.org> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------090006030202030409000509" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16335-done@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 14:51:10 -0000 This is a multi-part message in MIME format. --------------090006030202030409000509 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit I'm going to push the attached very soon, to address this. thanks, Pdraig. --------------090006030202030409000509 Content-Type: text/x-patch; name="cp-selinux-segfault.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cp-selinux-segfault.patch" >From 2b3b5bfcd5f4161d17c0bc3d43f6edcfc4a2b294 Mon Sep 17 00:00:00 2001 From: Nicolas Looss Date: Sat, 4 Jan 2014 03:03:51 +0000 Subject: [PATCH] copy: fix a segfault in SELinux context copying code * src/selinux.c (restorecon_private): On ArchLinux the `fakeroot cp -a file1 file2` command segfaulted due to getfscreatecon() returning a NULL context. So map this to the sometimes ignored ENODATA error, rather than crashing. * tests/cp/no-ctx.sh: Add a new test case. * tests/local.mk: Reference the new test. * NEWS: Mention the fix. Fixes http://bugs.gnu.org/16335 --- NEWS | 5 ++++ src/selinux.c | 5 ++++ tests/cp/no-ctx.sh | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/local.mk | 1 + 4 files changed, 64 insertions(+), 0 deletions(-) create mode 100755 tests/cp/no-ctx.sh diff --git a/NEWS b/NEWS index 3e1f9c6..699a7d3 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,11 @@ GNU coreutils NEWS -*- outline -*- the context of an existing directory to that of its last copied descendent. [bug introduced in coreutils-8.22] + cp -a, mv, and install --preserve-context, no longer seg fault when running + with SELinux enabled, when copying from file systems that return an error + when reading the SELinux context for a file. + [bug introduced in coreutils-8.22] + * Noteworthy changes in release 8.22 (2013-12-13) [stable] diff --git a/src/selinux.c b/src/selinux.c index cd38a81..016db16 100644 --- a/src/selinux.c +++ b/src/selinux.c @@ -192,6 +192,11 @@ restorecon_private (char const *path, bool local) { if (getfscreatecon (&tcon) < 0) return rc; + if (!tcon) + { + errno = ENODATA; + return rc; + } rc = lsetfilecon (path, tcon); freecon (tcon); return rc; diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh new file mode 100755 index 0000000..59d30de --- /dev/null +++ b/tests/cp/no-ctx.sh @@ -0,0 +1,53 @@ +#!/bin/sh +# Ensure we handle file systems returning no SELinux context, +# which triggered a segmentation fault in coreutils-8.22. +# This test is skipped on systems that lack LD_PRELOAD support; that's fine. +# Similarly, on a system that lacks lgetfilecon altogether, skipping it is fine. + +# Copyright (C) 2014 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src +print_ver_ cp +require_gcc_shared_ + +# Replace each getfilecon and lgetfilecon call with a call to these stubs. +cat > k.c <<'EOF' || framework_failure_ +#include +#include + +int getfilecon (const char *path, security_context_t *con) +{ errno=ENODATA; return -1; } +int lgetfilecon (const char *path, security_context_t *con) +{ errno=ENODATA; return -1; } +EOF + +# Then compile/link it: +$CC -shared -fPIC -O2 k.c -o k.so \ + || framework_failure_ 'failed to build SELinux shared library' + +touch file_src + +# New file with SELinux context optionally included +LD_PRELOAD=./k.so cp -a file_src file_dst || fail=1 + +# Existing file with SELinux context optionally included +LD_PRELOAD=./k.so cp -a file_src file_dst || fail=1 + +# ENODATA should give an immediate error when required to preserve ctx +# This is debatable, and maybe we should not fail when no context available? +LD_PRELOAD=./k.so cp --preserve=context file_src file_dst && fail=1 + +Exit $fail diff --git a/tests/local.mk b/tests/local.mk index dc7341c..9d556f6 100644 --- a/tests/local.mk +++ b/tests/local.mk @@ -161,6 +161,7 @@ all_tests = \ tests/rm/ext3-perf.sh \ tests/rm/cycle.sh \ tests/cp/link-heap.sh \ + tests/cp/no-ctx.sh \ tests/misc/tty-eof.pl \ tests/tail-2/inotify-hash-abuse.sh \ tests/tail-2/inotify-hash-abuse2.sh \ -- 1.7.7.6 --------------090006030202030409000509-- From MAILER-DAEMON Mon Jan 13 09:58:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2iy2-0005e1-5T for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:58:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ixu-0005cz-Bt for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:58:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2ixo-0003s0-7P for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:58:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ixn-0003rk-B7 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:58:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2ixm-0007cI-IG for bug-coreutils@gnu.org; Mon, 13 Jan 2014 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16335@debbugs.gnu.org, nicolas.iooss@m4x.org Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138962507529270 (code B ref 16335); Mon, 13 Jan 2014 14:58:02 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 14:57:55 +0000 Received: from localhost ([127.0.0.1]:49135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2ixa-0007by-MT for submit@debbugs.gnu.org; Mon, 13 Jan 2014 09:57:54 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:23762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2ixP-0007bi-8W for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 09:57:42 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAJP+01JtTCfK/2dsb2JhbAANTYNDukOBKIMZAQEBBDIBVgsNCwkWDwkDAgECAUUHDAgBAYgFqRabdhePDoQ3AQOfA45W Received: from unknown (HELO [192.168.1.79]) ([109.76.39.202]) by mail1.vodafone.ie with ESMTP; 13 Jan 2014 14:57:30 +0000 Message-ID: <52D3FED0.3020100@draigBrady.com> Date: Mon, 13 Jan 2014 14:57:20 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> In-Reply-To: <52D3FD25.3020704@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 14:58:16 -0000 On 01/13/2014 02:50 PM, Pdraig Brady wrote: > +# Then compile/link it: > +$CC -shared -fPIC -O2 k.c -o k.so \ > + || framework_failure_ 'failed to build SELinux shared library' I'll change that to a || skip_ ... so that we avoid issues with no (stub) being available. thanks, Pdraig. From MAILER-DAEMON Mon Jan 13 10:29:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2jS3-0002H3-Gg for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 10:29:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2jRu-0002F5-I5 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 10:29:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2jRn-0005yz-86 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 10:29:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2jRn-0005yv-4m for bug-coreutils@gnu.org; Mon, 13 Jan 2014 10:29:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2jRm-00005G-FR for bug-coreutils@gnu.org; Mon, 13 Jan 2014 10:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , 16335@debbugs.gnu.org, nicolas.iooss@m4x.org Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138962688232691 (code B ref 16335); Mon, 13 Jan 2014 15:29:02 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 15:28:02 +0000 Received: from localhost ([127.0.0.1]:49172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2jQo-0008Uz-2N for submit@debbugs.gnu.org; Mon, 13 Jan 2014 10:28:02 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:49255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2jQj-0008Uc-5F for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 10:27:58 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0LhePx-1VYObo3rrV-00maGK; Mon, 13 Jan 2014 16:27:54 +0100 Message-ID: <52D405EC.3000609@bernhard-voelker.de> Date: Mon, 13 Jan 2014 16:27:40 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> In-Reply-To: <52D3FED0.3020100@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:+rIIxwjgbHpZsBgOZF2+3ra2ijgq5xI7vAVrIijVPB6 OUS8xiucVsKHRkIRX51TxFiFFr+xb2T+DvfIDaQEXYysbRZTI+ jAICP3ZJ5dfMoFMt69AskY3eNMsE01w5TMZVGOyAGpb7Rk2sNm P+o4tQrmeqSjbboeNmlDFQAtS4qF1W6QoPMCuJnWqp33avNJma XbttxQqaXJUKID+Z+JYohLPXNE8Ujq9+HSEPDIvd+hlUOG7yJ/ +tbxh2WF/mGqlaPwIzcirSmd4zfCMGL0zpJjY+cslPMwWOw9zv YT2JP/ab5sCqwO7TmZlog+cERyQ3qplTJLWXfJpygQD9BECsD0 /7vh81PY5CNOXyKrwG3WYENCwx6gKK9iNVoUNxaqe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 15:29:17 -0000 On 01/13/2014 03:57 PM, Pdraig Brady wrote: > On 01/13/2014 02:50 PM, Pdraig Brady wrote: >> +# Then compile/link it: >> +$CC -shared -fPIC -O2 k.c -o k.so \ >> + || framework_failure_ 'failed to build SELinux shared library' > > I'll change that to a || skip_ ... > so that we avoid issues with no (stub) being available. LD_PRELOADed tests are sometimes a bit tricky, so doing double checks is a good idea: I'd add a fclose(fopen("x")); inside the dummies, and check if that file has really been created. Otherwise, you can't be sure if replacing the functions really worked. Furthermore, when I added a LD_PRELOADed test a while ago, I think Paul suggested to add -ldl for some non-GNU/Linux platforms. I'd also specify 'gcc' hardcoded ... probably with -Wall. +1 otherwise. Thanks & have a nice day, Berny From MAILER-DAEMON Mon Jan 13 12:10:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2l1j-0000Tb-GH for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 12:10:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2l1c-0000OV-9e for bug-coreutils@gnu.org; Mon, 13 Jan 2014 12:10:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2l1W-00057Z-Aw for bug-coreutils@gnu.org; Mon, 13 Jan 2014 12:10:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2l1W-000570-8W for bug-coreutils@gnu.org; Mon, 13 Jan 2014 12:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2l1V-00039k-Nf for bug-coreutils@gnu.org; Mon, 13 Jan 2014 12:10:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 17:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138963299812117 (code B ref 16335); Mon, 13 Jan 2014 17:10:01 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 17:09:58 +0000 Received: from localhost ([127.0.0.1]:49309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2l1S-00039N-BR for submit@debbugs.gnu.org; Mon, 13 Jan 2014 12:09:58 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:20702) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2l1Q-00039E-Ef for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 12:09:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAAMd1FJtTCfK/2dsb2JhbAANTYNDukWBK4MZAQEBAwEyAUYFCwsNAQoJFg8JAwIBAgFFBg0BBwEBh3gNqR+bTxePBweENwEDnwOOVg Received: from unknown (HELO [192.168.1.79]) ([109.76.39.202]) by mail1.vodafone.ie with ESMTP; 13 Jan 2014 17:09:55 +0000 Message-ID: <52D41DE2.7060608@draigBrady.com> Date: Mon, 13 Jan 2014 17:09:54 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> In-Reply-To: <52D405EC.3000609@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 17:10:14 -0000 On 01/13/2014 03:27 PM, Bernhard Voelker wrote: > On 01/13/2014 03:57 PM, Pdraig Brady wrote: >> On 01/13/2014 02:50 PM, Pdraig Brady wrote: >>> +# Then compile/link it: >>> +$CC -shared -fPIC -O2 k.c -o k.so \ >>> + || framework_failure_ 'failed to build SELinux shared library' >> >> I'll change that to a || skip_ ... >> so that we avoid issues with no (stub) being available. > > LD_PRELOADed tests are sometimes a bit tricky, so doing > double checks is a good idea: I'd add a > fclose(fopen("x")); > inside the dummies, and check if that file has really been > created. Otherwise, you can't be sure if replacing the functions > really worked. Right, I'll skip_ in that case to warn about stale tests. > Furthermore, when I added a LD_PRELOADed test a while ago, > I think Paul suggested to add -ldl for some non-GNU/Linux > platforms. Right. I'll refactor all those calls to a gcc_shared_() for consistency. > I'd also specify 'gcc' hardcoded ... probably with -Wall. Hmm, icc and clang support this gcc interface, so I'm inclined to leave it as $CC so as not preclude those from this part of the testing matrix. We can always beef up require_gcc_shared_() if this ever becomes an issue. thanks! Pdraig. From MAILER-DAEMON Mon Jan 13 15:10:14 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2npu-0007w5-AM for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:10:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2npp-0007ua-1M for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:10:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2npl-0000y6-CJ for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:10:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2npl-0000wF-8X for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:10:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2npj-0008Jb-I1 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:10:04 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 20:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138964379731947 (code B ref 16335); Mon, 13 Jan 2014 20:10:03 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 20:09:57 +0000 Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2npc-0008JC-Ij for submit@debbugs.gnu.org; Mon, 13 Jan 2014 15:09:57 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:12460) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2npY-0008Iw-7K for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 15:09:54 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqQBAF9H1FJtTCfK/2dsb2JhbAANQwqDQ1C5eYEvgxkBAQEEeRALDQEDAwECAQkWDwkDAgECAT0IBg0BAQQCAQEFEYdvA6kmm1cXjitLEQcJhC4EkDOJFIU8hXGIZQ Received: from unknown (HELO [192.168.1.79]) ([109.76.39.202]) by mail1.vodafone.ie with ESMTP; 13 Jan 2014 20:09:50 +0000 Message-ID: <52D4480D.8030703@draigBrady.com> Date: Mon, 13 Jan 2014 20:09:49 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> In-Reply-To: <52D41DE2.7060608@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------010901080605040602050206" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 20:10:12 -0000 This is a multi-part message in MIME format. --------------010901080605040602050206 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 01/13/2014 05:09 PM, Pdraig Brady wrote: > On 01/13/2014 03:27 PM, Bernhard Voelker wrote: >> On 01/13/2014 03:57 PM, Pdraig Brady wrote: >>> On 01/13/2014 02:50 PM, Pdraig Brady wrote: >>>> +# Then compile/link it: >>>> +$CC -shared -fPIC -O2 k.c -o k.so \ >>>> + || framework_failure_ 'failed to build SELinux shared library' >>> >>> I'll change that to a || skip_ ... >>> so that we avoid issues with no (stub) being available. >> >> LD_PRELOADed tests are sometimes a bit tricky, so doing >> double checks is a good idea: I'd add a >> fclose(fopen("x")); >> inside the dummies, and check if that file has really been >> created. Otherwise, you can't be sure if replacing the functions >> really worked. > > Right, I'll skip_ in that case to warn > about stale tests. > >> Furthermore, when I added a LD_PRELOADed test a while ago, >> I think Paul suggested to add -ldl for some non-GNU/Linux >> platforms. > > Right. I'll refactor all those calls to a gcc_shared_() for consistency. > >> I'd also specify 'gcc' hardcoded ... probably with -Wall. > > Hmm, icc and clang support this gcc interface, > so I'm inclined to leave it as $CC so as not > preclude those from this part of the testing matrix. > We can always beef up require_gcc_shared_() if > this ever becomes an issue. Pushing the attached 2 patches in a while. thanks, Pdraig. --------------010901080605040602050206 Content-Type: text/x-patch; name="cp-selinux-segfault.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cp-selinux-segfault.patch" >From 33825d7c872f1ad4887a448f6d1348fb7dcbb178 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Mon, 13 Jan 2014 19:39:52 +0000 Subject: [PATCH 1/2] maint: refactor gcc commands to build a shared lib in tests * init.cfg (gcc_shared_): A new function refactored from tests. (require_gcc_shared_): Adjust to call gcc_shared_() to build the test library, and remove that library before the function returns. * tests/cp/nfs-removal-race.sh: Call the new gcc_shared_(). * tests/df/no-mtab-status.sh: Likewise. * tests/df/skip-duplicates.sh: Likewise. * tests/ls/getxattr-speedup.sh: Likewise. * tests/rm/r-root.sh: Likewise. --- init.cfg | 11 ++++++++++- tests/cp/nfs-removal-race.sh | 2 +- tests/df/no-mtab-status.sh | 2 +- tests/df/skip-duplicates.sh | 2 +- tests/ls/getxattr-speedup.sh | 2 +- tests/rm/r-root.sh | 2 +- 6 files changed, 15 insertions(+), 6 deletions(-) diff --git a/init.cfg b/init.cfg index af3963c..876f5e6 100644 --- a/init.cfg +++ b/init.cfg @@ -500,13 +500,22 @@ require_sparse_support_() fi } +# Compile a shared lib using the GCC options for doing so. +# Pass input and output file as parameters respectively. +# Any other optional parmeters are passed to $CC. +gcc_shared_() +{ + $CC -Wall -shared --std=gnu99 -fPIC -ldl -O2 $3 "$1" -o "$2" +} + # There are a myriad of ways to build shared libs, # so we only consider running tests requiring shared libs, # on platforms that support building them as follows. require_gcc_shared_() { - $CC -shared -fPIC -O2 -xc -o d.so -ldl - < /dev/null 2>&1 \ + gcc_shared_ '-' 'd.so' -xc < /dev/null 2>&1 \ || skip_ '$CC -shared ... failed to build a shared lib' + rm -f d.so } mkfifo_or_skip_() diff --git a/tests/cp/nfs-removal-race.sh b/tests/cp/nfs-removal-race.sh index 0638db1..6969e8b 100755 --- a/tests/cp/nfs-removal-race.sh +++ b/tests/cp/nfs-removal-race.sh @@ -58,7 +58,7 @@ __xstat (int ver, const char *path, struct stat *st) EOF # Then compile/link it: -$CC -shared -fPIC -O2 k.c -o k.so -ldl \ +gcc_shared_ k.c k.so \ || framework_failure_ 'failed to build shared library' touch d2 || framework_failure_ diff --git a/tests/df/no-mtab-status.sh b/tests/df/no-mtab-status.sh index 58f1b46..f2fda5e 100755 --- a/tests/df/no-mtab-status.sh +++ b/tests/df/no-mtab-status.sh @@ -45,7 +45,7 @@ struct mntent *getmntent (FILE *fp) EOF # Then compile/link it: -$CC -shared -fPIC -ldl -O2 k.c -o k.so \ +gcc_shared_ k.c k.so \ || framework_failure_ 'failed to build shared library' # Test if LD_PRELOAD works: diff --git a/tests/df/skip-duplicates.sh b/tests/df/skip-duplicates.sh index 69182d2..266520a 100755 --- a/tests/df/skip-duplicates.sh +++ b/tests/df/skip-duplicates.sh @@ -60,7 +60,7 @@ struct mntent *getmntent (FILE *fp) EOF # Then compile/link it: -gcc --std=gnu99 -shared -fPIC -ldl -O2 k.c -o k.so \ +gcc_shared_ k.c k.so \ || framework_failure_ 'failed to build shared library' # Test if LD_PRELOAD works: diff --git a/tests/ls/getxattr-speedup.sh b/tests/ls/getxattr-speedup.sh index 5725fa5..0144571 100755 --- a/tests/ls/getxattr-speedup.sh +++ b/tests/ls/getxattr-speedup.sh @@ -48,7 +48,7 @@ ssize_t lgetxattr(const char *path, const char *name, void *value, size_t size) EOF # Then compile/link it: -$CC -shared -fPIC -O2 k.c -o k.so \ +gcc_shared_ k.c k.so \ || framework_failure_ 'failed to build shared library' # Create a few files: diff --git a/tests/rm/r-root.sh b/tests/rm/r-root.sh index 06e5769..04a88eb 100755 --- a/tests/rm/r-root.sh +++ b/tests/rm/r-root.sh @@ -60,7 +60,7 @@ int unlinkat (int dirfd, const char *pathname, int flags) EOF # Then compile/link it: -gcc -Wall --std=gnu99 -shared -fPIC -ldl -O2 k.c -o k.so \ +gcc_shared_ k.c k.so \ || framework_failure_ 'failed to build shared library' #------------------------------------------------------------------------------- -- 1.7.7.6 >From 6f54e3ffeeee69fa75dff00527f0c0bd96b3a6b9 Mon Sep 17 00:00:00 2001 From: Nicolas Looss Date: Sat, 4 Jan 2014 03:03:51 +0000 Subject: [PATCH 2/2] copy: fix a segfault in SELinux context copying code * src/selinux.c (restorecon_private): On ArchLinux the `fakeroot cp -a file1 file2` command segfaulted due to getfscreatecon() returning a NULL context. So map this to the sometimes ignored ENODATA error, rather than crashing. * tests/cp/no-ctx.sh: Add a new test case. * tests/local.mk: Reference the new test. * NEWS: Mention the fix. Fixes http://bugs.gnu.org/16335 --- NEWS | 5 ++++ src/selinux.c | 5 ++++ tests/cp/no-ctx.sh | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/local.mk | 1 + 4 files changed, 74 insertions(+), 0 deletions(-) create mode 100755 tests/cp/no-ctx.sh diff --git a/NEWS b/NEWS index 3e1f9c6..699a7d3 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,11 @@ GNU coreutils NEWS -*- outline -*- the context of an existing directory to that of its last copied descendent. [bug introduced in coreutils-8.22] + cp -a, mv, and install --preserve-context, no longer seg fault when running + with SELinux enabled, when copying from file systems that return an error + when reading the SELinux context for a file. + [bug introduced in coreutils-8.22] + * Noteworthy changes in release 8.22 (2013-12-13) [stable] diff --git a/src/selinux.c b/src/selinux.c index cd38a81..016db16 100644 --- a/src/selinux.c +++ b/src/selinux.c @@ -192,6 +192,11 @@ restorecon_private (char const *path, bool local) { if (getfscreatecon (&tcon) < 0) return rc; + if (!tcon) + { + errno = ENODATA; + return rc; + } rc = lsetfilecon (path, tcon); freecon (tcon); return rc; diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh new file mode 100755 index 0000000..3b5eb82 --- /dev/null +++ b/tests/cp/no-ctx.sh @@ -0,0 +1,63 @@ +#!/bin/sh +# Ensure we handle file systems returning no SELinux context, +# which triggered a segmentation fault in coreutils-8.22. +# This test is skipped on systems that lack LD_PRELOAD support; that's fine. +# Similarly, on a system that lacks lgetfilecon altogether, skipping it is fine. + +# Copyright (C) 2014 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +. "${srcdir=.}/tests/init.sh"; path_prepend_ ./src +print_ver_ cp +require_gcc_shared_ + +# Replace each getfilecon and lgetfilecon call with a call to these stubs. +cat > k.c <<'EOF' || framework_failure_ +#include +#include +#include + +int getfilecon (const char *path, security_context_t *con) +{ + /* Leave a marker so we can identify if the function was intercepted. */ + fclose(fopen("preloaded", "w")); + + errno=ENODATA; + return -1; +} + +int lgetfilecon (const char *path, security_context_t *con) +{ return getfilecon (path, con); } +EOF + +# Then compile/link it: +gcc_shared_ k.c k.so \ + || skip_ 'failed to build SELinux shared library' + +touch file_src + +# New file with SELinux context optionally included +LD_PRELOAD=./k.so cp -a file_src file_dst || fail=1 + +# Existing file with SELinux context optionally included +LD_PRELOAD=./k.so cp -a file_src file_dst || fail=1 + +# ENODATA should give an immediate error when required to preserve ctx +# This is debatable, and maybe we should not fail when no context available? +LD_PRELOAD=./k.so cp --preserve=context file_src file_dst && fail=1 + +test -e preloaded || skip_ 'LD_PRELOAD interception failed' + +Exit $fail diff --git a/tests/local.mk b/tests/local.mk index dc7341c..9d556f6 100644 --- a/tests/local.mk +++ b/tests/local.mk @@ -161,6 +161,7 @@ all_tests = \ tests/rm/ext3-perf.sh \ tests/rm/cycle.sh \ tests/cp/link-heap.sh \ + tests/cp/no-ctx.sh \ tests/misc/tty-eof.pl \ tests/tail-2/inotify-hash-abuse.sh \ tests/tail-2/inotify-hash-abuse2.sh \ -- 1.7.7.6 --------------010901080605040602050206-- From MAILER-DAEMON Mon Jan 13 15:37:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2oG7-00070H-OB for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:37:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2nsn-0008BT-NU for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2nsc-0001lQ-A8 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:13:13 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2nsc-0001lM-6p for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2nsb-0008P7-M5 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 15:13:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Nicolas Iooss Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138964397132285 (code B ref 16335); Mon, 13 Jan 2014 20:13:01 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 20:12:51 +0000 Received: from localhost ([127.0.0.1]:49396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2nsQ-0008Oc-VE for submit@debbugs.gnu.org; Mon, 13 Jan 2014 15:12:51 -0500 Received: from mx1.polytechnique.org ([129.104.30.34]:50176) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2nsO-0008OQ-2J for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 15:12:49 -0500 Received: from [10.5.5.101] (11.147.102.84.rev.sfr.net [84.102.147.11]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 81FA0140000B3; Mon, 13 Jan 2014 21:12:46 +0100 (CET) Message-ID: <52D448BD.3000200@m4x.org> Date: Mon, 13 Jan 2014 21:12:45 +0100 From: Nicolas Iooss Organization: M4X User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> In-Reply-To: <52D3FD25.3020704@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Mon Jan 13 21:12:46 2014 +0100 (CET)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Mon, 13 Jan 2014 15:37:17 -0500 Cc: 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 20:13:21 -0000 Le 13/01/2014 15:50, Pdraig Brady a crit : > I'm going to push the attached very soon, to address this. > > thanks, > Pdraig. > Thanks for setting me as the author of this patch. Nevertheless my name (Iooss) spells with and I (like India) and not L (Lima). Could you fix this? Nicolas From MAILER-DAEMON Mon Jan 13 18:15:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2qix-0008KK-AK for mharc-bug-coreutils@gnu.org; Mon, 13 Jan 2014 18:15:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2qiq-0008FT-KD for bug-coreutils@gnu.org; Mon, 13 Jan 2014 18:15:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2qil-0003C4-TE for bug-coreutils@gnu.org; Mon, 13 Jan 2014 18:15:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2qil-0003Br-R4 for bug-coreutils@gnu.org; Mon, 13 Jan 2014 18:15:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W2qil-0005Df-Dv for bug-coreutils@gnu.org; Mon, 13 Jan 2014 18:15:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 13 Jan 2014 23:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Nicolas Iooss Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138965487119996 (code B ref 16335); Mon, 13 Jan 2014 23:15:03 +0000 Received: (at 16335) by debbugs.gnu.org; 13 Jan 2014 23:14:31 +0000 Received: from localhost ([127.0.0.1]:49493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2qiE-0005CR-UV for submit@debbugs.gnu.org; Mon, 13 Jan 2014 18:14:31 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:43054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2qiC-0005CI-D1 for 16335@debbugs.gnu.org; Mon, 13 Jan 2014 18:14:29 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAPBy1FJtTCfK/2dsb2JhbAANTYNDukqBK4MZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAUIqRybfxePBweENwEDnwOOVg Received: from unknown (HELO [192.168.1.79]) ([109.76.39.202]) by mail1.vodafone.ie with ESMTP; 13 Jan 2014 23:14:27 +0000 Message-ID: <52D4734D.4070609@draigBrady.com> Date: Mon, 13 Jan 2014 23:14:21 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D448BD.3000200@m4x.org> In-Reply-To: <52D448BD.3000200@m4x.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 23:15:13 -0000 On 01/13/2014 08:12 PM, Nicolas Iooss wrote: > Le 13/01/2014 15:50, Pdraig Brady a crit : >> I'm going to push the attached very soon, to address this. >> >> thanks, >> Pdraig. >> > > Thanks for setting me as the author of this patch. Nevertheless my name > (Iooss) spells with and I (like India) and not L (Lima). Could you fix this? Done and pushed. http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=d718331e5 thanks again, Pdraig. From MAILER-DAEMON Tue Jan 14 05:55:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W31eQ-0004P1-Tu for mharc-bug-coreutils@gnu.org; Tue, 14 Jan 2014 05:55:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W31eI-0004H0-LR for bug-coreutils@gnu.org; Tue, 14 Jan 2014 05:55:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W31eB-0004YD-K1 for bug-coreutils@gnu.org; Tue, 14 Jan 2014 05:55:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W31eB-0004Wk-Fk for bug-coreutils@gnu.org; Tue, 14 Jan 2014 05:55:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W31eA-0000cL-EG for bug-coreutils@gnu.org; Tue, 14 Jan 2014 05:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 14 Jan 2014 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.13896968772323 (code B ref 16335); Tue, 14 Jan 2014 10:55:02 +0000 Received: (at 16335) by debbugs.gnu.org; 14 Jan 2014 10:54:37 +0000 Received: from localhost ([127.0.0.1]:49756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W31dk-0000bP-D0 for submit@debbugs.gnu.org; Tue, 14 Jan 2014 05:54:36 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:53629) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W31dh-0000bB-Ax for 16335@debbugs.gnu.org; Tue, 14 Jan 2014 05:54:34 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0LlVhP-1VT8K119E7-00bI4O; Tue, 14 Jan 2014 11:54:30 +0100 Message-ID: <52D51760.8070001@bernhard-voelker.de> Date: Tue, 14 Jan 2014 11:54:24 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> <52D4480D.8030703@draigBrady.com> In-Reply-To: <52D4480D.8030703@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:8b0LEHSEhWMqUaryYaX0ZmFpw33gRcYk8R2CqcGNi1a EQ1U3OuJ6r9TjdbHfD+iu2/Svwiy7hM1+dsAazogzx3grzVNc9 06nYwIi9DtGQouMKQlKD76F/hmxbENWHR9oE9vJ0owNnGSodHV QeLd7r+OCaRykg0fAK2Z4Oa4n6cMNPfdVlrv4pqVw5H+t7Ne/l ay+zE5JC7S1ms0atJ5r1jR9GGueDYeDYK53Gfh/sw8cgi2SGqc gWXxNTBS3AFcJWgEcDxlzCAL0QIpyVQt7kin5bEz/286UuhR6W cXYoyc1h9ww+eQ8yRjRAsPCLElOb7JLBa9yiqK0TXmZZXC48Ni CMpr66qxxsrE4IH3zZ93XJ1Q6VJkhRusZRvbU51bN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 10:55:17 -0000 On 01/13/2014 09:09 PM, Pdraig Brady wrote: > Pushing the attached 2 patches in a while. Hi Padraig, thanks, the refactoring into gcc_shared_ is a good idea. But I missed this one: when selinux is not supported, the new no-ctx.sh test is skipped with the wrong and misleading "LD_PRELOAD interception failed" diagnostic: + gcc -std=gnu99 -Wall -shared --std=gnu99 -fPIC -ldl -O2 k.c -o k.so + touch file_src + LD_PRELOAD=./k.so + cp -a file_src file_dst + LD_PRELOAD=./k.so + cp -a file_src file_dst + LD_PRELOAD=./k.so + cp --preserve=context file_src file_dst cp: cannot preserve security context without an SELinux-enabled kernel + test -e preloaded + skip_ 'LD_PRELOAD interception failed' + warn_ 'no-ctx.sh: skipped test: LD_PRELOAD interception failed' + case $IFS in + printf '%s\n' 'no-ctx.sh: skipped test: LD_PRELOAD interception failed' no-ctx.sh: skipped test: LD_PRELOAD interception failed + test 9 = 2 + printf '%s\n' 'no-ctx.sh: skipped test: LD_PRELOAD interception failed' + sed 1q + Exit 77 I've no time now to analyze further, unfortunately. Have a nice day, Berny From MAILER-DAEMON Tue Jan 14 06:36:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W32I0-00081h-VB for mharc-bug-coreutils@gnu.org; Tue, 14 Jan 2014 06:36:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W32Hv-00081X-MT for bug-coreutils@gnu.org; Tue, 14 Jan 2014 06:36:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W32Hr-0007sK-84 for bug-coreutils@gnu.org; Tue, 14 Jan 2014 06:36:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W32Hr-0007sF-4j for bug-coreutils@gnu.org; Tue, 14 Jan 2014 06:36:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W32Hq-0001oB-GB for bug-coreutils@gnu.org; Tue, 14 Jan 2014 06:36:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 14 Jan 2014 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.13896993206885 (code B ref 16335); Tue, 14 Jan 2014 11:36:02 +0000 Received: (at 16335) by debbugs.gnu.org; 14 Jan 2014 11:35:20 +0000 Received: from localhost ([127.0.0.1]:49772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W32H9-0001mx-Di for submit@debbugs.gnu.org; Tue, 14 Jan 2014 06:35:19 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:42578) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W32H6-0001mj-1B for 16335@debbugs.gnu.org; Tue, 14 Jan 2014 06:35:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAMgf1VJtTnzz/2dsb2JhbAANTYNDuyiBKIMZAQEBBDIBRhALDQEGBAklD0gGDQEFAgEBiAWpPpt1F48HB4Q3AQOZToU8jlY Received: from unknown (HELO [192.168.1.79]) ([109.78.124.243]) by mail3.vodafone.ie with ESMTP; 14 Jan 2014 11:35:14 +0000 Message-ID: <52D520F1.4@draigBrady.com> Date: Tue, 14 Jan 2014 11:35:13 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> <52D4480D.8030703@draigBrady.com> <52D51760.8070001@bernhard-voelker.de> In-Reply-To: <52D51760.8070001@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 11:36:12 -0000 On 01/14/2014 10:54 AM, Bernhard Voelker wrote: > On 01/13/2014 09:09 PM, Pdraig Brady wrote: >> Pushing the attached 2 patches in a while. > > Hi Padraig, > > thanks, the refactoring into gcc_shared_ is a good idea. > > But I missed this one: > when selinux is not supported, the new no-ctx.sh test is skipped > with the wrong and misleading "LD_PRELOAD interception failed" diagnostic: > + test -e preloaded > + skip_ 'LD_PRELOAD interception failed' Oh right. I think this should restrict the test appropriately... commit 3620df245a2211dc441e019845f98b91333bda77 Author: Pdraig Brady Date: Tue Jan 14 11:30:51 2014 +0000 tests: restrict a recent SELinux test to SELinux systems * tests/cp/no-ctx.sh: Since the test diagnoses whether the intercepted lgetfilecon() calls are actually called or not, restrict the test to systems where that occurs. The test cases are minimal on non SELinux systems and should be well covered by other tests. Reported-by: Bernhard Voelker diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh index 3b5eb82..6851785 100755 --- a/tests/cp/no-ctx.sh +++ b/tests/cp/no-ctx.sh @@ -22,6 +22,7 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ cp require_gcc_shared_ +requires_selinux_ # Replace each getfilecon and lgetfilecon call with a call to these stubs. cat > k.c <<'EOF' || framework_failure_ From MAILER-DAEMON Tue Jan 14 07:39:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W33Gz-0003sG-Ig for mharc-bug-coreutils@gnu.org; Tue, 14 Jan 2014 07:39:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W33Gt-0003s7-S7 for bug-coreutils@gnu.org; Tue, 14 Jan 2014 07:39:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W33Go-0001Uz-Op for bug-coreutils@gnu.org; Tue, 14 Jan 2014 07:39:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W33Go-0001Uv-LG for bug-coreutils@gnu.org; Tue, 14 Jan 2014 07:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W33Go-0004iJ-7m for bug-coreutils@gnu.org; Tue, 14 Jan 2014 07:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 14 Jan 2014 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138970311518079 (code B ref 16335); Tue, 14 Jan 2014 12:39:02 +0000 Received: (at 16335) by debbugs.gnu.org; 14 Jan 2014 12:38:35 +0000 Received: from localhost ([127.0.0.1]:49791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W33GN-0004hX-1D for submit@debbugs.gnu.org; Tue, 14 Jan 2014 07:38:35 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:59072) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W33GK-0004hN-8J for 16335@debbugs.gnu.org; Tue, 14 Jan 2014 07:38:33 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0MMnSJ-1W01nP31wd-008Fch; Tue, 14 Jan 2014 13:38:29 +0100 Message-ID: <52D52FC3.4030304@bernhard-voelker.de> Date: Tue, 14 Jan 2014 13:38:27 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> <52D4480D.8030703@draigBrady.com> <52D51760.8070001@bernhard-voelker.de> <52D520F1.4@draigBrady.com> In-Reply-To: <52D520F1.4@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:M2LLj8wmZTn+bJEXYB6N9K9cTR1uiAHQMFesdYJedOR b+gRru7dLv6rl/khsIl+EpbqKGW9Tbj7eRJb6EyLz/iPe0vNQy WUNJdcCg7AyDVnoull7zPqw6h4UM9GyREp4HAsXAM2Rwgxp3MM ohUKRQrydO6p1MImBQZ0opnwmuwq+7rrxFTq2bEBf1Ca1Jw04p z6yDuSFWn7I7LQJZr1xcUUIKrZSc7F0qyrANFQ+pUmNYst0khp T+bpsKQOlGwdYFQwiDUdNCISEKa+DpJdIhztNlPOXBHs0LzUuF k++qClZBUxlMSGTc7NWW75oUla7p4TqQemNPJkB1vqq/Hy7dFG HlAxgWpJNAGe1uQRLsZCHni+WMykSCV3zuBiK9Hrv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 12:39:13 -0000 On 01/14/2014 12:35 PM, Pdraig Brady wrote: > On 01/14/2014 10:54 AM, Bernhard Voelker wrote: >> + test -e preloaded >> + skip_ 'LD_PRELOAD interception failed' > > Oh right. I think this should restrict the test appropriately... > > commit 3620df245a2211dc441e019845f98b91333bda77 > Author: Pdraig Brady > Date: Tue Jan 14 11:30:51 2014 +0000 > > tests: restrict a recent SELinux test to SELinux systems > > * tests/cp/no-ctx.sh: Since the test diagnoses whether the > intercepted lgetfilecon() calls are actually called or not, The witness file is only created for getfilecon() - not for lgetfilecon(). > restrict the test to systems where that occurs. > The test cases are minimal on non SELinux systems and should > be well covered by other tests. > Reported-by: Bernhard Voelker > > diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh > index 3b5eb82..6851785 100755 > --- a/tests/cp/no-ctx.sh > +++ b/tests/cp/no-ctx.sh > @@ -22,6 +22,7 @@ > . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src > print_ver_ cp > require_gcc_shared_ > +requires_selinux_ > > # Replace each getfilecon and lgetfilecon call with a call to these stubs. > cat > k.c <<'EOF' || framework_failure_ I'm a bit biased about this patch. Okay, it's perfectly valid to skip the test if the system doesn't support SELinux, but OTOH it may be quite valuable to verify the exit codes like that on non-SELinux systems, i.e., based on stderr of the last cp call, the "preloaded" file must exist or not. The test could verify that. WDYT? Thanks & have a nice day, Berny From MAILER-DAEMON Tue Jan 14 08:56:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W34Ta-0002Y6-6P for mharc-bug-coreutils@gnu.org; Tue, 14 Jan 2014 08:56:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W34TU-0002XH-1d for bug-coreutils@gnu.org; Tue, 14 Jan 2014 08:56:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W34TP-0000Vd-Nc for bug-coreutils@gnu.org; Tue, 14 Jan 2014 08:56:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:35819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W34TP-0000VV-JW for bug-coreutils@gnu.org; Tue, 14 Jan 2014 08:56:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W34TO-0006ui-RT for bug-coreutils@gnu.org; Tue, 14 Jan 2014 08:56:07 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 14 Jan 2014 13:56:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138970773326522 (code B ref 16335); Tue, 14 Jan 2014 13:56:06 +0000 Received: (at 16335) by debbugs.gnu.org; 14 Jan 2014 13:55:33 +0000 Received: from localhost ([127.0.0.1]:49838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W34Sp-0006tg-OZ for submit@debbugs.gnu.org; Tue, 14 Jan 2014 08:55:32 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:23672) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W34Si-0006tS-MF for 16335@debbugs.gnu.org; Tue, 14 Jan 2014 08:55:26 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBALZA1VJtTnzz/2dsb2JhbAANTYNDuy2BKYMZAQEBAwEyAUYFCwsNAQYECSUPAkYGDQEFAgEBh3gNqEGbeBePBweENwSZToU8jlY Received: from unknown (HELO [192.168.1.79]) ([109.78.124.243]) by mail3.vodafone.ie with ESMTP; 14 Jan 2014 13:55:23 +0000 Message-ID: <52D541CA.30904@draigBrady.com> Date: Tue, 14 Jan 2014 13:55:22 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> <52D4480D.8030703@draigBrady.com> <52D51760.8070001@bernhard-voelker.de> <52D520F1.4@draigBrady.com> <52D52FC3.4030304@bernhard-voelker.de> In-Reply-To: <52D52FC3.4030304@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 13:56:16 -0000 On 01/14/2014 12:38 PM, Bernhard Voelker wrote: > On 01/14/2014 12:35 PM, Pdraig Brady wrote: >> On 01/14/2014 10:54 AM, Bernhard Voelker wrote: >>> + test -e preloaded >>> + skip_ 'LD_PRELOAD interception failed' >> >> Oh right. I think this should restrict the test appropriately... >> >> commit 3620df245a2211dc441e019845f98b91333bda77 >> Author: Pdraig Brady >> Date: Tue Jan 14 11:30:51 2014 +0000 >> >> tests: restrict a recent SELinux test to SELinux systems >> >> * tests/cp/no-ctx.sh: Since the test diagnoses whether the >> intercepted lgetfilecon() calls are actually called or not, > > The witness file is only created for getfilecon() - not for > lgetfilecon(). In the wrapper, lgetfilecon() calls getfilecon() ? >> restrict the test to systems where that occurs. >> The test cases are minimal on non SELinux systems and should >> be well covered by other tests. >> Reported-by: Bernhard Voelker >> >> diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh >> index 3b5eb82..6851785 100755 >> --- a/tests/cp/no-ctx.sh >> +++ b/tests/cp/no-ctx.sh >> @@ -22,6 +22,7 @@ >> . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src >> print_ver_ cp >> require_gcc_shared_ >> +requires_selinux_ BTW that should be require_selinux_ It's dangerous that we don't diagnose such typos. I wonder would it be appropriate to have a test_require_() wrapper that would catch such things, and be called like: test_require_ gcc_shared selinux >> # Replace each getfilecon and lgetfilecon call with a call to these stubs. >> cat > k.c <<'EOF' || framework_failure_ > > I'm a bit biased about this patch. Okay, it's perfectly valid to > skip the test if the system doesn't support SELinux, but OTOH it may > be quite valuable to verify the exit codes like that on non-SELinux > systems, Well I did state that "The test cases are minimal on non SELinux systems and should be well covered by other tests"... > i.e., based on stderr of the last cp call, the "preloaded" > file must exist or not. The test could verify that. WDYT? ...and if the last cp fails it could be due to the wrapper running, or SELinux not being supported. We'd need something else to distinguish here, and require_selinux_ is the best I can think of at present. I suppose an alternative would be to refactor require_selinux_ to a function that just determines if it's available and do: test -e preloaded || { have_selinux_ && framework_failure_ 'LD_PRELOAD interception failed'; } thanks, Pdraig. From MAILER-DAEMON Tue Jan 14 11:37:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W36zL-0007W5-MZ for mharc-bug-coreutils@gnu.org; Tue, 14 Jan 2014 11:37:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W36zE-0007Vl-ON for bug-coreutils@gnu.org; Tue, 14 Jan 2014 11:37:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W36z9-0007gF-3C for bug-coreutils@gnu.org; Tue, 14 Jan 2014 11:37:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:36483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W36z9-0007gB-0w for bug-coreutils@gnu.org; Tue, 14 Jan 2014 11:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W36z8-0003Jk-GA for bug-coreutils@gnu.org; Tue, 14 Jan 2014 11:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16335: Segmentation fault when using cp -a with SELinux and fakeroot Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 14 Jan 2014 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16335 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16335-submit@debbugs.gnu.org id=B16335.138971738112678 (code B ref 16335); Tue, 14 Jan 2014 16:37:02 +0000 Received: (at 16335) by debbugs.gnu.org; 14 Jan 2014 16:36:21 +0000 Received: from localhost ([127.0.0.1]:50502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W36yS-0003IP-Oo for submit@debbugs.gnu.org; Tue, 14 Jan 2014 11:36:21 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:56287) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W36yP-0003IB-3C for 16335@debbugs.gnu.org; Tue, 14 Jan 2014 11:36:18 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0MfSEV-1VjXc406cF-00Owyl; Tue, 14 Jan 2014 17:36:15 +0100 Message-ID: <52D5677E.5080202@bernhard-voelker.de> Date: Tue, 14 Jan 2014 17:36:14 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C734EA.9040701@m4x.org> <52C766E9.5020202@draigBrady.com> <52C779EA.2040202@draigBrady.com> <52C7EA36.8020302@m4x.org> <52D3FD25.3020704@draigBrady.com> <52D3FED0.3020100@draigBrady.com> <52D405EC.3000609@bernhard-voelker.de> <52D41DE2.7060608@draigBrady.com> <52D4480D.8030703@draigBrady.com> <52D51760.8070001@bernhard-voelker.de> <52D520F1.4@draigBrady.com> <52D52FC3.4030304@bernhard-voelker.de> <52D541CA.30904@draigBrady.com> In-Reply-To: <52D541CA.30904@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:1S/XrrAbAT86GzUA0fdR8aFVZmoBBHvRLEH3dloX2dK oZTVqO5S0FDU8RekJFzEyJHReJ8zkQPGHQfy3NzG4AbdNZAZF7 0nXyRQHEbPVWPCKaWcODZp2Ato/Uaz9o8PPDtNXNH54FKlud7b g2UovdzK1VkYkuZjYDuWwZb4SN0r96LNKoRcTnAgpka7H3OMVn aFigGa/3X3PiPlxniS9o/XLxRy8cBRLj40iwQruS8DpKOnQGCw ntwfTl3QKFvRP7xkAsWrzbWjnjUqDK69BsVOHDkUtu6POKw1oL DeCEpUyIWVR9bHYbnyLfRCVQ3nYgP/Bs9W9tlxMzXrx+GJ31Wq 4c87Hosv+u8pbBetHWX0a2BvXp7YLTgo1jvn8PRSq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: nicolas.iooss@m4x.org, 16335@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 16:37:14 -0000 On 01/14/2014 02:55 PM, Pdraig Brady wrote: > On 01/14/2014 12:38 PM, Bernhard Voelker wrote: >>> * tests/cp/no-ctx.sh: Since the test diagnoses whether the >>> intercepted lgetfilecon() calls are actually called or not, >> >> The witness file is only created for getfilecon() - not for >> lgetfilecon(). > > In the wrapper, lgetfilecon() calls getfilecon() ? Ah, sure. I missed that, sorry. >>> diff --git a/tests/cp/no-ctx.sh b/tests/cp/no-ctx.sh >>> index 3b5eb82..6851785 100755 >>> --- a/tests/cp/no-ctx.sh >>> +++ b/tests/cp/no-ctx.sh >>> @@ -22,6 +22,7 @@ >>> . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src >>> print_ver_ cp >>> require_gcc_shared_ >>> +requires_selinux_ > > BTW that should be require_selinux_ > It's dangerous that we don't diagnose such typos. > I wonder would it be appropriate to have a test_require_() > wrapper that would catch such things, and be called like: > test_require_ gcc_shared selinux Hmm, but that would imply the same problem - if someone misspells "test_require_" ... for which we could maybe add a syntax-check rule. I'm not sure if it's worth the effort - when adding/changing a test, we have to look into the .log file anyway. >>> # Replace each getfilecon and lgetfilecon call with a call to these stubs. >>> cat > k.c <<'EOF' || framework_failure_ >> >> I'm a bit biased about this patch. Okay, it's perfectly valid to >> skip the test if the system doesn't support SELinux, but OTOH it may >> be quite valuable to verify the exit codes like that on non-SELinux >> systems, > > Well I did state that "The test cases are minimal on non SELinux systems > and should be well covered by other tests"... okay, I'm fine with that. >> i.e., based on stderr of the last cp call, the "preloaded" >> file must exist or not. The test could verify that. WDYT? > > ...and if the last cp fails it could be due to the wrapper running, > or SELinux not being supported. We'd need something else to > distinguish here, and require_selinux_ is the best I can think of > at present. > > I suppose an alternative would be to refactor require_selinux_ > to a function that just determines if it's available and do: > > test -e preloaded || > { have_selinux_ && framework_failure_ 'LD_PRELOAD interception failed'; } I think we should keep it as simple as possible, therefore I'd now favor your initial version of the patch (with the typo corrected). Thanks & have a nice day, Berny From MAILER-DAEMON Wed Jan 15 16:48:11 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3YJn-0004mi-8k for mharc-bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:48:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YHt-0004KT-2I for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:46:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3YHj-0000sS-7v for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:46:13 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YHj-0000sG-5H for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:46:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3YHi-00048p-MO for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 15 Jan 2014 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16459@debbugs.gnu.org X-Debbugs-Original-To: "bug-coreutils@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.138982230815840 (code B ref -1); Wed, 15 Jan 2014 21:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jan 2014 21:45:08 +0000 Received: from localhost ([127.0.0.1]:52525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3YGp-00047P-6E for submit@debbugs.gnu.org; Wed, 15 Jan 2014 16:45:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36202) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3YAk-0003vw-Be for submit@debbugs.gnu.org; Wed, 15 Jan 2014 16:38:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3YAa-0007Ct-8L for submit@debbugs.gnu.org; Wed, 15 Jan 2014 16:38:50 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:58824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YAa-0007Cp-5n for submit@debbugs.gnu.org; Wed, 15 Jan 2014 16:38:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YAS-00008l-2v for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:38:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3YAI-00079O-Gy for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:38:32 -0500 Received: from nihxway4out.hub.nih.gov ([128.231.90.112]:23188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YAI-00079A-DJ for bug-coreutils@gnu.org; Wed, 15 Jan 2014 16:38:22 -0500 X-IronPortListener: Outbound_SMTP X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgMFAJb+1lKcKEfX/2dsb2JhbABZgwuBDrsLgRYWdIInAQQSKFEBFRUULxMmAQQbGodimDyEdKV4F45Og1yBEwSOXpAuiymDLYIq Received: from unknown (HELO MLBXV15.nih.gov) ([156.40.71.215]) by nihxway4out.hub.nih.gov with ESMTP/TLS/AES128-SHA; 15 Jan 2014 16:38:20 -0500 Received: from MLBXV04.nih.gov ([169.254.2.238]) by MLBXV15.nih.gov ([169.254.5.223]) with mapi id 14.03.0174.001; Wed, 15 Jan 2014 16:38:20 -0500 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Thread-Topic: groups to use a selectable separator or to encode group names with spaces Thread-Index: Ac8SOhmziKqqBjoeRCa+mvGmJ0IHgw== Date: Wed, 15 Jan 2014 21:38:19 +0000 Message-ID: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [156.40.71.125] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Wed, 15 Jan 2014 16:45:05 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 15 Jan 2014 16:48:09 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2014 21:46:23 -0000 Hi, When using groups on Cygwin, I get the following output: $ groups Domain Users Remote Desktop Users Users NCBIusers where all words are separated from each other with single spaces, resulting for example the two-word group "Domain Users" undistinguishable from two groups, "Domain" and "Users", and making it unsuitable for scripti= ng. Compare: $ id uid=3D11111(lavr) gid=3D10513(Domain Users) groups=3D10513(Domain Users),55= 5(Remote Desktop Users),545(Users),1009(NCBIusers) Suggested is either to have an option (cf. -z for "id") to separate the gro= ups on output (alternatively, have them quoted) or to encode the space (and perhaps all other "irregularities" that are encountered within the name) su= ch that the group names remain single tokens, e.g. Domain%20Users. Thanks for considering this, Anton Lavrentiev Contractor NIH/NLM/NCBI From MAILER-DAEMON Wed Jan 15 18:35:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3ZzR-0000Ma-5C for mharc-bug-coreutils@gnu.org; Wed, 15 Jan 2014 18:35:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ZzJ-0000Ig-1Q for bug-coreutils@gnu.org; Wed, 15 Jan 2014 18:35:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3ZzD-0004G3-6x for bug-coreutils@gnu.org; Wed, 15 Jan 2014 18:35:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ZzD-0004DQ-35 for bug-coreutils@gnu.org; Wed, 15 Jan 2014 18:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3ZzC-0007AB-He for bug-coreutils@gnu.org; Wed, 15 Jan 2014 18:35:02 -0500 Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Wed, 15 Jan 2014 23:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" , 16459-done@debbugs.gnu.org Mail-Followup-To: 16459@debbugs.gnu.org, mail@bernhard-voelker.de, lavr@ncbi.nlm.nih.gov Received: via spool by 16459-done@debbugs.gnu.org id=D16459.138982889427515 (code D ref 16459); Wed, 15 Jan 2014 23:35:01 +0000 Received: (at 16459-done) by debbugs.gnu.org; 15 Jan 2014 23:34:54 +0000 Received: from localhost ([127.0.0.1]:52601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Zz3-00079h-AY for submit@debbugs.gnu.org; Wed, 15 Jan 2014 18:34:53 -0500 Received: from moutng.kundenserver.de ([212.227.17.10]:49767) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Zz0-00079U-7r for 16459-done@debbugs.gnu.org; Wed, 15 Jan 2014 18:34:52 -0500 Received: from [192.168.1.11] (p57A5CC82.dip0.t-ipconnect.de [87.165.204.130]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0LiGd5-1VY6mp2N9v-00nGIg; Thu, 16 Jan 2014 00:34:48 +0100 Message-ID: <52D71B18.60808@bernhard-voelker.de> Date: Thu, 16 Jan 2014 00:34:48 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> In-Reply-To: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:2NKvjz32jnmNpbE6FrHe3Gh2fPvBd4fz0DarvaDSxSu KPawdx1ji/NdprUzaMk+D/aIldcn5rWqulylQrM0H4knkB/m3p IfNcM0R5VYaavZmhh3sPjqtHzELb3Oztdbtqy2ojtZwnaxkqup aokomQNI+//kBcWNwtqpvMbHI7WWWQdWkOVR3H0eFBfMKOXZss v5DsuWI+hgiePh4WOAKiZ+EBH4YWdZgK7qiB3yPXedqFkYiRf2 Gw487q62w1zuahQkGfzqeGjGMEx2RUfh3GBmN4u0zF/CTDsBIN AgrNyV50t87NzgUTnlgaTXZb55FCT92w/oQEYqRe0S0ZNxlYeB /JrWeE+ehcMRZM+zNBF8LYnoHmi6GYoNRfsDiFMjo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2014 23:35:15 -0000 tag 16459 notabug close thanks On 01/15/2014 10:38 PM, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: > Hi, Thanks for the report, however ... > When using groups on Cygwin, I get the following output: ... you reached the upstream coreutils development list while you are using groups(1) and id(1) from Cygwin (where the version of coreutils seems to be rather outdated, unfortunately). Did you try on the cygwin (developers?) mailing list? > $ groups > Domain Users Remote Desktop Users Users NCBIusers > > where all words are separated from each other with single spaces, > resulting for example the two-word group "Domain Users" undistinguishable > from two groups, "Domain" and "Users", and making it unsuitable for scripting. > > Compare: > > $ id > uid=11111(lavr) gid=10513(Domain Users) groups=10513(Domain Users),555(Remote Desktop Users),545(Users),1009(NCBIusers) > > Suggested is either to have an option (cf. -z for "id") to separate the groups > on output [...] But you're in luck ... at least half-way: we added support for "id -z,--zero" in version 8.22 which has been released just last December by this commit: http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=2a0d241f6 However, I have no idea when 8.22 will be available on Cygwin. As there's nothing we can do upstreams, I'm marking this as "not a bug" and set the status to closed. Have a nice day, Berny From MAILER-DAEMON Wed Jan 15 23:29:20 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3ea0-0005IO-6l for mharc-bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:29:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3eZq-0005Hz-HF for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:29:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3eZi-0000qA-EG for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:29:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3eZi-0000q5-AY for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3eZh-0007jA-QM for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:29:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 04:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , "16459-done@debbugs.gnu.org" <16459-done@debbugs.gnu.org> Received: via spool by 16459-done@debbugs.gnu.org id=D16459.138984648229623 (code D ref 16459); Thu, 16 Jan 2014 04:29:01 +0000 Received: (at 16459-done) by debbugs.gnu.org; 16 Jan 2014 04:28:02 +0000 Received: from localhost ([127.0.0.1]:52714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3eYk-0007hi-6V for submit@debbugs.gnu.org; Wed, 15 Jan 2014 23:28:02 -0500 Received: from nihxway3out.hub.nih.gov ([128.231.90.111]:49749) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3eYi-0007hH-8W for 16459-done@debbugs.gnu.org; Wed, 15 Jan 2014 23:28:00 -0500 X-IronPortListener: Outbound_SMTP X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiEFACpf11KcKEeu/2dsb2JhbABZgwuBDrsIgRcWdIIlAQEBAwESKEQLAgEIDQEUFBAfEyUBAQQBGhqHWgidb6YEF45OOIMkgRMEjl6QLospgW+BPoIq Received: from unknown (HELO CASHTV10.nih.gov) ([156.40.71.174]) by nihxway3out.hub.nih.gov with ESMTP/TLS/AES128-SHA; 15 Jan 2014 23:27:59 -0500 Received: from MLBXV04.nih.gov ([169.254.2.238]) by CASHTV10.nih.gov ([156.40.71.174]) with mapi id 14.03.0174.001; Wed, 15 Jan 2014 23:27:59 -0500 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Thread-Topic: bug#16459: groups to use a selectable separator or to encode group names with spaces Thread-Index: Ac8SOhmziKqqBjoeRCa+mvGmJ0IHgwAOjAMAAACLE4A= Date: Thu, 16 Jan 2014 04:27:58 +0000 Message-ID: <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov> References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> In-Reply-To: <52D71B18.60808@bernhard-voelker.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [156.40.71.125] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 04:29:18 -0000 > As there's nothing we can do upstreams, I'm marking this as "not a bug" > and set the status to closed. Why "nothing"? And it *is* a bug, IMO. My rebuttal is as the following: If the feature is implemented upstream it can get to CYGWIN, eventually. Not the other way around. Currently CYGWIN uses 8.15, which is not behind = a lot. They catch up from time to time to right to the current versions of the too= ls... As for their response, here it is: > > > is unparsable in CYGWIN (scripting becomes problematic), because t= he space is used both > > > in the group names (as obtained from Windows) and to delimit the g= roup names in the groups' > > > output: > > Such a proposal should be made to upstream coreutils, as it could > > possibly be of benefit to more platforms than just cygwin. Which is exactly what I was doing posting this suggestion here. Anton Lavrentiev Contractor NIH/NLM/NCBI From MAILER-DAEMON Wed Jan 15 23:31:20 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3ebw-0005oP-HQ for mharc-bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:31:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ebm-0005no-Up for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:31:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3ebe-0001LU-Q7 for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:31:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ebe-0001LP-MI for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3ebd-0007o1-Nw for bug-coreutils@gnu.org; Wed, 15 Jan 2014 23:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: FW: bug#16459: groups to use a selectable separator or to encode group names with spaces In-Reply-To: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> Resent-From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 04:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "16459@debbugs.gnu.org" <16459@debbugs.gnu.org> Received: via spool by 16459-submit@debbugs.gnu.org id=B16459.138984666029998 (code B ref 16459); Thu, 16 Jan 2014 04:31:01 +0000 Received: (at 16459) by debbugs.gnu.org; 16 Jan 2014 04:31:00 +0000 Received: from localhost ([127.0.0.1]:52718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3eba-0007nk-2b for submit@debbugs.gnu.org; Wed, 15 Jan 2014 23:30:59 -0500 Received: from nihxway6out.hub.nih.gov ([128.231.90.114]:38757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3ebW-0007na-VT for 16459@debbugs.gnu.org; Wed, 15 Jan 2014 23:30:55 -0500 X-IronPortListener: Outbound_SMTP X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEAPxf11KcKEex/2dsb2JhbABZhBm7CIEtdIIlAQEBAwESKEQLAgEIIhQQHxMbAQYDAQEEGxqHWgidcaYDF45Og1yBEwSOXptXgW+BPoIq Received: from citdcswebx.cit.nih.gov (HELO CASHTV14.nih.gov) ([156.40.71.177]) by nihxway6out.hub.nih.gov with ESMTP/TLS/AES128-SHA; 15 Jan 2014 23:30:50 -0500 Received: from MLBXV04.nih.gov ([169.254.2.238]) by CASHTV14.nih.gov ([156.40.71.177]) with mapi id 14.03.0174.001; Wed, 15 Jan 2014 23:30:50 -0500 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Thread-Topic: bug#16459: groups to use a selectable separator or to encode group names with spaces Thread-Index: Ac8SOhmziKqqBjoeRCa+mvGmJ0IHgwAOjAMAAACLE4AAALiewA== Date: Thu, 16 Jan 2014 04:30:49 +0000 Message-ID: <5F8AAC04F9616747BC4CC0E803D5907D0C45DD14@MLBXv04.nih.gov> References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [156.40.71.125] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 04:31:19 -0000 (sorry if this ends up posted twice) > As there's nothing we can do upstreams, I'm marking this as "not a bug" > and set the status to closed. Why "nothing"? And it *is* a bug, IMO. My rebuttal is as the following: If the feature is implemented upstream it can get to CYGWIN, eventually. Not the other way around. Currently CYGWIN uses 8.15, which is not behind = by a lot. They catch up from time to time right to the current versions of the tools.= .. As for their response, here it is: > > > is unparsable in CYGWIN (scripting becomes problematic), because t= he space is used both > > > in the group names (as obtained from Windows) and to delimit the g= roup names in the groups' > > > output: > > Such a proposal should be made to upstream coreutils, as it could > > possibly be of benefit to more platforms than just cygwin. Which is exactly what I was doing posting this suggestion here. Anton Lavrentiev Contractor NIH/NLM/NCBI From MAILER-DAEMON Thu Jan 16 01:53:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3gpH-00053i-Kk for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 01:53:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3gpA-00052w-MI for bug-coreutils@gnu.org; Thu, 16 Jan 2014 01:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3gp4-0005LC-RP for bug-coreutils@gnu.org; Thu, 16 Jan 2014 01:53:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:38713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3gp4-0005L8-On for bug-coreutils@gnu.org; Thu, 16 Jan 2014 01:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3gp4-0003Ez-0R for bug-coreutils@gnu.org; Thu, 16 Jan 2014 01:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 06:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" , "16459-done@debbugs.gnu.org" <16459-done@debbugs.gnu.org> Received: via spool by 16459-done@debbugs.gnu.org id=D16459.138985515112413 (code D ref 16459); Thu, 16 Jan 2014 06:53:01 +0000 Received: (at 16459-done) by debbugs.gnu.org; 16 Jan 2014 06:52:31 +0000 Received: from localhost ([127.0.0.1]:52732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3goY-0003E9-Jy for submit@debbugs.gnu.org; Thu, 16 Jan 2014 01:52:30 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:55524) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3goV-0003Dy-CW for 16459-done@debbugs.gnu.org; Thu, 16 Jan 2014 01:52:28 -0500 Received: from [192.168.1.11] (p57A5CC82.dip0.t-ipconnect.de [87.165.204.130]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0Mewsn-1Vji3i4BU9-00PAVn; Thu, 16 Jan 2014 07:52:24 +0100 Message-ID: <52D781A7.3070703@bernhard-voelker.de> Date: Thu, 16 Jan 2014 07:52:23 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov> In-Reply-To: <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:Hg+BApcCoGwYWJceJ3nHu8oD+3mHz/zKkxcY033sNm2 cZ6UxnUbMLWxRg08WDDV8otqc35ZL5PxJ0fJBSEQDtc1CssBME m9i0JoCv8WMeVrfWmYuX0VOi7h3X/eOyDJnhD9ZRovksw2aCMC jcBXEJCet0ZZiFthJ3blXYArwK0ogi6+EdHNUmrrZvPR+tDdja qjw4OVKPmPDBfjdLKPcYANrantxpVKSOzH35ctc63L8fPnVZYY ykMTmJUOEI/VcFInvowcCG0H/BverIdl0nAcfm49mYAY2NXv9u nbqvlUYnNQ2W2SZRjazdOyiV3qVXd09JJqqE7Ygp3bHgW1MHO8 aijWvKwRExnFprqqIKKfA6AtBlXT7XD1xubyZ3Api X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 06:53:14 -0000 On 01/16/2014 05:27 AM, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: >> As there's nothing we can do upstreams, I'm marking this as "not a bug" >> and set the status to closed. > > Why "nothing"? And it *is* a bug, IMO. It is not a bug because your suggestion is already implemented in upstream coreutils but just not yet picked up by the Cygwin distribution. > Currently CYGWIN uses 8.15, which is not behind a lot. 8.15 is already 2 years old: http://lists.gnu.org/archive/html/coreutils-announce/2012-01/msg00000.html > They catch up from time to time to right to the current versions of the tools... ... and when they do that the next time, then "id -z" will be available on Cygwin, too. Have a nice day, Berny From MAILER-DAEMON Thu Jan 16 09:33:24 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3o0a-0004ZQ-4O for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:33:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3o0P-0004PD-33 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3o0G-0004q5-R1 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:33:13 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3o0G-0004pu-OI for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:33:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3o0F-0002OW-8g for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:33:04 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , "16459-done@debbugs.gnu.org" <16459-done@debbugs.gnu.org> Received: via spool by 16459-done@debbugs.gnu.org id=D16459.13898827739186 (code D ref 16459); Thu, 16 Jan 2014 14:33:02 +0000 Received: (at 16459-done) by debbugs.gnu.org; 16 Jan 2014 14:32:53 +0000 Received: from localhost ([127.0.0.1]:53061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3o04-0002O5-ED for submit@debbugs.gnu.org; Thu, 16 Jan 2014 09:32:52 -0500 Received: from nihxwayout.hub.nih.gov ([128.231.90.109]:4703) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3nzy-0002Nq-UC for 16459-done@debbugs.gnu.org; Thu, 16 Jan 2014 09:32:47 -0500 X-IronPortListener: Outbound_SMTP X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgEFAGjs11KcKEes/2dsb2JhbABZhBm7C4ELFnSCJgEFEihECwIBCA0BFBQQHxMlAQEEARoah2Kda6Zljk44gySBFASOX5AwiymBb4E+gio Received: from unknown (HELO CASHTV08.nih.gov) ([156.40.71.172]) by nihxwayout.hub.nih.gov with ESMTP/TLS/AES128-SHA; 16 Jan 2014 09:24:21 -0500 Received: from MLBXV04.nih.gov ([169.254.2.238]) by CASHTV08.nih.gov ([156.40.71.172]) with mapi id 14.03.0174.001; Thu, 16 Jan 2014 09:24:20 -0500 From: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Thread-Topic: bug#16459: groups to use a selectable separator or to encode group names with spaces Thread-Index: Ac8SOhmziKqqBjoeRCa+mvGmJ0IHgwAOjAMAAACLE4AADr06gAAE/0xI Date: Thu, 16 Jan 2014 14:24:19 +0000 Message-ID: <5F8AAC04F9616747BC4CC0E803D5907D0C45DE56@MLBXv04.nih.gov> References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov>, <52D781A7.3070703@bernhard-voelker.de> In-Reply-To: <52D781A7.3070703@bernhard-voelker.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [156.40.71.192] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 14:33:21 -0000 > It is not a bug because your suggestion is already implemented in upstrea= m coreutils=0A= =0A= It's implemented only for the "id" command; not for "groups", which I asked= about -- please note the $subject.=0A= Can you please consider adding the -z there as well?=0A= =0A= Anton Lavrentiev=0A= Contractor NIH/NLM/NCBI=0A= From MAILER-DAEMON Thu Jan 16 09:45:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3oC7-0003CA-LT for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:45:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oC0-000382-Eb for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:45:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3oBr-0000aD-3A for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:45:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oBq-0000Zr-VI for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3oBq-0002ig-JF for bug-coreutils@gnu.org; Thu, 16 Jan 2014 09:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" , "16459-done@debbugs.gnu.org" <16459-done@debbugs.gnu.org> Received: via spool by 16459-done@debbugs.gnu.org id=D16459.138988344410367 (code D ref 16459); Thu, 16 Jan 2014 14:45:02 +0000 Received: (at 16459-done) by debbugs.gnu.org; 16 Jan 2014 14:44:04 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3oAu-0002h8-4b for submit@debbugs.gnu.org; Thu, 16 Jan 2014 09:44:04 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:60852) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3oAs-0002gp-GL for 16459-done@debbugs.gnu.org; Thu, 16 Jan 2014 09:44:03 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MTtCv-1VudF0101h-00RPvy; Thu, 16 Jan 2014 15:43:59 +0100 Message-ID: <52D7F02E.5020909@bernhard-voelker.de> Date: Thu, 16 Jan 2014 15:43:58 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov>, <52D781A7.3070703@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DE56@MLBXv04.nih.gov> In-Reply-To: <5F8AAC04F9616747BC4CC0E803D5907D0C45DE56@MLBXv04.nih.gov> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:NBz8wNy+5MF5VbAsLcSnBXgdTAqcnfCs2SsmoCyvCyF 9UY8czG1fTgRAeWIuyILjwWzavdXDP9why+dbl2e+Z5a0Qg/WQ JpSG+Xlicbff+KYZoOMogYNDj+DK3TVLt3B+DkhawLbd7PxXS+ TXa41DW7pAilu6z9ZHUPSYuD9OjYICMPyOpWZQfltVi0w1hyR9 VJpC6VUMaKUnhUxcs71c2MH6vihatfs/w2vhmNC7ko1MdKo8zx FF/58OGmTVupTz3hx+XubM3efHPRJ+ol8vmmfycgv2fy1W7pAF NF9BL2N3Ed348byenL/trg76odI8vcHK8GxAVhIXWDhrFsEG5j 3gGrxDSLOqsQOdzutOYUXxB38QPE3lWFgDtrkeawT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 14:45:18 -0000 On 01/16/2014 03:24 PM, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: >> It is not a bug because your suggestion is already implemented in upstream coreutils > > It's implemented only for the "id" command; not for "groups", which I asked about -- please note the $subject. > Can you please consider adding the -z there as well? I'd say no. That has been discussed before: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9987#49 Have a nice day, Berny From MAILER-DAEMON Thu Jan 16 12:10:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3qSP-0004j9-1t for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:10:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3qPH-0003q7-Bu for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:07:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3qPG-0005W8-A7 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:07:03 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3qPG-0005W3-6z for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3qPF-0006lc-WC for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: barry kesner Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16468@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138989198125950 (code B ref -1); Thu, 16 Jan 2014 17:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jan 2014 17:06:21 +0000 Received: from eggs.gnu.org ([208.118.235.92]:51805) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3osy-00043t-OY for submit@debbugs.gnu.org; Thu, 16 Jan 2014 10:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3osx-00071U-Fw for submit@debbugs.gnu.org; Thu, 16 Jan 2014 10:29:36 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:34048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3osx-00071L-Cf for submit@debbugs.gnu.org; Thu, 16 Jan 2014 10:29:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3osw-00071z-DQ for bug-coreutils@gnu.org; Thu, 16 Jan 2014 10:29:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3osu-00070z-A3 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 10:29:34 -0500 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:52358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3osu-0006zd-2m for bug-coreutils@gnu.org; Thu, 16 Jan 2014 10:29:32 -0500 Received: by mail-pd0-f180.google.com with SMTP id x10so1406931pdj.25 for ; Thu, 16 Jan 2014 07:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=czPmy1iABNUE42GAfVPM4qBZ/iJYN7NtpRtPvOfvLso=; b=p1++wLtbAkcylyHiG6bCoyleHGMT1Ct4PVIaJTGw1V8SMv8F/2qNHwiFXgj0AYBrRg 0THB4JlJJEONCLGWe/eAfmezwMl7qtOaJwTeR3J1j7iW9wwJG+hgfeyQNeYPAKytbYVh XtBBYn5CP5AdL+Z0/QMp/X7E3X83grAFai1zg0FZCZ112duaFJmmogrCDPw7Sj+4h2yv mj0vV0+XIfnCg+7swqWurmDogdseHt3LCPLp3qPXTVKwvqBs9gzEfMv8uc0xHUtk4hAZ Ig4wZ4KpXPKX+CeDiJ/3s1EuPqCNhl0NaDU+6kGU6XZ2B4bdY1eblNyke11kprH5wrnU fQRA== MIME-Version: 1.0 X-Received: by 10.69.20.11 with SMTP id gy11mr6050317pbd.64.1389886167579; Thu, 16 Jan 2014 07:29:27 -0800 (PST) Received: by 10.70.41.231 with HTTP; Thu, 16 Jan 2014 07:29:27 -0800 (PST) Date: Thu, 16 Jan 2014 10:29:27 -0500 Message-ID: From: barry kesner X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Thu, 16 Jan 2014 12:10:15 -0500 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 17:07:04 -0000 join is failing on large numbers somehow I have 2 files to join file 1 99910287 1 99978720 1 99980081 1 99980180 2 99980281 1 99980406 1 99980932 1 99982402 1 100002132 1 100002162 2 100002166 3 file 2 contains 99980081 1 100002129 1 100002136 2 100002162 3 Join fails to join properly only giving 99980081 if I prefix the 9's with a 0 join does not fail Barry From MAILER-DAEMON Thu Jan 16 12:16:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3qY9-00077C-NB for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:16:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3qY3-000775-VX for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:16:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3qXz-0008Oz-2P for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:16:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3qXy-0008Od-VA for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3qXy-000724-9V for bug-coreutils@gnu.org; Thu, 16 Jan 2014 12:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: barry kesner , 16468@debbugs.gnu.org Received: via spool by 16468-submit@debbugs.gnu.org id=B16468.138989251226905 (code B ref 16468); Thu, 16 Jan 2014 17:16:02 +0000 Received: (at 16468) by debbugs.gnu.org; 16 Jan 2014 17:15:12 +0000 Received: from localhost ([127.0.0.1]:53901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3qX9-0006zp-Lq for submit@debbugs.gnu.org; Thu, 16 Jan 2014 12:15:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1145) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3qX5-0006zd-Mr for 16468@debbugs.gnu.org; Thu, 16 Jan 2014 12:15:09 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GHF47t005939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 12:15:05 -0500 Received: from [10.3.113.148] (ovpn-113-148.phx2.redhat.com [10.3.113.148]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0GHF4rI026574; Thu, 16 Jan 2014 12:15:04 -0500 Message-ID: <52D81398.60203@redhat.com> Date: Thu, 16 Jan 2014 10:15:04 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LHOgxak8U9NniQUivAj6OWAfI44mbOVLB" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 17:16:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LHOgxak8U9NniQUivAj6OWAfI44mbOVLB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2014 08:29 AM, barry kesner wrote: > join is failing on large numbers somehow >=20 >=20 > Join fails to join properly only giving 99980081 > if I prefix the 9's with a 0 join does not fail Sounds to me like you didn't heed this advice in the --help text: Important: FILE1 and FILE2 must be sorted on the join fields. E.g., use "sort -k 1b,1" if 'join' has no options, or use "join -t ''" if 'sort' has no options. Note, comparisons honor the rules specified by 'LC_COLLATE'. If the input is not sorted and some lines cannot be joined, a warning message will be given. Does running 'LC_ALL=3DC join' change the behavior for you, in which case= it was an issue of your choice of LC_COLLATE? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LHOgxak8U9NniQUivAj6OWAfI44mbOVLB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS2BOYAAoJEKeha0olJ0NqZacH/ip+GHRKgPgUt9yu2ZsInYP5 nQwENU0WzFY9GfwCXjiuRXwmb0M60UrjqP4ifqKGROiEYYp4yBCOZ0L+2bX9a9Q8 8k+gkZjL8DoeNxeeF8KGU5HDAV9TKmnbPZXT8pJO/b81kfSFVnkhNTbeicBJafz/ ySkMzoWfCLmyj/sQAQhp1OcdEYAzjG/u8ehvVRRVd0+bumf4HYG60SDlKCWIcqqH YR+Cn8B1tbi/VEeu9bFv+3ZhV0eQNn/L88Xr0ym3VsJrq1vzPVGWqiJzcWFYehN8 2PIQjmxWG3x2KZdrfowtiO4g76FX0k1dWQcibhWlRcwBVV/i5uioUHNFSCE4+VE= =iMs9 -----END PGP SIGNATURE----- --LHOgxak8U9NniQUivAj6OWAfI44mbOVLB-- From MAILER-DAEMON Thu Jan 16 13:11:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3rPS-0003gK-M7 for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 13:11:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3rPM-0003dm-8a for bug-coreutils@gnu.org; Thu, 16 Jan 2014 13:11:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3rPD-00034k-BK for bug-coreutils@gnu.org; Thu, 16 Jan 2014 13:11:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3rPD-000342-67 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 13:11:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3rPC-0000Ac-8M for bug-coreutils@gnu.org; Thu, 16 Jan 2014 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: barry kesner , 16468@debbugs.gnu.org Received: via spool by 16468-submit@debbugs.gnu.org id=B16468.1389895819594 (code B ref 16468); Thu, 16 Jan 2014 18:11:02 +0000 Received: (at 16468) by debbugs.gnu.org; 16 Jan 2014 18:10:19 +0000 Received: from localhost ([127.0.0.1]:53946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3rOV-00009V-5z for submit@debbugs.gnu.org; Thu, 16 Jan 2014 13:10:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3rOR-00009H-4w for 16468@debbugs.gnu.org; Thu, 16 Jan 2014 13:10:17 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GIACMK027680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 13:10:14 -0500 Received: from [10.3.113.148] (ovpn-113-148.phx2.redhat.com [10.3.113.148]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0GIACf2023946; Thu, 16 Jan 2014 13:10:12 -0500 Message-ID: <52D82083.3010309@redhat.com> Date: Thu, 16 Jan 2014 11:10:11 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52D81398.60203@redhat.com> In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XDjdKbPcQEOPXlB4VoUPgJ7rhOrgq8VT4" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 18:11:17 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XDjdKbPcQEOPXlB4VoUPgJ7rhOrgq8VT4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [re-adding the list, with permission] On 01/16/2014 10:46 AM, barry kesner wrote: > Eric, > Thanks for response. > I now realize it wants sorted alpha input not numerical. 999 1000 100= 1 is > how it is sorted. I think there have been requests in the past to enhance 'join' so that it can have more fine-tuned control over how its fields are selected. Maybe something like sharing code so that 'join -1 k1,1n' would behave like it were using 'sort -k1,1n' sorting on file 1. But right now, that functionality doesn't exist. >=20 > How do you tell join this without resorting. The files are huge! Unfortunately, there isn't any really good way, short of re-processing the files to make the data appear sorted in the order join expects. That said, it certainly appears that for your given data, you can write a sed filter that can reprocess on a line-by-line basis, and feed that into join, without the penalty of having to re-sort the entire file and without having to have the processed file stored in your file system all at once. It also seems possible to write a post filter to get back to the style of the line in the original file. Here, extensions such as bas= h's join <(infilter file1) <(infilter file2) | outfilter make it easier to type (where the trick is to now write the correct sed scripts to serve as infilter and outfilter) than the alternative of having to use named fifos for limiting yourself to just POSIX semantics. >=20 > I can't find LC_COLLATE? It's an environment variable, like LC_ALL, that affects your locale. Running 'locale' will show you your current locale settings, including LC_COLLATE. Setting LC_ALL in the environment is shorthand that forces all other categories to behave the same, so it's easier to test whether 'LC_ALL=3DC command' has an effect than it is to figure out which locale category(ies) matter. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XDjdKbPcQEOPXlB4VoUPgJ7rhOrgq8VT4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS2CCDAAoJEKeha0olJ0NqW8wH/jW+8Mfyd9ZimoqK/cz5oJ0X sxPpjKBjM5Xw6i55u4+qi+21xdCNk5TtYkjkTnqLpBowKVLaogvkn+2GNyPt2g2L qc8DDbSne8GxVZn/fQRNjoE4D1G1ZOtLrIqZsVB8Y+jk5yYi+x4uhMETbO1HM0qk F6W64oz6SfjA51RMR5rKDMj0x50EcwclvEf3oQeEBAHSSXGusj13tOw2stzE0yZF h82pfOF0cQgDVERP8SjepTlHVe8ZozvJ7V3CIFN3F13KrPJdnSRV8MeDPzSvJC8N nxN4KsSjVEB0P5MyJGHCszFmEXJbYtXOzwAHTMq/CCHhAhIDFOoKsbxoYvawpKw= =AUR2 -----END PGP SIGNATURE----- --XDjdKbPcQEOPXlB4VoUPgJ7rhOrgq8VT4-- From MAILER-DAEMON Thu Jan 16 14:33:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3sgl-0000ob-6A for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 14:33:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3sgd-0000f0-Gb for bug-coreutils@gnu.org; Thu, 16 Jan 2014 14:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3sgY-0003X9-MH for bug-coreutils@gnu.org; Thu, 16 Jan 2014 14:33:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:39981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3sgY-0003Wy-Jn for bug-coreutils@gnu.org; Thu, 16 Jan 2014 14:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3sgY-0002UG-3F for bug-coreutils@gnu.org; Thu, 16 Jan 2014 14:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 16 Jan 2014 19:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake Received: via spool by 16468-submit@debbugs.gnu.org id=B16468.13899007249464 (code B ref 16468); Thu, 16 Jan 2014 19:33:02 +0000 Received: (at 16468) by debbugs.gnu.org; 16 Jan 2014 19:32:04 +0000 Received: from localhost ([127.0.0.1]:53999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3sfc-0002SY-7D for submit@debbugs.gnu.org; Thu, 16 Jan 2014 14:32:04 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:14587) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3sfZ-0002S4-P2 for 16468@debbugs.gnu.org; Thu, 16 Jan 2014 14:32:02 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBALMy2FJtTvfM/2dsb2JhbAANTINDg1S4EoElgxkBAQEEAQIgDwFGEAsNAQoCAgUWCwICCQMCAQIBFi8GDQEHAQGIBQind3acKxeBKY1WB4JvgUkElDuBFYQChT2OVg Received: from unknown (HELO [192.168.1.79]) ([109.78.247.204]) by mail2.vodafone.ie with ESMTP; 16 Jan 2014 19:32:00 +0000 Message-ID: <52D833AF.2060506@draigBrady.com> Date: Thu, 16 Jan 2014 19:31:59 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52D81398.60203@redhat.com> <52D82083.3010309@redhat.com> In-Reply-To: <52D82083.3010309@redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: barry kesner , 16468@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2014 19:33:12 -0000 On 01/16/2014 06:10 PM, Eric Blake wrote: > [re-adding the list, with permission] > > On 01/16/2014 10:46 AM, barry kesner wrote: >> How do you tell join this without resorting. The files are huge! > > Unfortunately, there isn't any really good way, short of re-processing > the files to make the data appear sorted in the order join expects. Note we are working on merging sort, uniq, and join key selection and comparison code, to support this directly. http://lists.gnu.org/archive/html/coreutils/2013-09/msg00047.html thanks, Pádraig. From MAILER-DAEMON Thu Jan 16 19:01:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3wsA-0007MA-3Y for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 19:01:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3ws1-0007Kz-NB for bug-coreutils@gnu.org; Thu, 16 Jan 2014 19:01:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3wru-0001Ty-DA for bug-coreutils@gnu.org; Thu, 16 Jan 2014 19:01:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:40188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3wru-0001Sl-AE for bug-coreutils@gnu.org; Thu, 16 Jan 2014 19:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3wrt-0003tT-Jb for bug-coreutils@gnu.org; Thu, 16 Jan 2014 19:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 17 Jan 2014 00:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Eric Blake , barry kesner , 16468@debbugs.gnu.org Received: via spool by 16468-submit@debbugs.gnu.org id=B16468.138991681514831 (code B ref 16468); Fri, 17 Jan 2014 00:01:01 +0000 Received: (at 16468) by debbugs.gnu.org; 17 Jan 2014 00:00:15 +0000 Received: from localhost ([127.0.0.1]:54205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3wr8-0003r8-Mn for submit@debbugs.gnu.org; Thu, 16 Jan 2014 19:00:14 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:57836) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3wr6-0003qu-Uj for 16468@debbugs.gnu.org; Thu, 16 Jan 2014 19:00:13 -0500 Received: from [192.168.1.11] (p57A5CC82.dip0.t-ipconnect.de [87.165.204.130]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MVqHM-1VoRDW2PH6-00XErk; Fri, 17 Jan 2014 01:00:10 +0100 Message-ID: <52D8728A.1010904@bernhard-voelker.de> Date: Fri, 17 Jan 2014 01:00:10 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52D81398.60203@redhat.com> <52D82083.3010309@redhat.com> In-Reply-To: <52D82083.3010309@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:vSbVdtq14ndWriASSymab5tkgeB7Ia/lf10L3+I+fqu tG8DUeQfwYEH4I9P+oZd42tQ9CFmbhveiSyxPwHvYCsvlGrgg2 fRttxP8CqCl4s08Ey5gXZ7K0QHcONqv0k0XLBClGIL0/wGUc0R NB4A/6zZrz7qCnACBC7Y+nQ7bYuPRQpHlCqdZugqubps9+JrhY q1GBYhwTs3JxjykuPbicH9GIu93E2JmqPoIR43S7RDbZxMi+kc sn1qeXWNISWamJqym1G7pp1Tw6TdBawo2V2OcRYhO3h/ENDRb0 rGaYl64kDr3+r4WQk1COZgkC9BgiNPycOunZGkcOOkONki2zK1 M5rIWCoUTblk//Zrnky3mbyqrIzkjRjIPI3X6E/sa X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 00:01:17 -0000 On 01/16/2014 07:10 PM, Eric Blake wrote: > On 01/16/2014 10:46 AM, barry kesner wrote: >> How do you tell join this without resorting. The files are huge! > > Unfortunately, there isn't any really good way, short of re-processing > the files to make the data appear sorted in the order join expects. > That said, it certainly appears that for your given data, you can write > a sed filter that can reprocess on a line-by-line basis, and feed that > into join, without the penalty of having to re-sort the entire file and > without having to have the processed file stored in your file system all > at once. It also seems possible to write a post filter to get back to > the style of the line in the original file. Here, extensions such as bash's > join <(infilter file1) <(infilter file2) | outfilter > make it easier to type (where the trick is to now write the correct sed > scripts to serve as infilter and outfilter) than the alternative of > having to use named fifos for limiting yourself to just POSIX semantics. Hum, isn't such number conversion filtering exactly what numfmt wasn't designed for? But wait ... $ numfmt --field 1 --format='%020f' < f2 99980081 1 100002129 1 100002136 2 100002162 3 ... it doesn't support leading zeros, unfortunately. ;-/ Wouldn't this be a nice enhancement? Have a nice day, Berny From MAILER-DAEMON Thu Jan 16 20:46:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3yVk-0005mP-Bo for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 20:46:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3yVc-0005mI-Eq for bug-coreutils@gnu.org; Thu, 16 Jan 2014 20:46:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3yVW-0001Hc-Bp for bug-coreutils@gnu.org; Thu, 16 Jan 2014 20:46:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:40219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3yVW-0001Gz-8E for bug-coreutils@gnu.org; Thu, 16 Jan 2014 20:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3yVV-0000Cm-PY for bug-coreutils@gnu.org; Thu, 16 Jan 2014 20:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16459: groups to use a selectable separator or to encode group names with spaces Resent-From: Bob Proulx Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 17 Jan 2014 01:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16459 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Lavrentiev, Anton (NIH/NLM/NCBI) [C]" Received: via spool by 16459-done@debbugs.gnu.org id=D16459.1389923101689 (code D ref 16459); Fri, 17 Jan 2014 01:46:01 +0000 Received: (at 16459-done) by debbugs.gnu.org; 17 Jan 2014 01:45:01 +0000 Received: from localhost ([127.0.0.1]:54238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3yUW-0000Ap-Sb for submit@debbugs.gnu.org; Thu, 16 Jan 2014 20:45:01 -0500 Received: from joseki.proulx.com ([216.17.153.58]:44980) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3yUT-0000Ae-QE for 16459-done@debbugs.gnu.org; Thu, 16 Jan 2014 20:44:58 -0500 Received: from hysteria.proulx.com (hysteria.proulx.com [192.168.230.119]) by joseki.proulx.com (Postfix) with ESMTP id 7794621227; Thu, 16 Jan 2014 18:44:56 -0700 (MST) Received: by hysteria.proulx.com (Postfix, from userid 1000) id 445042DCD2; Thu, 16 Jan 2014 18:44:56 -0700 (MST) Date: Thu, 16 Jan 2014 18:44:56 -0700 From: Bob Proulx Message-ID: <20140117014456.GH25864@hysteria.proulx.com> References: <5F8AAC04F9616747BC4CC0E803D5907D0C45DADE@MLBXv04.nih.gov> <52D71B18.60808@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DCCC@MLBXv04.nih.gov> <52D781A7.3070703@bernhard-voelker.de> <5F8AAC04F9616747BC4CC0E803D5907D0C45DE56@MLBXv04.nih.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5F8AAC04F9616747BC4CC0E803D5907D0C45DE56@MLBXv04.nih.gov> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16459-done@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 01:46:14 -0000 Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: > > It is not a bug because your suggestion is already implemented in upstream coreutils > > It's implemented only for the "id" command; not for "groups", which I asked about -- please note the $subject. > Can you please consider adding the -z there as well? The 'id -Gn' command is the standard way to get 'groups' output. The GNU id command already has -z added to it. Since in order to use the -z option you would need to actually use the -z option is there any reason not to use it with id instead of groups? Why request it in 'groups' if it is already available in 'id'? id -Gnz When Cygwin updates they will get the -z option. Even if it were added to groups Cygwin would still need to update in order to have it appear there. Therefore they are equivalent. Might as well use id then and get all of the option capability. That is why the group doesn't consider this a bug in 'groups'. Because the feature plus more has already been implemented in 'id'. Since id is one of the standard commands it should always be preferred over the not standard groups command. However needing -z would put this into the nonstandard camp regardless. Bob From MAILER-DAEMON Thu Jan 16 21:22:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W3z4a-00046Q-Vw for mharc-bug-coreutils@gnu.org; Thu, 16 Jan 2014 21:22:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3z4T-00045b-5L for bug-coreutils@gnu.org; Thu, 16 Jan 2014 21:22:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3z4N-00028u-63 for bug-coreutils@gnu.org; Thu, 16 Jan 2014 21:22:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:40223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3z4N-00028q-2o for bug-coreutils@gnu.org; Thu, 16 Jan 2014 21:22:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3z4M-0001Ca-Gd for bug-coreutils@gnu.org; Thu, 16 Jan 2014 21:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16468: join Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 17 Jan 2014 02:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16468 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16468-submit@debbugs.gnu.org id=B16468.13899252994586 (code B ref 16468); Fri, 17 Jan 2014 02:22:02 +0000 Received: (at 16468) by debbugs.gnu.org; 17 Jan 2014 02:21:39 +0000 Received: from localhost ([127.0.0.1]:54242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3z3z-0001Bt-2k for submit@debbugs.gnu.org; Thu, 16 Jan 2014 21:21:39 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:1269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3z3w-0001Bh-MW for 16468@debbugs.gnu.org; Thu, 16 Jan 2014 21:21:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAFVf2FJtTCcs/2dsb2JhbAANTIcXtQuDCIElgxkBAQEEIw8BRhALDQEKAgIFFAILAgIJAwIBAgFFBg0BBwEBiAWoKXacHReBKY1WB4JvgUkBA5Q7ilSOVg Received: from unknown (HELO [192.168.1.79]) ([109.76.39.44]) by mail2.vodafone.ie with ESMTP; 17 Jan 2014 02:21:35 +0000 Message-ID: <52D893AD.9070602@draigBrady.com> Date: Fri, 17 Jan 2014 02:21:33 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52D81398.60203@redhat.com> <52D82083.3010309@redhat.com> <52D8728A.1010904@bernhard-voelker.de> In-Reply-To: <52D8728A.1010904@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: barry kesner , Eric Blake , 16468@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 02:22:15 -0000 On 01/17/2014 12:00 AM, Bernhard Voelker wrote: > On 01/16/2014 07:10 PM, Eric Blake wrote: >> On 01/16/2014 10:46 AM, barry kesner wrote: >>> How do you tell join this without resorting. The files are huge! >> >> Unfortunately, there isn't any really good way, short of re-processing >> the files to make the data appear sorted in the order join expects. >> That said, it certainly appears that for your given data, you can write >> a sed filter that can reprocess on a line-by-line basis, and feed that >> into join, without the penalty of having to re-sort the entire file and >> without having to have the processed file stored in your file system all >> at once. It also seems possible to write a post filter to get back to >> the style of the line in the original file. Here, extensions such as bash's >> join <(infilter file1) <(infilter file2) | outfilter >> make it easier to type (where the trick is to now write the correct sed >> scripts to serve as infilter and outfilter) than the alternative of >> having to use named fifos for limiting yourself to just POSIX semantics. > > Hum, isn't such number conversion filtering exactly what numfmt > wasn't designed for? But wait ... > > $ numfmt --field 1 --format='%020f' < f2 > 99980081 1 > 100002129 1 > 100002136 2 > 100002162 3 > > ... it doesn't support leading zeros, unfortunately. ;-/ > Wouldn't this be a nice enhancement? Yes it really should support standard formatting directives. leading zeros, precision in the format, etc. thanks, Pádraig. From MAILER-DAEMON Thu Jan 23 11:48:12 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6NRs-00086d-Gb for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:48:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NRp-00085v-Ao for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:48:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6NRi-0000nv-JL for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:48:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:47866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NRi-0000no-GJ for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6NRi-0003VG-5j for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16530: Bootstrapping fails with missing "m4/cu-progs.m4" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 23 Jan 2014 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16530 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16530@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139049565613421 (code B ref -1); Thu, 23 Jan 2014 16:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2014 16:47:36 +0000 Received: from localhost ([127.0.0.1]:33651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6NRH-0003UM-Fw for submit@debbugs.gnu.org; Thu, 23 Jan 2014 11:47:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56860) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6NRD-0003UB-TH for submit@debbugs.gnu.org; Thu, 23 Jan 2014 11:47:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6NRB-0000RF-Hr for submit@debbugs.gnu.org; Thu, 23 Jan 2014 11:47:31 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:44427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NRB-0000R3-Ed for submit@debbugs.gnu.org; Thu, 23 Jan 2014 11:47:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NR9-0007wz-NQ for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:47:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6NR8-0000Oc-6o for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:47:27 -0500 Received: from mail-pb0-x233.google.com ([2607:f8b0:400e:c01::233]:59288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NR7-0000KX-Py for bug-coreutils@gnu.org; Thu, 23 Jan 2014 11:47:26 -0500 Received: by mail-pb0-f51.google.com with SMTP id un15so2061836pbc.38 for ; Thu, 23 Jan 2014 08:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=KkW003mJCM/NQZPqZC7qVCiR/DGHTei9YP0/cGdwFE8=; b=ZTX41/hUJxugVasNVRxruCebYfQCtIlOFlwwL2tOyaKSrLZGTXtpCReOX5PdorSRH2 tAQsrhjayy2wo5Qf61qz40TvaFlfxtvjgWpkdKejv3KyjJ0fBjHB7wxTfljsKxOuPsaX swTEAiH02LMINrhKpZgSEeZ7Zv1JE5wi/kccDpZS1d0rKb+a+NQWC2IqGN5bEyEPjEab NJiLhi/yN+wb/8pl8o5cf5yaRN/TeNXaYM1LZQRtdqbnLyIP383fBM7wAxhk8u0Z8iLU QMJ0cKdyM8MtNPUaqFwOlCV8ALNeUcA7bx9aMlUgzU2l1q/nLUzz53goG1k76N9Q8VmY F+CQ== MIME-Version: 1.0 X-Received: by 10.66.160.195 with SMTP id xm3mr8967565pab.93.1390495643500; Thu, 23 Jan 2014 08:47:23 -0800 (PST) Received: by 10.68.84.40 with HTTP; Thu, 23 Jan 2014 08:47:23 -0800 (PST) Date: Thu, 23 Jan 2014 11:47:23 -0500 Message-ID: From: Assaf Gordon X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 16:48:11 -0000 Hello, Just tried to compile coreutils from scratch, and encountered the following problem: === $ git clone git://git.sv.gnu.org/coreutils $ cd coreutils $ ./bootstrap ./bootstrap: Bootstrapping from checked-out coreutils sources... ./bootstrap: consider installing git-merge-changelog from gnulib ./bootstrap: getting gnulib files... Submodule 'gnulib' (git://git.sv.gnu.org/gnulib.git) registered for path 'gnulib' Cloning into 'gnulib'... remote: Counting objects: 152449, done. remote: Compressing objects: 100% (23127/23127), done. remote: Total 152449 (delta 129329), reused 152347 (delta 129264) Receiving objects: 100% (152449/152449), 26.01 MiB | 10.80 MiB/s, done. Resolving deltas: 100% (129329/129329), done. Checking connectivity... done Submodule path 'gnulib': checked out 'cfe23e81eb50e13417b1e2818314c50eb33088bb' ./bootstrap: getting translations into po/.reference for coreutils... receiving incremental file list ./ af.po be.po bg.po ca.po cs.po da.po de.po el.po eo.po es.po et.po eu.po fi.po fr.po ga.po gl.po hr.po hu.po ia.po id.po it.po ja.po kk.po ko.po lg.po lt.po ms.po nb.po nl.po pl.po pt.po pt_BR.po ro.po ru.po sk.po sl.po sv.po tr.po uk.po vi.po zh_CN.po zh_TW.po sent 835 bytes received 4407641 bytes 801541.09 bytes/sec total size is 16351164 speedup is 3.71 ./bootstrap: updated po/af.po... ./bootstrap: updated po/be.po... ./bootstrap: updated po/bg.po... ./bootstrap: updated po/ca.po... ./bootstrap: updated po/cs.po... ./bootstrap: updated po/da.po... ./bootstrap: updated po/de.po... ./bootstrap: updated po/el.po... ./bootstrap: updated po/eo.po... ./bootstrap: updated po/es.po... ./bootstrap: updated po/et.po... ./bootstrap: updated po/eu.po... ./bootstrap: updated po/fi.po... ./bootstrap: updated po/fr.po... ./bootstrap: updated po/ga.po... ./bootstrap: updated po/gl.po... ./bootstrap: updated po/hr.po... ./bootstrap: updated po/hu.po... ./bootstrap: updated po/ia.po... ./bootstrap: updated po/id.po... ./bootstrap: updated po/it.po... ./bootstrap: updated po/ja.po... ./bootstrap: updated po/kk.po... ./bootstrap: updated po/ko.po... ./bootstrap: updated po/lg.po... ./bootstrap: updated po/lt.po... ./bootstrap: updated po/ms.po... ./bootstrap: updated po/nb.po... ./bootstrap: updated po/nl.po... ./bootstrap: updated po/pl.po... ./bootstrap: updated po/pt.po... ./bootstrap: updated po/pt_BR.po... ./bootstrap: updated po/ro.po... ./bootstrap: updated po/ru.po... ./bootstrap: updated po/sk.po... ./bootstrap: updated po/sl.po... ./bootstrap: updated po/sv.po... ./bootstrap: updated po/tr.po... ./bootstrap: updated po/uk.po... ./bootstrap: updated po/vi.po... ./bootstrap: updated po/zh_CN.po... ./bootstrap: updated po/zh_TW.po... ./bootstrap: autopoint --force sh: build-aux/git-version-gen: not found /usr/bin/m4: m4_esyscmd subprocess failed /usr/bin/m4:configure.ac:444: cannot open `m4/cu-progs.m4': No such file or directory autom4te: /usr/bin/m4 failed with exit status: 1 autopoint: *** Missing version: please specify in configure.ac through a line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is using autopoint: *** Stop. === I'm using: ==== $ autoconf --version | head -n1 autoconf (GNU Autoconf) 2.65 $ automake --version | head -n1 automake (GNU automake) 1.14 $ gettext --version | head -n1 gettext (GNU gettext-runtime) 0.18.3 $ gcc --version | head -n1 gcc (GCC) 4.8.2 $ m4 --version | head -n1 m4 (GNU M4) 1.4.13 $ git describe --always v8.22-16-gbe97f3e ==== This was done on an old Ubuntu server, so some package (gettext,automake,gcc) were compiled from source and are in non-standard location, if that matters. Thanks, -Gordon From MAILER-DAEMON Thu Jan 23 13:23:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Ovs-0001l4-HH for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:23:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Ovl-0001kf-0p for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:23:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Ove-0007ZK-Rn for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:23:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:47917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Ove-0007ZG-O6 for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6Ove-0007Ry-9P for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16530: Bootstrapping fails with missing "m4/cu-progs.m4" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 23 Jan 2014 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16530 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16530@debbugs.gnu.org Received: via spool by 16530-submit@debbugs.gnu.org id=B16530.139050134328579 (code B ref 16530); Thu, 23 Jan 2014 18:23:02 +0000 Received: (at 16530) by debbugs.gnu.org; 23 Jan 2014 18:22:23 +0000 Received: from localhost ([127.0.0.1]:33703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Ouw-0007Qp-Ss for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:22:23 -0500 Received: from mail-qc0-f173.google.com ([209.85.216.173]:37337) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Our-0007Qd-AG for 16530@debbugs.gnu.org; Thu, 23 Jan 2014 13:22:17 -0500 Received: by mail-qc0-f173.google.com with SMTP id i8so2991559qcq.32 for <16530@debbugs.gnu.org>; Thu, 23 Jan 2014 10:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=336aEX/mdBI+1fv+BavMoRQ0VjSBIiJnKksy7uZss/A=; b=szNcc6CrZD7BJs1x6e+NrrQV2yMJQmGEIwpJ/h9AU/aBekg8ghu3F/gqbIO7DCEsQi 7/vH78+aSRG0mBgSjjwfpPdRdJgz8eUoUFtGoLHTTIL3kXwuF9MdfKcrmkNIham7kVVA ffiJ4rk1RdzqIsYjv4zkCt1hl40LcYlWXDQ9lZywmcjXOqEpd3WxA5iT2LKm+yRcZ16p HOUd086YkCDcPMd2YVVx8VlBXDWqhE69ayX6laPbvYDLWvh9RGWRteJRltks6Rd47yv0 /n0qAKSyZkmYXzeWh+gHaA2E18eQaBqES0vOOQLpDxJOeBAxOyEvlG24+o4gS2ZmEfvr NZTQ== X-Received: by 10.224.56.5 with SMTP id w5mr13800097qag.60.1390501332618; Thu, 23 Jan 2014 10:22:12 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id r4sm6851691qen.13.2014.01.23.10.22.10 for <16530@debbugs.gnu.org> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 10:22:10 -0800 (PST) Message-ID: <52E15DF0.3070706@gmail.com> Date: Thu, 23 Jan 2014 13:22:40 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 18:23:15 -0000 Follow-up: On 01/23/2014 11:47 AM, Assaf Gordon wrote: > > Just tried to compile coreutils from scratch, and encountered the following > problem: > === > $ git clone git://git.sv.gnu.org/coreutils > $ cd coreutils > $ ./bootstrap <...snip...> > /usr/bin/m4: m4_esyscmd subprocess failed > /usr/bin/m4:configure.ac:444: cannot open `m4/cu-progs.m4': No such file or > directory > autom4te: /usr/bin/m4 failed with exit status: 1 > autopoint: *** Missing version: please specify in configure.ac through a > line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is > using > autopoint: *** Stop. > === > Upgrading to autoconf version 2.69 and M4 version 1.4.17 solved this issue (but note that "bootstrap" required autoconf>=2.59 and I had 2.65 installed). -Gordon From MAILER-DAEMON Thu Jan 23 13:42:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6PEI-0005Fp-68 for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:42:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PE9-0005DW-HC for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:42:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6PE2-00051n-SU for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:42:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:47926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PE2-00051j-OR for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6PE2-0007zA-FR for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 23 Jan 2014 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16532@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139050249830658 (code B ref -1); Thu, 23 Jan 2014 18:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2014 18:41:38 +0000 Received: from localhost ([127.0.0.1]:33712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6PDZ-0007yM-UT for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6PDT-0007y7-6E for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6PDM-0004oi-12 for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:26 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:41195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PDL-0004ob-TX for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PDF-00057x-7C for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6PD5-0004mp-7N for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:13 -0500 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:50104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PD5-0004ml-1r for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:03 -0500 Received: by mail-qc0-f171.google.com with SMTP id n7so2993993qcx.16 for ; Thu, 23 Jan 2014 10:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=oYx4EhcI24bmGSeQ5OvcXzI9A18lvB33E8qnXbfQq5M=; b=xJ4J+WnMYShptKF0sVmWT4L298890kDSSjtq/IYhwxxSVKxLaHBChZTnH4DRTIF0zu Wwurd4jLj2GJbPQ4bgyIJOefNSppJWhfROFYwfIlGTugfI+rCQ01clTJrPs7ALWpKDVf 58UaQ4y/mlgr2K9LKlX0ZbLqj8sfFYb0DaGyS8V+8EZvN5JSKKN2jZlw859H+ZCsnm7j PPtBQDuRRWIwYDPVux6O8Ea4T76nASTdLbjj6w+UhgiLDqrpQimJ9x9mU5XV7L8x39oU 9fe/30atgUJhgwFFG/x+Hs3W7IoIDQNFPw6fNJci3KuLvKJIMu2fkygJHrQ34p7DiWxG 2LDg== X-Received: by 10.224.36.195 with SMTP id u3mr13974770qad.59.1390502462639; Thu, 23 Jan 2014 10:41:02 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id k1sm21851810qat.16.2014.01.23.10.41.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 10:41:01 -0800 (PST) Message-ID: <52E1625A.7040002@gmail.com> Date: Thu, 23 Jan 2014 13:41:30 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 18:42:16 -0000 Hello, Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, results in a test failure "tests/chown/separator" (log + strace below). System is: ==== $ uname -a Linux club 2.6.32-24-server #43-Ubuntu SMP Thu Sep 16 16:05:42 UTC 2010 x86_64 GNU/Linux $ cat /etc/issue Ubuntu 10.04.4 LTS \n \l ## Failed on the following file-system $ stat -f /data/gordon/projects/coreutils/ File: "/data/gordon/projects/coreutils/" ID: 83000000000 Namelen: 255 Type: xfs Block size: 4096 Fundamental block size: 4096 Blocks: Total: 1952592384 Free: 86807222 Available: 86807222 Inodes: Total: 1429327392 Free: 1388915606 ==== strace (same command which failed in the log below): ===== $ pwd /data/gordon/projects/coreutils/ $ mkdir foo $ cd foo $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown -- mmap(NULL, 895, PROT_READ, MAP_SHARED, 3, 0) = 0x7fb7ce753000 lseek(3, 895, SEEK_SET) = 895 munmap(0x7fb7ce753000, 895) = 0 close(3) = 0 newfstatat(AT_FDCWD, ".", {st_mode=S_IFDIR|0755, st_size=6, ...}, AT_SYMLINK_NOFOLLOW) = 0 fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) open("/usr/local/share/locale/en_US.UTF-8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en_US.utf8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en_US/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en.UTF-8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en.utf8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) -- ===== FAIL: tests/chown/separator =========================== ++ initial_cwd_=/data/gordon/projects/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/gordon/projects/coreutils gt-separator.sh.XXXX +++ case $# in +++ destdir_=/data/gordon/projects/coreutils +++ template_=gt-separator.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/gordon/projects/coreutils/gt-separator.sh.fh9P +++ case $d in +++ test -d /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++++ ls -dgo /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++++ tr S - +++ perms='drwx------ 2 6 Jan 23 13:22 /data/gordon/projects/coreutils/gt-separator.sh.fh9P' +++ case $perms in +++ test 0 = 0 +++ echo /data/gordon/projects/coreutils/gt-separator.sh.fh9P +++ return ++ test_dir_=/data/gordon/projects/coreutils/gt-separator.sh.fh9P ++ cd /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/gordon/projects/coreutils/./src + case $abs_path_dir_ in + PATH=/data/gordon/projects/coreutils/./src:/data/gordon/projects/coreutils/src:/data/gordon/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games + create_exe_shims_ /data/gordon/projects/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ chown + test yes = yes + local i + for i in '$*' + env chown --version chown (GNU coreutils) 8.22.16-be97f Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie and Jim Meyering. ++ id -u + id_u=34574 + test -n 34574 ++ id -un + id_un=agordon + test -n agordon ++ id -g + id_g=1000 + test -n 1000 ++ id -gn + id_gn=users + test -n users + case $host_triplet in + chown '' . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:1000 . + for sep in '$seps' + case $u$sep$g in + chown 34574.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown 34574.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574: . + for sep in '$seps' + case $u$sep$g in + chown 34574. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:1000 . + for sep in '$seps' + case $u$sep$g in + chown agordon.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown agordon.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon: . + for sep in '$seps' + case $u$sep$g in + chown agordon. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :1000 . + for sep in '$seps' + case $u$sep$g in + chown .1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :users . chown: changing group of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown .users . chown: changing group of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown : . + for sep in '$seps' + case $u$sep$g in + chown . . + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/gordon/projects/coreutils + chmod -R u+rwx /data/gordon/projects/coreutils/gt-separator.sh.fh9P + rm -rf /data/gordon/projects/coreutils/gt-separator.sh.fh9P + exit 1 === From MAILER-DAEMON Thu Jan 23 18:21:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6TaJ-0008LV-Dk for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:21:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6TaA-0008Bx-AT for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:21:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Ta3-0004xh-0c for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:21:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Ta2-0004xb-Nh for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6Ta2-00071S-2c for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 23 Jan 2014 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon , 16532@debbugs.gnu.org Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139051925726982 (code B ref 16532); Thu, 23 Jan 2014 23:21:02 +0000 Received: (at 16532) by debbugs.gnu.org; 23 Jan 2014 23:20:57 +0000 Received: from localhost ([127.0.0.1]:33861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TZx-000718-1e for submit@debbugs.gnu.org; Thu, 23 Jan 2014 18:20:57 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:61941) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TZu-00070x-FA for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 18:20:55 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0MdAvu-1VpUen2xUY-00IFVZ; Fri, 24 Jan 2014 00:20:51 +0100 Message-ID: <52E1A3D3.2000704@bernhard-voelker.de> Date: Fri, 24 Jan 2014 00:20:51 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> In-Reply-To: <52E1625A.7040002@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:m0u0tKjnftO3yymCXBgq4hatSOZz2kouXJQluouMbuY q3+2H2bud04NkAArnl7voW5dvAdcp9VNfHgtcLWbLCyDbm36/m DnShf61u6xoL2P/Y20lsLlHhfdXpQR0IAs+hscjnXIYLhqv+Yh hHajQ+o4cCDaG05EEh9TtqiD04GnnEwO9X6VpmWE1u88AFwRRk /o5eKXs58Eb9cXoYT5CrSlL/HFdxh5J3AG5CD1MvW8sG3OxvR1 /tYqywDNwUg/HinDes04AKAdXSJb6y7RcYk/XS4hjyC2HR3yUu SqJlhNRIBAqt5CjqLOAzDEnfSAMzoujWOK7D6d2mmusk9GBk7k 0eBW+87nuzFcAvpJJlRp/Z19l7/nksSBTktS19JQL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 23:21:17 -0000 tag 16532 + moreinfo thanks On 01/23/2014 07:41 PM, Assaf Gordon wrote: > Hello, welcome back! > Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, > results in a test failure "tests/chown/separator" (log + strace below). > $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown > fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) > ++ id -g > + id_g=1000 > + chown 34574:users . > chown: changing ownership of '.': Operation not permitted > + fail=1 Ooops, something very strange is going on on your system: chown resolves the group 'users' to gid 100 while 'id -g' says 1000. Can you find out why? Are you using some strange Samba/Kerberos authentication against an Active Directory or similar? (I've seen such issues with that combination,) Have a nice day, Berny From MAILER-DAEMON Thu Jan 23 18:41:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Ttf-000649-HW for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:41:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6TtW-00063z-2y for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:41:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6TtO-0001z9-PZ for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:41:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6TtO-0001z5-Kf for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6TtO-0007ZW-EV for bug-coreutils@gnu.org; Thu, 23 Jan 2014 18:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Thu, 23 Jan 2014 23:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , 16532@debbugs.gnu.org Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139052046029096 (code B ref 16532); Thu, 23 Jan 2014 23:41:02 +0000 Received: (at 16532) by debbugs.gnu.org; 23 Jan 2014 23:41:00 +0000 Received: from localhost ([127.0.0.1]:33866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TtL-0007ZE-TB for submit@debbugs.gnu.org; Thu, 23 Jan 2014 18:41:00 -0500 Received: from mail-qc0-f170.google.com ([209.85.216.170]:34233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TtI-0007Z4-6z for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 18:40:56 -0500 Received: by mail-qc0-f170.google.com with SMTP id e9so3515970qcy.15 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 15:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=TJtfXzbb6UITsE6gkj0eMTuuJQcJGQA6pcCl0ULfPsc=; b=0V30K/M2yotF6SouroYu+ZuuQkHw5O7gmMBBdRZruUBiBy2taefIKOkpQW794oOel5 mfY09k/TmwUTozxHclqNIS/2aI8OunJJLSrBWVQOOZfa/DVr2U0zt8OOuZrTA2uWWB4u 2Nx3QkpYIrBqjE8NZdJLy7Tje6fwWVpJ7VasJuDjX/zviGyPIMChJ+N9WYADaNZZpjc3 qLYAdj6GHtdsBb68J6Mu8CAWNXV+QkRy8OT6KLtqaAynDJqQwALiopE8MXeqFu9xXqaT koR5oGFTXHE1nHPhGkKbmsJAHKB0KIWfnPrGZrvgieeQSWBwyAWllPiItHcJNXU4vuBw OGHg== X-Received: by 10.224.168.13 with SMTP id s13mr16163724qay.18.1390520455623; Thu, 23 Jan 2014 15:40:55 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id a10sm13464961qew.10.2014.01.23.15.40.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 15:40:54 -0800 (PST) Message-ID: <52E1A8A3.6020500@gmail.com> Date: Thu, 23 Jan 2014 18:41:23 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> In-Reply-To: <52E1A3D3.2000704@bernhard-voelker.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 23:41:17 -0000 On 01/23/2014 06:20 PM, Bernhard Voelker wrote: > On 01/23/2014 07:41 PM, Assaf Gordon wrote: >> $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown > >> fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) > >> ++ id -g >> + id_g=1000 > >> + chown 34574:users . >> chown: changing ownership of '.': Operation not permitted >> + fail=1 > > Ooops, something very strange is going on on your system: > chown resolves the group 'users' to gid 100 while 'id -g' > says 1000. > > Can you find out why? > Are you using some strange Samba/Kerberos authentication against > an Active Directory or similar? (I've seen such issues with that > combination,) > Thanks for the quick reply - this is a strange old server (not my doing...). Indeed it uses an external authentication, and has conflicting local and global groups named "users". == $ grep users /etc/group users:x:100: $ getent group | grep ^users users:x:100: users:x:1000: $ id -G 1000 1001 3432 == So I guess this is not a bug, and can be closed. I'll just ignore this failure on this system. Thanks, -gordon From MAILER-DAEMON Thu Jan 23 20:10:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6VHl-0004rZ-Uv for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:10:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6VHd-0004iR-9U for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:10:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6VHX-0000hu-9D for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:10:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6VHX-0000gt-5i for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:10:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6VHW-0002ce-Ly for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 01:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139052576610023 (code B ref 16532); Fri, 24 Jan 2014 01:10:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 01:09:26 +0000 Received: from localhost ([127.0.0.1]:33911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VGw-0002ba-0n for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:09:26 -0500 Received: from mail5.vodafone.ie ([213.233.128.176]:34627) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VGt-0002bR-Ca for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 20:09:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAPC74VJda5Cx/2dsb2JhbAANTb1IgwWBJoMZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAapaJ0zF45NMweEOAEDk3uLF45W Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 01:09:22 +0000 Message-ID: <52E1BD42.2050101@draigBrady.com> Date: Fri, 24 Jan 2014 01:09:22 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> In-Reply-To: <52E1A8A3.6020500@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 01:10:15 -0000 On 01/23/2014 11:41 PM, Assaf Gordon wrote: > On 01/23/2014 06:20 PM, Bernhard Voelker wrote: >> On 01/23/2014 07:41 PM, Assaf Gordon wrote: >>> $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown >> >>> fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) >> >>> ++ id -g >>> + id_g=1000 >> >>> + chown 34574:users . >>> chown: changing ownership of '.': Operation not permitted >>> + fail=1 >> >> Ooops, something very strange is going on on your system: >> chown resolves the group 'users' to gid 100 while 'id -g' >> says 1000. >> >> Can you find out why? >> Are you using some strange Samba/Kerberos authentication against >> an Active Directory or similar? (I've seen such issues with that >> combination,) >> > > Thanks for the quick reply - this is a strange old server (not my doing...). > Indeed it uses an external authentication, and has conflicting local and global groups named "users". > > == > $ grep users /etc/group > users:x:100: > $ getent group | grep ^users > users:x:100: > users:x:1000: > $ id -G > 1000 1001 3432 > == > > So I guess this is not a bug, and can be closed. > I'll just ignore this failure on this system. It is a false failure though so would be worth avoiding. It's important to have robust tests we and builders can rely on. Would something along the following be possible? test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" welcome back! Pdraig. From MAILER-DAEMON Thu Jan 23 20:39:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Vjq-0008Hw-3A for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:39:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Vjk-0008Hq-5r for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:39:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Vja-0000Gu-N1 for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:39:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Vja-0000Gq-Jj for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6Vja-0003Pu-Dl for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139052748413020 (code B ref 16532); Fri, 24 Jan 2014 01:39:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 01:38:04 +0000 Received: from localhost ([127.0.0.1]:33917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Vid-0003Nw-Te for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:38:04 -0500 Received: from mail-qa0-f46.google.com ([209.85.216.46]:49752) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Via-0003NU-E6 for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 20:38:01 -0500 Received: by mail-qa0-f46.google.com with SMTP id ii20so3130818qab.19 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 17:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=UzN7ZZKQ7S7NXBIXvc6Ntam+2MQ2bUPcEoAJJQxP30o=; b=TSiaVd4KqUzY46/LorOTCgT5MCGnBJ4vwYHdy/9y+5PiLAFtA9gl4ZcTxeqRf2ysXS VMu6/SK3LP2iVR8bL0bU7Oj4u9yPLVF/tAVkIgYGdymC7OQYT8p5mnF9I0nAVaT7nAil AsX+Kp6IXgNftjEA/Qc8PgUF3S8PwLEA0NXXsRMxxp+h9oAUzdDJyJW/uXLmd5Gedyr7 OmFXkZE6njxjWVktZvX/Kn0KPmq8Ti8E8b6UsZcjE+6mHiFwASYAk4SVQpA4cUW5FbXI ylzd/GwNRinaE44EG9XYzCoNq/uJOI+b9obeEpgeS9UBJRgo3Leb6Xr4UrXsgs3VgpG4 z9cg== X-Received: by 10.224.26.71 with SMTP id d7mr16188443qac.99.1390527479726; Thu, 23 Jan 2014 17:37:59 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id k1sm24078688qat.16.2014.01.23.17.37.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 17:37:58 -0800 (PST) Message-ID: <52E1C414.4000300@gmail.com> Date: Thu, 23 Jan 2014 20:38:28 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> In-Reply-To: <52E1BD42.2050101@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 01:39:17 -0000 This patch makes the test skip on my server (did not test it on other systems). On 01/23/2014 08:09 PM, Pdraig Brady wrote: > On 01/23/2014 11:41 PM, Assaf Gordon wrote: >> So I guess this is not a bug, and can be closed. >> I'll just ignore this failure on this system. > > It is a false failure though so would be worth avoiding. > It's important to have robust tests we and builders can rely on. > > Would something along the following be possible? > > test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" > From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with duplicated groups * tests/chwon/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..ec33f4a 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +test $(getent group $id_gn | wc -l) != 1 || + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.8.4.3 From MAILER-DAEMON Thu Jan 23 20:45:14 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Vpa-00061w-08 for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:45:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6VpU-0005y0-5Q for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6VpP-0002Bo-UQ for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:45:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6VpP-0002BC-RU for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6VpP-0003aa-9J for bug-coreutils@gnu.org; Thu, 23 Jan 2014 20:45:03 -0500 Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 01:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Mail-Followup-To: 16532@debbugs.gnu.org, P@draigBrady.com, assafgordon@gmail.com Received: via spool by 16532-done@debbugs.gnu.org id=D16532.139052784213679 (code D ref 16532); Fri, 24 Jan 2014 01:45:02 +0000 Received: (at 16532-done) by debbugs.gnu.org; 24 Jan 2014 01:44:02 +0000 Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VoP-0003YL-8N for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:44:01 -0500 Received: from mail3.vodafone.ie ([213.233.128.45]:58765) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VoM-0003YC-Mb for 16532-done@debbugs.gnu.org; Thu, 23 Jan 2014 20:43:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmQFAEbE4VJda5Cx/2dsb2JhbAANTYNEUKIsAQGaC4EkgxkBAQEDATIBRgULCw0EAwECAQkWDwkDAgECAT0IBg0BBQIBAYd5DQOpc5NviUUXjwAHhDgBA5N7hVqFPYVxiGU Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 01:43:57 +0000 Message-ID: <52E1C55D.2000205@draigBrady.com> Date: Fri, 24 Jan 2014 01:43:57 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> In-Reply-To: <52E1C414.4000300@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532-done@debbugs.gnu.org, Bernhard Voelker X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 01:45:12 -0000 On 01/24/2014 01:38 AM, Assaf Gordon wrote: > This patch makes the test skip on my server (did not test it on other systems). > > On 01/23/2014 08:09 PM, Pdraig Brady wrote: >> On 01/23/2014 11:41 PM, Assaf Gordon wrote: > >>> So I guess this is not a bug, and can be closed. >>> I'll just ignore this failure on this system. >> >> It is a false failure though so would be worth avoiding. >> It's important to have robust tests we and builders can rely on. >> >> Would something along the following be possible? >> >> test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" >> > > > From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?P=C3=A1draig=20Brady?= > Date: Thu, 23 Jan 2014 20:34:52 -0500 > Subject: [PATCH] tests: skip chown/separator with duplicated groups > > * tests/chwon/separator.sh: skip test if the user's group has s/chwon/chown/ > multiple entries. > Fixes http://bugs.gnu.org/16532 > --- > tests/chown/separator.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh > index f64b738..ec33f4a 100755 > --- a/tests/chown/separator.sh > +++ b/tests/chown/separator.sh > @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ > id_gn=$(id -gn) || framework_failure_ > test -n "$id_gn" || framework_failure_ > > +test $(getent group $id_gn | wc -l) != 1 || > + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" > + > # FreeBSD 6.x's getgrnam fails to look up a group name containing > # a space. On such a system, skip this test if the group name contains > # a byte not in the portable filename character set. Cool I'll push that in your name since you did the hard work of tracking it down, generating the patch and testing. Marking this as done. cheers, Pdraig. From MAILER-DAEMON Thu Jan 23 21:06:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6W9t-0001wJ-Bo for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:06:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6W9m-0001vX-KO for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:06:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6W9i-0008Vd-68 for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:06:06 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6W9i-0008VX-2u for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6W9h-0004A7-Pe for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16530: Bootstrapping fails with missing "m4/cu-progs.m4" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16530 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Received: via spool by 16530-submit@debbugs.gnu.org id=B16530.139052914315964 (code B ref 16530); Fri, 24 Jan 2014 02:06:01 +0000 Received: (at 16530) by debbugs.gnu.org; 24 Jan 2014 02:05:43 +0000 Received: from localhost ([127.0.0.1]:33932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6W9O-00049P-GE for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:05:42 -0500 Received: from mail3.vodafone.ie ([213.233.128.45]:22633) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6W9M-00049B-8M for 16530@debbugs.gnu.org; Thu, 23 Jan 2014 21:05:41 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBACDK4VJda5Cx/2dsb2JhbAANTYNEvQuBIoMZAQEBBDIBRhALDQsJFAIPCQMCAQIBRQYNAQcBAYgGCKl0nTAXjj4PMweEOASZVYU9jlaBag Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 02:05:39 +0000 Message-ID: <52E1CA73.3010008@draigBrady.com> Date: Fri, 24 Jan 2014 02:05:39 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E15DF0.3070706@gmail.com> In-Reply-To: <52E15DF0.3070706@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16530@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 02:06:12 -0000 tag 16530 notabug close 16530 stop On 01/23/2014 06:22 PM, Assaf Gordon wrote: > Follow-up: > > On 01/23/2014 11:47 AM, Assaf Gordon wrote: >> >> Just tried to compile coreutils from scratch, and encountered the following >> problem: >> === >> $ git clone git://git.sv.gnu.org/coreutils >> $ cd coreutils >> $ ./bootstrap > <...snip...> >> /usr/bin/m4: m4_esyscmd subprocess failed >> /usr/bin/m4:configure.ac:444: cannot open `m4/cu-progs.m4': No such file or >> directory >> autom4te: /usr/bin/m4 failed with exit status: 1 >> autopoint: *** Missing version: please specify in configure.ac through a >> line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is >> using >> autopoint: *** Stop. >> === >> > > Upgrading to autoconf version 2.69 and M4 version 1.4.17 solved this issue (but note that "bootstrap" required autoconf>=2.59 and I had 2.65 installed). coreutils bootstrap.conf actually has >= 2.64 specified. Anyway using this documented method for getting specific versions: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=README-prereq;hb=HEAD I tried to reproduce with autoconf-2.65 and I couldn't. Then I tried with m4-1.4.13 and still couldn't. So my next guess is that it's an incompat between your newer automake-1.14 and your autoconf-2.65. Indeed when I went to build automake-1.14 it bailed saying it needed autoconf 2.69 or higher. So where did you get this automake-1.14? I suspect it is bumping the autoconf version requirement up. I'm closing this for now. thanks, Pdraig. From MAILER-DAEMON Thu Jan 23 21:33:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Wa0-0008DS-VO for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:33:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6WZv-0008CQ-Ld for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:33:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6WZr-0006yV-DT for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:33:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6WZr-0006yR-A7 for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:33:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6WZq-0004ts-HL for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 02:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16532@debbugs.gnu.org, assafgordon@gmail.com Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139053077418819 (code B ref 16532); Fri, 24 Jan 2014 02:33:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:32:54 +0000 Received: from localhost ([127.0.0.1]:33937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6WZh-0004tS-VN for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:32:54 -0500 Received: from mail4.vodafone.ie ([213.233.128.170]:48753) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6WZf-0004tI-Gu for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:32:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqUBAPXP4VJda5Cx/2dsb2JhbAANTYNEULw7gSKDGQEBAQSBCQsNBAMBAgEJDQEGAg8JAwIBAgEPLggHDAYCAQGHbQMWA6lvl1ANhVYXjGyCAxgSAYQlBJA8gz+COwGDHoU9hW4DiGWBagc Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 02:32:50 +0000 Message-ID: <52E1D0D2.4010303@draigBrady.com> Date: Fri, 24 Jan 2014 02:32:50 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> In-Reply-To: <52E1C55D.2000205@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------000605050003090404080608" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 02:33:11 -0000 This is a multi-part message in MIME format. --------------000605050003090404080608 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 01/24/2014 01:43 AM, Pdraig Brady wrote: > On 01/24/2014 01:38 AM, Assaf Gordon wrote: >> This patch makes the test skip on my server (did not test it on other systems). >> >> On 01/23/2014 08:09 PM, Pdraig Brady wrote: >>> On 01/23/2014 11:41 PM, Assaf Gordon wrote: >> >>>> So I guess this is not a bug, and can be closed. >>>> I'll just ignore this failure on this system. >>> >>> It is a false failure though so would be worth avoiding. >>> It's important to have robust tests we and builders can rely on. >>> >>> Would something along the following be possible? >>> >>> test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" >>> >> >> >> From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?P=C3=A1draig=20Brady?= >> Date: Thu, 23 Jan 2014 20:34:52 -0500 >> Subject: [PATCH] tests: skip chown/separator with duplicated groups >> >> * tests/chwon/separator.sh: skip test if the user's group has > > s/chwon/chown/ > >> multiple entries. >> Fixes http://bugs.gnu.org/16532 >> --- >> tests/chown/separator.sh | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh >> index f64b738..ec33f4a 100755 >> --- a/tests/chown/separator.sh >> +++ b/tests/chown/separator.sh >> @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ >> id_gn=$(id -gn) || framework_failure_ >> test -n "$id_gn" || framework_failure_ >> >> +test $(getent group $id_gn | wc -l) != 1 || Actually I messed up the login in the suggestion. I think the above should be s/!=/=/ which I've done in the attached patch. If you could confirm it was skipped on your system it would be great. I'll push soon anyway. >> + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" I also protected the $id_gn with quotes in case there were spaces in the group name or something. thanks, Pdraig. --------------000605050003090404080608 Content-Type: text/x-patch; name="tests-dupe-groups.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="tests-dupe-groups.patch" >From 9ad5f9f8d8e15c9f47173427714bfd6bcff2730e Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with conflicting group IDs * tests/chown/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..ed3635d 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,11 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +# Systems with both local and external groups with conflicting IDs, +# were seen to fail this test erroneously with EPERM errors. +test $(getent group "$id_gn" | wc -l) = 1 || + skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.7.7.6 --------------000605050003090404080608-- From MAILER-DAEMON Thu Jan 23 21:47:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6Wnf-00025U-5V for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:47:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6WnW-00025A-Et for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:47:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6WnO-0002Bv-Rd for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:47:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6WnO-0002Br-Mu for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6WnO-0005Hv-5H for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 02:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , 16532@debbugs.gnu.org Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139053159520285 (code B ref 16532); Fri, 24 Jan 2014 02:47:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:46:35 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wmw-0005H6-Cy for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:46:35 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:43381) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wmt-0005Gt-TI for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:46:32 -0500 Received: by mail-qc0-f181.google.com with SMTP id e9so3683519qcy.12 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 18:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=brlvVse/BT7Vxb5BGxhOu7kXOSQyjE76WM2LLC/vwrQ=; b=b7/Z4Ixl/QqbMLwhsL8qLMl/kzRqZFDPOXM2ei+S3mdQyqGp8lpo1Klvs8GojE8/nm 7uBE3peZxMEQdkkTjJfc7fyrBrKYShHn63p3T5PuDKyBrWmw/M95WjKisQr6Vr7JIG7x zeNR+ETSw4YfmTt8D7MjsuWcoiHF8K3Sw6UWVSLv1FlpOKcpWetN2pK6P4ARCEIbSKIw UuKGNrWIyVB8fbNv0Bi/c9gJwxpcn+QtpD0xPiQeuA+kDhmiWJPJna8/ptyQBCKKyUWd Rm2sUJ7xhfoUJg5yBdzcuq6GvQM00DcGT3xGvRyf6TVANvaOKcxwHdjIhfQCDsUTKION g5vg== X-Received: by 10.224.111.195 with SMTP id t3mr17074492qap.2.1390531591008; Thu, 23 Jan 2014 18:46:31 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id s2sm12371367qat.1.2014.01.23.18.46.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 18:46:30 -0800 (PST) Message-ID: <52E1D423.1060605@gmail.com> Date: Thu, 23 Jan 2014 21:46:59 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> In-Reply-To: <52E1D0D2.4010303@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 02:47:17 -0000 On 01/23/2014 09:32 PM, Pdraig Brady wrote: > > Actually I messed up the login in the suggestion. > I think the above should be s/!=/=/ which I've done > in the attached patch. > > If you could confirm it was skipped on your system > it would be great. > > I'll push soon anyway. > Please don't push yet - it doesn't work, but for un-expected reason: my previous patch was incorrect (The "=" vs "!=" as you pointed), but also "getent groups" was incorrect - so two wrongs did make a right :) The test fails, here's why: On my strange system: === $ getent group users users:x:100: === vs. === $ getent group | grep ^users users:x:100: users:x:1000:www-data,XXX,YYY === And so, the skip test didn't actual work to begin with. Should we change it to "getent" + "grep" ? -gordon From MAILER-DAEMON Thu Jan 23 21:58:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6WyH-0003nb-NO for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:58:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Wy8-0003ba-LA for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Wy2-0005Iy-Pa for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:58:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Wy2-0005Iu-LC for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6Wy1-0005Zi-PL for bug-coreutils@gnu.org; Thu, 23 Jan 2014 21:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 02:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , 16532@debbugs.gnu.org Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139053227321417 (code B ref 16532); Fri, 24 Jan 2014 02:58:01 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:57:53 +0000 Received: from localhost ([127.0.0.1]:33951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wxs-0005ZK-8a for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:57:53 -0500 Received: from mail-qa0-f50.google.com ([209.85.216.50]:42113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wxp-0005Z8-HC for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:57:50 -0500 Received: by mail-qa0-f50.google.com with SMTP id cm18so3217723qab.37 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 18:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=wBoajwDF9soksuYYkaabT/hrflMko+4PaYUkxa9q3Eg=; b=iSaQPCH8G6wkFNWnCiqgbiRALnE21d2i/EiAjQHOIrN2+6IYFbypv8fiNjBM9HiDme 9L8eHfGR1UoBXD8G9lOCEGY7q+E/VdFs+v8isjImg6vrJU4YfL/0Y4Zv+O23FKwLIidq efpT9e/B4H8nnyJdomVZjLivnYoEusLQhm0d3BqKyn9OMQsdDXJfoIfN0t7QQXj1Q10M hfc1SV0E2dkZ0LKDOwhFqki5dX5lr6HQBZGfOML+VwjlQfWuhhm6lYtfxXIuvHk1kRuf s1aHmB+E4Fzlxg9sRIxBf42S6EcKSeAgBMLJjOKb3rIBjnWqBkTB2+HTqVnDwpU4EY0o QehA== X-Received: by 10.229.10.197 with SMTP id q5mr16883932qcq.15.1390532268814; Thu, 23 Jan 2014 18:57:48 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id g68sm8375337qge.7.2014.01.23.18.57.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 18:57:47 -0800 (PST) Message-ID: <52E1D6C9.4000204@gmail.com> Date: Thu, 23 Jan 2014 21:58:17 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> In-Reply-To: <52E1D423.1060605@gmail.com> Content-Type: multipart/mixed; boundary="------------040901040607020202020807" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 02:58:14 -0000 This is a multi-part message in MIME format. --------------040901040607020202020807 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit On 01/23/2014 09:46 PM, Assaf Gordon wrote: > On 01/23/2014 09:32 PM, Pdraig Brady wrote: >> >> If you could confirm it was skipped on your system >> it would be great. >> > > Please don't push yet - it doesn't work, but for un-expected reason: > On my strange system For completeness, attached is the test fail log. Also, similar examples with other groups: === $ getent group | cut -f1 -d: | sort | uniq -d adm bin daemon lp mail root sys tty users uucp $ getent group | grep ^mail: mail:x:8: mail:x:6:root $ getent group mail mail:x:8: $ getent group | grep ^adm: adm:x:4: adm:x:4:root,adm,daemon $ getent group adm adm:x:4: === So yes, this is not an ideally-configured system. -gordon --------------040901040607020202020807 Content-Type: text/x-log; name="chown-group-test-suite.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chown-group-test-suite.log" =============================================================== GNU coreutils 8.22.17-ba34a-dirty: ./tests/test-suite.log =============================================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: ./tests/chown/separator ============================= ++ initial_cwd_=/data/gordon/projects/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/gordon/projects/coreutils gt-separator.sh.XXXX +++ case $# in +++ destdir_=/data/gordon/projects/coreutils +++ template_=gt-separator.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/gordon/projects/coreutils/gt-separator.sh.t8dv +++ case $d in +++ test -d /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++++ ls -dgo /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++++ tr S - +++ perms='drwx------ 2 6 Jan 23 21:41 /data/gordon/projects/coreutils/gt-separator.sh.t8dv' +++ case $perms in +++ test 0 = 0 +++ echo /data/gordon/projects/coreutils/gt-separator.sh.t8dv +++ return ++ test_dir_=/data/gordon/projects/coreutils/gt-separator.sh.t8dv ++ cd /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/gordon/projects/coreutils/./src + case $abs_path_dir_ in + PATH=/data/gordon/projects/coreutils/./src:/data/gordon/projects/coreutils/src:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games + create_exe_shims_ /data/gordon/projects/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ chown + test yes = yes + local i + for i in '$*' + env chown --version chown (GNU coreutils) 8.22.17-ba34a-dirty Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie and Jim Meyering. ++ id -u + id_u=34574 + test -n 34574 ++ id -un + id_un=agordon + test -n agordon ++ id -g + id_g=1000 + test -n 1000 ++ id -gn + id_gn=users + test -n users ++ getent group users ++ wc -l + test 1 = 1 + case $host_triplet in + chown '' . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:1000 . + for sep in '$seps' + case $u$sep$g in + chown 34574.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown 34574.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574: . + for sep in '$seps' + case $u$sep$g in + chown 34574. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:1000 . + for sep in '$seps' + case $u$sep$g in + chown agordon.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown agordon.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon: . + for sep in '$seps' + case $u$sep$g in + chown agordon. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :1000 . + for sep in '$seps' + case $u$sep$g in + chown .1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :users . chown: changing group of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown .users . chown: changing group of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown : . + for sep in '$seps' + case $u$sep$g in + chown . . + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/gordon/projects/coreutils + chmod -R u+rwx /data/gordon/projects/coreutils/gt-separator.sh.t8dv + rm -rf /data/gordon/projects/coreutils/gt-separator.sh.t8dv + exit 1 --------------040901040607020202020807-- From MAILER-DAEMON Thu Jan 23 22:10:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6X9r-0005kZ-N2 for mharc-bug-coreutils@gnu.org; Thu, 23 Jan 2014 22:10:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6X9k-0005ih-AJ for bug-coreutils@gnu.org; Thu, 23 Jan 2014 22:10:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6X9e-0008V4-AX for bug-coreutils@gnu.org; Thu, 23 Jan 2014 22:10:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6X9e-0008UK-6o for bug-coreutils@gnu.org; Thu, 23 Jan 2014 22:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6X9d-0005tz-MX for bug-coreutils@gnu.org; Thu, 23 Jan 2014 22:10:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 03:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139053294622614 (code B ref 16532); Fri, 24 Jan 2014 03:10:01 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 03:09:06 +0000 Received: from localhost ([127.0.0.1]:33956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6X8j-0005sf-Lu for submit@debbugs.gnu.org; Thu, 23 Jan 2014 22:09:06 -0500 Received: from mail5.vodafone.ie ([213.233.128.176]:3676) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6X8h-0005sV-Rt for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 22:09:04 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAFXY4VJda5Cx/2dsb2JhbAANTb1LgwWBIoMZAQEBBDIBRhALDQsJDQEGEQ8CRgYNAQcBAYgGqXedOBeOTTMHEgGEJQEDnxKOVoFqBw Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 03:09:03 +0000 Message-ID: <52E1D94E.704@draigBrady.com> Date: Fri, 24 Jan 2014 03:09:02 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> In-Reply-To: <52E1D423.1060605@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 03:10:14 -0000 On 01/24/2014 02:46 AM, Assaf Gordon wrote: > On 01/23/2014 09:32 PM, Pdraig Brady wrote: >> >> Actually I messed up the login in the suggestion. >> I think the above should be s/!=/=/ which I've done >> in the attached patch. >> >> If you could confirm it was skipped on your system >> it would be great. >> >> I'll push soon anyway. >> > > Please don't push yet - it doesn't work, but for un-expected reason: > > my previous patch was incorrect (The "=" vs "!=" as you pointed), but also "getent groups" was incorrect - so two wrongs did make a right :) > > The test fails, here's why: > > On my strange system: > > === > $ getent group users > users:x:100: > === > vs. > === > $ getent group | grep ^users > users:x:100: > users:x:1000:www-data,XXX,YYY > === Oh right, grep ^$id_gn: it is so. Note we can't rely on getent(1) being available (as noted in bug 9987), but the failure in that edge case is still a skip as the count will be 0 then. thanks, Pdraig. From MAILER-DAEMON Fri Jan 24 02:44:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6bR5-0006FR-EZ for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 02:44:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6bQw-0006EQ-OL for bug-coreutils@gnu.org; Fri, 24 Jan 2014 02:44:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6bQp-0001Uw-Dq for bug-coreutils@gnu.org; Fri, 24 Jan 2014 02:44:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6bQp-0001Uq-AI for bug-coreutils@gnu.org; Fri, 24 Jan 2014 02:44:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6bQo-0004v6-CY for bug-coreutils@gnu.org; Fri, 24 Jan 2014 02:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Assaf Gordon Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139054940218853 (code B ref 16532); Fri, 24 Jan 2014 07:44:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 07:43:22 +0000 Received: from localhost ([127.0.0.1]:34069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6bQ9-0004u0-F2 for submit@debbugs.gnu.org; Fri, 24 Jan 2014 02:43:21 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:51446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6bQ1-0004th-Vh for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 02:43:15 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0M3OD6-1VG0nY1THs-00rN0Y; Fri, 24 Jan 2014 08:43:12 +0100 Message-ID: <52E2198F.8060600@bernhard-voelker.de> Date: Fri, 24 Jan 2014 08:43:11 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> In-Reply-To: <52E1D94E.704@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:MawoqnBD64tbN3mdxhkK2gSGsXS/VcsMHzA4HwyfZY8 94KFwvheZceLNzI3+1GN9K3jUiHM31NYinj85UqpJy5sHB0/QX QMOaNiL0DR4OW/jN1HS9uDuRn8YDn17ofHXRduBCzmVHIlbcPC lKsYK6gRqOu6C8zqr2Msvoi3/AwFdGKaVpjU5f6gU4/CPnI/S0 VNxGg5dktNoDk6yUnzVDbG853E6Zcin9XNp2GCs+qpIGrzDL9W mdqnpU75HxRnpLHjeP+70maVqW3vsMkHPZvuouw39b8J6Z+9G6 3XIwBRuTy16twnlvJYrT5/2ugZYxXd6YpCiT/BccQTg8bwzo85 F8qxbWQ9rcmnYdSBW+du+8Iyec0Lt1qsZy1+hj1JC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 07:44:18 -0000 On 01/24/2014 04:09 AM, Pdraig Brady wrote: > On 01/24/2014 02:46 AM, Assaf Gordon wrote: >> $ getent group | grep ^users >> users:x:100: >> users:x:1000:www-data,XXX,YYY >> === > > Oh right, grep ^$id_gn: it is so. > > Note we can't rely on getent(1) being available (as noted in bug 9987), > but the failure in that edge case is still a skip as the count will be 0 then. I'm still not convinced that we should mask this misconfiguration by skipping the test. AFAIK it's totally valid to have several names for a gid, but is it permitted the other way round? I'd bet you run into other trouble on such a system, too. Therefore, I see the failing test more as a heads-up to fix the configuration. Thanks & have a nice day, Berny From MAILER-DAEMON Fri Jan 24 07:20:20 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6fkC-0007Tx-Av for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:20:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6fk2-0007R7-PC for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:20:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6fjv-00005y-3L for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:20:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6fju-00005Z-W6 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6fju-0003ir-54 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139056598914285 (code B ref 16532); Fri, 24 Jan 2014 12:20:02 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 12:19:49 +0000 Received: from localhost ([127.0.0.1]:34202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6fjh-0003iL-Hv for submit@debbugs.gnu.org; Fri, 24 Jan 2014 07:19:49 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:35505) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6fje-0003iC-Qd for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 07:19:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBALdZ4lJtTPUT/2dsb2JhbAANTb1LgwWBIIMZAQEBBDIBRhALDQEKCRYPCQMCAQIBRQYNAQcBAYgGqiSdYxeOTTMHhDgBA58Vjlw Received: from unknown (HELO [192.168.1.79]) ([109.76.245.19]) by mail1.vodafone.ie with ESMTP; 24 Jan 2014 12:19:45 +0000 Message-ID: <52E25A5E.5090609@draigBrady.com> Date: Fri, 24 Jan 2014 12:19:42 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> In-Reply-To: <52E2198F.8060600@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org, Assaf Gordon X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 12:20:18 -0000 On 01/24/2014 07:43 AM, Bernhard Voelker wrote: > On 01/24/2014 04:09 AM, Pdraig Brady wrote: >> On 01/24/2014 02:46 AM, Assaf Gordon wrote: >>> $ getent group | grep ^users >>> users:x:100: >>> users:x:1000:www-data,XXX,YYY >>> === >> >> Oh right, grep ^$id_gn: it is so. >> >> Note we can't rely on getent(1) being available (as noted in bug 9987), >> but the failure in that edge case is still a skip as the count will be 0 then. > > I'm still not convinced that we should mask this misconfiguration > by skipping the test. > > AFAIK it's totally valid to have several names for a gid, > but is it permitted the other way round? > > I'd bet you run into other trouble on such a system, too. > Therefore, I see the failing test more as a heads-up to > fix the configuration. > > Thanks & have a nice day, > Berny > Since it's an easy enough workaround it's worth adding IMHO. As a general point there should never be any questions about test failures. I've seen some test suites become less than useful through attrition of little issues. For me the tests take more time than the code and are more awkward to write, but that's all fine and good as that's were the real value is. thanks, Pdraig. From MAILER-DAEMON Fri Jan 24 07:47:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6gAH-0005gp-Ka for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:47:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6gA9-0005fm-Jk for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6gA2-0008RI-9X for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:47:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6gA2-0008R2-6D for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6gA1-0005Ys-Q9 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 07:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139056758421323 (code B ref 16532); Fri, 24 Jan 2014 12:47:01 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 12:46:24 +0000 Received: from localhost ([127.0.0.1]:34206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6g9P-0005Xq-Nk for submit@debbugs.gnu.org; Fri, 24 Jan 2014 07:46:24 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:51456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6g9M-0005Xf-PZ for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 07:46:22 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0Lgc4H-1VUa7A2S9d-00oEtP; Fri, 24 Jan 2014 13:46:17 +0100 Message-ID: <52E26097.6010205@bernhard-voelker.de> Date: Fri, 24 Jan 2014 13:46:15 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> In-Reply-To: <52E25A5E.5090609@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:LoCSDIyTJYIhxvOcL5YfqE/scmG0tZQUSkeIEtHmW88 OwzWqeAaGv1VUPJsYGaLl5WBncNx4IQYI3p531E0Mr04RU+xKw OttlHHqR1wM2qAdRhYWb31N15jbbg1m5OqH4nBE+oVZBXuaG84 t6gw+1vwoJZRZUU16nA3iCoFkQojYt72rcrAOygNM+qyhz1Fvf RAypqW5EyoNiCYymAyUNkvQRHrXtmjoE8n9M2vI1sxA3axq2zp uSma/hgL8xzA/mIOPA3b0C8yWVQRuNcQSg1KhwjMdC7PMvyKke WinHHN15v+mI5GKz81A47M2SFVnnMFTDHwHBp6CU44XmLfzSlU ztln5K5KastnJ4dyoUSi9eQTYhNkhiI00Qyyqqq/f X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org, Assaf Gordon X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 12:47:17 -0000 On 01/24/2014 01:19 PM, Pdraig Brady wrote: > On 01/24/2014 07:43 AM, Bernhard Voelker wrote: >> On 01/24/2014 04:09 AM, Pdraig Brady wrote: >>> Oh right, grep ^$id_gn: it is so. >>> >>> Note we can't rely on getent(1) being available (as noted in bug 9987), >>> but the failure in that edge case is still a skip as the count will be 0 then. >> >> I'm still not convinced that we should mask this misconfiguration >> by skipping the test. >> >> AFAIK it's totally valid to have several names for a gid, >> but is it permitted the other way round? >> >> I'd bet you run into other trouble on such a system, too. >> Therefore, I see the failing test more as a heads-up to >> fix the configuration. >> >> Thanks & have a nice day, >> Berny >> > > Since it's an easy enough workaround it's worth adding IMHO. > As a general point there should never be any questions > about test failures. I've seen some test suites become > less than useful through attrition of little issues. > For me the tests take more time than the code and are more > awkward to write, but that's all fine and good as that's > were the real value is. Okay, let's go with it then. Thanks. BTW: I'd change the skip_ message to reflect the above mentioned corner case where getent is not available, something like: - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" Have a nice day, Berny From MAILER-DAEMON Fri Jan 24 11:59:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6k67-0000Ko-2U for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 11:59:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6k5z-0000I7-OS for bug-coreutils@gnu.org; Fri, 24 Jan 2014 11:59:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6k5u-00081L-7j for bug-coreutils@gnu.org; Fri, 24 Jan 2014 11:59:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6k5u-00081C-3c for bug-coreutils@gnu.org; Fri, 24 Jan 2014 11:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6k5t-0003mY-Sj for bug-coreutils@gnu.org; Fri, 24 Jan 2014 11:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: Assaf Gordon Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139058270214477 (code B ref 16532); Fri, 24 Jan 2014 16:59:01 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 16:58:22 +0000 Received: from localhost ([127.0.0.1]:34763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6k5F-0003lQ-12 for submit@debbugs.gnu.org; Fri, 24 Jan 2014 11:58:21 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:35388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6k5C-0003lI-Hy for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 11:58:19 -0500 Received: by mail-qc0-f179.google.com with SMTP id e16so4807811qcx.10 for <16532@debbugs.gnu.org>; Fri, 24 Jan 2014 08:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=SRL49HMpWgWsZgQOj/wA01q5x7Y5ahtuUhPKVx3A2hc=; b=Rz93nYgy0uqLbUbXgUF+IUB2I0byssrbqKgIxtskwgve5GDAR3A9916lYLoBlC/aZH LouMj3vP/Cyqubd4uTrMxYN6iS4jdZ8RvorDJeugwpcWDpbxg9l7LogxQp+Qq0p01uRK 04waftqI1FDen9npPNnUYys9LLzDATfl2v+cEa8zk2aH/SexCQUAOiChlzTeFFbWzuEt hcoB/ut0ghIJFimGoW454+XXfqcJ7Dg7M4Ese16wpziJJBhwb+R4m2Wb2knxhGUajXjL eSVyQGYtZhNHZqP2ua1KRWZcFutOAuSmYjEnD269/3ct1ugqKQjyQR3+faiZjZl9j4AC /c/g== X-Received: by 10.224.32.133 with SMTP id c5mr22011349qad.54.1390582697727; Fri, 24 Jan 2014 08:58:17 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id v92sm1044762qge.6.2014.01.24.08.58.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Jan 2014 08:58:15 -0800 (PST) Message-ID: <52E29BC6.20606@gmail.com> Date: Fri, 24 Jan 2014 11:58:46 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> <52E26097.6010205@bernhard-voelker.de> In-Reply-To: <52E26097.6010205@bernhard-voelker.de> Content-Type: multipart/mixed; boundary="------------000706050103080500000305" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 16:59:13 -0000 This is a multi-part message in MIME format. --------------000706050103080500000305 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit On 01/24/2014 07:46 AM, Bernhard Voelker wrote: >>> On 01/24/2014 04:09 AM, Pdraig Brady wrote: >>>> Oh right, grep ^$id_gn: it is so. > > BTW: I'd change the skip_ message to reflect the above mentioned > corner case where getent is not available, something like: > > - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" > + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" > Attached is an updated version, using grep and the suggested error message. On addition is a "tr '\n' ','" - because "skip" only shows the first line of the message, and so multiple groups and not displayed. -gordon --------------000706050103080500000305 Content-Type: text/x-patch; name="chown-dup-group.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chown-dup-group.patch" >From 5fc10774383928b2fbfde33de3efb314166fe475 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with conflicting group IDs * tests/chown/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..f5ecb5b 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,12 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +# Systems with both local and external groups with conflicting IDs, +# were seen to fail this test erroneously with EPERM errors. +test $(getent group | grep "^$id_gn:" | wc -l) = 1 || + skip_ "group '$id_gn' not biunique: " \ + "$(getent group | grep "^$id_gn:" | tr '\n' ',')" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.8.4.3 --------------000706050103080500000305-- From MAILER-DAEMON Fri Jan 24 12:51:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6kuV-0007xi-3P for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 12:51:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6kuM-0007it-SG for bug-coreutils@gnu.org; Fri, 24 Jan 2014 12:51:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6kuE-0000xz-IP for bug-coreutils@gnu.org; Fri, 24 Jan 2014 12:51:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:48991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6kuE-0000xv-D8 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 12:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6kuD-0005Aa-TL for bug-coreutils@gnu.org; Fri, 24 Jan 2014 12:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16532: Test Fail: "tests/chown/separator" Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 17:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16532 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Assaf Gordon Received: via spool by 16532-submit@debbugs.gnu.org id=B16532.139058583419826 (code B ref 16532); Fri, 24 Jan 2014 17:51:01 +0000 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 17:50:34 +0000 Received: from localhost ([127.0.0.1]:34777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6ktl-00059h-JG for submit@debbugs.gnu.org; Fri, 24 Jan 2014 12:50:33 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:48445) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6kti-00059X-V9 for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 12:50:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAF6n4lJtTPUT/2dsb2JhbAANTb1KgwWBI4MZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAaqYZ1ZF48MB4Q4AQOfFo5c Received: from unknown (HELO [192.168.1.79]) ([109.76.245.19]) by mail1.vodafone.ie with ESMTP; 24 Jan 2014 17:50:28 +0000 Message-ID: <52E2A7E2.5090504@draigBrady.com> Date: Fri, 24 Jan 2014 17:50:26 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> <52E26097.6010205@bernhard-voelker.de> <52E29BC6.20606@gmail.com> In-Reply-To: <52E29BC6.20606@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 17:51:17 -0000 On 01/24/2014 04:58 PM, Assaf Gordon wrote: > On 01/24/2014 07:46 AM, Bernhard Voelker wrote: >>>> On 01/24/2014 04:09 AM, Pdraig Brady wrote: >>>>> Oh right, grep ^$id_gn: it is so. >> >> BTW: I'd change the skip_ message to reflect the above mentioned >> corner case where getent is not available, something like: >> >> - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" >> + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" >> > > Attached is an updated version, using grep and the suggested error message. > On addition is a "tr '\n' ','" - because "skip" only shows the first line of the message, and so multiple groups and not displayed. If you remove the "" from "$()" the '\n' would be changed to spaces Your changing to ',' is neater though. Note to avoid a trailing ',' one can use ... | paste -s -d, Anyway pushed. thanks! Pdraig. From MAILER-DAEMON Fri Jan 24 16:34:44 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6oOi-0001PP-Iu for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 16:34:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nWu-000459-HB for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6nWo-0005Lj-MP for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:39:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:49092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nWo-0005Le-J6 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6nWn-0002C9-W5 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: df command, possible bug? Resent-From: Curtis Rubel Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16539@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.13905959358422 (code B ref -1); Fri, 24 Jan 2014 20:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jan 2014 20:38:55 +0000 Received: from localhost ([127.0.0.1]:34878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6nWh-0002Bm-8B for submit@debbugs.gnu.org; Fri, 24 Jan 2014 15:38:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38982) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6nOL-0001xi-Bs for submit@debbugs.gnu.org; Fri, 24 Jan 2014 15:30:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6nOC-0002dW-Fl for submit@debbugs.gnu.org; Fri, 24 Jan 2014 15:30:16 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:47079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nOC-0002aO-DQ for submit@debbugs.gnu.org; Fri, 24 Jan 2014 15:30:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nHU-0007Yp-TZ for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:23:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6nHO-0000P9-7B for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:23:12 -0500 Received: from admin.comprocs.com ([12.186.155.30]:64505 helo=mx2.compro.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1W6nHO-0000Oi-3G for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:23:06 -0500 X-BYPSHEADER: 35740729 X-SMScore: -250 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 Jan 2014 15:23:02 -0500 From: Curtis Rubel Organization: Compro Computer Services, Inc. Mail-Reply-To: Message-ID: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> X-Sender: crubel@compro.net User-Agent: Roundcube Webmail/0.8.4 X-detected-operating-system: by eggs.gnu.org: iOS iPhone or iPad X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 24 Jan 2014 15:38:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 24 Jan 2014 16:34:42 -0500 X-BeenThere: bug-coreutils@gnu.org Reply-To: crubel@compro.net List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 20:39:14 -0000 The df command as distributed with OpenSuSE 13.1 -- package coreutils-8.21-7.8.1.x86_64 does not return all currently mounted nfs mounts when specifying the command with no command line arguments. Specifying the df command: df -at nfs works perfectly and returns the data for all mounted nfs filesystems. uname -a output for your reference: Linux otw-l0 3.11.6-4-desktop #1 SMP PREEMPT Wed Oct 30 18:04:56 UTC 2013 (e6d4a27) x86_64 x86_64 x86_64 GNU/Linux If you need further information please let me know. Thank you, Curtis -- Curtis Rubel Senior Development Engineer Compro Computer Services, Inc. 105 East Drive - Melbourne, Florida, 32904 Phone: 321-727-2211 email: crubel@compro.net Web: http://www.compro.net "An ISO 9001:2008 Registered Company" From MAILER-DAEMON Fri Jan 24 16:34:44 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6oOi-0001Pl-OY for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 16:34:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nfd-000781-2w for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:48:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6nfW-00086o-Ck for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:48:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:49106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6nfW-00086k-9X for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6nfV-0002Rh-NU for bug-coreutils@gnu.org; Fri, 24 Jan 2014 15:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> In-Reply-To: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> Resent-From: Curtis Rubel Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: <16539@debbugs.gnu.org> Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.13905964399350 (code B ref 16539); Fri, 24 Jan 2014 20:48:01 +0000 Received: (at 16539) by debbugs.gnu.org; 24 Jan 2014 20:47:19 +0000 Received: from localhost ([127.0.0.1]:34892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6nep-0002Qh-7q for submit@debbugs.gnu.org; Fri, 24 Jan 2014 15:47:19 -0500 Received: from admin.compro.net ([12.186.155.30]:64861 helo=mx2.compro.net) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1W6nem-0002QY-Nc for 16539@debbugs.gnu.org; Fri, 24 Jan 2014 15:47:17 -0500 X-BYPSHEADER: 26185162 X-SMScore: -250 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 Jan 2014 15:47:14 -0500 From: Curtis Rubel Organization: Compro Computer Services, Inc. Mail-Reply-To: Message-ID: <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> X-Sender: crubel@compro.net User-Agent: Roundcube Webmail/0.8.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 24 Jan 2014 16:34:42 -0500 X-BeenThere: bug-coreutils@gnu.org Reply-To: crubel@compro.net List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 20:48:14 -0000 df command output with no args: only 1 nfs mount is listed amx@otw-l0:~> df Filesystem 1K-blocks Used Available Use% Mounted on /dev/sda3 173232952 44850568 127310032 27% / devtmpfs 4049732 32 4049700 1% /dev tmpfs 4095336 76 4095260 1% /dev/shm tmpfs 4095336 4688 4090648 1% /run tmpfs 4095336 0 4095336 0% /sys/fs/cgroup tmpfs 4095336 4688 4090648 1% /var/run tmpfs 4095336 4688 4090648 1% /var/lock /dev/sda1 1035084 45272 920848 5% /boot host:/usr/local/bin 110217536 40202928 68990448 37% /usr/local/muse amx@otw-l0:~> df command with options to show nfs mounted filesystems showing all nfs mounts. amx@otw-l0:~> df -at nfs Filesystem 1K-blocks Used Available Use% Mounted on host:/usr/local/muse 110217536 40203472 68989896 37% /usr/local/muse host:/usr/local/LINUX_FILES 110217536 40203472 68989896 37% /usr/local/LINUX_FILES host:/usr/local/3rdparty 110217536 40203472 68989896 37% /usr/local/3rdparty amx@otw-l0:~> Thank you. -- Curtis Rubel Senior Development Engineer Compro Computer Services, Inc. 105 East Drive - Melbourne, Florida, 32904 Phone: 321-727-2211 email: crubel@compro.net Web: http://www.compro.net "An ISO 9001:2008 Registered Company" --------------------------------------------------------------------------- CONFIDENTIALITY NOTICE: This email transmission, and any documents, files or previous email messages attached to it may contain confidential information that is legally privileged. If you are not the intended recipient or a person responsible for delivering it to the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of any of the information contained in or attached to this transmission is STRICTLY PROHIBITED. If you have received this transmission in error, please immediately notify the sender by email or call 321-727-2211. Please destroy the original transmission and its attachments without reading or saving it in any manner. From MAILER-DAEMON Fri Jan 24 17:28:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6pEZ-0006uG-3y for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 17:28:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pEQ-0006qT-3E for bug-coreutils@gnu.org; Fri, 24 Jan 2014 17:28:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6pEI-0000Kf-Pt for bug-coreutils@gnu.org; Fri, 24 Jan 2014 17:28:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:49159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pEI-0000KX-ME for bug-coreutils@gnu.org; Fri, 24 Jan 2014 17:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6pEI-0006Ng-80 for bug-coreutils@gnu.org; Fri, 24 Jan 2014 17:28:02 -0500 Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Fri, 24 Jan 2014 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: crubel@compro.net, 16539-done@debbugs.gnu.org Mail-Followup-To: 16539@debbugs.gnu.org, mail@bernhard-voelker.de, crubel@compro.net Received: via spool by 16539-done@debbugs.gnu.org id=D16539.139060244324466 (code D ref 16539); Fri, 24 Jan 2014 22:28:01 +0000 Received: (at 16539-done) by debbugs.gnu.org; 24 Jan 2014 22:27:23 +0000 Received: from localhost ([127.0.0.1]:34945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6pDe-0006MX-UD for submit@debbugs.gnu.org; Fri, 24 Jan 2014 17:27:23 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:53717) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6pDc-0006ML-Ah for 16539-done@debbugs.gnu.org; Fri, 24 Jan 2014 17:27:21 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MEaVh-1W4sKM2POL-00FrSx; Fri, 24 Jan 2014 23:27:11 +0100 Message-ID: <52E2E8BF.1000700@bernhard-voelker.de> Date: Fri, 24 Jan 2014 23:27:11 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> In-Reply-To: <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:BSaiibixKieEIS45KBOAjMe3+c4pDW4xuApueIWW08s Vi41rtKBYxCUGXdB7/PH/+R1z0rzifeC3AMYe2nosnjIpsr/aJ lwFPOlCFDSUBYQkIkbIAnTEvHM4RcVcWJ7r/VIMUz5yrwdvgPE idutyrRAhAlM/kbWtqWxsbhNUoEwBUt6oZJOApzhUYKd8inWAs 0/xtAyGRkU6Rr6rtO2gFdvBTCVbNi/9dURf9GSMTXMGyutf2dL 9cMunPT7g+DCkXZDtaawjFeIjaTShUJFVjyTrtJvEuGFeZYATE bs+4YcWaKsHItM5I03DTaey95xXzSRi5y6AI81XmWUk+ip2Xfp UWu5VtxP0D4lnJTSPyi2w19PUaN/U5tsNnu5xEW9J X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jan 2014 22:28:17 -0000 tag 16539 notabug close thanks On 01/24/2014 09:47 PM, Curtis Rubel wrote: > > df command output with no args: > > only 1 nfs mount is listed > > amx@otw-l0:~> df > Filesystem 1K-blocks Used Available Use% Mounted on > /dev/sda3 173232952 44850568 127310032 27% / > devtmpfs 4049732 32 4049700 1% /dev > tmpfs 4095336 76 4095260 1% /dev/shm > tmpfs 4095336 4688 4090648 1% /run > tmpfs 4095336 0 4095336 0% /sys/fs/cgroup > tmpfs 4095336 4688 4090648 1% /var/run > tmpfs 4095336 4688 4090648 1% /var/lock > /dev/sda1 1035084 45272 920848 5% /boot > host:/usr/local/bin 110217536 40202928 68990448 37% /usr/local/muse > amx@otw-l0:~> > > > df command with options to show nfs mounted filesystems > showing all nfs mounts. > > amx@otw-l0:~> df -at nfs > Filesystem 1K-blocks Used Available Use% Mounted > on > host:/usr/local/muse 110217536 40203472 68989896 37% > /usr/local/muse > host:/usr/local/LINUX_FILES 110217536 40203472 68989896 37% > /usr/local/LINUX_FILES > host:/usr/local/3rdparty 110217536 40203472 68989896 37% > /usr/local/3rdparty > amx@otw-l0:~> Just for info: df in openSUSE-13.1 is currently identical to that in coreutils-v8.21. The above is the result of df suppressing duplicate entries like bind mounts. This filtering is done based on the device number. As this example shows, a few exports of directories of the same file system from "host" are mounted - yet it's the same file system. We already had a few discussions about this filtering of duplicate mount entries. For me, this example shows that the current implementation is not that bad because df's job is to show block and inode usage statistics about mounted file systems. When it comes to information about mount points, then I think findmnt(1) from util-linux is the right tool. I'm therefore tagging this bug as "notabug" and mark it as done. If you or someone else wants to continue this discussion, then this can of course be done in this thread. And if someone has the *golden* idea how to solve this problem, then just stand up and let use know. Have a nice day, Berny From MAILER-DAEMON Fri Jan 24 22:21:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W6to4-00059w-5s for mharc-bug-coreutils@gnu.org; Fri, 24 Jan 2014 22:21:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6tnx-00059m-FH for bug-coreutils@gnu.org; Fri, 24 Jan 2014 22:21:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6tnq-0007nD-TB for bug-coreutils@gnu.org; Fri, 24 Jan 2014 22:21:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:49223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6tnq-0007n9-PH for bug-coreutils@gnu.org; Fri, 24 Jan 2014 22:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W6tnq-0008Qc-Hf for bug-coreutils@gnu.org; Fri, 24 Jan 2014 22:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 03:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16539@debbugs.gnu.org, mail@bernhard-voelker.de, crubel@compro.net Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139062002232344 (code B ref 16539); Sat, 25 Jan 2014 03:21:02 +0000 Received: (at 16539) by debbugs.gnu.org; 25 Jan 2014 03:20:22 +0000 Received: from localhost ([127.0.0.1]:35009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6tnA-0008PY-Kx for submit@debbugs.gnu.org; Fri, 24 Jan 2014 22:20:21 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:31655) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6tn5-0008PJ-1p for 16539@debbugs.gnu.org; Fri, 24 Jan 2014 22:20:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAGMs41JtTPUT/2dsb2JhbAANTYNEg1O5SIEfgxkBAQEDASMEVwsLDQQDAQIBCRYLAgIJAwIBAgE9CAcMBgIBARYEh18NqyN2nQEXjkM4DAyCb4FJAQOQPY5ZjlyBaQ Received: from unknown (HELO [192.168.1.79]) ([109.76.245.19]) by mail2.vodafone.ie with ESMTP; 25 Jan 2014 03:20:13 +0000 Message-ID: <52E32D5D.2030900@draigBrady.com> Date: Sat, 25 Jan 2014 03:19:57 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> In-Reply-To: <52E2E8BF.1000700@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------020905060000010807090909" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 03:21:14 -0000 This is a multi-part message in MIME format. --------------020905060000010807090909 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/24/2014 10:27 PM, Bernhard Voelker wrote: > tag 16539 notabug > close > thanks > > On 01/24/2014 09:47 PM, Curtis Rubel wrote: >> >> df command output with no args: >> >> only 1 nfs mount is listed > Just for info: df in openSUSE-13.1 is currently identical to that > in coreutils-v8.21. > > The above is the result of df suppressing duplicate entries like > bind mounts. This filtering is done based on the device number. > As this example shows, a few exports of directories of the same file > system from "host" are mounted - yet it's the same file system. Right. Essentially df is showing storage for available file systems. Noting that df also has a --total option, it makes sense by default to not repeat file systems. This can be overridden easily with the -a option as noted above. Actually we should in fact be merging more entries! Notice the following: >> tmpfs 4095336 4688 4090648 1% /run >> tmpfs 4095336 4688 4090648 1% /var/run >> tmpfs 4095336 4688 4090648 1% /var/lock Hopefully the attached patch addresses this (and a couple of other test issues). thanks, Pádraig. --------------020905060000010807090909 Content-Type: text/x-patch; name="df-tmpfs-merge.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="df-tmpfs-merge.patch" >From 5991616451187db13ea9731ac06101081af8ccda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Sat, 25 Jan 2014 01:14:29 +0000 Subject: [PATCH] df: also deduplicate virtual file systems * src/df.c (filter_mountlist): Remove the constraint that a '/' needs to be in the device name for a mount entry to be considered for deduplication. Virtual file systems also have storage associated with them (like tmpfs for example), and thus need to be deduplicated since they will be shown in the default df output and subject to --total processing also. * test/df/skip-duplicates.sh: Add a test to ensure we deduplicate all entries, even for virtual file systems. Also avoid possible length operations on many remote file systems in the initial check of df operation. Also avoid the assumption that "/root" is on the same file system as "/". * NEWS: Mention the change in behavior. --- NEWS | 5 ++++ src/df.c | 31 +++++++++++++---------------- tests/df/skip-duplicates.sh | 45 ++++++++++++++++++++++++++++++------------ 3 files changed, 51 insertions(+), 30 deletions(-) diff --git a/NEWS b/NEWS index 88a4154..2bf110a 100644 --- a/NEWS +++ b/NEWS @@ -18,6 +18,11 @@ GNU coreutils NEWS -*- outline -*- it would display an error, requiring --no-dereference to avoid the issue. [bug introduced in coreutils-5.3.0] +** Changes in behavior + + df now properly outputs file system information for virtual file systems + like tmpfs, by skipping duplicate entries (identified by the device number). + * Noteworthy changes in release 8.22 (2013-12-13) [stable] diff --git a/src/df.c b/src/df.c index e4fafb9..23b5156 100644 --- a/src/df.c +++ b/src/df.c @@ -630,26 +630,23 @@ filter_mount_list (void) } else { - /* If the device name is a real path name ... */ - if (strchr (me->me_devname, '/')) + /* If we've already seen this device... */ + for (devlist = devlist_head; devlist; devlist = devlist->next) + if (devlist->dev_num == buf.st_dev) + break; + + if (devlist) { - /* ... try to find its device number in the devlist. */ - for (devlist = devlist_head; devlist; devlist = devlist->next) - if (devlist->dev_num == buf.st_dev) - break; + discard_me = me; - if (devlist) + /* ...let the shorter mountdir win. */ + if ((strchr (me->me_devname, '/') + && ! strchr (devlist->me->me_devname, '/')) + || (strlen (devlist->me->me_mountdir) + > strlen (me->me_mountdir))) { - discard_me = me; - - /* Let the shorter mountdir win. */ - if (! strchr (devlist->me->me_devname, '/') - || (strlen (devlist->me->me_mountdir) - > strlen (me->me_mountdir))) - { - discard_me = devlist->me; - devlist->me = me; - } + discard_me = devlist->me; + devlist->me = me; } } } diff --git a/tests/df/skip-duplicates.sh b/tests/df/skip-duplicates.sh index 266520a..b41623f 100755 --- a/tests/df/skip-duplicates.sh +++ b/tests/df/skip-duplicates.sh @@ -21,19 +21,26 @@ print_ver_ df require_gcc_shared_ -df || skip_ "df fails" +# We use --local here so as to not activate +# potentially very many remote mounts. +df --local || skip_ "df fails" -# Simulate an mtab file with two entries of the same device number. -# Also add entries with unstatable mount dirs to ensure that's handled. +export CU_NONROOT_FS=$(df --local --output=target 2>&1 | grep /. | head -n1) +test -z "$CU_NONROOT_FS" && unique_entries=1 || unique_entries=2 + +# Simulate an mtab file to test various cases. cat > k.c <<'EOF' || framework_failure_ #include #include +#include #include struct mntent *getmntent (FILE *fp) { + static char *nonroot_fs; + static int done; + /* Prove that LD_PRELOAD works. */ - static int done = 0; if (!done) { fclose (fopen ("x", "w")); @@ -43,18 +50,30 @@ struct mntent *getmntent (FILE *fp) static struct mntent mntents[] = { {.mnt_fsname="/short", .mnt_dir="/invalid/mount/dir"}, {.mnt_fsname="fsname", .mnt_dir="/",}, - {.mnt_fsname="/fsname", .mnt_dir="/root"}, + {.mnt_fsname="/fsname", .mnt_dir="/."}, {.mnt_fsname="/fsname", .mnt_dir="/"}, + {.mnt_fsname="virtfs", .mnt_dir="/NONROOT"}, + {.mnt_fsname="virtfs", .mnt_dir="/NONROOT"}, }; - if (!getenv ("CU_TEST_DUPE_INVALID") && done == 1) + if (done == 1) + { + nonroot_fs = getenv ("CU_NONROOT_FS"); + if (!nonroot_fs || !*nonroot_fs) + nonroot_fs = "/"; /* merge into / entries. */ + } + + if (done == 1 && !getenv ("CU_TEST_DUPE_INVALID")) done++; /* skip the first entry. */ - while (done++ <= 4) + while (done++ <= 6) { mntents[done-2].mnt_type = "-"; + if (strcmp (mntents[done-2].mnt_dir, "/NONROOT") == 0) + mntents[done-2].mnt_dir = nonroot_fs; return &mntents[done-2]; } + return NULL; } EOF @@ -69,22 +88,22 @@ test -f x || skip_ "internal test failure: maybe LD_PRELOAD doesn't work?" # The fake mtab file should only contain entries # having the same device number; thus the output should -# consist of a header and one entry. +# consist of a header and unique entries. LD_PRELOAD=./k.so df >out || fail=1 -test $(wc -l out && fail=1 -test $(wc -l out || fail=1 -test $(wc -l ) id 1W77Ti-0005UZ-B9 for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W77Tc-0005wB-Gm for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W77Tc-0005w7-Cn for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W77Tb-0004n8-Tj for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:04 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16550: Request review of CHOWN man page synopsis Resent-From: Anubhav Chaturvedi Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 17:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16550 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16550@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139067258118340 (code B ref -1); Sat, 25 Jan 2014 17:57:03 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2014 17:56:21 +0000 Received: from localhost ([127.0.0.1]:35862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77Su-0004lf-6Y for submit@debbugs.gnu.org; Sat, 25 Jan 2014 12:56:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43130) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W731r-0000CW-S9 for submit@debbugs.gnu.org; Sat, 25 Jan 2014 08:12:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W731q-0000gH-KE for submit@debbugs.gnu.org; Sat, 25 Jan 2014 08:12:07 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:58020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W731q-0000fy-Gr for submit@debbugs.gnu.org; Sat, 25 Jan 2014 08:12:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W731l-0006KB-Ms for bug-coreutils@gnu.org; Sat, 25 Jan 2014 08:12:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W731k-0000W3-Mr for bug-coreutils@gnu.org; Sat, 25 Jan 2014 08:12:01 -0500 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:49564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W731k-0000Ue-GY for bug-coreutils@gnu.org; Sat, 25 Jan 2014 08:12:00 -0500 Received: by mail-wg0-f51.google.com with SMTP id z12so3937582wgg.6 for ; Sat, 25 Jan 2014 05:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=qiI7ieukw8Xf6412MoyMy+3gmUpzBV4LFaHII/oN+rc=; b=mvxO8GhJDEU7rQ64ZnLTaJ0u7Veb+89gTktTAh6EoLWZ+RS3qcindyqPV6iW44mLif AooXn8idAdEVEspMWUyS5d1tlKKI7fuCG/ptwvBjM4Xox/gsZLZrBHIWlkMUNrZm8WpQ xEfZviT5tVF9orS9uRxLq1cv+JycWelOLlTqJhZoZd7vVkM4HoGna7vQz6bRahzWD7MQ ZZlz5KpCd18/N/fkkJz9ILSQIItt92vxqDZdIMp2SWHifqJH8pvTADJ04lTwe5Og8Isy /nEhXDaqJ/Pz6ZeHQ7O3hiEgOKlF2iHteDEDovEATC1NANOs0x9savU1Fg/BwGYjGSnf NvDQ== X-Received: by 10.194.104.39 with SMTP id gb7mr22103wjb.69.1390655519158; Sat, 25 Jan 2014 05:11:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.94.132 with HTTP; Sat, 25 Jan 2014 05:11:39 -0800 (PST) From: Anubhav Chaturvedi Date: Sat, 25 Jan 2014 18:41:39 +0530 Message-ID: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sat, 25 Jan 2014 12:56:18 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 25 Jan 2014 13:21:18 -0500 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 17:57:15 -0000 Hi I was going through the man page ( on my Ubuntu 12.04 ) and noticed that in the synopsis, owner has been marked as optional ( i.e, it is enclosed in [ ] ). chown [OPTION]... [OWNER][:[GROUP]] FILE... On browsing the man pages on web i noticed this was only the case with UNIX man page. Man pages at freeBSDand oracle showed the command usage as expected. I believe the correct usage would be chown [OPTION]... OWNER[:GROUP] FILE... Please do the corrections necessary and inform me if i am making a mistake in interpreting this. *Regards,* *Anubhav Chaturvedi* *Birla Institute of Technology & Science, Pilani* KK Birla Goa Campus +91-9637399150 *" You can do anything if you stop doing everything "* From MAILER-DAEMON Sat Jan 25 13:21:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W77r5-0000EZ-C1 for mharc-bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:21:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W77Tj-0005Ub-Al for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W77Ta-0005vy-UM for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W77Ta-0005vu-QZ for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W77Ta-0004mq-4P for bug-coreutils@gnu.org; Sat, 25 Jan 2014 12:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16549: bug Resent-From: sneha@eaglet.co.in Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16549 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16549@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139067258118334 (code B ref -1); Sat, 25 Jan 2014 17:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2014 17:56:21 +0000 Received: from localhost ([127.0.0.1]:35860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77St-0004lb-8q for submit@debbugs.gnu.org; Sat, 25 Jan 2014 12:56:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W70YO-0003Aq-AF for submit@debbugs.gnu.org; Sat, 25 Jan 2014 05:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W70YF-00069g-UB for submit@debbugs.gnu.org; Sat, 25 Jan 2014 05:33:32 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:38028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W70YF-00069c-Rj for submit@debbugs.gnu.org; Sat, 25 Jan 2014 05:33:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W70Y9-0000km-Ky for bug-coreutils@gnu.org; Sat, 25 Jan 2014 05:33:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W70Y3-00068t-MT for bug-coreutils@gnu.org; Sat, 25 Jan 2014 05:33:17 -0500 Received: from cp-14.webhostbox.net ([174.122.93.152]:35863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W70Y3-00068e-I2 for bug-coreutils@gnu.org; Sat, 25 Jan 2014 05:33:11 -0500 Received: from mailnull by cp-14.webhostbox.net with sa-checked (Exim 4.80.1) (envelope-from ) id 1W70Y0-001fyE-ED for bug-coreutils@gnu.org; Sat, 25 Jan 2014 10:33:08 +0000 Received: from localhost ([127.0.0.1]:38044 helo=webmail.eaglet.co.in) by cp-14.webhostbox.net with esmtpa (Exim 4.80.1) (envelope-from ) id 1W70Y0-001fvh-1e for bug-coreutils@gnu.org; Sat, 25 Jan 2014 10:33:08 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 25 Jan 2014 10:33:07 +0000 From: sneha@eaglet.co.in Message-ID: <6668b3b6b5fccfb28f903689c45cf7f2@eaglet.co.in> X-Sender: sneha@eaglet.co.in User-Agent: Roundcube Webmail/0.9.3 X-Authenticated_sender: sneha@eaglet.co.in X-OutGoing-Spam-Status: No, score=-2.9 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020209.52E392E4.00B4, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: sneha@eaglet.co.in X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cp-14.webhostbox.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - eaglet.co.in X-Get-Message-Sender-Via: cp-14.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sat, 25 Jan 2014 12:56:18 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 25 Jan 2014 13:21:18 -0500 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 17:57:19 -0000 make[6]: *** [test-suite.log] Error 1 make[6]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' make[5]: *** [check-TESTS] Error 2 make[5]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' make[4]: *** [check-am] Error 2 make[4]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' make[3]: *** [check-recursive] Error 1 make[3]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' make[2]: *** [check] Error 2 make[2]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory `/sources/coreutils-8.21' make: *** [check] Error 2 From MAILER-DAEMON Sat Jan 25 13:29:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W77yj-0001Tf-HJ for mharc-bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:29:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W77yd-0001Rm-Ba for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:29:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W77yY-0005RH-ET for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:29:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W77yY-0005RD-BP for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W77yY-0005dr-5K for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16550: Request review of CHOWN man page synopsis Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16550 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Anubhav Chaturvedi Received: via spool by 16550-submit@debbugs.gnu.org id=B16550.139067451821639 (code B ref 16550); Sat, 25 Jan 2014 18:29:02 +0000 Received: (at 16550) by debbugs.gnu.org; 25 Jan 2014 18:28:38 +0000 Received: from localhost ([127.0.0.1]:35881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77yA-0005cv-EQ for submit@debbugs.gnu.org; Sat, 25 Jan 2014 13:28:38 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:14201) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77y8-0005cj-7T; Sat, 25 Jan 2014 13:28:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBABwB5FJtTpH+/2dsb2JhbAANTYNEvFNPgR6DGQEBAQQyAUYQCw0BCgkWDwkDAgECAUUGDQEHAQEFiAEIqwSdbhePDQeEOASZWYU9jlw Received: from unknown (HELO [192.168.1.79]) ([109.78.145.254]) by mail2.vodafone.ie with ESMTP; 25 Jan 2014 18:28:34 +0000 Message-ID: <52E40243.5050409@draigBrady.com> Date: Sat, 25 Jan 2014 18:28:19 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16550@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 18:29:12 -0000 tag 16550 notabug close 16550 stop On 01/25/2014 01:11 PM, Anubhav Chaturvedi wrote: > Hi > > I was going through the man page ( on my Ubuntu 12.04 ) and noticed that in > the synopsis, owner has been marked as optional ( i.e, it is enclosed in [ > ] ). > > chown [OPTION]... [OWNER][:[GROUP]] FILE... > > On browsing the man pages on web i noticed this was only the case with UNIX > man page. Man pages at > freeBSDand > oracle showed > the command usage as expected. > > I believe the correct usage would be > > chown [OPTION]... OWNER[:GROUP] FILE... > > Please do the corrections necessary and inform me if i am making a mistake > in interpreting this. Owner is optional. The info docs illustrate this more clearly: https://www.gnu.org/software/coreutils/manual/html_node/chown-invocation.html thanks, Pdraig. From MAILER-DAEMON Sat Jan 25 13:31:14 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W780g-0002cW-Kv for mharc-bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:31:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W780Z-0002cQ-NZ for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:31:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W780U-0006Gu-Kf for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:31:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W780U-0006Gq-HM for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W780T-0006pJ-QJ for bug-coreutils@gnu.org; Sat, 25 Jan 2014 13:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16549: bug Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16549 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16549@debbugs.gnu.org Received: via spool by 16549-submit@debbugs.gnu.org id=B16549.139067462823854 (code B ref 16549); Sat, 25 Jan 2014 18:31:01 +0000 Received: (at 16549) by debbugs.gnu.org; 25 Jan 2014 18:30:28 +0000 Received: from localhost ([127.0.0.1]:35891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77zv-0006Bl-Dt for submit@debbugs.gnu.org; Sat, 25 Jan 2014 13:30:27 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:4576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W77zt-00068t-Qc for 16549@debbugs.gnu.org; Sat, 25 Jan 2014 13:30:26 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAHQC5FJtTpH+/2dsb2JhbAANTYcXuU+BHoMZAQEBBCMPAVYLDQsCAgUhAgIPAkYTBgIBAYgGqwp2nHgXgSmNaxaCWYFJAQOfFo5c Received: from unknown (HELO [192.168.1.79]) ([109.78.145.254]) by mail2.vodafone.ie with ESMTP; 25 Jan 2014 18:30:08 +0000 Message-ID: <52E402B0.10104@draigBrady.com> Date: Sat, 25 Jan 2014 18:30:08 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <6668b3b6b5fccfb28f903689c45cf7f2@eaglet.co.in> In-Reply-To: <6668b3b6b5fccfb28f903689c45cf7f2@eaglet.co.in> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 18:31:12 -0000 On 01/25/2014 10:33 AM, sneha@eaglet.co.in wrote: > make[6]: *** [test-suite.log] Error 1 > make[6]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' > make[5]: *** [check-TESTS] Error 2 > make[5]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' > make[4]: *** [check-am] Error 2 > make[4]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' > make[3]: *** [check-recursive] Error 1 > make[3]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' > make[2]: *** [check] Error 2 > make[2]: Leaving directory `/sources/coreutils-8.21/gnulib-tests' > make[1]: *** [check-recursive] Error 1 > make[1]: Leaving directory `/sources/coreutils-8.21' > make: *** [check] Error 2 We need more info than that. What platform are you on? Can you attach the test-suite.log? thanks, Pádraig. From MAILER-DAEMON Sat Jan 25 18:56:25 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7D5N-00013o-G0 for mharc-bug-coreutils@gnu.org; Sat, 25 Jan 2014 18:56:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7D5E-00013J-76 for bug-coreutils@gnu.org; Sat, 25 Jan 2014 18:56:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7D54-0003EN-9D for bug-coreutils@gnu.org; Sat, 25 Jan 2014 18:56:16 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7D54-0003EC-6W for bug-coreutils@gnu.org; Sat, 25 Jan 2014 18:56:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7D53-000800-DD for bug-coreutils@gnu.org; Sat, 25 Jan 2014 18:56:05 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 25 Jan 2014 23:56:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , 16539@debbugs.gnu.org, crubel@compro.net Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139069412630698 (code B ref 16539); Sat, 25 Jan 2014 23:56:05 +0000 Received: (at 16539) by debbugs.gnu.org; 25 Jan 2014 23:55:26 +0000 Received: from localhost ([127.0.0.1]:35988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7D4Q-0007z3-0l for submit@debbugs.gnu.org; Sat, 25 Jan 2014 18:55:26 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:50841) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7D4L-0007yl-7w for 16539@debbugs.gnu.org; Sat, 25 Jan 2014 18:55:22 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MIAsE-1W8qQk47nq-003aL2; Sun, 26 Jan 2014 00:55:17 +0100 Message-ID: <52E44EE4.9020503@bernhard-voelker.de> Date: Sun, 26 Jan 2014 00:55:16 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> In-Reply-To: <52E32D5D.2030900@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:4sgCX2fgq2DYsFOz0VtTQKwc7AznXEu7nwxvxhYhRgS kHp+c0bFqB8zbNw33XcoeOe+mgaWxcBa1HiigxKjlp33Posfub vf22Kv3kvPd0ah4isD6VlcT6e6mQW2hPCvcoNX4sFOvf5vsy70 g890eOeVryCWwQjVXObWgrllGFI1wdokAcfWeelQaGI+fsAyH6 SOXfdrR46PJ4G49ljfBPysB8jGZm00Kw0y6Xxt+wLM5si2N/b7 UoNpuvE0mmpgj8TtjXSD7p4h3Ooo6gU+/SAsdvAIzp909AiSNY 9b/0koVpkhdccoP9xlWtIrFb5/Ym0y+GEM/rYFvg+Ke8SGIKpB mgTL0xGNfv+tJK3MBR8OxBi1k2B1CyO53sg5unG5W X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jan 2014 23:56:24 -0000 On 01/25/2014 04:19 AM, Pádraig Brady wrote: > On 01/24/2014 10:27 PM, Bernhard Voelker wrote: >> The above is the result of df suppressing duplicate entries like >> bind mounts. This filtering is done based on the device number. >> As this example shows, a few exports of directories of the same file >> system from "host" are mounted - yet it's the same file system. > > Right. Essentially df is showing storage for available file systems. > Noting that df also has a --total option, it makes sense by default > to not repeat file systems. This can be overridden easily with the > -a option as noted above. > > Actually we should in fact be merging more entries! > Notice the following: > >>> tmpfs 4095336 4688 4090648 1% /run >>> tmpfs 4095336 4688 4090648 1% /var/run >>> tmpfs 4095336 4688 4090648 1% /var/lock > > Hopefully the attached patch addresses this > (and a couple of other test issues). Good idea. I think we're on the right way - and the patch looks good to me. Thanks. However, I remember some other corner cases with eclipsed file systems in the Fedora bug tracker. I think we're quite close to solve them all this time (hopefully). The idea was to trust the order of mount entries returned by the kernel, i.e. in the loop over the mount entries, if the mount point is the same one as a previous one, then we should process the one mounted later. E.g. the situation where 2 file systems are mounted on the same mount point: $ findmnt | grep loop └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered df - the new one with your patch - still shows the wrong device: $ src/df | grep loop /dev/loop0 122835 1551 112110 2% /mnt /dev/loop1 122835 1550 112111 2% /mnt/dir It should say /dev/loop2 here. BTW the numbers are correct. Have a nice day, Berny From MAILER-DAEMON Sat Jan 25 19:05:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7DDy-0003Hm-Op for mharc-bug-coreutils@gnu.org; Sat, 25 Jan 2014 19:05:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7DDp-0003Ew-MG for bug-coreutils@gnu.org; Sat, 25 Jan 2014 19:05:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7DDj-00054W-3N for bug-coreutils@gnu.org; Sat, 25 Jan 2014 19:05:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7DDj-00053u-0N for bug-coreutils@gnu.org; Sat, 25 Jan 2014 19:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7DDi-0008F5-BV for bug-coreutils@gnu.org; Sat, 25 Jan 2014 19:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jan 2014 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , 16539@debbugs.gnu.org, crubel@compro.net Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139069465631621 (code B ref 16539); Sun, 26 Jan 2014 00:05:02 +0000 Received: (at 16539) by debbugs.gnu.org; 26 Jan 2014 00:04:16 +0000 Received: from localhost ([127.0.0.1]:35996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7DCy-0008Dx-Ct for submit@debbugs.gnu.org; Sat, 25 Jan 2014 19:04:16 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:62344) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7DCv-0008Dn-Pw for 16539@debbugs.gnu.org; Sat, 25 Jan 2014 19:04:14 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MF8TX-1W5rkU2bud-00GPW0; Sun, 26 Jan 2014 01:04:05 +0100 Message-ID: <52E450F5.5000203@bernhard-voelker.de> Date: Sun, 26 Jan 2014 01:04:05 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> In-Reply-To: <52E44EE4.9020503@bernhard-voelker.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:9cEY2ZUhfy/1cLU3KwV7h77/9BZcpqXyjT/yRt1h3zC qSBTjhBI+nYTOy4/ciJT0Ps7VED817IZv+Q6jvFgjVd5MIBnhw hmC7hrKocPk0vSa9nM6kHpJ2p/lgb72AS11EPEZoDUXpP1b4AM Q7H0mi9T1568/rb4bRWfreEo2MO2kx6A+HY5OO/8fC/G2XD7Nf dDipoueu9PPKjmEhQxKdtImNjH9Z40NMASNdPbnErTFb1XTdUP N8N1Mk3ZLx4IijrBwlgmjoZUeLLaq1IxWCLCbDjwIkJCewJqB2 T0daAWPbocg7yT8p5ChlrQ81HJi+va2YuIedsh9C3XmaLaBTCs X8gldd3JgJQCJG7xGcSHpgj/baTzNN7QUM82Ut7AI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 00:05:16 -0000 On 01/26/2014 12:55 AM, Bernhard Voelker wrote: > I think we're on the right way - and the patch looks good to me. oops, too early: $ make syntax-check ... tests/df/skip-duplicates.sh:72: if (strcmp (mntents[done-2].mnt_dir, "/NONROOT") == 0) maint.mk: replace strcmp calls above with STREQ/STRNEQ make: *** [sc_prohibit_strcmp] Error 1 make: *** Waiting for unfinished jobs.... --- ./po/POTFILES.in +++ ./po/POTFILES.in @@ -16,11 +16,14 @@ lib/rpmatch.c lib/set-acl.c lib/siglist.h +lib/spawn-pipe.c lib/strsignal.c lib/unicodeio.c lib/userspec.c lib/verror.c lib/version-etc.c +lib/w32spawn.h +lib/wait-process.c lib/xalloc-die.c lib/xfreopen.c lib/xmemcoll.c maint.mk: you have changed the set of files with translatable diagnostics; apply the above patch make: *** [sc_po_check] Error 1 The latter sc error is not related to this patch, obviously. Have a nice day, Berny From MAILER-DAEMON Sun Jan 26 06:30:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7Nur-0001ad-FB for mharc-bug-coreutils@gnu.org; Sun, 26 Jan 2014 06:30:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7Nuj-0001ZW-Jo for bug-coreutils@gnu.org; Sun, 26 Jan 2014 06:30:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7Nud-0003C8-KZ for bug-coreutils@gnu.org; Sun, 26 Jan 2014 06:30:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:50370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7Nud-0003By-IJ for bug-coreutils@gnu.org; Sun, 26 Jan 2014 06:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7Nud-0002FJ-1Q for bug-coreutils@gnu.org; Sun, 26 Jan 2014 06:30:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jan 2014 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.13907357478545 (code B ref 16539); Sun, 26 Jan 2014 11:30:02 +0000 Received: (at 16539) by debbugs.gnu.org; 26 Jan 2014 11:29:07 +0000 Received: from localhost ([127.0.0.1]:36156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7Ntj-0002Dk-1E for submit@debbugs.gnu.org; Sun, 26 Jan 2014 06:29:07 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:27792) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7Ntg-0002DS-8y for 16539@debbugs.gnu.org; Sun, 26 Jan 2014 06:29:05 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBADbx5FJtThEL/2dsb2JhbAANTYcXtlGDBYEagxkBAQEDASMPAUYFCwkCDQEKAgIFFgsCAgkDAgECAUUGDQEHAQGHeQ2PVpp7dpwsF4EpjRtJB4JvgUkBA5Q/ileOXIFp Received: from unknown (HELO [192.168.1.79]) ([109.78.17.11]) by mail2.vodafone.ie with ESMTP; 26 Jan 2014 11:28:51 +0000 Message-ID: <52E4F174.9040602@draigBrady.com> Date: Sun, 26 Jan 2014 11:28:52 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> In-Reply-To: <52E44EE4.9020503@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 11:30:15 -0000 On 01/25/2014 11:55 PM, Bernhard Voelker wrote: > On 01/25/2014 04:19 AM, Pádraig Brady wrote: >> On 01/24/2014 10:27 PM, Bernhard Voelker wrote: >>> The above is the result of df suppressing duplicate entries like >>> bind mounts. This filtering is done based on the device number. >>> As this example shows, a few exports of directories of the same file >>> system from "host" are mounted - yet it's the same file system. >> >> Right. Essentially df is showing storage for available file systems. >> Noting that df also has a --total option, it makes sense by default >> to not repeat file systems. This can be overridden easily with the >> -a option as noted above. >> >> Actually we should in fact be merging more entries! >> Notice the following: >> >>>> tmpfs 4095336 4688 4090648 1% /run >>>> tmpfs 4095336 4688 4090648 1% /var/run >>>> tmpfs 4095336 4688 4090648 1% /var/lock >> >> Hopefully the attached patch addresses this >> (and a couple of other test issues). > > Good idea. > > I think we're on the right way - and the patch looks good to me. Thanks for the review. I'll handle the syntax check too. > However, I remember some other corner cases with eclipsed file > systems in the Fedora bug tracker. I think we're quite close > to solve them all this time (hopefully). > The idea was to trust the order of mount entries returned by > the kernel, i.e. in the loop over the mount entries, if the > mount point is the same one as a previous one, then we should > process the one mounted later. > > E.g. the situation where 2 file systems are mounted on the > same mount point: > > $ findmnt | grep loop > └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered > └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered > └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered > > df - the new one with your patch - still shows the wrong device: > > $ src/df | grep loop > /dev/loop0 122835 1551 112110 2% /mnt > /dev/loop1 122835 1550 112111 2% /mnt/dir > > It should say /dev/loop2 here. BTW the numbers are correct. Right, that could be handled easy enough. loop1 is not accessible above and so should be hidden. But consider a bind mount resulting in something like: > └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered > └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered > └─/some/place/else /dev/loop1 ext4 rw,relatime,data=ordered > └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered If we did a linear scan through that, we'd lose the /some/place/else due to it being a longer mount dir, and then also the original loop1 as we took /dev/loop2 for /mnt/dir. Seems like when discarding we would need to see if this was the last entry for a device and then see if there are any other candidate mount points for that device? thanks, Pádraig. From MAILER-DAEMON Sun Jan 26 18:37:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7ZGQ-00085g-DU for mharc-bug-coreutils@gnu.org; Sun, 26 Jan 2014 18:37:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7ZGI-00084e-0k for bug-coreutils@gnu.org; Sun, 26 Jan 2014 18:37:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7ZGA-0003Vy-F0 for bug-coreutils@gnu.org; Sun, 26 Jan 2014 18:37:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:51238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7ZGA-0003Vu-BZ for bug-coreutils@gnu.org; Sun, 26 Jan 2014 18:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7ZG9-0007hY-U4 for bug-coreutils@gnu.org; Sun, 26 Jan 2014 18:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jan 2014 23:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139077937329541 (code B ref 16539); Sun, 26 Jan 2014 23:37:01 +0000 Received: (at 16539) by debbugs.gnu.org; 26 Jan 2014 23:36:13 +0000 Received: from localhost ([127.0.0.1]:37024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7ZFM-0007gN-Aj for submit@debbugs.gnu.org; Sun, 26 Jan 2014 18:36:12 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:58928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7ZFK-0007gE-6N for 16539@debbugs.gnu.org; Sun, 26 Jan 2014 18:36:11 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0MUASM-1Vhotg3pB4-00QaXD; Mon, 27 Jan 2014 00:35:59 +0100 Message-ID: <52E59BDE.9020206@bernhard-voelker.de> Date: Mon, 27 Jan 2014 00:35:58 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> <52E4F174.9040602@draigBrady.com> In-Reply-To: <52E4F174.9040602@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:7l7JUCoRUnmA3eCWQZhXfvoi6m3VpIWsWK8uT0CzFcM VVhxTuxbHpVuD0wQFDMJZ//t0xrUDdZ7H+VKFWvlk5g1Zl24RT 12M7t7+vq8k66778L83FHdwjoF6lM7vlXNllaNSd7oN55iAISK +qBmxUibCxf8FxigKOzp/r4CinYDMQCbZb4PqE53vFLbXhCY9q GJ2vP9dkF81Yv/RzWEnBZn+pPYnKffJX94hH812LmsrTvacHOb 9COt0JxuRhBiTocJrNpL6+e0sL5effp8NXAi378jYq6lso06Ii Nl3JCMqWo4Fwp4DCu2GVLZL/L3d0x9Z5Hm6EDRIDxboE4BhkgK 5J2POhCXcaO7ASi8aMz3iU3ug7jizaSavp8tdNP89 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 23:37:17 -0000 On 01/26/2014 12:28 PM, Pádraig Brady wrote: > On 01/25/2014 11:55 PM, Bernhard Voelker wrote: >> However, I remember some other corner cases with eclipsed file >> systems in the Fedora bug tracker. I think we're quite close >> to solve them all this time (hopefully). >> The idea was to trust the order of mount entries returned by >> the kernel, i.e. in the loop over the mount entries, if the >> mount point is the same one as a previous one, then we should >> process the one mounted later. >> >> E.g. the situation where 2 file systems are mounted on the >> same mount point: >> >> $ findmnt | grep loop >> └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered >> └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered >> └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered >> >> df - the new one with your patch - still shows the wrong device: >> >> $ src/df | grep loop >> /dev/loop0 122835 1551 112110 2% /mnt >> /dev/loop1 122835 1550 112111 2% /mnt/dir >> >> It should say /dev/loop2 here. BTW the numbers are correct. BTW: the fstype is wrong, too (which can only be seen with -T or --output, and if it differs, of course). > Right, that could be handled easy enough. > loop1 is not accessible above and so should be hidden. > But consider a bind mount resulting in something like: > >> └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered >> └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered >> └─/some/place/else /dev/loop1 ext4 rw,relatime,data=ordered >> └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered > > If we did a linear scan through that, we'd lose the /some/place/else > due to it being a longer mount dir, and then also the original loop1 > as we took /dev/loop2 for /mnt/dir. > Seems like when discarding we would need to see if this was the > last entry for a device and then see if there are any other candidate > mount points for that device? Hi Padraig, thanks. Again, mount_list is a little beast - more below. The following patch (on top of yours) would handle both cases without a problem. Feel free to squash it in, if you like. diff --git a/src/df.c b/src/df.c index 23b5156..78768cc 100644 --- a/src/df.c +++ b/src/df.c @@ -631,9 +631,20 @@ filter_mount_list (void) else { /* If we've already seen this device... */ + struct devlist *d = NULL; for (devlist = devlist_head; devlist; devlist = devlist->next) if (devlist->dev_num == buf.st_dev) - break; + { + d = devlist; + if (!STREQ (devlist->me->me_devname, me->me_devname)) + { + /* Fix the devname if the mount dir has been + mounted over by a different devname. */ + free (devlist->me->me_devname); + devlist->me->me_devname = xstrdup (me->me_devname); + } + } + devlist = d; if (devlist) { But there is yet another issue with the -a mode for such over-mounted and therefore eclipsed file systems: # Create 2 file system images: 1 ext4, 1 xfs. $ dd if=/dev/zero bs=1M status=none count=128 of=img1 $ dd if=/dev/zero bs=1M status=none count=256 of=img2 $ mkfs -t ext4 -F img1 >/dev/null 2>&1 $ mkfs -t xfs -f img2 >/dev/null 2>&1 $ mkdir /mnt{1,2} # Mount both on /mnt1. $ mount -o loop img1 /mnt1 $ mount -o loop img2 /mnt1 # Mount the former (ext4) also on /mnt2 via its loop device. $ mount /dev/loop0 /mnt2 # Result: $ findmnt --output=TARGET,SOURCE,FSTYPE | grep loop ├─/mnt1 /dev/loop0 ext4 │ └─/mnt1 /dev/loop1 xfs └─/mnt2 /dev/loop0 ext4 Everything is fine now with the filtered df run ... $ src/df --out -h | grep loop /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 /dev/loop0 ext4 32K 11 32K 1% 120M 1.6M 110M 2% - /mnt2 ...but "df -a" prints the wrong statistics for the "over-mounted" /mnt1! $ src/df --out -h -a | grep loop /dev/loop0 ext4 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 /dev/loop0 ext4 32K 11 32K 1% 120M 1.6M 110M 2% - /mnt2 Okay, this is nothing new. BTW: strictly speaking, also the output of today's "df -t rootfs -a" is wrong because the numbers are definitely not that of the early-boot rootfs file system. Now, how should df handle this? a) df silently filters out the mount entries of all eclipsed mount dirs, even with -a. --> Hmm, I think this would probably contradict to POSIX. b) df prints an error diagnostic for each eclipsed mount dir, and exits non-Zero. --> Well, there are probably such mounts on every system, e.g. on my box: TARGET SOURCE FSTYPE /proc/sys/fs/binfmt_misc systemd-1 autofs /proc/sys/fs/binfmt_misc binfmt_misc binfmt_misc Therefore, a "df -a" would always fail. ;-( At least on my system, there are c) df prints a warning diagnostic for each eclipsed mount dir, and exits Zero (unless another error occurs). --> Due to the same reason as in b), these warning might be messy and users will probably be irritated. d) df outputs "-" for all numbers of such eclipsed file systems, e.g. $ src/df --out -h -a | grep mnt1 /dev/loop0 ext4 - - - - - - - - - /mnt1 /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 Maybe d) is the best solution, as it mirrors what df can know: it knows source, target and the file system type, but it doesn't have access to the block and inode numbers. WDYT? Have a nice day, Berny From MAILER-DAEMON Sun Jan 26 20:07:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7afU-0005bD-0O for mharc-bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:07:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7afM-0005b3-TQ for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:07:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7afG-0006KK-QH for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:07:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:51263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7afG-0006JB-MU for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7afG-0001YD-9Y for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 27 Jan 2014 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.13907847825904 (code B ref 16539); Mon, 27 Jan 2014 01:07:02 +0000 Received: (at 16539) by debbugs.gnu.org; 27 Jan 2014 01:06:22 +0000 Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7aeb-0001X9-Nc for submit@debbugs.gnu.org; Sun, 26 Jan 2014 20:06:22 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:14450) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7aeY-0001Wz-Gh for 16539@debbugs.gnu.org; Sun, 26 Jan 2014 20:06:19 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBAMGv5VJtThEL/2dsb2JhbAANTIcXtlSDBYEegxkBAQEEIwQLAUYQCQINAQoCAgUWCwICCQMCAQIBRQYNAQcBAReHb49dmnt2nDAXgSmNZAeCb4FJAQOUP4pXjlw Received: from unknown (HELO [192.168.1.79]) ([109.78.17.11]) by mail2.vodafone.ie with ESMTP; 27 Jan 2014 01:06:16 +0000 Message-ID: <52E5B108.5080304@draigBrady.com> Date: Mon, 27 Jan 2014 01:06:16 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> <52E4F174.9040602@draigBrady.com> <52E59BDE.9020206@bernhard-voelker.de> In-Reply-To: <52E59BDE.9020206@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 01:07:15 -0000 On 01/26/2014 11:35 PM, Bernhard Voelker wrote: > On 01/26/2014 12:28 PM, Pádraig Brady wrote: >> On 01/25/2014 11:55 PM, Bernhard Voelker wrote: >>> However, I remember some other corner cases with eclipsed file >>> systems in the Fedora bug tracker. I think we're quite close >>> to solve them all this time (hopefully). >>> The idea was to trust the order of mount entries returned by >>> the kernel, i.e. in the loop over the mount entries, if the >>> mount point is the same one as a previous one, then we should >>> process the one mounted later. >>> >>> E.g. the situation where 2 file systems are mounted on the >>> same mount point: >>> >>> $ findmnt | grep loop >>> └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered >>> └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered >>> └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered >>> >>> df - the new one with your patch - still shows the wrong device: >>> >>> $ src/df | grep loop >>> /dev/loop0 122835 1551 112110 2% /mnt >>> /dev/loop1 122835 1550 112111 2% /mnt/dir >>> >>> It should say /dev/loop2 here. BTW the numbers are correct. > > BTW: the fstype is wrong, too (which can only be seen with -T or --output, > and if it differs, of course). > >> Right, that could be handled easy enough. >> loop1 is not accessible above and so should be hidden. >> But consider a bind mount resulting in something like: >> >>> └─/mnt /dev/loop0 ext4 rw,relatime,data=ordered >>> └─/mnt/dir /dev/loop1 ext4 rw,relatime,data=ordered >>> └─/some/place/else /dev/loop1 ext4 rw,relatime,data=ordered >>> └─/mnt/dir /dev/loop2 ext4 rw,relatime,data=ordered >> >> If we did a linear scan through that, we'd lose the /some/place/else >> due to it being a longer mount dir, and then also the original loop1 >> as we took /dev/loop2 for /mnt/dir. >> Seems like when discarding we would need to see if this was the >> last entry for a device and then see if there are any other candidate >> mount points for that device? > > Hi Padraig, > > thanks. > Again, mount_list is a little beast - more below. > > The following patch (on top of yours) would handle both cases > without a problem. Feel free to squash it in, if you like. > > diff --git a/src/df.c b/src/df.c > index 23b5156..78768cc 100644 > --- a/src/df.c > +++ b/src/df.c > @@ -631,9 +631,20 @@ filter_mount_list (void) > else > { > /* If we've already seen this device... */ > + struct devlist *d = NULL; > for (devlist = devlist_head; devlist; devlist = devlist->next) > if (devlist->dev_num == buf.st_dev) > - break; > + { > + d = devlist; > + if (!STREQ (devlist->me->me_devname, me->me_devname)) > + { > + /* Fix the devname if the mount dir has been > + mounted over by a different devname. */ > + free (devlist->me->me_devname); > + devlist->me->me_devname = xstrdup (me->me_devname); > + } > + } > + devlist = d; > > if (devlist) > { > > But there is yet another issue with the -a mode for such > over-mounted and therefore eclipsed file systems: > > # Create 2 file system images: 1 ext4, 1 xfs. > $ dd if=/dev/zero bs=1M status=none count=128 of=img1 > $ dd if=/dev/zero bs=1M status=none count=256 of=img2 > $ mkfs -t ext4 -F img1 >/dev/null 2>&1 > $ mkfs -t xfs -f img2 >/dev/null 2>&1 > $ mkdir /mnt{1,2} > > # Mount both on /mnt1. > $ mount -o loop img1 /mnt1 > $ mount -o loop img2 /mnt1 > > # Mount the former (ext4) also on /mnt2 via its loop device. > $ mount /dev/loop0 /mnt2 > > # Result: > $ findmnt --output=TARGET,SOURCE,FSTYPE | grep loop > ├─/mnt1 /dev/loop0 ext4 > │ └─/mnt1 /dev/loop1 xfs > └─/mnt2 /dev/loop0 ext4 > > Everything is fine now with the filtered df run ... > > $ src/df --out -h | grep loop > /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 > /dev/loop0 ext4 32K 11 32K 1% 120M 1.6M 110M 2% - /mnt2 > > ...but "df -a" prints the wrong statistics for the "over-mounted" /mnt1! > > $ src/df --out -h -a | grep loop > /dev/loop0 ext4 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 > /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 > /dev/loop0 ext4 32K 11 32K 1% 120M 1.6M 110M 2% - /mnt2 > > Okay, this is nothing new. > BTW: strictly speaking, also the output of today's "df -t rootfs -a" > is wrong because the numbers are definitely not that of the early-boot > rootfs file system. > > Now, how should df handle this? > > a) > df silently filters out the mount entries of all eclipsed mount dirs, > even with -a. > --> Hmm, I think this would probably contradict to POSIX. > > b) > df prints an error diagnostic for each eclipsed mount dir, and exits > non-Zero. > --> Well, there are probably such mounts on every system, e.g. on my box: > > TARGET SOURCE FSTYPE > /proc/sys/fs/binfmt_misc systemd-1 autofs > /proc/sys/fs/binfmt_misc binfmt_misc binfmt_misc > > Therefore, a "df -a" would always fail. ;-( > At least on my system, there are > > c) > df prints a warning diagnostic for each eclipsed mount dir, and exits > Zero (unless another error occurs). > > --> Due to the same reason as in b), these warning might be messy > and users will probably be irritated. > > d) > df outputs "-" for all numbers of such eclipsed file systems, e.g. > > $ src/df --out -h -a | grep mnt1 > /dev/loop0 ext4 - - - - - - - - - /mnt1 > /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 > > > Maybe d) is the best solution, as it mirrors what df can know: > it knows source, target and the file system type, but it doesn't > have access to the block and inode numbers. > > WDYT? Thanks for the nice analysis and tests. d) seems like the best option here, though we'd have to be careful about cases where /proc/mounts was giving a system wide view, while df wasn't privy to that due to mount namespaces or overmounts etc. I'm not thinking of a specific issue here, just the general problem. wrt c) and annoying warnings, I also notice `df -a` on a default Fedora 20 install here, giving multiple duplicate warnings like: df: ‘net:[4026532416]’: No such file or directory df: ‘net:[4026532416]’: No such file or directory That's due to: $ grep net: /proc/mounts proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 Which is due to support for namespaces. Seems like we should not try to lookup non absolute mount points? Also a general point is that a lot of stuff has changed underneath us recently, and perhaps we should be looking at abstracting that away somewhere (like libmount that is part of util-linux). In the short term anyway we should fix up the above warts within df. thanks, Pádraig. thanks, Pádraig. From MAILER-DAEMON Sun Jan 26 20:10:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7aiL-00061b-ED for mharc-bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:10:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7VZz-0007KU-Vy for bug-coreutils@gnu.org; Sun, 26 Jan 2014 14:41:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7VZn-000566-Mp for bug-coreutils@gnu.org; Sun, 26 Jan 2014 14:41:15 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:51113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7VZn-000562-JA for bug-coreutils@gnu.org; Sun, 26 Jan 2014 14:41:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7VZn-0000SB-Ah for bug-coreutils@gnu.org; Sun, 26 Jan 2014 14:41:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16561: Bug report for 'head' (and 'wc' et. al.) Resent-From: LGUC Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 Jan 2014 19:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16561 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16561@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13907652161640 (code B ref -1); Sun, 26 Jan 2014 19:41:03 +0000 Received: (at submit) by debbugs.gnu.org; 26 Jan 2014 19:40:16 +0000 Received: from localhost ([127.0.0.1]:36897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7VZ1-0000QH-FZ for submit@debbugs.gnu.org; Sun, 26 Jan 2014 14:40:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33363) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7RKT-0000eg-H8 for submit@debbugs.gnu.org; Sun, 26 Jan 2014 10:08:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7RKK-0002Qt-Sh for submit@debbugs.gnu.org; Sun, 26 Jan 2014 10:08:57 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:44253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7RKK-0002Qp-PS for submit@debbugs.gnu.org; Sun, 26 Jan 2014 10:08:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7RKC-0001QY-9I for bug-coreutils@gnu.org; Sun, 26 Jan 2014 10:08:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7RK3-0002PU-Sf for bug-coreutils@gnu.org; Sun, 26 Jan 2014 10:08:40 -0500 Received: from mail-ve0-x22a.google.com ([2607:f8b0:400c:c01::22a]:60767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7RK3-0002PO-NM for bug-coreutils@gnu.org; Sun, 26 Jan 2014 10:08:31 -0500 Received: by mail-ve0-f170.google.com with SMTP id cz12so3004049veb.29 for ; Sun, 26 Jan 2014 07:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:disposition-notification-to:date:to:from:subject :mime-version:content-type; bh=r+a2vlc7TDJ5rjzhXb887omIrCx9+3xHuPdOr/ImWuw=; b=x/enHQYUiGqyWOpo+Uc80xc29RbNw3xgI9QvFj2PwEpikliX2LrKOWWrjHXCNmLuLy jxV+bJHlyYUPj4O4kOS0S/xxCzjPkYruqaIbl4+geQ8riHXX1VDMT1lBcsFOfjszYwN1 FjZK1IOvHVpXbWUu8ukncjd1p+YangrCqsff9OwjygoZ5kcEyg5nIElCZ9c7jDXcCb7k KMtN2904D0hxTdc6IwSvQNvzlkjg8Bt58JRHucP+XIW590nhuVaKCxgN6yDMXd4QDhLl /k3ZEhMaYffcGAyh/ERulxHXUz/0BLTxC/ktPUmHUvkbcTkEdnxFMM8o/ut6ReB/7MCu KRVg== X-Received: by 10.58.100.197 with SMTP id fa5mr13211247veb.24.1390748911243; Sun, 26 Jan 2014 07:08:31 -0800 (PST) Received: from LG-LaptopW8.gmail.com (181-182-37-10.genericrev.telcel.net.ve. [181.182.37.10]) by mx.google.com with ESMTPSA id kf16sm4577551vdb.5.2014.01.26.07.08.28 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 26 Jan 2014 07:08:30 -0800 (PST) Message-ID: <52e524ee.b075340a.4538.01a5@mx.google.com> X-Mailer: QUALCOMM Windows Eudora Version 7.1.0.9 Date: Sun, 26 Jan 2014 10:37:54 -0430 From: LGUC Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=====================_174644640==_" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sun, 26 Jan 2014 14:40:13 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sun, 26 Jan 2014 20:10:11 -0500 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jan 2014 19:41:24 -0000 --=====================_174644640==_ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" THE INCOMPLETE ATTACMENT! (working on sunday makes not my lucky day. Sorry for the inconveniences!. Please disregard the previous 2 mails) __________________________________________________________________ Caracas, Sunday 26th, 2014 Ref: Bug report for 'head' (and 'wc' et. al.) Dear friends: Please find attached the text file 'head-tst.txt' As you easily can see, the following command fails and do not print anything, even if the file has: 6 lines, 49 words and 250 chars: 'head -n -0 head-tst.txt' The last line on the file does NOT end with a '\n', and this seems to be the base of the problem. If you add the last '\n', 'head' works pretty fine. So this seems to be a problem with the definition of a 'text line': I guess that a line that has around 68 normal chars and 13 spaces, is a good candidate to be considered as a line. I found the same problem in several other core utils, being the most remarcable 'wc'. If you executes: 'wc head-tst.txt' you will get: 5 49 250 head-tst.txt what is wrong, as the file has six (6) lines instead of five (5). The last one line is missing due to the fact that it does not include a '\n' at the end. In 1998 I fix 'wc', and I have attached 'wc-fix.c' including only the most remarkable aspects, in case it could be of any help. Best regards, Luis G. Uribe C. __________________________________________________________________ Attachments inside 'head-tst.zip': - 'head-tst.txt': text file that makes 'head' core utility to fail - 'wc-fix.c': fix to same problem, applyied to 'wc' in 1998 Software ID: GNU coreutils 8.15 January 2012 HEAD(1) (Cygwin) --=====================_174644640==_ Content-Type: application/octet-stream; name="head-tst.zip" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="head-tst.zip" UEsDBBQAAgAIABEWOkT9UhumqAAAAPoAAAAMAAAAaGVhZC10c3QudHh0Vc5BC4JAEIbhu+B/+Drt Ja1znSISBNMgIQIvm67t0jJCO2H++2wNwusM8z6TJmCtYKVjWEMKWjrkRQlJUNQYukNUJJYQWskG ESFaC7DjmN+MVhrr4jAIg9m6754PhyTND+gN67E1oDVWjZRkL8zNCQoD4Db8OJ/z+SnB2jjf8Fr2 vbqsinFC0qKiDfoaTaem3+vuRQzDW/y/QrJLszP2xfGUHcrsuvgAUEsDBBQAAgAIACoVOkQs77f0 EQEAAGMCAAAIAAAAd2MtZml4LmN1UtFKwzAUfR/sH86e1rGatEXEOfog0okwENThy0BYlmqgS6VN qeL67zbp1jZz3hDIPck9OecmlKJkF7H4crEsRI57glUmNhx3xIU/m11T36NBAASef0k9nwZXwwEA SkEIOU4DlR8i4Q4cMIR454o5iD8xqQdGIRA9LurljzmqY/OteI7pdN4iLC2kekuE5DXBy9Mq6rZE bGhDjOux3x/Wa9VPZD/JxtZlhkOWabatqRe3y+cet82vaU4rdWhZtlw0beiMdBhLdzuSFsrFWt6A ZUjieWMPQiGVjP/ht8yfUVi1WcWTnBvFo6Onf63aXdShN2wfVaM5kls8xAbtIa/6UQ1oWtSJnLT1 dmdOP8Zw8AtQSwECFAAUAAIACAARFjpE/VIbpqgAAAD6AAAADAAAAAAAAAABACAAAAAAAAAAaGVh ZC10c3QudHh0UEsBAhQAFAACAAgAKhU6RCzvt/QRAQAAYwIAAAgAAAAAAAAAAQAgAAAA0gAAAHdj LWZpeC5jUEsFBgAAAAACAAIAcAAAAAkCAAAAAA== --=====================_174644640==_-- From MAILER-DAEMON Sun Jan 26 20:25:14 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7aws-0008Iu-1U for mharc-bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:25:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7awl-0008HH-V1 for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:25:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7awg-0002hf-Ql for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:25:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:51275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7awg-0002h6-Me for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7awg-00037i-2E for bug-coreutils@gnu.org; Sun, 26 Jan 2014 20:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16561: Bug report for 'head' (and 'wc' et. al.) Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 27 Jan 2014 01:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16561 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: LGUC Received: via spool by 16561-submit@debbugs.gnu.org id=B16561.139078586711954 (code B ref 16561); Mon, 27 Jan 2014 01:25:02 +0000 Received: (at 16561) by debbugs.gnu.org; 27 Jan 2014 01:24:27 +0000 Received: from localhost ([127.0.0.1]:37059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7aw6-00036i-Kq for submit@debbugs.gnu.org; Sun, 26 Jan 2014 20:24:26 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:41132) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7aw4-00036X-7u; Sun, 26 Jan 2014 20:24:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApkFAIq05VJtThEL/2dsb2JhbAANTINEUKJPAQGWDYN+gR6DGQEBAQMBMgFGBQsLDQsJFg8JAwIBAgFFBg0BBwEBh3kNA6pSk2uJPBePDQeEOAEDjgGLWIU9hXGIaw Received: from unknown (HELO [192.168.1.79]) ([109.78.17.11]) by mail2.vodafone.ie with ESMTP; 27 Jan 2014 01:24:23 +0000 Message-ID: <52E5B547.2030206@draigBrady.com> Date: Mon, 27 Jan 2014 01:24:23 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52e524ee.b075340a.4538.01a5@mx.google.com> In-Reply-To: <52e524ee.b075340a.4538.01a5@mx.google.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16561@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 01:25:13 -0000 forcemerge 16561 16329 stop On 01/26/2014 03:07 PM, LGUC wrote: > THE INCOMPLETE ATTACMENT! (working on sunday makes not my lucky day. > Sorry for the inconveniences!. > Please disregard the previous 2 mails) > __________________________________________________________________ > > Caracas, Sunday 26th, 2014 > Ref: Bug report for 'head' (and 'wc' et. al.) > Dear friends: > Please find attached the text file 'head-tst.txt' > > As you easily can see, the following command fails and do not print > anything, even if the file has: 6 lines, 49 words and 250 chars: > 'head -n -0 head-tst.txt' > The last line on the file does NOT end with a '\n', and this seems > to be the base of the problem. If you add the last '\n', 'head' works > pretty fine. Right that's an issue, coincidentally recently reported: http://bugs.gnu.org/16329 We'll include the fix for that soon. > So this seems to be a problem with the definition of a 'text line': > I guess that a line that has around 68 normal chars and 13 spaces, is > a good candidate to be considered as a line. > I found the same problem in several other core utils, being the > most remarcable 'wc'. If you executes: > 'wc head-tst.txt' > you will get: > 5 49 250 head-tst.txt > what is wrong, as the file has six (6) lines instead of five (5). > The last one line is missing due to the fact that it does not > include a '\n' at the end. > In 1998 I fix 'wc', and I have attached 'wc-fix.c' including only > the most remarkable aspects, in case it could be of any help. So wc is different and is defined by POSIX to only count '\n' chars. So we can't change that really. We might be able to add a --visible-lines option that would handle this and also unicode line separators etc. But that would require more debate since it would be a new option. thanks, Pdraig. From MAILER-DAEMON Mon Jan 27 08:23:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7m9l-00078t-Da for mharc-bug-coreutils@gnu.org; Mon, 27 Jan 2014 08:23:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7m9g-000720-1x for bug-coreutils@gnu.org; Mon, 27 Jan 2014 08:23:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7m9W-0005Rk-Ih for bug-coreutils@gnu.org; Mon, 27 Jan 2014 08:23:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:51715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7m9W-0005Re-F9 for bug-coreutils@gnu.org; Mon, 27 Jan 2014 08:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7m9W-00080C-4n for bug-coreutils@gnu.org; Mon, 27 Jan 2014 08:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16550: Request review of CHOWN man page synopsis Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 27 Jan 2014 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16550 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: notabug To: =?UTF-8?Q?P=C3=A1draig?= Brady , Anubhav Chaturvedi Received: via spool by 16550-submit@debbugs.gnu.org id=B16550.139082894030706 (code B ref 16550); Mon, 27 Jan 2014 13:23:02 +0000 Received: (at 16550) by debbugs.gnu.org; 27 Jan 2014 13:22:20 +0000 Received: from localhost ([127.0.0.1]:37501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7m8p-0007zB-LW for submit@debbugs.gnu.org; Mon, 27 Jan 2014 08:22:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7m8m-0007yy-0L for 16550@debbugs.gnu.org; Mon, 27 Jan 2014 08:22:18 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0RDMEqw026242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Jan 2014 08:22:14 -0500 Received: from [10.3.113.111] (ovpn-113-111.phx2.redhat.com [10.3.113.111]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0RDMDsi022405; Mon, 27 Jan 2014 08:22:13 -0500 Message-ID: <52E65D85.7040707@redhat.com> Date: Mon, 27 Jan 2014 06:22:13 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52E40243.5050409@draigBrady.com> In-Reply-To: <52E40243.5050409@draigBrady.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kAhMX6OnNHEdExfbdKqqtih2DSD22vwNi" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16550@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 13:23:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kAhMX6OnNHEdExfbdKqqtih2DSD22vwNi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/25/2014 11:28 AM, P=C3=A1draig Brady wrote: >> On browsing the man pages on web i noticed this was only the case with= UNIX >> man page. Man pages at >> freeBSDand >> oracle showed >> the command usage as expected. BSD and Solaris do not have as many extensions as GNU. >> >> I believe the correct usage would be >> >> chown [OPTION]... OWNER[:GROUP] FILE... Wrong - in GNU, we have intentionally chosen to add an extension that allows owner to be optional, even though POSIX does not require such an extension. >> >> Please do the corrections necessary and inform me if i am making a mis= take >> in interpreting this. >=20 > Owner is optional. The info docs illustrate this more clearly: > https://www.gnu.org/software/coreutils/manual/html_node/chown-invocatio= n.html This document covers the GNU extension. That said, there IS a bug about the documentation being misleading. See http://debbugs.gnu.org/15945 which states: > But I _still_ think we need to > split into two lines to make it obvious that the argument itself is > mandatory, as in: >=20 > Usage: chown [OPTION]... OWNER[:[GROUP]] FILE... > or: chown [OPTION]... :[GROUP] FILE... >=20 > or even rewrite it along the lines of the info page: >=20 > Usage: chown [OPTION]... NEWSPEC FILE... >=20 > and document that NEWSPEC is [OWNER][:[GROUP]] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kAhMX6OnNHEdExfbdKqqtih2DSD22vwNi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS5l2FAAoJEKeha0olJ0NqxCoH/0wxsAnXD4VwVi6iI0ru2vZO pYdxJU9D9eL/HTDPbkOJa5oI7o+/H46CPnOrs+WuNfvqxGmRnLJev3cv4kC9o5+W DHbYa7SxHXdHeRS/ggs7AkLg6kWKZSizyCz/zr6jiKlMDz+38YEUJSF0at0yaDbv aLn9/2FQfJv9NJDMmjbvNhl+R8dvPQdRbxpTI3YFGe9pAPSfTZXtLC1sNTGeZeuL a8YwmHkR02nG3m0nUt6QlWUDrVExlccKrGqyFCnX8JzyTFFPG437kcG/99ZP7SXt hxnQC3ESmrUvrAKNnZg1QB+KmWvD+ajfSbvrlAFXqDxKpYTJUO/MS8mkSDHo3Q8= =smP/ -----END PGP SIGNATURE----- --kAhMX6OnNHEdExfbdKqqtih2DSD22vwNi-- From MAILER-DAEMON Mon Jan 27 17:48:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W7uyZ-00034a-HK for mharc-bug-coreutils@gnu.org; Mon, 27 Jan 2014 17:48:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7uyQ-00033E-4D for bug-coreutils@gnu.org; Mon, 27 Jan 2014 17:48:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7uyI-000299-Qn for bug-coreutils@gnu.org; Mon, 27 Jan 2014 17:48:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:52664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7uyI-000293-Ml for bug-coreutils@gnu.org; Mon, 27 Jan 2014 17:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W7uyI-000831-BQ for bug-coreutils@gnu.org; Mon, 27 Jan 2014 17:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 27 Jan 2014 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139086285130886 (code B ref 16539); Mon, 27 Jan 2014 22:48:02 +0000 Received: (at 16539) by debbugs.gnu.org; 27 Jan 2014 22:47:31 +0000 Received: from localhost ([127.0.0.1]:38450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7uxm-000825-W6 for submit@debbugs.gnu.org; Mon, 27 Jan 2014 17:47:31 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:62459) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W7uxk-00081w-JD for 16539@debbugs.gnu.org; Mon, 27 Jan 2014 17:47:29 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MOETY-1WBEsF0YdQ-005deq; Mon, 27 Jan 2014 23:47:19 +0100 Message-ID: <52E6E1F6.2040803@bernhard-voelker.de> Date: Mon, 27 Jan 2014 23:47:18 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> <52E4F174.9040602@draigBrady.com> <52E59BDE.9020206@bernhard-voelker.de> <52E5B108.5080304@draigBrady.com> In-Reply-To: <52E5B108.5080304@draigBrady.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:UNcAoIPFGomb8DfyQQq2RL3KUlVeyJnVbPUDI7U/8VC yzaHD+urTWp6PxeS047kVvcW28DwlKVFxkQ/1M6+2EnyVvW7B6 1Wp4S4J2jBNQov2Ml6UOVfG9p+JAcP0mGW+iKmGaymdm1gkUN9 z0KzPmo55psgTvTyQF3oKioHQB95rlQOGhupV2p3HcmzsT2Ed1 rKG+qCWga6w/EQmCtZNNc/QVR4TQejRUA5SgRsHJC/UMkGtmGy fE9r8hVZfIFXtFUDlUY5SlSxEeufxutrLUYbMBWsLgX2F9wklU uKml/AB2fxEG4iF9x8a/cT7U6vVsLRNbnN+ju5BDDiLGcZoL83 aWqYs2ZTh/wlZeumnzjQnXjzCO50jb0E4cwjv8wbJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jan 2014 22:48:17 -0000 On 01/27/2014 02:06 AM, Pádraig Brady wrote: > On 01/26/2014 11:35 PM, Bernhard Voelker wrote: >> Now, how should df handle this? >> >> a) >> df silently filters out the mount entries of all eclipsed mount dirs, >> even with -a. >> --> Hmm, I think this would probably contradict to POSIX. >> >> b) >> df prints an error diagnostic for each eclipsed mount dir, and exits >> non-Zero. >> --> Well, there are probably such mounts on every system, e.g. on my box: >> >> TARGET SOURCE FSTYPE >> /proc/sys/fs/binfmt_misc systemd-1 autofs >> /proc/sys/fs/binfmt_misc binfmt_misc binfmt_misc >> >> Therefore, a "df -a" would always fail. ;-( >> At least on my system, there are >> >> c) >> df prints a warning diagnostic for each eclipsed mount dir, and exits >> Zero (unless another error occurs). >> >> --> Due to the same reason as in b), these warning might be messy >> and users will probably be irritated. >> >> d) >> df outputs "-" for all numbers of such eclipsed file systems, e.g. >> >> $ src/df --out -h -a | grep mnt1 >> /dev/loop0 ext4 - - - - - - - - - /mnt1 >> /dev/loop1 xfs 256K 3 256K 1% 252M 13M 239M 6% - /mnt1 >> >> >> Maybe d) is the best solution, as it mirrors what df can know: >> it knows source, target and the file system type, but it doesn't >> have access to the block and inode numbers. >> >> WDYT? > > Thanks for the nice analysis and tests. > d) seems like the best option here, though we'd have to be careful > about cases where /proc/mounts was giving a system wide view, > while df wasn't privy to that due to mount namespaces or > overmounts etc. I'm not thinking of a specific issue here, > just the general problem. okay, let's try it that way. I think this is not much related to the issue your patch (with my amendment) is trying to fix. Therefore, I suggest to finish that and handle the overmounts in a separate commit. > wrt c) and annoying warnings, I also notice `df -a` on a default Fedora 20 install here, > giving multiple duplicate warnings like: > df: ‘net:[4026532416]’: No such file or directory > df: ‘net:[4026532416]’: No such file or directory > That's due to: > $ grep net: /proc/mounts > proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 > proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 > Which is due to support for namespaces. Ugh ... and that's a third problm class for df. ;-( > Seems like we should not try to lookup non absolute mount points? yes, that's probably our best chance. > Also a general point is that a lot of stuff has changed underneath us recently, > and perhaps we should be looking at abstracting that away somewhere > (like libmount that is part of util-linux). In the short term anyway > we should fix up the above warts within df. I'm not sure about such an abstraction. Actually, the mount_list is already abstracted ... by gnulib. And that's the biggest difference to the situation in util-linux: while util-linux only has to run on GNU/Linux, coreutils' df has to run on a big variety of systems including far-off systems like cygwin. I think if we find a way to ignore such non-accessible file systems without producing too many annoying warnings, then I'd say we're off the hook. Namespaces have been invented to hide mounts, so people shouldn't wonder that they are hidden to df. ;-) Have a nice day, Berny From MAILER-DAEMON Tue Jan 28 06:14:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W86cU-0006Ew-Fc for mharc-bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:14:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W86cL-0006CV-Sj for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W86cE-00060B-JF for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:14:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:52918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W86cE-000603-EO for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W86cE-0002WO-1c for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 28 Jan 2014 11:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.13909075939622 (code B ref 16539); Tue, 28 Jan 2014 11:14:01 +0000 Received: (at 16539) by debbugs.gnu.org; 28 Jan 2014 11:13:13 +0000 Received: from localhost ([127.0.0.1]:38704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W86bR-0002V7-1g for submit@debbugs.gnu.org; Tue, 28 Jan 2014 06:13:13 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:51308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W86bO-0002Ux-2L for 16539@debbugs.gnu.org; Tue, 28 Jan 2014 06:13:10 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0Mh8wH-1VugTk1byz-00MUCz; Tue, 28 Jan 2014 12:13:01 +0100 Message-ID: <52E790BC.2030303@bernhard-voelker.de> Date: Tue, 28 Jan 2014 12:13:00 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> <52E4F174.9040602@draigBrady.com> <52E59BDE.9020206@bernhard-voelker.de> <52E5B108.5080304@draigBrady.com> <52E6E1F6.2040803@bernhard-voelker.de> In-Reply-To: <52E6E1F6.2040803@bernhard-voelker.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:RQzc8eyPaph524PSPHPz4CdfSqL7aJcB5On0c17gVYx MrmvBkKgNE3AnfK2a8t1r063hP5lPZjyWS0EL73NvR/uK+3E+b 1uExEDHQAYahoCqYTa4DLYerVidOTYyMq3qUZB+PYj0SFI6UI6 TZgP8K30dTO8wjNncZVAO1ve/fXGo1YXXyIJDexzA0WaCQuh0n cWD1eoa2w/5tZ+NLmxCxB7ssbuwM9g5htYrElFB/ObbZS5C76u dWgH2sv2rDQcIDPKmy834wPMlIIydrVF3Xq17wVXpuZfpnUV1D eChdHSxGtXcRx1nYjnpxLcGsLTtZ2NPji4VILzodqkTRBY9wxc wAwa4Cm/CeaEk3AUjNjuGXvIyLqav+hvmszHB9NHx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2014 11:14:17 -0000 On 01/27/2014 11:47 PM, Bernhard Voelker wrote: > On 01/27/2014 02:06 AM, Pádraig Brady wrote: >> wrt c) and annoying warnings, I also notice `df -a` on a default Fedora 20 install here, >> giving multiple duplicate warnings like: >> df: ‘net:[4026532416]’: No such file or directory >> df: ‘net:[4026532416]’: No such file or directory >> That's due to: >> $ grep net: /proc/mounts >> proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 >> proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 >> Which is due to support for namespaces. > > Ugh ... and that's a third problm class for df. ;-( > >> Seems like we should not try to lookup non absolute mount points? > > yes, that's probably our best chance. Thinking further, this is mandatory: $ touch 'net:[4026532416]' This would make the stat() in df succeed and lead to wrong output. Have a nice day, Berny From MAILER-DAEMON Tue Jan 28 06:35:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W86wo-0008ML-Mj for mharc-bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:35:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W86wh-0008K5-BD for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:35:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W86wZ-0004mf-LB for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:35:11 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:52930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W86wZ-0004kf-HZ for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W86wY-00035N-En for bug-coreutils@gnu.org; Tue, 28 Jan 2014 06:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16539: More details on df command output for you Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 28 Jan 2014 11:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16539 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Received: via spool by 16539-submit@debbugs.gnu.org id=B16539.139090886811811 (code B ref 16539); Tue, 28 Jan 2014 11:35:02 +0000 Received: (at 16539) by debbugs.gnu.org; 28 Jan 2014 11:34:28 +0000 Received: from localhost ([127.0.0.1]:38716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W86vz-00034R-Mt for submit@debbugs.gnu.org; Tue, 28 Jan 2014 06:34:28 -0500 Received: from mail5.vodafone.ie ([213.233.128.176]:28927) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W86vx-00034H-6o for 16539@debbugs.gnu.org; Tue, 28 Jan 2014 06:34:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQBADuV51JtTnZ1/2dsb2JhbAANTYcXtlKDBoEngxkBAQEEIw8BRhALDQEKAgIFFgsCAgkDAgECAUUGDQEHAQGIBqhjdp91F4EpjVYHgm+BSQEDnxiOXA Received: from unknown (HELO [192.168.1.79]) ([109.78.118.117]) by mail3.vodafone.ie with ESMTP; 28 Jan 2014 11:34:23 +0000 Message-ID: <52E795BE.2050902@draigBrady.com> Date: Tue, 28 Jan 2014 11:34:22 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <67f0ced2351b31a6ac4523659f306b25@msmail.compro.net> <3ce9319232fc3427c2ecefb1d68df226@msmail.compro.net> <52E2E8BF.1000700@bernhard-voelker.de> <52E32D5D.2030900@draigBrady.com> <52E44EE4.9020503@bernhard-voelker.de> <52E4F174.9040602@draigBrady.com> <52E59BDE.9020206@bernhard-voelker.de> <52E5B108.5080304@draigBrady.com> <52E6E1F6.2040803@bernhard-voelker.de> <52E790BC.2030303@bernhard-voelker.de> In-Reply-To: <52E790BC.2030303@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16539@debbugs.gnu.org, crubel@compro.net X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2014 11:35:17 -0000 On 01/28/2014 11:13 AM, Bernhard Voelker wrote: > On 01/27/2014 11:47 PM, Bernhard Voelker wrote: >> On 01/27/2014 02:06 AM, Pádraig Brady wrote: >>> wrt c) and annoying warnings, I also notice `df -a` on a default Fedora 20 install here, >>> giving multiple duplicate warnings like: >>> df: ‘net:[4026532416]’: No such file or directory >>> df: ‘net:[4026532416]’: No such file or directory >>> That's due to: >>> $ grep net: /proc/mounts >>> proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 >>> proc net:[4026532416] proc rw,nosuid,nodev,noexec,relatime 0 0 >>> Which is due to support for namespaces. >> >> Ugh ... and that's a third problm class for df. ;-( >> >>> Seems like we should not try to lookup non absolute mount points? >> >> yes, that's probably our best chance. > > Thinking further, this is mandatory: > > $ touch 'net:[4026532416]' > > This would make the stat() in df succeed and lead to wrong output. OK I'll do a patchset for these df issue this evening hopefully. thanks, Pádraig. From MAILER-DAEMON Tue Jan 28 08:27:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W88h7-0008Vf-G3 for mharc-bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:27:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W88h1-0008VS-JI for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W88gw-00040o-Qg for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:27:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:52972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W88gw-00040j-NT for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W88gw-0006xB-7G for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16578: Wish: Support for non-native endianness in od Resent-From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 28 Jan 2014 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16578 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16578@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139091561326711 (code B ref -1); Tue, 28 Jan 2014 13:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2014 13:26:53 +0000 Received: from localhost ([127.0.0.1]:38758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W88gn-0006wk-12 for submit@debbugs.gnu.org; Tue, 28 Jan 2014 08:26:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42792) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W88gk-0006wb-CP for submit@debbugs.gnu.org; Tue, 28 Jan 2014 08:26:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W88gf-0003yW-GP for submit@debbugs.gnu.org; Tue, 28 Jan 2014 08:26:49 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:37598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W88gf-0003yS-D1 for submit@debbugs.gnu.org; Tue, 28 Jan 2014 08:26:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W88ga-0008U8-Rf for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:26:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W88gZ-0003we-QB for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:26:40 -0500 Received: from bacon.lysator.liu.se ([2001:6b0:17:f0a0::ce]:51918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W88gZ-0003uH-E5 for bug-coreutils@gnu.org; Tue, 28 Jan 2014 08:26:39 -0500 Received: from bacon.lysator.liu.se (localhost [127.0.0.1]) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5) with ESMTP id s0SCsl6G019526 for ; Tue, 28 Jan 2014 13:54:47 +0100 (MET) Received: (from nisse@localhost) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5/Submit) id s0SCsleM019525; Tue, 28 Jan 2014 13:54:47 +0100 (MET) X-Authentication-Warning: bacon.lysator.liu.se: nisse set sender to nisse@lysator.liu.se using -f From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) Date: Tue, 28 Jan 2014 13:54:47 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by bacon.lysator.liu.se id s0SCsl6G019526 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2014 13:27:12 -0000 For the "od" program, it would be nice with a flag to specify the endianness for all types which are larger than a byte. Possible alternatives could be "big endian", "little endian", "native endian". And for floats, besides endianness, it would be nice to be able to specify native format or ieee format, for systems where these are different. Regards, /Niels --=20 Niels M=F6ller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance. From MAILER-DAEMON Tue Jan 28 20:23:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W8Js1-0004f1-OJ for mharc-bug-coreutils@gnu.org; Tue, 28 Jan 2014 20:23:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Jrv-0004e6-Oz for bug-coreutils@gnu.org; Tue, 28 Jan 2014 20:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8Jrq-000769-Vv for bug-coreutils@gnu.org; Tue, 28 Jan 2014 20:23:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:53896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Jrq-000763-SD for bug-coreutils@gnu.org; Tue, 28 Jan 2014 20:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W8Jrq-0003B2-K3 for bug-coreutils@gnu.org; Tue, 28 Jan 2014 20:23:02 -0500 Subject: bug#16336: bug report tail with hfsplus filesystem Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Wed, 29 Jan 2014 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Pieter van Voorst Vader Mail-Followup-To: 16336@debbugs.gnu.org, P@draigBrady.com, pietervvv@gmail.com Received: via spool by 16336-done@debbugs.gnu.org id=D16336.139095855912166 (code D ref 16336); Wed, 29 Jan 2014 01:23:02 +0000 Received: (at 16336-done) by debbugs.gnu.org; 29 Jan 2014 01:22:39 +0000 Received: from localhost ([127.0.0.1]:39682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8JrT-0003AA-IQ for submit@debbugs.gnu.org; Tue, 28 Jan 2014 20:22:39 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:37982) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8JrR-0003A1-Gn for 16336-done@debbugs.gnu.org; Tue, 28 Jan 2014 20:22:38 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAEtX6FJtTnZ1/2dsb2JhbAANTYNEvVuBJYMZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBQIBAYgGCKk9oDoXjn8HhDgBA58Yjlw Received: from unknown (HELO [192.168.1.79]) ([109.78.118.117]) by mail3.vodafone.ie with ESMTP; 29 Jan 2014 01:22:36 +0000 Message-ID: <52E857DB.7050800@draigBrady.com> Date: Wed, 29 Jan 2014 01:22:35 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <52C7A39C.90507@draigBrady.com> In-Reply-To: <52C7A39C.90507@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16336-done@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 01:23:12 -0000 On 01/04/2014 06:01 AM, Pdraig Brady wrote: > On 01/04/2014 03:04 AM, Pieter van Voorst Vader wrote: >> Hi bug-coreutils, >> got this bug in tail for a hfsplus filesystem on ubuntu 13.10 >> >> tail: unrecognized file system type 0x0000482b for serviio.log. please report this to bug-coreutils@gnu.org. reverting to polling > > Cool thanks, we'll add this, probably identified as HFS+ > A little searching also suggests adding 0x4858 for HFSX might be useful also. Pushed fix at: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=b938b6e2 thanks, Pdraig. From MAILER-DAEMON Wed Jan 29 06:57:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W8Tlb-0004kD-5o for mharc-bug-coreutils@gnu.org; Wed, 29 Jan 2014 06:57:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8TlU-0004hd-DF for bug-coreutils@gnu.org; Wed, 29 Jan 2014 06:57:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8TlP-0001yO-RQ for bug-coreutils@gnu.org; Wed, 29 Jan 2014 06:57:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:54076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8TlP-0001yI-NW for bug-coreutils@gnu.org; Wed, 29 Jan 2014 06:57:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W8TlP-00037m-61 for bug-coreutils@gnu.org; Wed, 29 Jan 2014 06:57:03 -0500 Subject: bug#16329: Acknowledgement (`head --lines=-0' prints nothing if no newline at the EOF) Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-To: bug-coreutils@gnu.org Resent-Date: Wed, 29 Jan 2014 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16329 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9_?= =?UTF-8?Q?=D0=A8=D0=B8=D0=BB=D0=B8=D0=BD?= Mail-Followup-To: 16329@debbugs.gnu.org, P@draigBrady.com, rootlexx@mail.ru Received: via spool by 16329-done@debbugs.gnu.org id=D16329.139099658311951 (code D ref 16329); Wed, 29 Jan 2014 11:57:02 +0000 Received: (at 16329-done) by debbugs.gnu.org; 29 Jan 2014 11:56:23 +0000 Received: from localhost ([127.0.0.1]:39862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8Tkk-00036g-Fn for submit@debbugs.gnu.org; Wed, 29 Jan 2014 06:56:22 -0500 Received: from mail3.vodafone.ie ([213.233.128.45]:36018) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8Tkh-00036X-6i for 16329-done@debbugs.gnu.org; Wed, 29 Jan 2014 06:56:20 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsABAJjr6FJtTv4m/2dsb2JhbAANTINEUIMEpzySRIEbgxkBAQEEIwRSEAkCDQQDAQIBCRYLAgIJAwIBAgE9CAYNAQUCAQEWh1cDFgOOEZp7dpcvFYgUF44uAQE+EQcJgmaBSQEDkD6BModqhT6FcYctgT6BcQ Received: from unknown (HELO [192.168.1.79]) ([109.78.254.38]) by mail3.vodafone.ie with ESMTP; 29 Jan 2014 11:55:54 +0000 Message-ID: <52E8EC49.1090103@draigBrady.com> Date: Wed, 29 Jan 2014 11:55:53 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: <1388764256.577663010@f412.i.mail.ru> <1388781627.45947684@f346.i.mail.ru> In-Reply-To: <1388781627.45947684@f346.i.mail.ru> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------030008040109060905060006" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16329-done@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 11:57:13 -0000 This is a multi-part message in MIME format. --------------030008040109060905060006 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 01/03/2014 08:40 PM, Алексей Шилин wrote: > Looks like I was overly cautious about decrementing an unsigned... > > size_t n = bytes_read; > while (n) > { > if (all_lines) > n -= n ? 1 : 0; // ...here. > else > > As it is under `while (n)' statement, n is always true here, and thus the ternary operator, though makes no > harm, is needless, and the whole line can be replaced with just `n--;'. Sorry for that. > > The fixed version of the original patch is attached. > I've updated the patch to also handle the pipe case, and I added a test. Will push soon. thanks, Pádraig. --------------030008040109060905060006 Content-Type: text/x-patch; name="head--lines-0.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="head--lines-0.patch" >From b1387eb3e922398ab90cf6aa63cac6dea37971fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B5=D0=B9=20=D0=A8=D0=B8=D0?= =?UTF-8?q?=BB=D0=B8=D0=BD?= Date: Wed, 29 Jan 2014 01:23:46 +0000 Subject: [PATCH] head: fix --lines=-0 outputting nothing if no newline at EOF * src/head.c (elide_tail_lines_pipe): Just output all input in this case to avoid the issue and also avoid redundant '\n' processing. (elide_tail_lines_seekable): Likewise. * tests/misc/head-elide-tail.pl: Add tests for no '\n' at EOF. * NEWS: Mention the fix. Fixes http://bugs.gnu.org/16329 --- NEWS | 4 ++++ src/head.c | 27 +++++++++++++++++++++------ tests/misc/head-elide-tail.pl | 7 +++++-- 3 files changed, 30 insertions(+), 8 deletions(-) diff --git a/NEWS b/NEWS index e091d18..f86e589 100644 --- a/NEWS +++ b/NEWS @@ -14,6 +14,10 @@ GNU coreutils NEWS -*- outline -*- when reading the SELinux context for a file. [bug introduced in coreutils-8.22] + head --lines=-0, when the input does not contain a trailing '\n', + now copies all input to stdout. Previously nothing was output in this case. + [bug introduced with the --lines=-N feature in coreutils-5.0.1] + ln -sf now replaces symbolic links whose targets can't exist. Previously it would display an error, requiring --no-dereference to avoid the issue. [bug introduced in coreutils-5.3.0] diff --git a/src/head.c b/src/head.c index ddaa990..ef368d7 100644 --- a/src/head.c +++ b/src/head.c @@ -501,6 +501,13 @@ elide_tail_lines_pipe (const char *filename, int fd, uintmax_t n_elide) n_read = safe_read (fd, tmp->buffer, BUFSIZ); if (n_read == 0 || n_read == SAFE_READ_ERROR) break; + + if (! n_elide) + { + fwrite (tmp->buffer, 1, n_read, stdout); + continue; + } + tmp->nbytes = n_read; tmp->nlines = 0; tmp->next = NULL; @@ -636,8 +643,11 @@ elide_tail_lines_seekable (const char *pretty_filename, int fd, return false; } + /* n_lines == 0 case needs special treatment. */ + const bool all_lines = !n_lines; + /* Count the incomplete line on files that don't end with a newline. */ - if (bytes_read && buffer[bytes_read - 1] != '\n') + if (n_lines && bytes_read && buffer[bytes_read - 1] != '\n') --n_lines; while (1) @@ -647,11 +657,16 @@ elide_tail_lines_seekable (const char *pretty_filename, int fd, size_t n = bytes_read; while (n) { - char const *nl; - nl = memrchr (buffer, '\n', n); - if (nl == NULL) - break; - n = nl - buffer; + if (all_lines) + n -= 1; + else + { + char const *nl; + nl = memrchr (buffer, '\n', n); + if (nl == NULL) + break; + n = nl - buffer; + } if (n_lines-- == 0) { /* Found it. */ diff --git a/tests/misc/head-elide-tail.pl b/tests/misc/head-elide-tail.pl index 758e1c9..3c178d6 100755 --- a/tests/misc/head-elide-tail.pl +++ b/tests/misc/head-elide-tail.pl @@ -52,6 +52,8 @@ my @Tests = ['elide-l2', "--lines=-1", {IN=>"a"}, {OUT=>''}], ['elide-l3', "--lines=-1", {IN=>"a\nb"}, {OUT=>"a\n"}], ['elide-l4', "--lines=-1", {IN=>"a\nb\n"}, {OUT=>"a\n"}], + ['elide-l5', "--lines=-0", {IN=>"a\nb\n"}, {OUT=>"a\nb\n"}], + ['elide-l6', "--lines=-0", {IN=>"a\nb"}, {OUT=>"a\nb"}], ); if ($ENV{RUN_EXPENSIVE_TESTS}) @@ -80,9 +82,10 @@ if ($ENV{RUN_EXPENSIVE_TESTS}) } $s =~ s/(.)/$1\n/g; - for my $file_size (0..20) + $s .= 'u'; # test without trailing '\n' + for my $file_size (0..21) { - for my $n_elide (0..20) + for my $n_elide (0..21) { my $input = substr $s, 0, 2 * $file_size; my $out_len = $n_elide < $file_size ? $file_size - $n_elide : 0; -- 1.7.7.6 --------------030008040109060905060006-- From MAILER-DAEMON Wed Jan 29 16:45:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W8cwf-00013J-64 for mharc-bug-coreutils@gnu.org; Wed, 29 Jan 2014 16:45:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8cwX-0000yi-SZ for bug-coreutils@gnu.org; Wed, 29 Jan 2014 16:45:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8cwR-0002h3-Re for bug-coreutils@gnu.org; Wed, 29 Jan 2014 16:45:09 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:54929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8cwR-0002g9-Nr for bug-coreutils@gnu.org; Wed, 29 Jan 2014 16:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W8cwQ-0002OS-W4 for bug-coreutils@gnu.org; Wed, 29 Jan 2014 16:45:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16578: Wish: Support for non-native endianness in od Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 29 Jan 2014 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16578 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Niels =?UTF-8?Q?M=C3=B6ller?= Received: via spool by 16578-submit@debbugs.gnu.org id=B16578.13910318899161 (code B ref 16578); Wed, 29 Jan 2014 21:45:02 +0000 Received: (at 16578) by debbugs.gnu.org; 29 Jan 2014 21:44:49 +0000 Received: from localhost ([127.0.0.1]:40715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8cwC-0002Ne-Cb for submit@debbugs.gnu.org; Wed, 29 Jan 2014 16:44:48 -0500 Received: from mail6.vodafone.ie ([213.233.128.184]:4935) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W8cw8-0002NT-Qz for 16578@debbugs.gnu.org; Wed, 29 Jan 2014 16:44:45 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBACd16VJtTv4m/2dsb2JhbAANTL4igwaBHIMZAQEBAwEyAUYFCwsNCwkWDwkDAgECAUUGDQEHAQGHeQ2pfaAoF45/B4Q4AQOUQIpYjlw Received: from unknown (HELO [192.168.1.79]) ([109.78.254.38]) by mail3.vodafone.ie with ESMTP; 29 Jan 2014 21:44:42 +0000 Message-ID: <52E97649.6010905@draigBrady.com> Date: Wed, 29 Jan 2014 21:44:41 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16578@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2014 21:45:15 -0000 On 01/28/2014 12:54 PM, Niels Mller wrote: > For the "od" program, it would be nice with a flag to specify the > endianness for all types which are larger than a byte. Possible > alternatives could be "big endian", "little endian", "native endian". I agree this would be useful and easy enough to add. I suppose the interface would be --endian=little|big We could augment that with specific byte order spec, but those two are probably enough. > And for floats, besides endianness, it would be nice to be able to > specify native format or ieee format, for systems where these are > different. That's a bit less useful I think and harder to implement. We say this in the info docs: "Almost all modern systems use IEEE-754 floating point, and it is typically portable to assume IEEE-754 behavior these days." thanks, Pdraig. From MAILER-DAEMON Fri Jan 31 01:45:44 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W97rD-0006HN-Un for mharc-bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:45:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W97VQ-0002ez-QN for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:23:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W97VG-0002Ct-Jl for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:23:12 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:56432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W97VG-0002Cp-F5 for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W97VG-0005qM-1r for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16606: date command throws error when DST is turned on Resent-From: "Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco)" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jan 2014 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16606 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 16606@debbugs.gnu.org X-Debbugs-Original-To: "bug-coreutils@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.139114937222438 (code B ref -1); Fri, 31 Jan 2014 06:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jan 2014 06:22:52 +0000 Received: from localhost ([127.0.0.1]:42218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W97V5-0005pp-SO for submit@debbugs.gnu.org; Fri, 31 Jan 2014 01:22:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W97Jc-0005WC-IK for submit@debbugs.gnu.org; Fri, 31 Jan 2014 01:11:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W97JU-0007bx-Ah for submit@debbugs.gnu.org; Fri, 31 Jan 2014 01:11:00 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:48518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W97JU-0007bn-7E for submit@debbugs.gnu.org; Fri, 31 Jan 2014 01:10:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W97JN-0001oA-8L for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:10:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W97JG-0007ar-A8 for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:10:45 -0500 Received: from alln-iport-8.cisco.com ([173.37.142.95]:2865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W97JG-0007ai-0u for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:10:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6877; q=dns/txt; s=iport; t=1391148638; x=1392358238; h=from:to:subject:date:message-id:mime-version; bh=4aAcz/Wco68tsKC08XRK+Cw12IPI5A5i27IwOdSTrD0=; b=ZrlsI5Ik8f2Me5N++i0Hk0p3HCgVvamYTXpvRaIQc3uOMn77wfeeKURO FUNrvsWnEsQ30wdNW1A/tUhDOVNdHT0M8jc1ofjeM+rAPRgu+U43vBmeM BD8gfWPP/Zt0ldl8P6IAg0hbBnsjlSWJVgJf+1ONTaitKx665XgrlzrPG U=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai8FAFg961KtJXHA/2dsb2JhbABZgkhEOFe6K4MIgQwWdIInAQQtXgEqQxMmAQQbh32cabA5F45Rg1yBFASOY5tngy2CKg X-IronPort-AV: E=Sophos; i="4.95,755,1384300800"; d="scan'208,217"; a="16916243" Received: from rcdn-core2-5.cisco.com ([173.37.113.192]) by alln-iport-8.cisco.com with ESMTP; 31 Jan 2014 06:10:36 +0000 Received: from xhc-rcd-x08.cisco.com (xhc-rcd-x08.cisco.com [173.37.183.82]) by rcdn-core2-5.cisco.com (8.14.5/8.14.5) with ESMTP id s0V6AaL7032424 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Fri, 31 Jan 2014 06:10:36 GMT Received: from xmb-aln-x02.cisco.com ([169.254.5.76]) by xhc-rcd-x08.cisco.com ([173.37.183.82]) with mapi id 14.03.0123.003; Fri, 31 Jan 2014 00:10:36 -0600 From: "Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco)" Thread-Topic: date command throws error when DST is turned on Thread-Index: Ac8eSyPqKScip3B6Q5a8MveIDv7TDA== Date: Fri, 31 Jan 2014 06:10:36 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.202.80] MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 31 Jan 2014 01:22:49 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Fri, 31 Jan 2014 01:45:42 -0500 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 06:23:21 -0000 Hi, The date command throws error when the DST is turned on. # date +%s -d "2013/11/20" 1384912800 # date +%s -d "2013/10/20" date: invalid date `2013/10/20' 1 sec after Oct 19 23:59:59 2013 becomes Oct 20 01:00:00 2013 As there is no 0th hour on Oct 20, it shows invalid date. Are there any options to fix this problems ? Has there been a patch posted for this. #date Sun Mar 10 07:02:07 BRT 2013 # zdump -v /etc/localtime | grep 2013 /etc/localtime Sun Feb 17 01:59:59 2013 UTC =3D Sat Feb 16 23:59:59 2013 BR= ST isdst=3D1 gmtoff=3D-7200 /etc/localtime Sun Feb 17 02:00:00 2013 UTC =3D Sat Feb 16 23:00:00 2013 BR= T isdst=3D0 gmtoff=3D-10800 /etc/localtime Sun Oct 20 02:59:59 2013 UTC =3D Sat Oct 19 23:59:59 2013 BR= T isdst=3D0 gmtoff=3D-10800 /etc/localtime Sun Oct 20 03:00:00 2013 UTC =3D Sun Oct 20 01:00:00 2013 BR= ST isdst=3D1 gmtoff=3D-7200 Thanks, Lakshmi From MAILER-DAEMON Fri Jan 31 01:58:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W983M-0007qO-F2 for mharc-bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:58:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W983G-0007pW-DK for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9839-0003Di-Af for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:58:10 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:56455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9839-0003DZ-79 for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:58:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W9838-0006ls-47 for bug-coreutils@gnu.org; Fri, 31 Jan 2014 01:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16578: Wish: Support for non-native endianness in od Resent-From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jan 2014 06:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16578 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16578-submit@debbugs.gnu.org id=B16578.139115142725956 (code B ref 16578); Fri, 31 Jan 2014 06:58:01 +0000 Received: (at 16578) by debbugs.gnu.org; 31 Jan 2014 06:57:07 +0000 Received: from localhost ([127.0.0.1]:42241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W982E-0006ka-2Q for submit@debbugs.gnu.org; Fri, 31 Jan 2014 01:57:06 -0500 Received: from bacon.lysator.liu.se ([130.236.254.206]:40896) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W982A-0006k9-O9 for 16578@debbugs.gnu.org; Fri, 31 Jan 2014 01:57:04 -0500 Received: from bacon.lysator.liu.se (localhost [127.0.0.1]) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5) with ESMTP id s0V6v1Ov018809; Fri, 31 Jan 2014 07:57:01 +0100 (MET) Received: (from nisse@localhost) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5/Submit) id s0V6v0vk018804; Fri, 31 Jan 2014 07:57:00 +0100 (MET) X-Authentication-Warning: bacon.lysator.liu.se: nisse set sender to nisse@lysator.liu.se using -f From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) References: <52E97649.6010905@draigBrady.com> Date: Fri, 31 Jan 2014 07:57:00 +0100 In-Reply-To: <52E97649.6010905@draigBrady.com> ("=?UTF-8?Q?P=C3=A1draig?= Brady"'s message of "Wed, 29 Jan 2014 21:44:41 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16578@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 06:58:15 -0000 Pdraig Brady writes: > On 01/28/2014 12:54 PM, Niels Mller wrote: >> For the "od" program, it would be nice with a flag to specify the >> endianness for all types which are larger than a byte. Possible >> alternatives could be "big endian", "little endian", "native endian". > > I agree this would be useful and easy enough to add. > I suppose the interface would be --endian=little|big Maybe I can have a look at what it takes. >> And for floats, besides endianness, it would be nice to be able to >> specify native format or ieee format, for systems where these are >> different. > > That's a bit less useful I think and harder to implement. I agree that's a bit more obscure. So I understand if you don't want to do that until there's some concrete usecase. Endianness for float types should be easier, I hope. Regards, /Niels -- Niels Mller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance. From MAILER-DAEMON Fri Jan 31 02:18:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W98Mf-0002pr-Qz for mharc-bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:18:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98Ma-0002om-7L for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:18:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W98MV-0008Jx-DY for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:18:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:56476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98MV-0008Jt-AK for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:18:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W98MU-0007Gw-LX for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16606: date command throws error when DST is turned on Resent-From: Bob Proulx Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jan 2014 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16606 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: "Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco)" Received: via spool by 16606-submit@debbugs.gnu.org id=B16606.139115264527898 (code B ref 16606); Fri, 31 Jan 2014 07:18:02 +0000 Received: (at 16606) by debbugs.gnu.org; 31 Jan 2014 07:17:25 +0000 Received: from localhost ([127.0.0.1]:42260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W98Ls-0007Fq-CA for submit@debbugs.gnu.org; Fri, 31 Jan 2014 02:17:25 -0500 Received: from joseki.proulx.com ([216.17.153.58]:33051) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W98Lo-0007Fe-Dc; Fri, 31 Jan 2014 02:17:21 -0500 Received: from hysteria.proulx.com (hysteria.proulx.com [192.168.230.119]) by joseki.proulx.com (Postfix) with ESMTP id 48EF521227; Fri, 31 Jan 2014 00:17:19 -0700 (MST) Received: by hysteria.proulx.com (Postfix, from userid 1000) id 221E02DC46; Fri, 31 Jan 2014 00:17:19 -0700 (MST) Date: Fri, 31 Jan 2014 00:17:19 -0700 From: Bob Proulx Message-ID: <20140131071719.GA8676@hysteria.proulx.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16606@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 07:18:13 -0000 tag 16606 +notabug close 16606 thanks Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco) wrote: > The date command throws error when the DST is turned on. > > # date +%s -d "2013/11/20" > 1384912800 > # date +%s -d "2013/10/20" > date: invalid date `2013/10/20' > > 1 sec after Oct 19 23:59:59 2013 becomes Oct 20 01:00:00 2013 > As there is no 0th hour on Oct 20, it shows invalid date. You are completely correct that there is no midnight in your timezone and therefore the date you are requesting *in your timezone* does not exist and therefore it is an invalid date. The date command is working correctly in reporting it as an invalid date. I will emphasize that this is timezone specific behavior. > Are there any options to fix this problems ? > Has there been a patch posted for this. The option to fix this is the -u option to select UTC. No patches are needed. The best choice is to work with dates in the UTC timezone which avoids all DST issues since UTC never changes and never skips seconds. The second best choice is to work with times around noon which avoids DST time changes that usually happen at night. These hints are discussed in the FAQ entry in more detail. You didn't say what specific timezone you were concerned with so I will pick one at random for an example. $ env TZ=America/Sao_Paulo date -R -d "2013/10/20" date: invalid date ‘2013/10/20’ That date at midnight does not exist in that timezone. $ env TZ=America/Sao_Paulo date -R -d "2013/10/20 12:00" Sun, 20 Oct 2013 12:00:00 -0200 Using 12:00 noon avoids the skipped interval. $ date -u -R -d "2013/10/20" Sun, 20 Oct 2013 00:00:00 +0000 Using UTC avoids the problem because UTC doesn't skip intervals for DST. I also didn't show setting a default timezone (TZ) because that is also not matter when using UTC. It is just simpler all around. Please see the FAQ entry where this is explained in detail. http://www.gnu.org/software/coreutils/faq/coreutils-faq.html#The-date-command-is-not-working-right_002e Bob From MAILER-DAEMON Fri Jan 31 02:57:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W98yR-0001h7-3I for mharc-bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:57:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98yK-0001gy-BB for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:57:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W98yE-0002A3-BT for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:57:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:56496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98yE-00029z-7B for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W98yD-00024d-MM for bug-coreutils@gnu.org; Fri, 31 Jan 2014 02:57:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16606: date command throws error when DST is turned on Resent-From: "Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco)" Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jan 2014 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16606 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: notabug To: Bob Proulx Received: via spool by 16606-submit@debbugs.gnu.org id=B16606.13911550027932 (code B ref 16606); Fri, 31 Jan 2014 07:57:01 +0000 Received: (at 16606) by debbugs.gnu.org; 31 Jan 2014 07:56:42 +0000 Received: from localhost ([127.0.0.1]:42279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W98xt-00023r-Q1 for submit@debbugs.gnu.org; Fri, 31 Jan 2014 02:56:42 -0500 Received: from rcdn-iport-5.cisco.com ([173.37.86.76]:7654) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W98xq-00023e-7n for 16606@debbugs.gnu.org; Fri, 31 Jan 2014 02:56:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3338; q=dns/txt; s=iport; t=1391154998; x=1392364598; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bcZXzwRjFmRY1etOlmnF8gd2Hvqbex1NuLjku+3pYtM=; b=Srk0LcuFGRvoWV17pTnd+xzqpUsZBAH9gGaUXqzJJkuVtAgx9kZ+I1pE gjQjzMhQHgowMKanfe4eaV42ueQKtLwmA7P9TsWPnBPjBYmvyqIbnBSoJ UHsOWJdUqySQJsmHtaIRoDFPxPV4vC/99c5Lj5I4xbaItrEVcjCmGBm3W Y=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: An8FADVW61KtJV2d/2dsb2JhbABZgww4V4MBujQYbhZ0giUBAQEDASMRRQUHBAIBCBEEAQEBAgIGHQMCAgIdExQBCAgBAQQOBQgBh3QIDatToSUXgSmNAScWGwcGgmk1gRQEjmObZ4MtgWhC X-IronPort-AV: E=Sophos;i="4.95,756,1384300800"; d="scan'208";a="300946871" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-5.cisco.com with ESMTP; 31 Jan 2014 07:56:37 +0000 Received: from xhc-aln-x03.cisco.com (xhc-aln-x03.cisco.com [173.36.12.77]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id s0V7uak1028824 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 31 Jan 2014 07:56:36 GMT Received: from xmb-aln-x02.cisco.com ([169.254.5.76]) by xhc-aln-x03.cisco.com ([173.36.12.77]) with mapi id 14.03.0123.003; Fri, 31 Jan 2014 01:56:36 -0600 From: "Lakshmi Ramamurthi -X (lramamur - HCL TECHNOLOGIES LIMITED at Cisco)" Thread-Topic: bug#16606: date command throws error when DST is turned on Thread-Index: Ac8eSyPqKScip3B6Q5a8MveIDv7TDAAO6CyAAAs2HcA= Date: Fri, 31 Jan 2014 07:56:35 +0000 Message-ID: References: <20140131071719.GA8676@hysteria.proulx.com> In-Reply-To: <20140131071719.GA8676@hysteria.proulx.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.202.80] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: "16606@debbugs.gnu.org" <16606@debbugs.gnu.org> X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 07:57:14 -0000 VGhhbmtzIGEgbG90IGZvciB5b3VyIHF1aWNrIHJlcGx5Lg0KDQotTGFrc2htaQ0KDQotLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogQm9iIFByb3VseCBbbWFpbHRvOmJvYkBwcm91bHgu Y29tXSANClNlbnQ6IEZyaWRheSwgSmFudWFyeSAzMSwgMjAxNCAxMjo0NyBQTQ0KVG86IExha3No bWkgUmFtYW11cnRoaSAtWCAobHJhbWFtdXIgLSBIQ0wgVEVDSE5PTE9HSUVTIExJTUlURUQgYXQg Q2lzY28pDQpDYzogMTY2MDZAZGViYnVncy5nbnUub3JnDQpTdWJqZWN0OiBSZTogYnVnIzE2NjA2 OiBkYXRlIGNvbW1hbmQgdGhyb3dzIGVycm9yIHdoZW4gRFNUIGlzIHR1cm5lZCBvbg0KDQp0YWcg MTY2MDYgK25vdGFidWcNCmNsb3NlIDE2NjA2DQp0aGFua3MNCg0KTGFrc2htaSBSYW1hbXVydGhp IC1YIChscmFtYW11ciAtIEhDTCBURUNITk9MT0dJRVMgTElNSVRFRCBhdCBDaXNjbykgd3JvdGU6 DQo+IFRoZSBkYXRlIGNvbW1hbmQgdGhyb3dzIGVycm9yIHdoZW4gdGhlIERTVCBpcyB0dXJuZWQg b24uDQo+IA0KPiAjIGRhdGUgKyVzIC1kICIyMDEzLzExLzIwIg0KPiAxMzg0OTEyODAwDQo+ICMg ZGF0ZSArJXMgLWQgIjIwMTMvMTAvMjAiDQo+IGRhdGU6IGludmFsaWQgZGF0ZSBgMjAxMy8xMC8y MCcNCj4NCj4gMSBzZWMgYWZ0ZXIgT2N0IDE5IDIzOjU5OjU5IDIwMTMgYmVjb21lcyBPY3QgMjAg MDE6MDA6MDAgMjAxMyBBcyB0aGVyZSANCj4gaXMgbm8gMHRoIGhvdXIgb24gT2N0IDIwLCBpdCBz aG93cyBpbnZhbGlkIGRhdGUuDQoNCllvdSBhcmUgY29tcGxldGVseSBjb3JyZWN0IHRoYXQgdGhl cmUgaXMgbm8gbWlkbmlnaHQgaW4geW91ciB0aW1lem9uZSBhbmQgdGhlcmVmb3JlIHRoZSBkYXRl IHlvdSBhcmUgcmVxdWVzdGluZyAqaW4geW91ciB0aW1lem9uZSogZG9lcyBub3QgZXhpc3QgYW5k IHRoZXJlZm9yZSBpdCBpcyBhbiBpbnZhbGlkIGRhdGUuICBUaGUgZGF0ZSBjb21tYW5kIGlzIHdv cmtpbmcgY29ycmVjdGx5IGluIHJlcG9ydGluZyBpdCBhcyBhbiBpbnZhbGlkIGRhdGUuICBJIHdp bGwgZW1waGFzaXplIHRoYXQgdGhpcyBpcyB0aW1lem9uZSBzcGVjaWZpYyBiZWhhdmlvci4NCg0K PiBBcmUgdGhlcmUgYW55IG9wdGlvbnMgdG8gZml4IHRoaXMgcHJvYmxlbXMgPw0KPiBIYXMgdGhl cmUgYmVlbiBhIHBhdGNoIHBvc3RlZCBmb3IgdGhpcy4NCg0KVGhlIG9wdGlvbiB0byBmaXggdGhp cyBpcyB0aGUgLXUgb3B0aW9uIHRvIHNlbGVjdCBVVEMuICBObyBwYXRjaGVzIGFyZSBuZWVkZWQu DQoNClRoZSBiZXN0IGNob2ljZSBpcyB0byB3b3JrIHdpdGggZGF0ZXMgaW4gdGhlIFVUQyB0aW1l em9uZSB3aGljaCBhdm9pZHMgYWxsIERTVCBpc3N1ZXMgc2luY2UgVVRDIG5ldmVyIGNoYW5nZXMg YW5kIG5ldmVyIHNraXBzIHNlY29uZHMuICBUaGUgc2Vjb25kIGJlc3QgY2hvaWNlIGlzIHRvIHdv cmsgd2l0aCB0aW1lcyBhcm91bmQgbm9vbiB3aGljaCBhdm9pZHMgRFNUIHRpbWUgY2hhbmdlcyB0 aGF0IHVzdWFsbHkgaGFwcGVuIGF0IG5pZ2h0LiAgVGhlc2UgaGludHMgYXJlIGRpc2N1c3NlZCBp biB0aGUgRkFRIGVudHJ5IGluIG1vcmUgZGV0YWlsLg0KDQpZb3UgZGlkbid0IHNheSB3aGF0IHNw ZWNpZmljIHRpbWV6b25lIHlvdSB3ZXJlIGNvbmNlcm5lZCB3aXRoIHNvIEkgd2lsbCBwaWNrIG9u ZSBhdCByYW5kb20gZm9yIGFuIGV4YW1wbGUuDQoNCiAgJCBlbnYgVFo9QW1lcmljYS9TYW9fUGF1 bG8gZGF0ZSAtUiAtZCAiMjAxMy8xMC8yMCINCiAgZGF0ZTogaW52YWxpZCBkYXRlIOKAmDIwMTMv MTAvMjDigJkNCg0KVGhhdCBkYXRlIGF0IG1pZG5pZ2h0IGRvZXMgbm90IGV4aXN0IGluIHRoYXQg dGltZXpvbmUuDQoNCiAgJCBlbnYgVFo9QW1lcmljYS9TYW9fUGF1bG8gZGF0ZSAtUiAtZCAiMjAx My8xMC8yMCAxMjowMCINCiAgU3VuLCAyMCBPY3QgMjAxMyAxMjowMDowMCAtMDIwMA0KDQpVc2lu ZyAxMjowMCBub29uIGF2b2lkcyB0aGUgc2tpcHBlZCBpbnRlcnZhbC4NCg0KICAkIGRhdGUgLXUg LVIgLWQgIjIwMTMvMTAvMjAiDQogIFN1biwgMjAgT2N0IDIwMTMgMDA6MDA6MDAgKzAwMDANCg0K VXNpbmcgVVRDIGF2b2lkcyB0aGUgcHJvYmxlbSBiZWNhdXNlIFVUQyBkb2Vzbid0IHNraXAgaW50 ZXJ2YWxzIGZvciBEU1QuICBJIGFsc28gZGlkbid0IHNob3cgc2V0dGluZyBhIGRlZmF1bHQgdGlt ZXpvbmUgKFRaKSBiZWNhdXNlIHRoYXQgaXMgYWxzbyBub3QgbWF0dGVyIHdoZW4gdXNpbmcgVVRD LiAgSXQgaXMganVzdCBzaW1wbGVyIGFsbCBhcm91bmQuDQoNClBsZWFzZSBzZWUgdGhlIEZBUSBl bnRyeSB3aGVyZSB0aGlzIGlzIGV4cGxhaW5lZCBpbiBkZXRhaWwuDQoNCiAgaHR0cDovL3d3dy5n bnUub3JnL3NvZnR3YXJlL2NvcmV1dGlscy9mYXEvY29yZXV0aWxzLWZhcS5odG1sI1RoZS1kYXRl LWNvbW1hbmQtaXMtbm90LXdvcmtpbmctcmlnaHRfMDAyZQ0KDQpCb2INCg== From MAILER-DAEMON Fri Jan 31 03:45:13 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W99ir-0003ZK-DY for mharc-bug-coreutils@gnu.org; Fri, 31 Jan 2014 03:45:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W99il-0003XA-MT for bug-coreutils@gnu.org; Fri, 31 Jan 2014 03:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W99ih-0006KI-Ab for bug-coreutils@gnu.org; Fri, 31 Jan 2014 03:45:07 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:56558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W99ih-0006Ix-6W for bug-coreutils@gnu.org; Fri, 31 Jan 2014 03:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W99ig-0005cr-2W for bug-coreutils@gnu.org; Fri, 31 Jan 2014 03:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#16578: Wish: Support for non-native endianness in od Resent-From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jan 2014 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16578 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady Received: via spool by 16578-submit@debbugs.gnu.org id=B16578.139115790121604 (code B ref 16578); Fri, 31 Jan 2014 08:45:01 +0000 Received: (at 16578) by debbugs.gnu.org; 31 Jan 2014 08:45:01 +0000 Received: from localhost ([127.0.0.1]:42344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W99id-0005cL-Oa for submit@debbugs.gnu.org; Fri, 31 Jan 2014 03:45:00 -0500 Received: from bacon.lysator.liu.se ([130.236.254.206]:43262) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W99ia-0005c9-D2 for 16578@debbugs.gnu.org; Fri, 31 Jan 2014 03:44:57 -0500 Received: from bacon.lysator.liu.se (localhost [127.0.0.1]) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5) with ESMTP id s0V8is5F021950; Fri, 31 Jan 2014 09:44:54 +0100 (MET) Received: (from nisse@localhost) by bacon.lysator.liu.se (8.14.5+Sun/8.14.5/Submit) id s0V8islU021949; Fri, 31 Jan 2014 09:44:54 +0100 (MET) X-Authentication-Warning: bacon.lysator.liu.se: nisse set sender to nisse@lysator.liu.se using -f From: nisse@lysator.liu.se (Niels =?UTF-8?Q?M=C3=B6ller?=) References: <52E97649.6010905@draigBrady.com> Date: Fri, 31 Jan 2014 09:44:54 +0100 In-Reply-To: ("Niels =?UTF-8?Q?M=C3=B6ller?="'s message of "Fri, 31 Jan 2014 07:57:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16578@debbugs.gnu.org X-BeenThere: bug-coreutils@gnu.org List-Id: GNU coreutils Bug Reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2014 08:45:12 -0000 nisse@lysator.liu.se (Niels Mller) writes: > Pdraig Brady writes: >> I agree this would be useful and easy enough to add. >> I suppose the interface would be --endian=little|big > > Maybe I can have a look at what it takes. Below is a crude patch (missing: usage message, tests cases, docs, translation). I think it should work fine for floats too. I see no obvious and more beautiful way to do it. (And I think I have copyright assignment papers for coreutils in place, since work on factor some year ago). Regards, /Niels diff --git a/src/od.c b/src/od.c index 514fe50..a71e302 100644 --- a/src/od.c +++ b/src/od.c @@ -259,13 +259,16 @@ static enum size_spec integral_type_size[MAX_INTEGRAL_TYPE_SIZE + 1]; #define MAX_FP_TYPE_SIZE sizeof (long double) static enum size_spec fp_type_size[MAX_FP_TYPE_SIZE + 1]; +bool input_swap; + static char const short_options[] = "A:aBbcDdeFfHhIij:LlN:OoS:st:vw::Xx"; /* For long options that have no equivalent short option, use a non-character as a pseudo short option, starting with CHAR_MAX + 1. */ enum { - TRADITIONAL_OPTION = CHAR_MAX + 1 + TRADITIONAL_OPTION = CHAR_MAX + 1, + ENDIAN_OPTION, }; static struct option const long_options[] = @@ -278,6 +281,7 @@ static struct option const long_options[] = {"strings", optional_argument, NULL, 'S'}, {"traditional", no_argument, NULL, TRADITIONAL_OPTION}, {"width", optional_argument, NULL, 'w'}, + {"endian", required_argument, NULL, ENDIAN_OPTION }, {GETOPT_HELP_OPTION_DECL}, {GETOPT_VERSION_OPTION_DECL}, @@ -406,7 +410,21 @@ N (size_t fields, size_t blank, void const *block, \ { \ int next_pad = pad * (i - 1) / fields; \ int adjusted_width = pad_remaining - next_pad + width; \ - T x = *p++; \ + T x; \ + if (input_swap && sizeof(T) > 1) \ + { \ + int j; \ + union { \ + T x; \ + char b[sizeof(T)]; \ + } u; \ + for (j = 0; j < sizeof(T); j++) \ + u.b[j] = ((const char *) p)[sizeof(T) - 1 - j]; \ + x = u.x; \ + } \ + else \ + x = *p; \ + p++; \ ACTION; \ pad_remaining = next_pad; \ } \ @@ -1664,6 +1682,24 @@ main (int argc, char **argv) traditional = true; break; + case ENDIAN_OPTION: + if (!strcmp (optarg, "big")) + { +#if !WORDS_BIGENDIAN + input_swap = true; +#endif + } + else if (!strcmp (optarg, "little")) + { +#if WORDS_BIGENDIAN + input_swap = true; +#endif + } + else + error (EXIT_FAILURE, 0, + _("bad argument '%s' for --endian option"), optarg); + break; + /* The next several cases map the traditional format specification options to the corresponding modern format specs. GNU od accepts any combination of old- and -- Niels Mller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance.