From MAILER-DAEMON Sun Mar 04 16:04:11 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1esanj-0006rR-2Y for mharc-bug-guile@gnu.org; Sun, 04 Mar 2018 16:04:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esang-0006pm-It for bug-guile@gnu.org; Sun, 04 Mar 2018 16:04:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esanb-0005ox-Lo for bug-guile@gnu.org; Sun, 04 Mar 2018 16:04:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esanb-0005ot-IB for bug-guile@gnu.org; Sun, 04 Mar 2018 16:04:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esanb-00074y-6F for bug-guile@gnu.org; Sun, 04 Mar 2018 16:04:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#30703: [PATCH] Fix minor typo in PEG documentation. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 04 Mar 2018 21:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30703 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 30703@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152019738527135 (code B ref -1); Sun, 04 Mar 2018 21:04:03 +0000 Received: (at submit) by debbugs.gnu.org; 4 Mar 2018 21:03:05 +0000 Received: from localhost ([127.0.0.1]:44760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esamf-00073b-JH for submit@debbugs.gnu.org; Sun, 04 Mar 2018 16:03:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esamc-000735-PB for submit@debbugs.gnu.org; Sun, 04 Mar 2018 16:03:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esamW-00052N-NV for submit@debbugs.gnu.org; Sun, 04 Mar 2018 16:02:57 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:42009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1esamW-00052F-KJ for submit@debbugs.gnu.org; Sun, 04 Mar 2018 16:02:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esamV-0006MH-HV for bug-guile@gnu.org; Sun, 04 Mar 2018 16:02:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esamQ-0004yg-Lv for bug-guile@gnu.org; Sun, 04 Mar 2018 16:02:55 -0500 Received: from [2001:19f0:5:274f:4827:c39:448f:6777] (port=56600 helo=vultr.systemreboot.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1esamQ-0004xC-2V for bug-guile@gnu.org; Sun, 04 Mar 2018 16:02:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender: Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3LNF11gnn/Gp5CVRLMGHGnquRoiGu0XrZx6ux3t71Xg=; b=en0uwUdrtNFb72muTSQL2efbFL 6DbYTALYVgo1jBu0B+Tp++GG/H4Yk6Hdmp+iRs32TaGQHgWFxHXCn6bHBI19XSFdrhCLV3XFlEElz dUwQatvD9XPYs52UkXEtEUome32/29W2CqggjnCdBJC5oXLb6GeN5qNHTBPurz6wdgZg=; Received: from [117.192.98.54] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1esamJ-0001yn-T1; Mon, 05 Mar 2018 02:32:43 +0530 From: Arun Isaac Date: Mon, 5 Mar 2018 02:32:30 +0530 Message-Id: <20180304210230.21501-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.15.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Mar 2018 21:04:09 -0000 * doc/ref/api-peg.texi (PEG Internals): Fix minor typo. --- doc/ref/api-peg.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ref/api-peg.texi b/doc/ref/api-peg.texi index cbe3edd34..82e2758b4 100644 --- a/doc/ref/api-peg.texi +++ b/doc/ref/api-peg.texi @@ -1012,7 +1012,7 @@ interpreted internally in two steps. First, any string PEG is expanded into an s-expression PEG by the code in the @code{(ice-9 peg string-peg)} module. -Then, then s-expression PEG that results is compiled into a parsing +Then, the s-expression PEG that results is compiled into a parsing function by the @code{(ice-9 peg codegen)} module. In particular, the function @code{compile-peg-pattern} is called on the s-expression. It then decides what to do based on the form it is passed. -- 2.15.1 From MAILER-DAEMON Thu Mar 08 06:42:09 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ettw0-0003Ct-Ue for mharc-bug-guile@gnu.org; Thu, 08 Mar 2018 06:42:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ettvx-00039S-Ah for bug-guile@gnu.org; Thu, 08 Mar 2018 06:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ettvu-0005GX-5H for bug-guile@gnu.org; Thu, 08 Mar 2018 06:42:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42355) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ettvu-0005GO-19 for bug-guile@gnu.org; Thu, 08 Mar 2018 06:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ettvt-00072u-QV for bug-guile@gnu.org; Thu, 08 Mar 2018 06:42:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#30542: [PATCH] gnu: java-jeromq: Fix tests. References: In-Reply-To: Resent-From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 08 Mar 2018 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30542 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30542@debbugs.gnu.org Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits Received: via spool by 30542-submit@debbugs.gnu.org id=B30542.152050929327041 (code B ref 30542); Thu, 08 Mar 2018 11:42:01 +0000 Received: (at 30542) by debbugs.gnu.org; 8 Mar 2018 11:41:33 +0000 Received: from localhost ([127.0.0.1]:50252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ettvQ-000725-Ih for submit@debbugs.gnu.org; Thu, 08 Mar 2018 06:41:33 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:40456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ettvM-00071n-GC for 30542@debbugs.gnu.org; Thu, 08 Mar 2018 06:41:31 -0500 Received: by mail-wm0-f53.google.com with SMTP id t6so10469676wmt.5 for <30542@debbugs.gnu.org>; Thu, 08 Mar 2018 03:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0LLUCH7GNCNL+HI47NnegUBZDwYEIih5lTkIJA7PX9M=; b=o6gDCM3bawDLzPrtqVWFOpXNBkBpUJTb6sDZSybiYkXVDbwF9C9HZzuXGKLP2v5Auz o+9pgFK+xg5K4jsN47MntYmsG/I/WE6+w5pK6V/wRbNBzLGJgHn/YNF8Qq8aBaFCMSlZ /IZThpHbouezxhkJCpNoPZY8aX5Pyxn3lOQ294nK8t7osgKFFCQ661mphr8F9SxhcuGD xNgA8CW/tfQvyM990rFncbzC35nNpCoRyGAxAP3VkD3thwyRRsZlrhSB9+66t4JglaQ3 cBZjlYzzy/JSpcTVJO1F9Xfosrwlc/HhIJnVNJ4oIvNq3Dj87zCtd+JvEXEpndG3wMnY az5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0LLUCH7GNCNL+HI47NnegUBZDwYEIih5lTkIJA7PX9M=; b=a87uQ07hATBEGr0fx9EfcRRPh2RLSX46LfMdixDNRRQ9GcSygHw1YgaTvatNY88eRi KmALdXXYuCrsT65WZtqgytdsU1c4r6h6JieSgaAqi4WoM8wl5WSKPKvk1kc8Q7vRqDN7 TZDJreDclEumjZ+aH6g6JtA0TKkECZzvUe471WErf1+bmviPOEqQ5PDFOA4jsSriz60s H3WBmFfnyzirdZpD50vP+KSIEydKckTo2M84AdWUE97kgBshoL2A/sGlVuFeqlBpqFqi XEvY4Kp6whLYGVxF6SmxfK2sLL7AmmJ/mkFqfyiYe6ghfsiuWw2+9FaiCnMi6A6DbPLy 2LdQ== X-Gm-Message-State: AElRT7FIP09nH9bedrcnLT0o4cKgBANyolNJoIk9NA/JwQl15MbZ11qd y2WHuWUaP8EOsuDdLsOqerJk+MI= X-Google-Smtp-Source: AG47ELu1hfQkNWVH/2SZn2giusarrUoQi/fq7uMiNOLdrQ39IDiQpCxFB3xpVVG29quJsq74ueOzAA== X-Received: by 10.28.9.19 with SMTP id 19mr19071692wmj.114.1520509282188; Thu, 08 Mar 2018 03:41:22 -0800 (PST) Received: from localhost.localdomain (54013B9C.dsl.pool.telekom.hu. [84.1.59.156]) by smtp.gmail.com with ESMTPSA id a72sm13403314wme.28.2018.03.08.03.41.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Mar 2018 03:41:21 -0800 (PST) From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Thu, 8 Mar 2018 12:40:54 +0100 Message-Id: <20180308114054.22523-1-boskovits@gmail.com> X-Mailer: git-send-email 2.16.2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 11:42:07 -0000 * gnu/packages/patches/java-jeromq-fix-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/java.scm (java-jeromq)[source](patches): Add it. [arguments](#test-exclude): Disable more failing tests. --- gnu/local.mk | 1 + gnu/packages/java.scm | 11 +- gnu/packages/patches/java-jeromq-fix-tests.patch | 247 +++++++++++++++++++++++ 3 files changed, 257 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/java-jeromq-fix-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index 9684d949f..2bae3660c 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -782,6 +782,7 @@ dist_patch_DATA = \ %D%/packages/patches/intltool-perl-compatibility.patch \ %D%/packages/patches/isl-0.11.1-aarch64-support.patch \ %D%/packages/patches/jacal-fix-texinfo.patch \ + %D%/packages/patches/java-jeromq-fix-tests.patch \ %D%/packages/patches/java-powermock-fix-java-files.patch \ %D%/packages/patches/java-xerces-bootclasspath.patch \ %D%/packages/patches/java-xerces-build_dont_unzip.patch \ diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 0f8c04e8b..85a8c9b3a 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -8117,7 +8117,8 @@ protocol-independent framework to build mail and messaging applications.") (file-name (string-append name "-" version "-checkout")) (sha256 (base32 - "1gxkp7lv2ahymgrqdw94ncq54bmp4m4sw5m1x9gkp7l5bxn0xsyj")))) + "1gxkp7lv2ahymgrqdw94ncq54bmp4m4sw5m1x9gkp7l5bxn0xsyj")) + (patches (search-patches "java-jeromq-fix-tests.patch")))) (build-system ant-build-system) (arguments `(#:jar-name "java-jeromq.jar" @@ -8131,7 +8132,13 @@ protocol-independent framework to build mail and messaging applications.") ;; Failures "**/DealerSpecTest.java" "**/CustomDecoderTest.java" - "**/CustomEncoderTest.java"))) + "**/CustomEncoderTest.java" + "**/ConnectRidTest.java" + "**/ReqSpecTest.java" + "**/PushPullSpecTest.java" + "**/PubSubHwmTest.java" + "**/RouterSpecTest.java" + "**/ProxyTest.java"))) (inputs `(("java-jnacl" ,java-jnacl))) (native-inputs diff --git a/gnu/packages/patches/java-jeromq-fix-tests.patch b/gnu/packages/patches/java-jeromq-fix-tests.patch new file mode 100644 index 000000000..40fa64801 --- /dev/null +++ b/gnu/packages/patches/java-jeromq-fix-tests.patch @@ -0,0 +1,247 @@ +From 5803aadd3f209eba1ffbb2cf7bf16778019dbee1 Mon Sep 17 00:00:00 2001 +From: fredoboulo +Date: Fri, 23 Feb 2018 23:55:57 +0100 +Subject: [PATCH] Fix #524 : V1 and V2 protocol downgrades handle received data + in handshake buffer + +--- + src/main/java/zmq/io/StreamEngine.java | 21 ++++++++++-- + src/test/java/zmq/io/AbstractProtocolVersion.java | 41 +++++++++++++---------- + src/test/java/zmq/io/V0ProtocolTest.java | 12 +++++++ + src/test/java/zmq/io/V1ProtocolTest.java | 16 +++++++-- + src/test/java/zmq/io/V2ProtocolTest.java | 16 +++++++-- + 5 files changed, 81 insertions(+), 25 deletions(-) + +diff --git a/src/main/java/zmq/io/StreamEngine.java b/src/main/java/zmq/io/StreamEngine.java +index b8933c92..fe2f2d8d 100644 +--- a/src/main/java/zmq/io/StreamEngine.java ++++ b/src/main/java/zmq/io/StreamEngine.java +@@ -816,9 +816,7 @@ private boolean handshake() + assert (bufferSize == headerSize); + + // Make sure the decoder sees the data we have already received. +- greetingRecv.flip(); +- inpos = greetingRecv; +- insize = greetingRecv.limit(); ++ decodeDataAfterHandshake(0); + + // To allow for interoperability with peers that do not forward + // their subscriptions, we inject a phantom subscription message +@@ -846,6 +844,8 @@ else if (greetingRecv.get(revisionPos) == Protocol.V1.revision) { + } + encoder = new V1Encoder(errno, Config.OUT_BATCH_SIZE.getValue()); + decoder = new V1Decoder(errno, Config.IN_BATCH_SIZE.getValue(), options.maxMsgSize, options.allocator); ++ ++ decodeDataAfterHandshake(V2_GREETING_SIZE); + } + else if (greetingRecv.get(revisionPos) == Protocol.V2.revision) { + // ZMTP/2.0 framing. +@@ -859,6 +859,8 @@ else if (greetingRecv.get(revisionPos) == Protocol.V2.revision) { + } + encoder = new V2Encoder(errno, Config.OUT_BATCH_SIZE.getValue()); + decoder = new V2Decoder(errno, Config.IN_BATCH_SIZE.getValue(), options.maxMsgSize, options.allocator); ++ ++ decodeDataAfterHandshake(V2_GREETING_SIZE); + } + else { + zmtpVersion = Protocol.V3; +@@ -904,6 +906,19 @@ else if (greetingRecv.get(revisionPos) == Protocol.V2.revision) { + return true; + } + ++ private void decodeDataAfterHandshake(int greetingSize) ++ { ++ final int pos = greetingRecv.position(); ++ if (pos > greetingSize) { ++ // data is present after handshake ++ greetingRecv.position(greetingSize).limit(pos); ++ ++ // Make sure the decoder sees this extra data. ++ inpos = greetingRecv; ++ insize = greetingRecv.remaining(); ++ } ++ } ++ + private Msg identityMsg() + { + Msg msg = new Msg(options.identitySize); +diff --git a/src/test/java/zmq/io/AbstractProtocolVersion.java b/src/test/java/zmq/io/AbstractProtocolVersion.java +index e60db403..aa06b4a7 100644 +--- a/src/test/java/zmq/io/AbstractProtocolVersion.java ++++ b/src/test/java/zmq/io/AbstractProtocolVersion.java +@@ -18,15 +18,18 @@ + import zmq.SocketBase; + import zmq.ZError; + import zmq.ZMQ; ++import zmq.ZMQ.Event; + import zmq.util.Utils; + + public abstract class AbstractProtocolVersion + { ++ protected static final int REPETITIONS = 1000; ++ + static class SocketMonitor extends Thread + { +- private final Ctx ctx; +- private final String monitorAddr; +- private final List events = new ArrayList<>(); ++ private final Ctx ctx; ++ private final String monitorAddr; ++ private final ZMQ.Event[] events = new ZMQ.Event[1]; + + public SocketMonitor(Ctx ctx, String monitorAddr) + { +@@ -41,15 +44,15 @@ public void run() + boolean rc = s.connect(monitorAddr); + assertThat(rc, is(true)); + // Only some of the exceptional events could fire +- while (true) { +- ZMQ.Event event = ZMQ.Event.read(s); +- if (event == null && s.errno() == ZError.ETERM) { +- break; +- } +- assertThat(event, notNullValue()); +- +- events.add(event); ++ ++ ZMQ.Event event = ZMQ.Event.read(s); ++ if (event == null && s.errno() == ZError.ETERM) { ++ s.close(); ++ return; + } ++ assertThat(event, notNullValue()); ++ ++ events[0] = event; + s.close(); + } + } +@@ -69,11 +72,12 @@ public void run() + boolean rc = ZMQ.setSocketOption(receiver, ZMQ.ZMQ_LINGER, 0); + assertThat(rc, is(true)); + +- SocketMonitor monitor = new SocketMonitor(ctx, "inproc://monitor"); +- monitor.start(); + rc = ZMQ.monitorSocket(receiver, "inproc://monitor", ZMQ.ZMQ_EVENT_HANDSHAKE_PROTOCOL); + assertThat(rc, is(true)); + ++ SocketMonitor monitor = new SocketMonitor(ctx, "inproc://monitor"); ++ monitor.start(); ++ + rc = ZMQ.bind(receiver, host); + assertThat(rc, is(true)); + +@@ -81,17 +85,18 @@ public void run() + OutputStream out = sender.getOutputStream(); + for (ByteBuffer raw : raws) { + out.write(raw.array()); +- ZMQ.msleep(100); + } + + Msg msg = ZMQ.recv(receiver, 0); + assertThat(msg, notNullValue()); + assertThat(new String(msg.data(), ZMQ.CHARSET), is(payload)); + +- ZMQ.msleep(500); +- assertThat(monitor.events.size(), is(1)); +- assertThat(monitor.events.get(0).event, is(ZMQ.ZMQ_EVENT_HANDSHAKE_PROTOCOL)); +- assertThat((Integer) monitor.events.get(0).arg, is(version)); ++ monitor.join(); ++ ++ final Event event = monitor.events[0]; ++ assertThat(event, notNullValue()); ++ assertThat(event.event, is(ZMQ.ZMQ_EVENT_HANDSHAKE_PROTOCOL)); ++ assertThat((Integer) event.arg, is(version)); + + InputStream in = sender.getInputStream(); + byte[] data = new byte[255]; +diff --git a/src/test/java/zmq/io/V0ProtocolTest.java b/src/test/java/zmq/io/V0ProtocolTest.java +index bd547d23..1a5b7aef 100644 +--- a/src/test/java/zmq/io/V0ProtocolTest.java ++++ b/src/test/java/zmq/io/V0ProtocolTest.java +@@ -10,6 +10,18 @@ + + public class V0ProtocolTest extends AbstractProtocolVersion + { ++ @Test ++ public void testFixIssue524() throws IOException, InterruptedException ++ { ++ for (int idx = 0; idx < REPETITIONS; ++idx) { ++ if (idx % 100 == 0) { ++ System.out.print(idx + " "); ++ } ++ testProtocolVersion0short(); ++ } ++ System.out.println(); ++ } ++ + @Test(timeout = 2000) + public void testProtocolVersion0short() throws IOException, InterruptedException + { +diff --git a/src/test/java/zmq/io/V1ProtocolTest.java b/src/test/java/zmq/io/V1ProtocolTest.java +index e1045f34..764159d0 100644 +--- a/src/test/java/zmq/io/V1ProtocolTest.java ++++ b/src/test/java/zmq/io/V1ProtocolTest.java +@@ -10,7 +10,19 @@ + + public class V1ProtocolTest extends AbstractProtocolVersion + { +- @Test(timeout = 2000) ++ @Test ++ public void testFixIssue524() throws IOException, InterruptedException ++ { ++ for (int idx = 0; idx < REPETITIONS; ++idx) { ++ if (idx % 100 == 0) { ++ System.out.print(idx + " "); ++ } ++ testProtocolVersion1short(); ++ } ++ System.out.println(); ++ } ++ ++ @Test + public void testProtocolVersion1short() throws IOException, InterruptedException + { + List raws = raws(0); +@@ -25,7 +37,7 @@ public void testProtocolVersion1short() throws IOException, InterruptedException + assertProtocolVersion(1, raws, "abcdefg"); + } + +- @Test(timeout = 2000) ++ @Test + public void testProtocolVersion1long() throws IOException, InterruptedException + { + List raws = raws(0); +diff --git a/src/test/java/zmq/io/V2ProtocolTest.java b/src/test/java/zmq/io/V2ProtocolTest.java +index d5e64bce..7fda31bc 100644 +--- a/src/test/java/zmq/io/V2ProtocolTest.java ++++ b/src/test/java/zmq/io/V2ProtocolTest.java +@@ -21,7 +21,19 @@ protected ByteBuffer identity() + .put((byte) 0); + } + +- @Test(timeout = 2000) ++ @Test ++ public void testFixIssue524() throws IOException, InterruptedException ++ { ++ for (int idx = 0; idx < REPETITIONS; ++idx) { ++ if (idx % 100 == 0) { ++ System.out.print(idx + " "); ++ } ++ testProtocolVersion2short(); ++ } ++ System.out.println(); ++ } ++ ++ @Test + public void testProtocolVersion2short() throws IOException, InterruptedException + { + List raws = raws(1); +@@ -38,7 +50,7 @@ public void testProtocolVersion2short() throws IOException, InterruptedException + assertProtocolVersion(2, raws, "abcdefg"); + } + +- @Test(timeout = 2000) ++ @Test + public void testProtocolVersion2long() throws IOException, InterruptedException + { + List raws = raws(1); -- 2.16.2 From MAILER-DAEMON Fri Mar 09 16:45:08 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1euPp6-0006SA-7i for mharc-bug-guile@gnu.org; Fri, 09 Mar 2018 16:45:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euPp4-0006RU-2S for bug-guile@gnu.org; Fri, 09 Mar 2018 16:45:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euPp0-0000Bb-UB for bug-guile@gnu.org; Fri, 09 Mar 2018 16:45:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:44970) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euPp0-0000BX-Qd for bug-guile@gnu.org; Fri, 09 Mar 2018 16:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euPp0-0002Ln-Ke for bug-guile@gnu.org; Fri, 09 Mar 2018 16:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#30542: [PATCH] gnu: java-jeromq: Fix tests. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 09 Mar 2018 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30542 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 30542@debbugs.gnu.org Received: via spool by 30542-submit@debbugs.gnu.org id=B30542.15206318488944 (code B ref 30542); Fri, 09 Mar 2018 21:45:02 +0000 Received: (at 30542) by debbugs.gnu.org; 9 Mar 2018 21:44:08 +0000 Received: from localhost ([127.0.0.1]:52867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euPo7-0002KB-RD for submit@debbugs.gnu.org; Fri, 09 Mar 2018 16:44:08 -0500 Received: from world.peace.net ([50.252.239.5]:37560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euPo3-0002JQ-RJ for 30542@debbugs.gnu.org; Fri, 09 Mar 2018 16:44:07 -0500 Received: from turntable.mit.edu ([18.18.160.11] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1euPnw-0008TB-Qe; Fri, 09 Mar 2018 16:43:56 -0500 From: Mark H Weaver References: <20180308114054.22523-1-boskovits@gmail.com> Date: Fri, 09 Mar 2018 16:43:08 -0500 In-Reply-To: <20180308114054.22523-1-boskovits@gmail.com> ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Thu, 8 Mar 2018 12:40:54 +0100") Message-ID: <87vae56i37.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 21:45:07 -0000 Hi G=C3=A1bor, G=C3=A1bor Boskovits writes: > * gnu/packages/patches/java-jeromq-fix-tests.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/java.scm (java-jeromq)[source](patches): Add it. > [arguments](#test-exclude): Disable more failing tests. You sent this email to bug 30542, which is a Guile bug that has nothing to do Guix or java-jeromq. See . You might want to resend it to the appropriate bug. Thanks, Mark From MAILER-DAEMON Thu Mar 15 19:27:06 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewcH4-0002bg-DS for mharc-bug-guile@gnu.org; Thu, 15 Mar 2018 19:27:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewcH1-0002Wt-7q for bug-guile@gnu.org; Thu, 15 Mar 2018 19:27:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewcH0-00017F-FM for bug-guile@gnu.org; Thu, 15 Mar 2018 19:27:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewcH0-000177-A0 for bug-guile@gnu.org; Thu, 15 Mar 2018 19:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewcH0-0006Ci-1k for bug-guile@gnu.org; Thu, 15 Mar 2018 19:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian) Resent-From: "Manuel A. Fernandez Montecelo" Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 15 Mar 2018 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30832 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30832@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152115639223808 (code B ref -1); Thu, 15 Mar 2018 23:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2018 23:26:32 +0000 Received: from localhost ([127.0.0.1]:35524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewcGW-0006Bw-Cm for submit@debbugs.gnu.org; Thu, 15 Mar 2018 19:26:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewcGU-0006Bj-JN for submit@debbugs.gnu.org; Thu, 15 Mar 2018 19:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewcGO-0000ko-KY for submit@debbugs.gnu.org; Thu, 15 Mar 2018 19:26:25 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:37755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ewcGO-0000kh-GB for submit@debbugs.gnu.org; Thu, 15 Mar 2018 19:26:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewcGN-00022g-0z for bug-guile@gnu.org; Thu, 15 Mar 2018 19:26:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewcGL-0000jQ-RA for bug-guile@gnu.org; Thu, 15 Mar 2018 19:26:23 -0400 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:36993) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewcGL-0000iV-I1 for bug-guile@gnu.org; Thu, 15 Mar 2018 19:26:21 -0400 Received: by mail-lf0-x231.google.com with SMTP id y19-v6so12716237lfd.4 for ; Thu, 15 Mar 2018 16:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=8tS7DrC3t9vk/OxA0OwWMSg7AyhY7LO/B9hQzNs+Tmg=; b=qmv+pEpkvT4eIHOECjmvbodRfTQQP0BeQ2wRTOplfZKLYMvdmN9uh9THMJc0G/DuZV EsVcSlLXLxQ1sGJZmqv8yCpUjRuRUD2DXa4mex8ReSzUGN12SvwH2zGLWxbZiPT6g7Us bw9EVgSb41xIaazroZMDusbiG7XQuR/A4ZDuxOCwiWPGULnUdm7M1wIF4pxMTJJn3cfi 1b+xjk9rK+vLCtogan/I3hoMonLlARFIfnSn7wsT27AfUgewJmgEsQwDYdjl9uOSc8gP AscYSXVoJYDC7tfvCQ9NBGbeIff9P2nTjO4lQbwxCpwC43D/PdnY2oluPvlhyz+WQcqD mG9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8tS7DrC3t9vk/OxA0OwWMSg7AyhY7LO/B9hQzNs+Tmg=; b=TBqO4C6P7CnR+Nm+T3m4OnXe0BWDcrggq46SSnjRegyoFieRsc4eoULrpgiAYZkjLO Ctd8bQaT7CBWYdQUjJ13bTzbonYsoa9kGrjoKkeuw8q7MrQYTGmAAZMql2LrfODKeW6Z enmw9O/QKJqp+h4INgTM++wc1d0Evy+bvyyeEq6ZKnDvXFHyirScXtIBD2Ml4fyY9eVP ETyR8IpysySqKjwbB2MHFCastS5ZpKNEaz+of+1kVm9nzGPrAkqFhEyFO5NIWa9htW9h xRSzErW67AKdPu6xwM66qSZhaY+kcCgeBmIzFBZVv4wrIVxPK9JxQYuwZTzW3zK7LVhm 1sUA== X-Gm-Message-State: AElRT7FnpDgEvcnYbuQxvCiwDCQ4BMjwMXIzFJsDHzk5M+BBMExXZtCy hgtVPJ/ABq3kEQzyRgiUqU8G95RFgR+hVUgfx5Xhmg== X-Google-Smtp-Source: AG47ELuWk9MoY2FB3xKbzNx4X/6sM6zbXrILSKH5J0P9BVX5VP0JVVHvhJmi04yhSbn/gts+sJrKAEowv2ux5E5NDbg= X-Received: by 2002:a19:d0d5:: with SMTP id h204-v6mr7306619lfg.124.1521156379718; Thu, 15 Mar 2018 16:26:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9a08:0:0:0:0:0 with HTTP; Thu, 15 Mar 2018 16:25:38 -0700 (PDT) From: "Manuel A. Fernandez Montecelo" Date: Fri, 16 Mar 2018 00:25:38 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000a9585e05677bd105" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 23:27:04 -0000 --000000000000a9585e05677bd105 Content-Type: text/plain; charset="UTF-8" Hello, Please add support for this architecture, simple patch attached (based on guile-2.0, the most popular version in Debian). The change is simply to add "riscv64" in the following location, the arch name seems to be missing in: http://git.savannah.gnu.org/cgit/guile.git/tree/module/system/base/target.scm#n74 Since it ends in -64, the pointer size should be detected correctly in the current code. I compiled this and ran the test suite successfully: Totals for this test run: passes: 40317 failures: 0 unexpected passes: 0 expected failures: 9 unresolved test cases: 571 untested test cases: 1 unsupported test cases: 10 errors: 0 If there's anything missing, please let me know. Cheers. -- Manuel A. Fernandez Montecelo --000000000000a9585e05677bd105 Content-Type: text/x-patch; charset="US-ASCII"; name="riscv64.patch" Content-Disposition: attachment; filename="riscv64.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jet573h00 SW5kZXg6IGd1aWxlLTIuMC0yLjAuMTMrMS9tb2R1bGUvc3lzdGVtL2Jhc2UvdGFyZ2V0LnNjbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBndWlsZS0yLjAtMi4wLjEzKzEub3JpZy9tb2R1bGUvc3lzdGVtL2Jhc2Uv dGFyZ2V0LnNjbQorKysgZ3VpbGUtMi4wLTIuMC4xMysxL21vZHVsZS9zeXN0ZW0vYmFzZS90YXJn ZXQuc2NtCkBAIC02NSw3ICs2NSw3IEBACiAgICAgICAoY29uZCAoKHN0cmluZy1tYXRjaCAiXmlb MC05XTg2JCIgY3B1KQogICAgICAgICAgICAgIChlbmRpYW5uZXNzIGxpdHRsZSkpCiAgICAgICAg ICAgICAoKG1lbWJlciBjcHUgJygieDg2XzY0IiAiaWE2NCIKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICJwb3dlcnBjbGUiICJwb3dlcnBjNjRsZSIgIm1pcHNlbCIgIm1pcHM2NGVsIiAibmlv czIiICJzaDQiICJhbHBoYSIpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgInBvd2VycGNs ZSIgInBvd2VycGM2NGxlIiAibWlwc2VsIiAibWlwczY0ZWwiICJuaW9zMiIgInNoNCIgImFscGhh IiAicmlzY3Y2NCIpKQogICAgICAgICAgICAgIChlbmRpYW5uZXNzIGxpdHRsZSkpCiAgICAgICAg ICAgICAoKG1lbWJlciBjcHUgJygic3BhcmMiICJzcGFyYzY0IiAicG93ZXJwYyIgInBvd2VycGM2 NCIgInNwdSIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICJtaXBzIiAibWlwczY0IiAibTY4 ayIgInMzOTB4IikpCg== --000000000000a9585e05677bd105-- From MAILER-DAEMON Thu Mar 15 23:43:07 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewgGp-0003Po-7V for mharc-bug-guile@gnu.org; Thu, 15 Mar 2018 23:43:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewgGn-0003P4-RX for bug-guile@gnu.org; Thu, 15 Mar 2018 23:43:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgGk-00064Q-Pg for bug-guile@gnu.org; Thu, 15 Mar 2018 23:43:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewgGk-00064I-Ll for bug-guile@gnu.org; Thu, 15 Mar 2018 23:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewgGk-00005D-FF for bug-guile@gnu.org; Thu, 15 Mar 2018 23:43:02 -0400 Subject: bug#29520: peval leaves behind dangling lexical reference Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 03:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29520 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Stefan Israelsson Tampe Cc: 29520-done@debbugs.gnu.org Mail-Followup-To: 29520@debbugs.gnu.org, mhw@netris.org, stefan.itampe@gmail.com Received: via spool by 29520-done@debbugs.gnu.org id=D29520.152117175632741 (code D ref 29520); Fri, 16 Mar 2018 03:43:02 +0000 Received: (at 29520-done) by debbugs.gnu.org; 16 Mar 2018 03:42:36 +0000 Received: from localhost ([127.0.0.1]:35615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgGK-0008W0-2K for submit@debbugs.gnu.org; Thu, 15 Mar 2018 23:42:36 -0400 Received: from world.peace.net ([50.252.239.5]:47756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgGI-0008Vn-H1 for 29520-done@debbugs.gnu.org; Thu, 15 Mar 2018 23:42:34 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgGC-00037I-Jw; Thu, 15 Mar 2018 23:42:28 -0400 From: Mark H Weaver References: <87shcrxyat.fsf@netris.org> <87mv2zxqym.fsf@netris.org> <878tejxd76.fsf@netris.org> <87wp22w66v.fsf@netris.org> <878tehvq7a.fsf@netris.org> Date: Thu, 15 Mar 2018 23:41:32 -0400 In-Reply-To: <878tehvq7a.fsf@netris.org> (Mark H. Weaver's message of "Mon, 04 Dec 2017 21:55:21 -0500") Message-ID: <871sgk661f.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 03:43:06 -0000 Mark H Weaver writes: > diff --git a/module/language/tree-il/peval.scm b/module/language/tree-il/peval.scm > index 993fa0ad6..13b7d9bc4 100644 > --- a/module/language/tree-il/peval.scm > +++ b/module/language/tree-il/peval.scm > @@ -1585,11 +1585,15 @@ top-level bindings from ENV and return the resulting expression." > (and (not opt) rest (not kw) > (match body > (($ _ 'apply > - (($ _ _ (and lcase ($ ))) > + (($ _ _ (and lcase ($ _ req1))) > ($ _ _ sym) > ...)) > (and (equal? sym gensyms) > (not (lambda-case-alternate lcase)) > + (<= (length req) (length req1)) > + (every (lambda (s) > + (= (lexical-refcount s) 1)) > + sym) > lcase)) > (_ #f)))) > (let* ((vars (map lookup-var gensyms)) Applied in commit b56e084c77914a7fde558e8fd28a218759a4ddd7 on the stable-2.2 branch. I'm closing this bug now, but feel free to reopen if you still see related problems. Thanks! Mark From MAILER-DAEMON Fri Mar 16 00:07:09 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewge4-0007Iw-UK for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 00:07:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewge2-0007Ic-QD for bug-guile@gnu.org; Fri, 16 Mar 2018 00:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgdy-00069P-PI for bug-guile@gnu.org; Fri, 16 Mar 2018 00:07:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewgdy-00069G-LP for bug-guile@gnu.org; Fri, 16 Mar 2018 00:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewgdy-0000eI-Av for bug-guile@gnu.org; Fri, 16 Mar 2018 00:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH] doc: Document (ice-9 match) macros. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 04:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.15211732052472 (code B ref 30144); Fri, 16 Mar 2018 04:07:02 +0000 Received: (at 30144) by debbugs.gnu.org; 16 Mar 2018 04:06:45 +0000 Received: from localhost ([127.0.0.1]:35624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgdf-0000dm-0W for submit@debbugs.gnu.org; Fri, 16 Mar 2018 00:06:44 -0400 Received: from world.peace.net ([50.252.239.5]:47852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgdc-0000dY-QG for 30144@debbugs.gnu.org; Fri, 16 Mar 2018 00:06:41 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgdW-0003Kq-Rj; Fri, 16 Mar 2018 00:06:35 -0400 From: Mark H Weaver References: <20180117122504.25583-1-arunisaac@systemreboot.net> Date: Fri, 16 Mar 2018 00:05:39 -0400 In-Reply-To: <20180117122504.25583-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Wed, 17 Jan 2018 17:55:04 +0530") Message-ID: <87woyc4qcs.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 04:07:08 -0000 Hi Arun, I apologize for the long delay on this. This patch mostly looks great to me, but there are a few minor issues. Please see below for comments. Arun Isaac writes: > * doc/ref/match.texi: Document match-lambda, match-lambda*, match-let, > match-let* and match-letrec. > --- > doc/ref/match.texi | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 63 insertions(+), 2 deletions(-) > > diff --git a/doc/ref/match.texi b/doc/ref/match.texi > index 12e3814ae..4d85fe3f9 100644 > --- a/doc/ref/match.texi > +++ b/doc/ref/match.texi > @@ -213,8 +213,69 @@ any @var{person} whose second slot is a promise that evaluates to a > one-element list containing a @var{person} whose first slot is > @code{"Bob"}. > > -Please refer to the @code{ice-9/match.upstream.scm} file in your Guile > -installation for more details. > +The @code{(ice-9 match)} module also provides the following convenient > +syntactic sugar macros wrapping around @code{match}. > + > +@deffn {Scheme Syntax} match-lambda exp clause1 clause2 @dots{} > +Create a procedure of one argument that matches its argument against > +each clause. How about adding "and evaluates the corresponding expressions" or something like that? > + > +@example > +(match-lambda clause1 clause2 @dots{}) > +@equiv{} > +(lambda (arg) (match arg clause1 clause2 @dots{})) > +@end example It might be nicer to include an actual example here, rather than just showing the raw transformation. What do you think? > +@end deffn > + > +@deffn {Scheme Syntax} match-lambda* exp clause1 clause2 @dots{} > +Create a procedure of any number of arguments that matches its argument > +list against each clause. > + > +Equivalent to > +@example > +(match-lambda* clause1 clause2 @dots{}) > +@equiv{} > +(lambda args (match args clause1 clause2 @dots{})) > +@end example > +@end deffn My suggestions above for 'match-lambda' also apply to 'match-lambda*'. > + > +@deffn {Scheme Syntax} match-let ((variable expression) @dots{}) body "variable" here should be replaced with "pattern". In general, any pattern can go there. > +Match each variable to the corresponding expression, and evaluate the > +body with all matched variables in scope. Raise an error if any of the > +expressions fail to match. @code{match-let} is analogous to named let It's only analogous to a named let if a variable name is inserted immediately after 'match-let', before the clauses. In fact, the named-let case is not covered by the first line of your definition where you give the syntax. How about removing any mention of named-let in this definition, and then add a separate brief definition for the named-let variant of 'match-let'? It might be worthwhile to keep them separate given that their use cases and relevant examples are so different. What do you think? > +and can also be used for recursive functions which match on their > +arguments as in @code{match-lambda*}. > + > +@example > +(match-let (((x y) (list 1 2)) > + ((a b) (list 3 4))) There's a tab character in the line above, which causes things to not line up properly when looking at the diff. Could you convert tabs to spaces? In emacs, it can be done using M-x untabify. Would you like to send a revised patch? Mark From MAILER-DAEMON Fri Mar 16 00:15:11 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewglp-0000ei-0j for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 00:15:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewglm-0000dI-Tl for bug-guile@gnu.org; Fri, 16 Mar 2018 00:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgli-0002z8-VN for bug-guile@gnu.org; Fri, 16 Mar 2018 00:15:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewgli-0002yb-Bf for bug-guile@gnu.org; Fri, 16 Mar 2018 00:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewglh-0000r2-Tv for bug-guile@gnu.org; Fri, 16 Mar 2018 00:15:01 -0400 Subject: bug#30276: typos in the manual (api-macros, vm) Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 04:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30276 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Matt Wette Cc: 30276-done@debbugs.gnu.org Mail-Followup-To: 30276@debbugs.gnu.org, mhw@netris.org, matt.wette@gmail.com Received: via spool by 30276-done@debbugs.gnu.org id=D30276.15211736923245 (code D ref 30276); Fri, 16 Mar 2018 04:15:01 +0000 Received: (at 30276-done) by debbugs.gnu.org; 16 Mar 2018 04:14:52 +0000 Received: from localhost ([127.0.0.1]:35630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewglY-0000qH-Ir for submit@debbugs.gnu.org; Fri, 16 Mar 2018 00:14:52 -0400 Received: from world.peace.net ([50.252.239.5]:47922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewglW-0000q3-LG for 30276-done@debbugs.gnu.org; Fri, 16 Mar 2018 00:14:50 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewglQ-0003Vi-TX; Fri, 16 Mar 2018 00:14:45 -0400 From: Mark H Weaver In-Reply-To: <78e822a3-a2d1-9d56-311a-3b32c1a1f8b7@gmail.com> (Matt Wette's message of "Sun, 28 Jan 2018 13:26:02 -0800") References: <78e822a3-a2d1-9d56-311a-3b32c1a1f8b7@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Date: Fri, 16 Mar 2018 00:13:49 -0400 Message-ID: <87po444pz6.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 04:15:08 -0000 Matt Wette writes: > A couple typos in the maual > > --- api-macros.texi-fix 2018-01-28 13:22:52.305712852 -0800 > +++ api-macros.texi 2017-11-19 11:22:01.000000000 -0800 > @@ -1280,7 +1280,7 @@ > In this way @code{(macroexpand @var{foo})} is equivalent to > @code{(macroexpand @var{foo} 'e '(eval))}. The second argument is the > -mode (@code{'e} for ``eval'') and the third is the > +mode (@code{'e} for ``eval'') and the second is the > eval-syntax-expanders-when parameter (only @code{eval} in this default > setting). > --- vm.texi 2017-05-13 09:41:37.000000000 -0700 > +++ vm.texi-fix 2018-01-28 13:21:31.621618026 -0800 > @@ -719,7 +719,7 @@ > For calls, both in tail position and in non-tail position, we require > that the procedure and the arguments already be shuffled into place > -befor the call instruction. ``Into place'' for a tail call means that > +before the call instruction. ``Into place'' for a tail call means that > the procedure should be in slot 0, relative to the @code{fp}, and the > arguments should follow. For a non-tail call, if the procedure is in > @code{fp}-relative slot @var{n}, the arguments should follow from slot Applied in commit 6d9c6833e78e560420a7805bf73a9dfbaa4b0cbb on the stable-2.2 branch. Thanks! Mark From MAILER-DAEMON Fri Mar 16 00:18:08 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewgoi-0001CW-00 for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 00:18:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewgof-0001Av-I5 for bug-guile@gnu.org; Fri, 16 Mar 2018 00:18:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgoc-0004u0-C8 for bug-guile@gnu.org; Fri, 16 Mar 2018 00:18:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewgoc-0004to-9G for bug-guile@gnu.org; Fri, 16 Mar 2018 00:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewgoc-0000vp-40 for bug-guile@gnu.org; Fri, 16 Mar 2018 00:18:02 -0400 Subject: bug#30703: [PATCH] Fix minor typo in PEG documentation. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 04:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30703 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 30703-done@debbugs.gnu.org Mail-Followup-To: 30703@debbugs.gnu.org, mhw@netris.org, arunisaac@systemreboot.net Received: via spool by 30703-done@debbugs.gnu.org id=D30703.15211738523537 (code D ref 30703); Fri, 16 Mar 2018 04:18:01 +0000 Received: (at 30703-done) by debbugs.gnu.org; 16 Mar 2018 04:17:32 +0000 Received: from localhost ([127.0.0.1]:35637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgo8-0000uz-03 for submit@debbugs.gnu.org; Fri, 16 Mar 2018 00:17:32 -0400 Received: from world.peace.net ([50.252.239.5]:47944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgo6-0000ul-1y for 30703-done@debbugs.gnu.org; Fri, 16 Mar 2018 00:17:30 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgo0-0003Zm-7a; Fri, 16 Mar 2018 00:17:24 -0400 From: Mark H Weaver References: <20180304210230.21501-1-arunisaac@systemreboot.net> Date: Fri, 16 Mar 2018 00:16:29 -0400 In-Reply-To: <20180304210230.21501-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Mon, 5 Mar 2018 02:32:30 +0530") Message-ID: <87lges4puq.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 04:18:06 -0000 Arun Isaac writes: > * doc/ref/api-peg.texi (PEG Internals): Fix minor typo. > --- > doc/ref/api-peg.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/ref/api-peg.texi b/doc/ref/api-peg.texi > index cbe3edd34..82e2758b4 100644 > --- a/doc/ref/api-peg.texi > +++ b/doc/ref/api-peg.texi > @@ -1012,7 +1012,7 @@ interpreted internally in two steps. > First, any string PEG is expanded into an s-expression PEG by the code > in the @code{(ice-9 peg string-peg)} module. > > -Then, then s-expression PEG that results is compiled into a parsing > +Then, the s-expression PEG that results is compiled into a parsing > function by the @code{(ice-9 peg codegen)} module. In particular, the > function @code{compile-peg-pattern} is called on the s-expression. It then > decides what to do based on the form it is passed. Applied in commit 01f97cfc0a2621f664202e6b19f79cf138869a3d of the stable-2.2 branch. Thanks! Mark From MAILER-DAEMON Fri Mar 16 00:23:08 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewgtY-0002X0-2L for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 00:23:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewgtV-0002VV-El for bug-guile@gnu.org; Fri, 16 Mar 2018 00:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgtS-0007AO-8i for bug-guile@gnu.org; Fri, 16 Mar 2018 00:23:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55982) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewgtS-0007AH-5o for bug-guile@gnu.org; Fri, 16 Mar 2018 00:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewgtS-00014d-0j for bug-guile@gnu.org; Fri, 16 Mar 2018 00:23:02 -0400 Subject: bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian) Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 04:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30832 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: "Manuel A. Fernandez Montecelo" Cc: 30832-done@debbugs.gnu.org Mail-Followup-To: 30832@debbugs.gnu.org, mhw@netris.org, manuel.montezelo@gmail.com Received: via spool by 30832-done@debbugs.gnu.org id=D30832.15211741324034 (code D ref 30832); Fri, 16 Mar 2018 04:23:01 +0000 Received: (at 30832-done) by debbugs.gnu.org; 16 Mar 2018 04:22:12 +0000 Received: from localhost ([127.0.0.1]:35644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgse-000130-I2 for submit@debbugs.gnu.org; Fri, 16 Mar 2018 00:22:12 -0400 Received: from world.peace.net ([50.252.239.5]:47982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgsc-00012m-Rq for 30832-done@debbugs.gnu.org; Fri, 16 Mar 2018 00:22:11 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgsX-0003fl-7N; Fri, 16 Mar 2018 00:22:05 -0400 From: Mark H Weaver References: Date: Fri, 16 Mar 2018 00:21:08 -0400 In-Reply-To: (Manuel A. Fernandez Montecelo's message of "Fri, 16 Mar 2018 00:25:38 +0100") Message-ID: <87h8pg4pmz.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 04:23:06 -0000 "Manuel A. Fernandez Montecelo" writes: > Please add support for this architecture, simple patch attached (based > on guile-2.0, the most popular version in Debian). This should be fixed now, using a patch provided earlier by Shea Levy which also covers riscv32. See commit 08bb4628369cf3efe7c96a32919705c41a9ed9e9 on the stable-2.2 branch and d6e669b8cb26f870ea6611a54788b75fbad67bbe on the stable-2.0 branch. I'm closing this bug now, but please reopen if there are still issues. Thanks! Mark From MAILER-DAEMON Fri Mar 16 00:35:09 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewh5B-0004R8-AK for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 00:35:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewh59-0004PZ-04 for bug-guile@gnu.org; Fri, 16 Mar 2018 00:35:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewh54-0005jW-0g for bug-guile@gnu.org; Fri, 16 Mar 2018 00:35:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewh53-0005ip-Sj for bug-guile@gnu.org; Fri, 16 Mar 2018 00:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewh53-0001PI-KW for bug-guile@gnu.org; Fri, 16 Mar 2018 00:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH] doc: Document (ice-9 match) macros. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 04:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.15211748585347 (code B ref 30144); Fri, 16 Mar 2018 04:35:01 +0000 Received: (at 30144) by debbugs.gnu.org; 16 Mar 2018 04:34:18 +0000 Received: from localhost ([127.0.0.1]:35657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewh4M-0001OA-0A for submit@debbugs.gnu.org; Fri, 16 Mar 2018 00:34:18 -0400 Received: from world.peace.net ([50.252.239.5]:48022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewh4L-0001Nz-8T for 30144@debbugs.gnu.org; Fri, 16 Mar 2018 00:34:17 -0400 Received: from pool-72-93-30-18.bstnma.east.verizon.net ([72.93.30.18] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewh4F-0003oJ-Ff; Fri, 16 Mar 2018 00:34:11 -0400 From: Mark H Weaver References: <20180117122504.25583-1-arunisaac@systemreboot.net> <87woyc4qcs.fsf@netris.org> Date: Fri, 16 Mar 2018 00:33:16 -0400 In-Reply-To: <87woyc4qcs.fsf@netris.org> (Mark H. Weaver's message of "Fri, 16 Mar 2018 00:05:39 -0400") Message-ID: <87d1044p2r.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 04:35:08 -0000 Mark H Weaver writes: > Arun Isaac writes: >> +@deffn {Scheme Syntax} match-lambda exp clause1 clause2 @dots{} >> +Create a procedure of one argument that matches its argument against >> +each clause. > > How about adding "and evaluates the corresponding expressions" or > something like that? It occurs to me that we should also document the return value. How about adding "and returns the result(s) of evaluating the corresponding expressions"? Mark From MAILER-DAEMON Fri Mar 16 06:08:16 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewmHY-0005TI-MP for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 06:08:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewmHP-0005PQ-MW for bug-guile@gnu.org; Fri, 16 Mar 2018 06:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewmHK-0002jb-2j for bug-guile@gnu.org; Fri, 16 Mar 2018 06:08:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewmHJ-0002jX-Tq for bug-guile@gnu.org; Fri, 16 Mar 2018 06:08:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewmHJ-0003N3-Ja for bug-guile@gnu.org; Fri, 16 Mar 2018 06:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian) Resent-From: "Manuel A. Fernandez Montecelo" Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30832 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Mark H Weaver Cc: 30832@debbugs.gnu.org Received: via spool by 30832-submit@debbugs.gnu.org id=B30832.152119487412943 (code B ref 30832); Fri, 16 Mar 2018 10:08:01 +0000 Received: (at 30832) by debbugs.gnu.org; 16 Mar 2018 10:07:54 +0000 Received: from localhost ([127.0.0.1]:35732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewmHC-0003Mh-Hc for submit@debbugs.gnu.org; Fri, 16 Mar 2018 06:07:54 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:37567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewmHB-0003MQ-5U for 30832@debbugs.gnu.org; Fri, 16 Mar 2018 06:07:53 -0400 Received: by mail-lf0-f53.google.com with SMTP id y19-v6so14525777lfd.4 for <30832@debbugs.gnu.org>; Fri, 16 Mar 2018 03:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Mr8WvUMJPXmt4/fv/1t3f5nqvtfFj5V7t6kyiJmCkKU=; b=Xg5LP2xhjO3l+RGN6G4Ld5rSdKCW1LK1z3dnpQIuXCJRx/B0r+4dQxOv7bDKb1dIH/ lpgOrOvSBMecKq0m5rapOmivd13Lr7XqnRiGbsiNYVFZydY2cP041ybNgaEUFp847074 4BzNsXOUkJpGwIB7VYwEBoF/yBG8yzaUasbzlXHGt8pyJN0DCvMP0ek17doe9Ev3rzPQ unDZlBSmRb/SKzR90tQH1fckcp1bBe2XlT/vimJnl+PHngsUGyjjKvGL3/wlGK1ux+H0 P8yMe8b9NLnDNGJ9Ds71LlvFTPtjYVW66pZnj08Fs81sQ4cO+zoQ7ELawkBexwCCF0Ie nuag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Mr8WvUMJPXmt4/fv/1t3f5nqvtfFj5V7t6kyiJmCkKU=; b=jkfV6UK6SAMCwIwXl1Lt0g/9MunTliKQKfSsEdyaWwUO8NVt7uIM9gXwr/OksLVvgX Fb6H0HUHR2UZGkfmC7KC/zirNkRASE+hze4FdclRGo5F4vDyBwVDyYlwiYciGNW1b7eW o31LznjUEVQQUONlBFuNEzhq+WGFZHmDg4pjioZhUtxPLQPpoFNSpYzQ2XlZQWwFr7ks QQkTAAflE65PosxB20LL52aniT6TB4jlNwyO3MyHew8cKUXRT4Ia8FCe4zo9baCK8bkg N+zh5IoaBBrqIccbxCugpkdFomXh9mmTnuWr+50iFyP0l/hcToZK4FaV7m1HgydEmzFr o7cQ== X-Gm-Message-State: AElRT7HB+/wbQ8+nYGqRxkdcC3NmjhJUWSOKMriwk4pvp0H1TgKX2dLj tw83E+CCFpnSGmds6LuI+kWiRiLNNu2bHdZqI2s= X-Google-Smtp-Source: AG47ELvdh3UZoqaquVWBxpqJp/ti+5cC1Ei84EtYYR2fAY8NdlyO6k/c/bwUxXcXtDkS3BgRa1tu2nE7YQvIaTHSEQ0= X-Received: by 10.46.13.10 with SMTP id 10mr983879ljn.8.1521194867382; Fri, 16 Mar 2018 03:07:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9a08:0:0:0:0:0 with HTTP; Fri, 16 Mar 2018 03:07:06 -0700 (PDT) In-Reply-To: <87h8pg4pmz.fsf@netris.org> References: <87h8pg4pmz.fsf@netris.org> From: "Manuel A. Fernandez Montecelo" Date: Fri, 16 Mar 2018 11:07:06 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 10:08:13 -0000 2018-03-16 5:21 GMT+01:00 Mark H Weaver : > "Manuel A. Fernandez Montecelo" writes: >> Please add support for this architecture, simple patch attached (based >> on guile-2.0, the most popular version in Debian). > > This should be fixed now, using a patch provided earlier by Shea Levy > which also covers riscv32. See commit > 08bb4628369cf3efe7c96a32919705c41a9ed9e9 on the stable-2.2 branch and > d6e669b8cb26f870ea6611a54788b75fbad67bbe on the stable-2.0 branch. > > I'm closing this bug now, but please reopen if there are still issues. Ah, it's fine then. I assumed that addition of new features started in master and then some changes flowed down to stable branches when needed. Thanks! -- Manuel A. Fernandez Montecelo From MAILER-DAEMON Fri Mar 16 19:28:10 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ewyle-0002Ui-1o for mharc-bug-guile@gnu.org; Fri, 16 Mar 2018 19:28:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewylb-0002TL-Nd for bug-guile@gnu.org; Fri, 16 Mar 2018 19:28:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewylW-0007pP-Pl for bug-guile@gnu.org; Fri, 16 Mar 2018 19:28:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewylW-0007ox-JI for bug-guile@gnu.org; Fri, 16 Mar 2018 19:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewylW-0005fx-82 for bug-guile@gnu.org; Fri, 16 Mar 2018 19:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH] doc: Document (ice-9 match) macros. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 16 Mar 2018 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Mark H Weaver Cc: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.152124285421781 (code B ref 30144); Fri, 16 Mar 2018 23:28:02 +0000 Received: (at 30144) by debbugs.gnu.org; 16 Mar 2018 23:27:34 +0000 Received: from localhost ([127.0.0.1]:37391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewyl4-0005fF-1a for submit@debbugs.gnu.org; Fri, 16 Mar 2018 19:27:34 -0400 Received: from vultr.systemreboot.net ([45.77.148.100]:35046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewyl2-0005f1-2s for 30144@debbugs.gnu.org; Fri, 16 Mar 2018 19:27:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XLsxiNxY8Ac7Cpss71J+UcBvRcdH+MO0oocl+BI8ROM=; b=VsbeCCPFr6pyK442XXzzmflXh Isr8J1STxr0wSvLQlbxx7NNplTdeiZvfmzfVhbgSpsjhEmv/HX0ph+WGaZ4nDk/Uuh/4Hk5qhup18 IG18qC5AajbN8eQPM8cCcNmO/UMEwc2Zv3dCdPGXJB9p4qOMUdqX5EN0V5tIkKvW0cnUQ=; Received: from [61.3.26.0] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ewyko-0001W1-Fl; Sat, 17 Mar 2018 04:57:18 +0530 From: Arun Isaac In-Reply-To: <87woyc4qcs.fsf@netris.org> References: <20180117122504.25583-1-arunisaac@systemreboot.net> <87woyc4qcs.fsf@netris.org> Date: Sat, 17 Mar 2018 04:57:17 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 23:28:09 -0000 >> +Match each variable to the corresponding expression, and evaluate the >> +body with all matched variables in scope. Raise an error if any of the >> +expressions fail to match. @code{match-let} is analogous to named let > > It's only analogous to a named let if a variable name is inserted > immediately after 'match-let', before the clauses. In fact, the > named-let case is not covered by the first line of your definition where > you give the syntax. > How about removing any mention of named-let in this definition, and then > add a separate brief definition for the named-let variant of > 'match-let'? It might be worthwhile to keep them separate given that > their use cases and relevant examples are so different. What do you > think? I have made all the other changes except this one. I have never used match-let analogous to a named let, and am unable to get a working example. If you could show me a working example, I'll add it to the new patch. I'll send you the revised patch once we decide on the above. Thanks! From MAILER-DAEMON Mon Mar 19 20:34:07 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ey5E7-00057U-MZ for mharc-bug-guile@gnu.org; Mon, 19 Mar 2018 20:34:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey5E5-000579-QU for bug-guile@gnu.org; Mon, 19 Mar 2018 20:34:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey5E2-0000RW-LX for bug-guile@gnu.org; Mon, 19 Mar 2018 20:34:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey5E2-0000RS-Id for bug-guile@gnu.org; Mon, 19 Mar 2018 20:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ey5E2-00047G-7P for bug-guile@gnu.org; Mon, 19 Mar 2018 20:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH] doc: Document (ice-9 match) macros. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 20 Mar 2018 00:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.152150599015757 (code B ref 30144); Tue, 20 Mar 2018 00:34:02 +0000 Received: (at 30144) by debbugs.gnu.org; 20 Mar 2018 00:33:10 +0000 Received: from localhost ([127.0.0.1]:42390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey5DB-000465-VH for submit@debbugs.gnu.org; Mon, 19 Mar 2018 20:33:10 -0400 Received: from world.peace.net ([50.252.239.5]:33766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey5D9-00045Z-09 for 30144@debbugs.gnu.org; Mon, 19 Mar 2018 20:33:08 -0400 Received: from pool-72-93-34-155.bstnma.east.verizon.net ([72.93.34.155] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ey5D2-0003jY-Km; Mon, 19 Mar 2018 20:33:00 -0400 From: Mark H Weaver References: <20180117122504.25583-1-arunisaac@systemreboot.net> <87woyc4qcs.fsf@netris.org> Date: Mon, 19 Mar 2018 20:32:12 -0400 In-Reply-To: (Arun Isaac's message of "Sat, 17 Mar 2018 04:57:17 +0530") Message-ID: <87zi33bn8z.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 00:34:06 -0000 Hi Arun, Arun Isaac writes: >>> +Match each variable to the corresponding expression, and evaluate the >>> +body with all matched variables in scope. Raise an error if any of the >>> +expressions fail to match. @code{match-let} is analogous to named let >> >> It's only analogous to a named let if a variable name is inserted >> immediately after 'match-let', before the clauses. In fact, the >> named-let case is not covered by the first line of your definition where >> you give the syntax. > >> How about removing any mention of named-let in this definition, and then >> add a separate brief definition for the named-let variant of >> 'match-let'? It might be worthwhile to keep them separate given that >> their use cases and relevant examples are so different. What do you >> think? > > I have made all the other changes except this one. I have never used > match-let analogous to a named let, and am unable to get a working > example. If you could show me a working example, I'll add it to the new > patch. > > I'll send you the revised patch once we decide on the above. Thanks! I thought about it, and I can't easily think of a good use for named 'match-let'. Any recursion needs a base case, which requires at least two cases in the match, but 'match-let' does not allow for multiple cases for its matches. How about if we omit an example for named 'match-let', and simply say something like: @deffn {Scheme Syntax} match-let variable ((pattern init) @dots{}) body Similar to @code{match-let}, but analogously to @dfn{named let}, locally bind VARIABLE to a new procedure which accepts as many arguments as there are INIT expressions. The procedure is initially applied to the results of evaluating the INIT expressions. When called, the procedure matches each argument against the corresponding PATTERN, and returns the result(s) of evaluating the BODY expressions. @xref{while do, Iteration} for more on @dfn{named let}. Thanks! Mark From MAILER-DAEMON Mon Mar 19 21:20:07 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ey5wd-00042O-Ry for mharc-bug-guile@gnu.org; Mon, 19 Mar 2018 21:20:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey5wb-00041u-46 for bug-guile@gnu.org; Mon, 19 Mar 2018 21:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey5wX-0000Ny-UG for bug-guile@gnu.org; Mon, 19 Mar 2018 21:20:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34524) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey5wX-0000Ns-RG for bug-guile@gnu.org; Mon, 19 Mar 2018 21:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ey5wX-0005F3-L5 for bug-guile@gnu.org; Mon, 19 Mar 2018 21:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30869: regexp-substitute/global does not like #\nul in string Resent-From: Matt Wette Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 20 Mar 2018 01:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30869 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30869@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152150878520119 (code B ref -1); Tue, 20 Mar 2018 01:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2018 01:19:45 +0000 Received: from localhost ([127.0.0.1]:42421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey5wH-0005ER-Fx for submit@debbugs.gnu.org; Mon, 19 Mar 2018 21:19:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey5wF-0005EE-CN for submit@debbugs.gnu.org; Mon, 19 Mar 2018 21:19:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey5w6-00007Z-BM for submit@debbugs.gnu.org; Mon, 19 Mar 2018 21:19:38 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:54350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ey5w6-00007R-7U for submit@debbugs.gnu.org; Mon, 19 Mar 2018 21:19:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey5w5-0003xj-5S for bug-guile@gnu.org; Mon, 19 Mar 2018 21:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey5w1-0008W7-Vm for bug-guile@gnu.org; Mon, 19 Mar 2018 21:19:33 -0400 Received: from mail-pl0-x230.google.com ([2607:f8b0:400e:c01::230]:36657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey5w1-0008VO-P1 for bug-guile@gnu.org; Mon, 19 Mar 2018 21:19:29 -0400 Received: by mail-pl0-x230.google.com with SMTP id 61-v6so11397918plf.3 for ; Mon, 19 Mar 2018 18:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=4HygmLFK3bPThs0t7vNnivByNLUmhjx4qrlbq6RyLQw=; b=fECr78mAJwJnBo3z22OKe6RQqXe411+6RM6S0k18lcJKmaRTYtNXKaKh3gSCcnCyJT An6ESJoGO80kHugXguptCfRDlSwvlsFDPRrKfFlsuaAPNl8rT5uuJvGW1UVOL8VDd3V3 gQtCb1N7oX7NVL2viAgA98qlAPh2mbF6z6HgLxik4a20/EDoNE4jmDSYSpcqM3A1YG1j l2HE/f6B9Th8VUdeX2lYHeR5HgXGgVHgb0aysdvGFqBUUn8Oo3rCAbAkYiwJEPSUW1wt 8WzYkyUO3jhHPjOUwlE+zmh9jmrDUfhwakRcuqOOJjRmdX1475JnQy293E9Qx6ECHnvd kgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=4HygmLFK3bPThs0t7vNnivByNLUmhjx4qrlbq6RyLQw=; b=g31/uA3GQwbD1DqF6bqqtYwuiIlaFwbGlQ4Lw5Vd1jylX5q8xm1iPzG+bW8UiEzAbW v9gyrOnqA+vVWLtKUFGowTVsMdtW3HxYSuSvOTGt4mOdnuCUvrYfwJRIOavUWrs3jmE+ QmcSXG60tfuopv1BxqVtdTR7eJ7I1bQIRmPuVILSGvTqBDbRuPKwgt0086GYaUA42UFa 3k5qeRRvoij3v+4nIWHNBbLbPBFuHCGxQqpe96mpNmZUbi6UV7pa+qL5VXwWAANHFTyE km6AFqguxFWVjKk5n7lCu2KXXbDMk/yM6vwYVLhByq5UEDb18e666z+l4uFa27r1vs2u 2DdQ== X-Gm-Message-State: AElRT7HMoY7zm+Q1eJ6T/4ZO5KyvsfLyefajJKEKR4du7n1D+lXpUQ5s HnU8KY/SxO4dP2jygmYIvr4RN0N3 X-Google-Smtp-Source: AG47ELs3Kw+gpRslfoHsou9m7rbXqlD/QlrNZ2yLPYWUszPMC3JPixxYhJOdQ+/ZnV0CVtCwKJy27Q== X-Received: by 2002:a17:902:5588:: with SMTP id g8-v6mr14144344pli.73.1521508768208; Mon, 19 Mar 2018 18:19:28 -0700 (PDT) Received: from [192.168.2.183] (216-165-229-229.championbroadband.com. [216.165.229.229]) by smtp.gmail.com with ESMTPSA id r16sm540039pfj.111.2018.03.19.18.19.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Mar 2018 18:19:27 -0700 (PDT) From: Matt Wette Message-ID: Date: Mon, 19 Mar 2018 18:19:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 01:20:06 -0000 version = 2.2.3 I think this is a bug: regexp-substitute/global rejects strings with #\nul: scheme@(guile-user)> (regexp-substitute/global #f "b.d" "ab\x00de" 'pre 'post) ERROR: In procedure regexp-exec: string contains #\nul character: "ab\x00de" From MAILER-DAEMON Fri Mar 23 10:23:10 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ezNb4-0007yx-JF for mharc-bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNb1-0007xh-F5 for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNaw-0004lG-Up for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezNaw-0004l2-Qw for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezNaw-0005Gc-LU for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH 1/1] doc: Document (ice-9 match) macros. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 23 Mar 2018 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.152181496620196 (code B ref 30144); Fri, 23 Mar 2018 14:23:02 +0000 Received: (at 30144) by debbugs.gnu.org; 23 Mar 2018 14:22:46 +0000 Received: from localhost ([127.0.0.1]:49835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNag-0005Fg-8P for submit@debbugs.gnu.org; Fri, 23 Mar 2018 10:22:46 -0400 Received: from vultr.systemreboot.net ([45.77.148.100]:59998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNae-0005FR-6Z for 30144@debbugs.gnu.org; Fri, 23 Mar 2018 10:22:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JL3BSAGhHWXbCgNjP2YFatP4zfhKJZ6vEWBt1QCpevY=; b=QednUtFzoiX7uvsv8tUcoEA67 V2rYlIKntX86CDDfQjdI9tU/4lRZOumOuPTrVf8Z7zgm+GheAQw/DDnsraqBjlEkTXEBm2lLOl6jE LkSVH0qVtmlTw/CmfyQhB9yWvAkwFPpmwq70sJBHhTupxuMkpBoWj0QRWFlG1f6L4Msuk=; Received: from [117.192.124.137] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ezNaW-0007f4-Rc; Fri, 23 Mar 2018 19:52:36 +0530 From: Arun Isaac Date: Fri, 23 Mar 2018 19:52:04 +0530 Message-Id: <20180323142204.23420-2-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180323142204.23420-1-arunisaac@systemreboot.net> References: <20180323142204.23420-1-arunisaac@systemreboot.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 14:23:09 -0000 * doc/ref/match.texi: Document match-lambda, match-lambda*, match-let, match-let* and match-letrec. --- doc/ref/match.texi | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/doc/ref/match.texi b/doc/ref/match.texi index 12e3814ae..0fc5105d1 100644 --- a/doc/ref/match.texi +++ b/doc/ref/match.texi @@ -213,8 +213,96 @@ any @var{person} whose second slot is a promise that evaluates to a one-element list containing a @var{person} whose first slot is @code{"Bob"}. -Please refer to the @code{ice-9/match.upstream.scm} file in your Guile -installation for more details. +The @code{(ice-9 match)} module also provides the following convenient +syntactic sugar macros wrapping around @code{match}. + +@deffn {Scheme Syntax} match-lambda exp clause1 clause2 @dots{} +Create a procedure of one argument that matches its argument against +each clause, and returns the result of evaluating the corresponding +expressions. + +@example +(match-lambda clause1 clause2 @dots{}) +@equiv{} +(lambda (arg) (match arg clause1 clause2 @dots{})) +@end example +@end deffn + +@example +((match-lambda + (('hello (who)) + who)) + '(hello (world))) +@result{} world +@end example + +@deffn {Scheme Syntax} match-lambda* exp clause1 clause2 @dots{} +Create a procedure of any number of arguments that matches its argument +list against each clause, and returns the result of evaluating the +corresponding expressions. + +@example +(match-lambda* clause1 clause2 @dots{}) +@equiv{} +(lambda args (match args clause1 clause2 @dots{})) +@end example +@end deffn + +@example +((match-lambda* + (('hello (who)) + who)) + 'hello '(world)) +@result{} world +@end example + +@deffn {Scheme Syntax} match-let ((pattern expression) @dots{}) body +Match each pattern to the corresponding expression, and evaluate the +body with all matched variables in scope. Raise an error if any of the +expressions fail to match. @code{match-let} is analogous to named let +and can also be used for recursive functions which match on their +arguments as in @code{match-lambda*}. + +@example +(match-let (((x y) (list 1 2)) + ((a b) (list 3 4))) + (list a b x y)) +@result{} +(3 4 1 2) +@end example +@end deffn + +@deffn {Scheme Syntax} match-let variable ((pattern init) @dots{}) body +Similar to @code{match-let}, but analogously to @dfn{named let}, locally +bind VARIABLE to a new procedure which accepts as many arguments as +there are INIT expressions. The procedure is initially applied to the +results of evaluating the INIT expressions. When called, the procedure +matches each argument against the corresponding PATTERN, and returns the +result(s) of evaluating the BODY expressions. @xref{while do, +Iteration}, for more on @dfn{named let}. +@end deffn + +@deffn {Scheme Syntax} match-let* ((variable expression) @dots{}) body +Similar to @code{match-let}, but analogously to @code{let*}, match and +bind the variables in sequence, with preceding match variables in scope. + +@example +(match-let* (((x y) (list 1 2)) + ((a b) (list x 4))) + (list a b x y)) +@equiv{} +(match-let (((x y) (list 1 2))) + (match-let (((a b) (list x 4))) + (list a b x y))) +@result{} +(1 4 1 2) +@end example +@end deffn + +@deffn {Scheme Syntax} match-letrec ((variable expression) @dots{}) body +Similar to @code{match-let}, but analogously to @code{letrec}, match and +bind the variables with all match variables in scope. +@end deffn Guile also comes with a pattern matcher specifically tailored to SXML trees, @xref{sxml-match}. -- 2.15.1 From MAILER-DAEMON Fri Mar 23 10:23:12 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ezNb6-00080W-06 for mharc-bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNb2-0007y1-BN for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNaw-0004kT-H9 for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezNaw-0004kL-Ci for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezNaw-0005GU-5O for bug-guile@gnu.org; Fri, 23 Mar 2018 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30144: [PATCH 0/1] Document (ice-9 match) macros References: <20180117122504.25583-1-arunisaac@systemreboot.net> In-Reply-To: <20180117122504.25583-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 23 Mar 2018 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30144 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 30144@debbugs.gnu.org Received: via spool by 30144-submit@debbugs.gnu.org id=B30144.152181495620172 (code B ref 30144); Fri, 23 Mar 2018 14:23:02 +0000 Received: (at 30144) by debbugs.gnu.org; 23 Mar 2018 14:22:36 +0000 Received: from localhost ([127.0.0.1]:49832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNaW-0005FI-21 for submit@debbugs.gnu.org; Fri, 23 Mar 2018 10:22:36 -0400 Received: from vultr.systemreboot.net ([45.77.148.100]:59990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNaU-0005F4-8q for 30144@debbugs.gnu.org; Fri, 23 Mar 2018 10:22:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender: Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q0UyC5ziXZrqo2LeKjLBsQWwghLcIuEMlGmn+I6PJ0c=; b=SmXwKLkslcX93haMKy80cUzwvC bK4eWBVMQG0r9+FKZMmozw+Gbs7UZHQfFSdNUm3rIIBAZWnYf5Q4PSXQeS8lKz2WJeRuJR0b4j1F9 0ApMlaWy4uLHxAkmHttH97VSfRrkl7KISAF3iPhKWebUT7OO4cLns8rhTLdgmapq83So=; Received: from [117.192.124.137] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ezNaL-0007f4-4E; Fri, 23 Mar 2018 19:52:25 +0530 From: Arun Isaac Date: Fri, 23 Mar 2018 19:52:03 +0530 Message-Id: <20180323142204.23420-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.15.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 14:23:09 -0000 Hi, I have made all the changes you suggested. Patch follows. Thanks. Arun Isaac (1): doc: Document (ice-9 match) macros. doc/ref/match.texi | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 90 insertions(+), 2 deletions(-) -- 2.15.1 From MAILER-DAEMON Sat Mar 24 01:16:11 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ezbXG-0006LL-V7 for mharc-bug-guile@gnu.org; Sat, 24 Mar 2018 01:16:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezbXD-0006Jk-Oi for bug-guile@gnu.org; Sat, 24 Mar 2018 01:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezbXA-0006lR-J0 for bug-guile@gnu.org; Sat, 24 Mar 2018 01:16:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezbXA-0006lA-Fh for bug-guile@gnu.org; Sat, 24 Mar 2018 01:16:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezbXA-00029L-84 for bug-guile@gnu.org; Sat, 24 Mar 2018 01:16:04 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30920: doc: Inconsistent parentheses in "(guile) sxml-match" Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 24 Mar 2018 05:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30920 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30920@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15218685088181 (code B ref -1); Sat, 24 Mar 2018 05:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Mar 2018 05:15:08 +0000 Received: from localhost ([127.0.0.1]:50340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezbWG-00027s-Kd for submit@debbugs.gnu.org; Sat, 24 Mar 2018 01:15:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezbWE-000275-Hw for submit@debbugs.gnu.org; Sat, 24 Mar 2018 01:15:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezbW8-00064K-Kg for submit@debbugs.gnu.org; Sat, 24 Mar 2018 01:15:01 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:43058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezbW8-000645-HX for submit@debbugs.gnu.org; Sat, 24 Mar 2018 01:15:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezbW7-0005TV-2a for bug-guile@gnu.org; Sat, 24 Mar 2018 01:15:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezbW3-0005yr-Uu for bug-guile@gnu.org; Sat, 24 Mar 2018 01:14:59 -0400 Received: from vultr.systemreboot.net ([45.77.148.100]:50578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezbW3-0005v7-GP for bug-guile@gnu.org; Sat, 24 Mar 2018 01:14:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gt1sE0G5OcxwiLXps3VYPKK/DHxqZUxSGn9+5CLoZLc=; b=WW1OV+4DrXEiEMV9zLYiFi2JYC yzZxhz3LKmSylqEF6uy6SwsrGzsbbDE/qfKSKzx5jb4hSyBSHSsxKjcrM3wEH466g0yLCx2jSUPfg 5hY3a5ur1gi0dOMTIePch922je5e1ik8o+tKuOOdnfIjFrr9ijP9HVjh61A5sfD/6XQk=; Received: from [103.61.73.218] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ezbVu-0004DI-Vi for bug-guile@gnu.org; Sat, 24 Mar 2018 10:44:47 +0530 From: Arun Isaac Date: Sat, 24 Mar 2018 10:44:46 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 05:16:09 -0000 All examples in "(guile) sxml-match" use square parentheses around each match clause. However, in the subsection "Guards in Patterns" alone, the example has round parentheses. I think it would be nice to use round parentheses consistently in all examples so that sxml-match and match have the same syntax. But, I have no strong opinions. If you can recommend which way to go, I can provide a patch for the same. From MAILER-DAEMON Sun Mar 25 17:31:08 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f0DEK-0007Ni-4W for mharc-bug-guile@gnu.org; Sun, 25 Mar 2018 17:31:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0DEH-0007NP-Eo for bug-guile@gnu.org; Sun, 25 Mar 2018 17:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0DEE-0008Gj-Sg for bug-guile@gnu.org; Sun, 25 Mar 2018 17:31:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0DEE-0008Gb-Ow for bug-guile@gnu.org; Sun, 25 Mar 2018 17:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0DEE-0002Q3-JK for bug-guile@gnu.org; Sun, 25 Mar 2018 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30941: Documentation bug. Resent-From: Fis Trivial Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 25 Mar 2018 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30941 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30941@debbugs.gnu.org X-Debbugs-Original-To: "bug-guile@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.15220134579286 (code B ref -1); Sun, 25 Mar 2018 21:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Mar 2018 21:30:57 +0000 Received: from localhost ([127.0.0.1]:53242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0DE8-0002Pi-S1 for submit@debbugs.gnu.org; Sun, 25 Mar 2018 17:30:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0DE6-0002PS-Pa for submit@debbugs.gnu.org; Sun, 25 Mar 2018 17:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0DE0-00086C-Ot for submit@debbugs.gnu.org; Sun, 25 Mar 2018 17:30:49 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:53149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0DE0-000865-LC for submit@debbugs.gnu.org; Sun, 25 Mar 2018 17:30:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0DDz-0007He-8v for bug-guile@gnu.org; Sun, 25 Mar 2018 17:30:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0DDw-00083Y-Kk for bug-guile@gnu.org; Sun, 25 Mar 2018 17:30:47 -0400 Received: from mail-oln040092002093.outbound.protection.outlook.com ([40.92.2.93]:64810 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0DDw-00082d-De for bug-guile@gnu.org; Sun, 25 Mar 2018 17:30:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+DcewAyTVm3bz1BwKPat5xLLpBCmP1LNZA8aby2Etj4=; b=jNs4wEXh6NsbdvylksNgTBFLWlKvD0G/x5XO5Ug617zrRXQs9iPV8LZ6Phcg+4gBaHFPXOo3OJuu4DHHzWv1SVjtSmfzL6Nsd9d4nxj5iZqsfeUg3MnBr2JjmSHtOfWCSb62O2tY0eqajHmFX92gOIEQkM8JU2nX+sSSNC+HgWV8qeNCXwHMiEDTVdS9xOL6prLwRzGQbiD1nWGi6ypTp8QnAuaMuptWW0g9VgKnIN7CNlaXzKTIY0D1aER50WHQzwkLnL3M++eW6bUZJJO/Q6KlpDFQmjp53ME7ejq6fBF39rPO0Jf1Y81wEB8Q1qTUNawe2a+nxpcavUy8A4NO5w== Received: from SN1NAM01FT048.eop-nam01.prod.protection.outlook.com (10.152.64.54) by SN1NAM01HT021.eop-nam01.prod.protection.outlook.com (10.152.64.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.18; Sun, 25 Mar 2018 21:30:42 +0000 Received: from MWHPR16MB0063.namprd16.prod.outlook.com (10.152.64.56) by SN1NAM01FT048.mail.protection.outlook.com (10.152.64.249) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.18 via Frontend Transport; Sun, 25 Mar 2018 21:30:42 +0000 Received: from MWHPR16MB0063.namprd16.prod.outlook.com ([fe80::4837:ff64:fd4d:db58]) by MWHPR16MB0063.namprd16.prod.outlook.com ([fe80::4837:ff64:fd4d:db58%17]) with mapi id 15.20.0609.012; Sun, 25 Mar 2018 21:30:42 +0000 From: Fis Trivial Thread-Topic: Documentation bug. Thread-Index: AQHTxICHnJCIgiFE5kqOpreJsTmKFw== Date: Sun, 25 Mar 2018 21:30:42 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:891F132842253183576450D02846401A98375ABE0859FAD68B8BAFBE19743CED; UpperCasedChecksum:508352ADF3FBDD553A35CDCA135192EE63743443AB818DCBE23D00230388112A; SizeAsReceived:6859; Count:44 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [c4FElvTEoS6tlWB6B6ycXicJ3dYj3Kn9] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN1NAM01HT021; 6:GD58nUETfsizjGQwXBiC/VqjzgzZPAHhP1MYMDC1YiZXZ/YgO/elpco3EqUjQJkMwomOrNcggIfZO3C4uSQg3WChGzFkEY+Ge8mj6PH32qKaE/ee30dWgGWxa1qWQAa8WMYh3qPbd2Q1dh2QPUpkmEMiJEVq376sfyq9hW3Q58SzmODI1F/2n9tmaWaDI9YkcFDj790SNgnmR85+bX01urd0KeyGbW4pV/IyLbjCwJZg1EPSaoNAE0ZxXmTclsH5EBSyk7nuiwkJNJEue77cFFaogox3QS4XVMimw0huLdjpgwaH9fHNNYF1SQqr3XaM3eo4LRmvGZxcKsmdbjUa95z8pYqoIN7xDAqAwH0lHE0=; 5:QNkSV8hCkhadCfFNHcZq1IeHT6hSoTTBmX1f3CWOyNwu2lH1mjnzkpdtDy40dsEo92TODTvveazjARRyQP4ch9MO45ofWb4m3fyue1Yekf3M2iRGZh6pMHP1CTFIwkvww8IphelS2U/uYQ9w48OjESDbZQpypC86apiHYiK2PUI=; 24:eM52arzwYio9wvzcN9KevD8NPLh5ugKQ96EvFAE95Me5tJTWT9zOLv9/Vw7XM+nZe1k3JxjOnPLT3mGpTpOSedOv26C64dR2I8YAiNuxzhI=; 7:Dr5EsmgyEFYkBmQWSD5lxHdcW/ZsEQsR2yrfwfZEN9pgNnFxj21M2y822OHaG8xMXcIQSyxh1ZxmU7h2JrAbMJAzFGnn+Kl6NVDu6pDAXfFivVwpnQEAaUqAwPGz8LyxTPJj0+OzD1z0xkepniJb1ZQ0jzfHHfHD/p88jJuiyy1nrYehk3F6Cg0fRfgtdzm69LFn0otD1qzLd5Tyvv80noR2O6xK+5MZjpc6MZDKsdrTYFI8cVNkze2jWQR/UpuH x-incomingheadercount: 44 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125374)(1603101448)(1701031045); SRVR:SN1NAM01HT021; x-ms-traffictypediagnostic: SN1NAM01HT021: x-ms-office365-filtering-correlation-id: 5f26015b-266a-4d54-5535-08d59297a93a x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:SN1NAM01HT021; BCL:0; PCL:0; RULEID:; SRVR:SN1NAM01HT021; x-forefront-prvs: 0622A98CD5 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:SN1NAM01HT021; H:MWHPR16MB0063.namprd16.prod.outlook.com; FPR:; SPF:None; LANG:; x-microsoft-antispam-message-info: JwCEcVX+mA71L8jZsmgTFNmX3OKx7Fj4UqQlcYnHiZT3WT04HJR9B5ezeQuthyqKn5p2/YwnHJZ631zIbcDYZHUx4JrmXctap3R634uwpsvcSaFyT5ywyrx6oZybbHeU4iQW4YBD+sWgX7IZm0dUizEUGiAE0KJ4yuFFRLuhr/zH65r/rpeZE+KNp3Xrfvie spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f26015b-266a-4d54-5535-08d59297a93a X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2018 21:30:42.5776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM01HT021 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 21:31:06 -0000 On the subject: Defining Foreign Object Types at https://www.gnu.org/software/guile/manual/html_node/Defining-Foreign-Object= -Types.html#Defining-Foreign-Object-Types There is a example code snippet written in c. In the middle of that snippet: #+BEGIN_SRC c static SCM image_type image_type; #+END_SRC I think the declaration is wrong, there should be only one `image_type`. :). From MAILER-DAEMON Mon Mar 26 10:12:14 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f0Sr8-0001YN-0u for mharc-bug-guile@gnu.org; Mon, 26 Mar 2018 10:12:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Sr0-0001ST-K5 for bug-guile@gnu.org; Mon, 26 Mar 2018 10:12:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Sqw-0002rC-Nx for bug-guile@gnu.org; Mon, 26 Mar 2018 10:12:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0Sqw-0002qw-Jz for bug-guile@gnu.org; Mon, 26 Mar 2018 10:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0Sqw-0007om-Ee for bug-guile@gnu.org; Mon, 26 Mar 2018 10:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30953: =?UTF-8?Q?=E2=80=98min=E2=80=99?= and =?UTF-8?Q?=E2=80=98max=E2=80=99?= behavior when mixing exact and inexact numbers. Resent-From: Mathieu Lirzin Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 26 Mar 2018 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30953 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 30953@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152207348730000 (code B ref -1); Mon, 26 Mar 2018 14:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Mar 2018 14:11:27 +0000 Received: from localhost ([127.0.0.1]:54467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0SqN-0007no-GY for submit@debbugs.gnu.org; Mon, 26 Mar 2018 10:11:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0SqL-0007nZ-2R for submit@debbugs.gnu.org; Mon, 26 Mar 2018 10:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0SqC-0002NA-1k for submit@debbugs.gnu.org; Mon, 26 Mar 2018 10:11:19 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:45289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0SqB-0002N0-Mb for submit@debbugs.gnu.org; Mon, 26 Mar 2018 10:11:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Sq5-0001Ja-WC for bug-guile@gnu.org; Mon, 26 Mar 2018 10:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Sq0-0002G5-2Z for bug-guile@gnu.org; Mon, 26 Mar 2018 10:11:09 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Spz-0002G0-VV for bug-guile@gnu.org; Mon, 26 Mar 2018 10:11:04 -0400 Received: from [2a01:e35:2ec2:e580:7d5f:f616:fc6f:3970] (port=35610 helo=godel) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f0Spz-0006lD-GR for bug-guile@gnu.org; Mon, 26 Mar 2018 10:11:03 -0400 From: Mathieu Lirzin Date: Mon, 26 Mar 2018 16:11:01 +0200 Message-ID: <87sh8nkjuy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 14:12:12 -0000 Hello, I am observing a unexpected behavior of =E2=80=98min=E2=80=99 and =E2=80=98= max=E2=80=99: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (min 1 2.4) $2 =3D 1.0 scheme@(guile-user)> (min 1/2 4.0) $7 =3D 0.5 scheme@(guile-user)> (max 4 3.5) $4 =3D 4.0 --8<---------------cut here---------------end--------------->8--- I would expect the results to be integers instead. AIUI the implementation of the =E2=80=98min=E2=80=99 procedure should to be equivale= nt to: (define (min val . rest) (let loop ((x val) (other rest)) (match other (() x) ((y . rest) (loop (if (< x y) x y) rest))))) Maybe there is a good performance reason for the current behavior. If that's the case then it should be specified in the manual that exact numbers are converted to real numbers when at least one of the arguments is inexact. Thanks. --=20 Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 From MAILER-DAEMON Mon Mar 26 22:23:11 2018 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f0eGU-00019Z-Vz for mharc-bug-guile@gnu.org; Mon, 26 Mar 2018 22:23:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0eGQ-00017e-Fz for bug-guile@gnu.org; Mon, 26 Mar 2018 22:23:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0eGM-0004DZ-EM for bug-guile@gnu.org; Mon, 26 Mar 2018 22:23:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0eGM-0004DK-Au for bug-guile@gnu.org; Mon, 26 Mar 2018 22:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0eGM-0008DN-2U for bug-guile@gnu.org; Mon, 26 Mar 2018 22:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30953: =?UTF-8?Q?=E2=80=98min=E2=80=99?= and =?UTF-8?Q?=E2=80=98max=E2=80=99?= behavior when mixing exact and inexact numbers. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 27 Mar 2018 02:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30953 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Mathieu Lirzin Cc: 30953@debbugs.gnu.org Received: via spool by 30953-submit@debbugs.gnu.org id=B30953.152211734431529 (code B ref 30953); Tue, 27 Mar 2018 02:23:02 +0000 Received: (at 30953) by debbugs.gnu.org; 27 Mar 2018 02:22:24 +0000 Received: from localhost ([127.0.0.1]:54984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0eFk-0008CR-Hf for submit@debbugs.gnu.org; Mon, 26 Mar 2018 22:22:24 -0400 Received: from world.peace.net ([50.252.239.5]:57062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0eFi-0008C3-LP; Mon, 26 Mar 2018 22:22:22 -0400 Received: from pool-72-93-33-63.bstnma.east.verizon.net ([72.93.33.63] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0eFc-000363-Du; Mon, 26 Mar 2018 22:22:16 -0400 From: Mark H Weaver References: <87sh8nkjuy.fsf@gnu.org> Date: Mon, 26 Mar 2018 22:21:25 -0400 In-Reply-To: <87sh8nkjuy.fsf@gnu.org> (Mathieu Lirzin's message of "Mon, 26 Mar 2018 16:11:01 +0200") Message-ID: <87bmfa45sq.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 02:23:07 -0000 tags 30953 + notabug close 30953 thanks Hi Mathieu, Mathieu Lirzin writes: > I am observing a unexpected behavior of =E2=80=98min=E2=80=99 and =E2=80= =98max=E2=80=99: > > --8<---------------cut here---------------start------------->8--- > scheme@(guile-user)> (min 1 2.4) > $2 =3D 1.0 > scheme@(guile-user)> (min 1/2 4.0) > $7 =3D 0.5 > scheme@(guile-user)> (max 4 3.5) > $4 =3D 4.0 > --8<---------------cut here---------------end--------------->8--- > > I would expect the results to be integers instead. 1.0 and 4.0 _are_ integers, in the terminology of both Scheme and mathematics. However, they are _inexact_ integers. I'm not sure why you would expect (min 1/2 4.0) to return an integer. By the result of exactness propagation in Scheme, these results must be inexact, because the results depend on the value of an inexact argument. For example, in (min 1 2.4), if the 2.4 were replaced with 0.8, then the result would be 0.8 instead of 1.0. It's entirely possible that the inexact arithmetic leading to 2.4 might have a maximum error greater than 1.4. The idea is that if Scheme tells you that the result of some computation is exact, then it could in principle be proved to be the true mathematical result, and therefore known to be unaffected by any inexact computation. So, (min 1 2.4) could only return an exact 1 if it were somehow known that the 2.4 has a maximum error of 1.4. I suspect you are thinking to yourself "the 2.4 might be imprecise, but surely it's not so far off to affect the result here." However, there's no upper bound on the error of an inexact number, when one considers the entire history of inexact operations that led to it. For details, see R5RS section 6.2.2 (Exactness), R6RS section 11.7.1 (Propagation of exactness and inexactness), and R7RS section 6.2.2 (Exactness). > AIUI the > implementation of the =E2=80=98min=E2=80=99 procedure should to be equiva= lent to: > > (define (min val . rest) > (let loop ((x val) (other rest)) > (match other > (() x) > ((y . rest) (loop (if (< x y) x y) rest))))) This would violate the exactness propagation rules. > Maybe there is a good performance reason for the current behavior. If > that's the case then it should be specified in the manual that exact > numbers are converted to real numbers when at least one of the arguments > is inexact. In Scheme (and mathematics), 1 and 1/2 are considered real numbers, and 1.0 is both a real number and an integer. In Scheme, the only difference between 1 and 1.0 is that 1 is exact and 1.0 is inexact. Lesser programming languages say that 1 is not a real number and that 1.0 is not an integer, but from a mathematical point of view, that's nonsense :) Regards, Mark