From MAILER-DAEMON Wed Apr 01 02:05:44 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJWVU-0007pz-IM for mharc-bug-make@gnu.org; Wed, 01 Apr 2020 02:05:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34790) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJWVS-0007nj-7d for bug-make@gnu.org; Wed, 01 Apr 2020 02:05:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJWVR-0006XN-5x for bug-make@gnu.org; Wed, 01 Apr 2020 02:05:42 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:38038) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJWVR-0006Vt-2r; Wed, 01 Apr 2020 02:05:41 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 7D24820B76; Wed, 1 Apr 2020 02:05:40 -0400 (EDT) To: "Paul D. Smith" , Natanael Copa , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #57674] GNU make doesn't use default path if PATH not set X-PHP-Originating-Script: 1001:sendmail.php From: "Paul D. Smith" X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 57674 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36 X-Apparently-From: 98.118.0.140 (Savane authenticated user psmith) Message-Id: <20200401-020540.sv260.78248@savannah.gnu.org> References: <20200127-114155.sv41114.7598@savannah.gnu.org> <20200130-102530.sv41114.92193@savannah.gnu.org> <20200331-193248.sv260.78428@savannah.gnu.org> <20200331-193331.sv260.49986@savannah.gnu.org> <20200331-193344.sv260.49508@savannah.gnu.org> In-Reply-To: <20200331-193344.sv260.49508@savannah.gnu.org> Date: Wed, 1 Apr 2020 02:05:40 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 06:05:43 -0000 Update of bug #57674 (project make): Status: None => Fixed Open/Closed: Open => Closed Fixed Release: None => SCM _______________________________________________________ Follow-up Comment #3: I pushed a fix for this. Thanks for reporting! _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Wed Apr 01 08:34:04 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJcZI-0000F3-79 for mharc-bug-make@gnu.org; Wed, 01 Apr 2020 08:34:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53705) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJcZD-0000Dl-8e for bug-make@gnu.org; Wed, 01 Apr 2020 08:34:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJcZB-0004Hf-9Z for bug-make@gnu.org; Wed, 01 Apr 2020 08:33:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:35832) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJcYy-0003v9-Fy; Wed, 01 Apr 2020 08:33:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5AD54AD39; Wed, 1 Apr 2020 12:14:42 +0000 (UTC) From: Andreas Schwab To: "Paul D. Smith" Cc: "Paul D. Smith" , Natanael Copa , boris@kolpackov.net, bug-make@gnu.org Subject: Re: [bug #57674] regression in make 4.3 with makefile from stdin References: <20200127-114155.sv41114.7598@savannah.gnu.org> <20200130-102530.sv41114.92193@savannah.gnu.org> <20200331-193248.sv260.78428@savannah.gnu.org> X-Yow: Make me look like LINDA RONSTADT again!! Date: Wed, 01 Apr 2020 14:14:42 +0200 In-Reply-To: <20200331-193248.sv260.78428@savannah.gnu.org> (Paul D. Smith's message of "Tue, 31 Mar 2020 19:32:49 -0400 (EDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 12:34:00 -0000 On M=C3=A4r 31 2020, Paul D. Smith wrote: > In GNU make 4.3, for performance reasons we choose to use posix_spawn()= if > it's available on the system. posix_spawn() doesn't do any path search= , so we > do it ourselves and we don't have this backup default PATH lookup that > execvp() does. There is also posix_spawnp. Andreas. --=20 Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D= 7 "And now for something completely different." From MAILER-DAEMON Wed Apr 01 09:02:10 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJd0U-000067-M9 for mharc-bug-make@gnu.org; Wed, 01 Apr 2020 09:02:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33236) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJd0S-000060-Gr for bug-make@gnu.org; Wed, 01 Apr 2020 09:02:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jJd0S-00039G-2J; Wed, 01 Apr 2020 09:02:08 -0400 Received: from pool-98-118-0-140.bstnma.fios.verizon.net ([98.118.0.140]:52310 helo=pdslaptop.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jJd0R-000059-L0; Wed, 01 Apr 2020 09:02:07 -0400 Message-ID: <687fdbab50d52921527e430d2677960ca4533852.camel@gnu.org> Subject: Re: [bug #57674] regression in make 4.3 with makefile from stdin From: Paul Smith Reply-To: psmith@gnu.org To: Andreas Schwab Cc: Natanael Copa , bug-make@gnu.org Date: Wed, 01 Apr 2020 09:02:06 -0400 In-Reply-To: References: <20200127-114155.sv41114.7598@savannah.gnu.org> <20200130-102530.sv41114.92193@savannah.gnu.org> <20200331-193248.sv260.78428@savannah.gnu.org> Organization: GNU's Not UNIX! Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 13:02:09 -0000 On Wed, 2020-04-01 at 14:14 +0200, Andreas Schwab wrote: > On Mär 31 2020, Paul D. Smith wrote: > > > In GNU make 4.3, for performance reasons we choose to use > > posix_spawn() if it's available on the system. posix_spawn() > > doesn't do any path search, so we do it ourselves and we don't have > > this backup default PATH lookup that execvp() does. > > There is also posix_spawnp. Unfortunately it's hard to use for us. The fork/exec code worked by first forking, then installing the child's environment, then running execvp. This ensured that the PATH lookup happened with the child's environment. posix_spawnp obviously does not do the fork, which means that it will do the path lookup with the parent's environment, which is wrong (for us at least). The only option would be to setenv the child's PATH before invoking posix_spawnp() then set it back again afterward. From MAILER-DAEMON Wed Apr 01 14:43:57 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJiLE-0000g0-Om for mharc-bug-make@gnu.org; Wed, 01 Apr 2020 14:43:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJiLB-0000fW-Qr for bug-make@gnu.org; Wed, 01 Apr 2020 14:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJiL9-00051l-UG for bug-make@gnu.org; Wed, 01 Apr 2020 14:43:53 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:60974) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJiL9-00051L-Ff; Wed, 01 Apr 2020 14:43:51 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 4661720CB4; Wed, 1 Apr 2020 14:43:51 -0400 (EDT) To: Steffen Dettmer , "Paul D. Smith" , Martin Dorey , David Boyce , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #57914] abspath does resolve symlink X-PHP-Originating-Script: 1001:sendmail.php From: Steffen Dettmer X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 57914 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36 X-Apparently-From: 165.225.194.202 (Savane authenticated user sdettmer) Message-Id: <20200401-184351.sv183076.9185@savannah.gnu.org> References: <20200228-090750.sv0.78409@savannah.gnu.org> <20200228-091705.sv183076.51936@savannah.gnu.org> <20200331-153401.sv82528.77521@savannah.gnu.org> <20200331-180759.sv183076.71105@savannah.gnu.org> <20200331-182215.sv82528.16302@savannah.gnu.org> <20200331-114858.sv46964.51218@savannah.gnu.org> <20200331-182706.sv260.72731@savannah.gnu.org> In-Reply-To: <20200331-182706.sv260.72731@savannah.gnu.org> Date: Wed, 1 Apr 2020 14:43:51 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 18:43:55 -0000 Follow-up Comment #7, bug #57914 (project make): Thank you all for your explanations. I think I now understand it correctly :) [comment #6 comment #6:] > Just as another proof that it's a feature of the shell: if you don't use the shell's built-in pwd command but instead use /bin/pwd, you'll see that just like make (also not a built-in command in the shell :-)) it shows the physical path: This one I know (already met in practice). According to the documentation, it is just a matter of defaults: "pwd" w/o args defaults to "pwd -L", but "/bin/pwd" to "/bin/pwd -P", but that are just defaults: sdettmer@RefVm3:/tmp $ cd /tmp/ sdettmer@RefVm3:/tmp $ mkdir /tmp/x1 sdettmer@RefVm3:/tmp $ ln -s /tmp/x1 foo sdettmer@RefVm3:/tmp $ (cd foo && pwd -L && pwd && pwd -P) /tmp/foo /tmp/foo /tmp/x1 sdettmer@RefVm3:/tmp $ (cd foo && /bin/pwd -L && /bin/pwd && /bin/pwd -P) /tmp/foo /tmp/x1 /tmp/x1 sdettmer@RefVm3:/tmp $ At least my /bin/pwd (GNU coreutils 8.26) is using $PWD from environment: sdettmer@RefVm3:/tmp $ man pwd|grep -1 -- -L -L, --logical use PWD from environment, even if it contains symlinks sdettmer@RefVm3:/tmp $ (cd foo && /bin/pwd -L && PWD="" /bin/pwd -L ) /tmp/foo /tmp/x1 I guess the different defaults are needed for complex compatibility issues. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Wed Apr 01 15:15:49 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJiq5-0003h2-GQ for mharc-bug-make@gnu.org; Wed, 01 Apr 2020 15:15:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32832) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJiq3-0003gT-Tc for bug-make@gnu.org; Wed, 01 Apr 2020 15:15:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJiq2-0001n8-Pi for bug-make@gnu.org; Wed, 01 Apr 2020 15:15:47 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:51710) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJiq2-0001mc-MD; Wed, 01 Apr 2020 15:15:46 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 75E3120B9C; Wed, 1 Apr 2020 15:15:46 -0400 (EDT) To: Steffen Dettmer , "Paul D. Smith" , Martin Dorey , David Boyce , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #57914] abspath does resolve symlink X-PHP-Originating-Script: 1001:sendmail.php From: "Paul D. Smith" X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 57914 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36 X-Apparently-From: 98.118.0.140 (Savane authenticated user psmith) Message-Id: <20200401-151546.sv260.73389@savannah.gnu.org> References: <20200228-090750.sv0.78409@savannah.gnu.org> <20200228-091705.sv183076.51936@savannah.gnu.org> <20200331-153401.sv82528.77521@savannah.gnu.org> <20200331-180759.sv183076.71105@savannah.gnu.org> <20200331-182215.sv82528.16302@savannah.gnu.org> <20200331-114858.sv46964.51218@savannah.gnu.org> <20200331-182706.sv260.72731@savannah.gnu.org> <20200401-184351.sv183076.9185@savannah.gnu.org> In-Reply-To: <20200401-184351.sv183076.9185@savannah.gnu.org> Date: Wed, 1 Apr 2020 15:15:46 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 19:15:49 -0000 Follow-up Comment #8, bug #57914 (project make): Right... GNU make doesn't have any option to act like "pwd -L" does when it manages paths. The user could do that themselves in their makefile since they have access to "$(PWD)". Maybe not pretty, but something like this could work: labspath = $(patsubst $(CURDIR)/%,$(PWD)/%,$(abspath $1)) $(info labspath = $(call labspath,$(dir))) which puts back the "$(PWD)" prefix. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Thu Apr 02 00:18:16 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJrJ2-00049A-LV for mharc-bug-make@gnu.org; Thu, 02 Apr 2020 00:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54825) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJrJ0-00048n-2z for bug-make@gnu.org; Thu, 02 Apr 2020 00:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJrIz-0007UX-0s for bug-make@gnu.org; Thu, 02 Apr 2020 00:18:14 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:52118) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJrIy-0007TF-UD; Thu, 02 Apr 2020 00:18:12 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id BC23420809; Thu, 2 Apr 2020 00:18:12 -0400 (EDT) To: Dmitry Goncharov , "Paul D. Smith" , Frederick Eaton , frederik@ofb.net, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #57962] apparent regression involving PATH resolution X-PHP-Originating-Script: 1001:sendmail.php From: Frederick Eaton X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 57962 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 X-Apparently-From: 135.180.145.134 (Savane authenticated user misfit) Message-Id: <20200402-041812.sv99966.24061@savannah.gnu.org> References: <20200306-042440.sv99966.72741@savannah.gnu.org> <20200306-100248.sv260.78725@savannah.gnu.org> <20200306-151741.sv99966.31853@savannah.gnu.org> <20200307-034050.sv159675.85335@savannah.gnu.org> <20200307-034209.sv159675.44445@savannah.gnu.org> <20200307-034955.sv159675.80031@savannah.gnu.org> <20200307-042823.sv99966.23196@savannah.gnu.org> <20200401-235718.sv260.68295@savannah.gnu.org> In-Reply-To: <20200401-235718.sv260.68295@savannah.gnu.org> Date: Thu, 2 Apr 2020 00:18:12 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 04:18:15 -0000 Follow-up Comment #8, bug #57962 (project make): Thank you Paul _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Fri Apr 03 10:05:53 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jKMxD-0003hS-VA for mharc-bug-make@gnu.org; Fri, 03 Apr 2020 10:05:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37284) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKMq7-0005XZ-3W for bug-make@gnu.org; Fri, 03 Apr 2020 09:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKMq5-0005BE-Pp for bug-make@gnu.org; Fri, 03 Apr 2020 09:58:31 -0400 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:47025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKMq5-0005B8-LS for bug-make@gnu.org; Fri, 03 Apr 2020 09:58:29 -0400 Received: by mail-qk1-x729.google.com with SMTP id u4so7929369qkj.13 for ; Fri, 03 Apr 2020 06:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=31ihTmSuA+sT5JTFYy1yMSOpKGvyYt1n50Ej2hEvs5Q=; b=VMdPzXwL3OFVkTTpxlsjvI6BiuinZlnLkfLxZnTkBTFw7aK33KHXctkYYTg2zgAh5D SwNhiRGZmWUxMwTAYMVFLhm5btrezMri8mZQ5D1+vb3akHO0h6nO8HF4ImHQJPM9G393 5SNk39D+h+gJZ8usEiMk0ei2aYCNCwSkLAKILX/bpe65zrcVP306Jo0f1rv/P9APKvIy ZV9p0aONzNIs2P+GPcoFcWziqrsP/8Pj3a8jFIMxuG4aQXqAPqo/5XbThzSY+40sg4gq B/Sloy3d93X5caiKw/W0/LYBCZnC2N3GzGHTOq9GrfTawxJb/V0h4cVzGuIbEujS865P zmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=31ihTmSuA+sT5JTFYy1yMSOpKGvyYt1n50Ej2hEvs5Q=; b=XYQMxg24KsGm6FZj0RR+alJnsHIfllcNcsUQGE7iKRcY6SOEkweeys0/nezhZimJxQ 2gByvJkoqUGlaR2XgNxPZKMvvzil2Zpyef8ACwja2W6rOqbKfTsDBE3QKHUJVnIoETOX OrViXLF2HVxsxf9pq2k9uS5VsH0WXDxDYmyIcif99Q5x4WqBpYB/Ang2/nXpPK2kHucA bWNYP+5dhn8jtQVg1PtTMqgL9RocMaCvg0hhoLqA13c7ahu4PPwWxirfCUqpLmU/WtDR cYGWf6HyT0LBeIrK9sfo9Wc7ba1W3iKFxRcSEv8TIR3YRrOfPYuTr4Ge4yY0y4/xBlkV rCkw== X-Gm-Message-State: AGi0PuYfXDoHCLSFAZRKRvmedjxXmrKrjjjo4eYD48pUluR0+4l2uiVB 5vNzLMbqM65KkyfCgVeOYrlwSrzd9Lw3IOWD4urdqyQ= X-Google-Smtp-Source: APiQypLpOdtT+HtT/ifqWYQ6usCT/4dEbA5FLG5XBU4uFSTsmWiFQg0IcHtyPOq8vHxqhgAAfrus3ihj6r6b55J54KI= X-Received: by 2002:a05:620a:11b0:: with SMTP id c16mr8929973qkk.309.1585922308661; Fri, 03 Apr 2020 06:58:28 -0700 (PDT) MIME-Version: 1.0 From: Nikolay Vakhlyarskiy Date: Fri, 3 Apr 2020 16:58:17 +0300 Message-ID: Subject: Some suggestion to improve documentation for GNU Make To: bug-make@gnu.org Content-Type: multipart/alternative; boundary="000000000000d965fa05a2634f7c" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::729 X-Mailman-Approved-At: Fri, 03 Apr 2020 10:05:49 -0400 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 13:58:32 -0000 --000000000000d965fa05a2634f7c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I would like to make some notices about documentation for GNU Make utility in its part which concerns automatic generation dependency files for C/C++ sources. This is paragraph *"4.13 Generating Prerequisites Automatically"*. According to documentation dependency rules for C/C++ files could be generated with -M compiler flag. But -M flag generates dependency rule, which contains, among others, system include files in prerequisite list. On Unix system These prerequisites start usually with " /usr/include/" prefix. Normally system includes are not so important for application project, and -MM compiler flag is more suitable as it ends up with shorter dependency list. *1) So the suggestion is to replace "-M" compiler flag to "-MM" one.* My second suggestion for this chapter concerns the recipe of rule for generating dependency file. The current rule is redundantly complex. Modern GCC compiler, when it is used for dependency generation, allows to specify output file name with -MF. Also it is possible to specify target name for generated rules with -MT flag. The -MT flag can be used multiple times in single command. *2) The second suggestion is to replace example rule for dependency generation:* *Current one is:* *%.d: %.c* *@set -e; rm -f $@; \* *$(CC) -M $(CPPFLAGS) $< > $@.$$$$; \* *sed =E2=80=99s,\($*\)\.o[ :]*,\1.o $@ : ,g=E2=80=99 < $@.$$$$ > $@; \* *rm -f $@.$$$$* *Replacement:* *%.d: %.c* *$(CC) $(CFLAGS) -MF $@ -MT $(patsubst %.d,%.o,$@) -MT $@ $^* So target file example.d will be updated upon update of example.c with the recipe working as follows: -MF $@ output file name will be the name of the rule's target -MT $(patsubst %.d,%.o,$@) the first target in dependency rule will be the name of object file -MT $@ the second target in dependency rule will be the name of dependency file $^ is a "paranoid check" that there will be definitely alone example.c file used Having single command for dependency generation will increase speed of compilation. Also there is no need for temporary files reading/writing anymore, which also makes performance penalty. hope my suggestions are useful... Thanks, Nikoay Vakhlyarskiy. --000000000000d965fa05a2634f7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

=C2=A0 =C2=A0 I would like to make = some notices about documentation=C2=A0for GNU Make utility in its part
which concerns automatic generation dependency files for C/C++ source= s. This is
paragraph "4.13 Generating Prerequisites Autom= atically".

=C2=A0 =C2=A0 According to doc= umentation dependency rules for C/C++ files could be generated
wi= th -M compiler flag. But -M flag generates dependency rule, which contains,= among
others, system include files in prerequisite list. On Unix= system These prerequisites
start usually with " /usr/includ= e/" prefix. Normally system includes are not so important
fo= r application project, and -MM compiler flag is more suitable as it ends up= with shorter
dependency list.

1)= So the suggestion is to replace "-M" compiler flag to "-MM&= quot; one.

=C2=A0 =C2=A0 My second suggestion = for this chapter concerns the recipe=C2=A0of rule for generating=C2=A0
dependency=C2=A0file. The current rule is redundantly complex.
<= div>
=C2=A0 =C2=A0 Modern GCC compiler, when it is used for= =C2=A0dependency generation, allows to specify output file name with -MF. A= lso it is possible to specify target=C2=A0name for generated rules with -MT= flag. The -MT flag can be used multiple times in single command.

2) The second suggestion is to replace example rule for = dependency generation:

Current one is:<= /div>

%.d: %.c
@set -e; rm -f $@; \
$(CC) -M $(CPPFLAGS) $< > $@.$$$$; \
s= ed =E2=80=99s,\($*\)\.o[ :]*,\1.o $@ : ,g=E2=80=99 < $@.$$$$ > $@; \<= /i>
rm -f $@.$$$$

Replacement:

%.d: %.c
=
<= b>$(CC) $(CFLAGS) -MF $@ -MT $(patsubst %.d,%.o,$@) -MT $@ $^

=C2=A0 =C2=A0 So target file example.d will be upda= ted upon update of example.c with the
recipe working as follows:<= /div>

-MF $@=C2=A0 =C2=A0 =C2=A0 output file name will be the name = of the rule's target

-MT $(patsubst %.d,%.o,= $@) the first target in dependency rule will be the name
of objec= t file

-MT $@=C2=A0 the second target in depen= dency=C2=A0rule will be the name of dependency file

<= div>$^ is a "paranoid check" that there will be definitely alone = example.c file used
=C2=A0 =C2=A0 Having single command f= or dependency generation will increase speed of compilation.
Also there= is no need for temporary files reading/writing anymore, which also makes= =C2=A0
performance penalty.

hope my sugg= estions are useful...

Thanks, Nikoay Vakhlyarskiy.=
=C2=A0 =C2=A0
--000000000000d965fa05a2634f7c-- From MAILER-DAEMON Sun Apr 05 09:33:29 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jL5Oz-0000M8-J5 for mharc-bug-make@gnu.org; Sun, 05 Apr 2020 09:33:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL5Os-0000Jr-KJ for bug-make@gnu.org; Sun, 05 Apr 2020 09:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL5Or-0005yj-IB for bug-make@gnu.org; Sun, 05 Apr 2020 09:33:22 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:13141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jL5Oq-0005wZ-Pb for bug-make@gnu.org; Sun, 05 Apr 2020 09:33:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1586093597; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=u/+k4W7CoKtGiBcsf4xsMZ6xIYPukou1AZLBostAV2k=; b=SVfhCjkKRtv7QP/yCYjYXt7/nHLTtDnsrGGdpORSnrMTpuzpoTuS8RCheCxIB8Wz+a NGd+5fscpC6pB6SVI+yF+QNQD1XY2gnlTotygD2vBuNE/fy0wi1ffjf8S52P2PWIgmez IPyqydc3ghy2i2Bw5TxEvwk/yCSmAYAPuTb3CGAq+iJfCU6+0A4IvW0k5V8ms5DZiHUo 14EYQvy/XAGVBeTk6oL0ZazvQoKIVTPibRrrJNOJiqkwl1NdQHBDy9XrKVYgBBwtaacZ 9dOcPhUXLFxjstcxVfj5Wm3ENxidBF5Gr9n5Vd1L4aewqUCDJB88NA7O/+lI0Vi3hmdR iJfw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.2.1 DYNA|AUTH) with ESMTPSA id D01ccaw35DXGkKP (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 5 Apr 2020 15:33:16 +0200 (CEST) From: Bruno Haible To: bug-make@gnu.org Subject: make-4.3: wildcard test #9 fails Date: Sun, 05 Apr 2020 15:33:16 +0200 Message-ID: <2967995.WYVNKZyvct@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::5 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 13:33:27 -0000 Hi, Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: $ ./configure --prefix=3D/arch/x86_64-linux-gnu/gnu-inst-make/4.3 $ make $ make check =2E.. functions/wildcard ...................................... FAILED (9/10 pass= ed) =2E.. vms/library ............................................. N/A 1 Test in 1 Category Failed (See .diff* files in work dir for details) :-( Makefile:1998: die Regel f=C3=BCr Ziel =E2=80=9Echeck-regression=E2=80=9C s= cheiterte make[2]: *** [check-regression] Fehler 1 $ cat tests/work/functions/wildcard.diff.9 *** work/functions/wildcard.base.9 Sun Apr 5 15:16:18 2020 =2D-- work/functions/wildcard.log.9 Sun Apr 5 15:16:18 2020 *************** *** 1 **** ! __ldir =2D-- 1 ---- !=20 This is on an ext4 file system. It's not locale dependent: the same result occurs with 'LC_ALL=3DC make che= ck'. Additional data: $ nm make | grep wildcard 000000000040f820 t func_wildcard $ nm make | grep glob 0000000000408620 T ar_glob 0000000000408280 t ar_glob_match 000000000040b220 T dir_setup_glob 0000000000408210 t __do_global_dtors_aux 0000000000632e08 t __do_global_dtors_aux_fini_array_entry 0000000000634560 b global_dl.6802 00000000006341d0 d global_setlist 0000000000637080 b global_variable_set U globfree@@GLIBC_2.2.5 U glob@@GLIBC_2.2.5 0000000000424760 T init_hash_global_variable_set Bruno From MAILER-DAEMON Sun Apr 05 09:48:21 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jL5dN-0007ax-KF for mharc-bug-make@gnu.org; Sun, 05 Apr 2020 09:48:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57513) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL5dL-0007Z0-SY for bug-make@gnu.org; Sun, 05 Apr 2020 09:48:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jL5dL-00082L-Kz; Sun, 05 Apr 2020 09:48:19 -0400 Received: from pool-98-118-0-140.bstnma.fios.verizon.net ([98.118.0.140]:54790 helo=pdslaptop.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jL5dL-0005EJ-2F; Sun, 05 Apr 2020 09:48:19 -0400 Message-ID: <4b91ffed803e040b72c2fcdc96b715f532830a81.camel@gnu.org> Subject: Re: make-4.3: wildcard test #9 fails From: Paul Smith Reply-To: psmith@gnu.org To: Bruno Haible , bug-make@gnu.org Date: Sun, 05 Apr 2020 09:48:17 -0400 In-Reply-To: <2967995.WYVNKZyvct@omega> References: <2967995.WYVNKZyvct@omega> Organization: GNU's Not UNIX! Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 13:48:21 -0000 On Sun, 2020-04-05 at 15:33 +0200, Bruno Haible wrote: > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: This is because the glob() function in the older GNU libc has a bug related to handling symlinks correctly. From MAILER-DAEMON Sun Apr 05 10:19:56 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jL67w-0000TJ-LP for mharc-bug-make@gnu.org; Sun, 05 Apr 2020 10:19:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60494) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL67r-0000Rm-UC for bug-make@gnu.org; Sun, 05 Apr 2020 10:19:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL67q-0006Uj-HG for bug-make@gnu.org; Sun, 05 Apr 2020 10:19:51 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:30289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jL67m-0006PD-VD; Sun, 05 Apr 2020 10:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1586096384; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=oyXYoPfYKlZ1K5a2kDyjcqsqk7fOf9caUdhDeXFxyWc=; b=B0h6Rxvw5hm8V/xtLKzFB/4WlUQ1ZU75mdFvTQ35tZns060Wuf62QF8yWBiwmhmSS7 eSN+fm9COiT32M42Af0Ayi8FdUEzF4DSs2bdqQG10O/9ll2MMMsDIEdOr4pR28dBPK00 CxF2cHEGY0KPtlfxuQlChl+YwHirhtiJprsOPNyhL6+et6806smbkelVqLdW1MLTx5IU ksDgBngk16JPPFd2Y979q55dqcdZ8U4rN8iZ0KcZA/GrJ0IcnrjZpDYL8edzkCGfj4e/ eqPdZ90JayVcf8/DVSjF4kvlxAP0cLXf+tTJwTSxd1tYvdtvzWTW5qO5bnxeFEMEqZKu rfdg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6fzxfs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 46.2.1 DYNA|AUTH) with ESMTPSA id D01ccaw35EJhkQE (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sun, 5 Apr 2020 16:19:43 +0200 (CEST) From: Bruno Haible To: psmith@gnu.org Cc: bug-make@gnu.org Subject: Re: make-4.3: wildcard test #9 fails Date: Sun, 05 Apr 2020 16:19:43 +0200 Message-ID: <1612603.L0tUgrvugm@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <4b91ffed803e040b72c2fcdc96b715f532830a81.camel@gnu.org> References: <2967995.WYVNKZyvct@omega> <4b91ffed803e040b72c2fcdc96b715f532830a81.camel@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::5 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 14:19:53 -0000 Hi Paul, > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: > > This is because the glob() function in the older GNU libc has a bug > related to handling symlinks correctly. Gnulib provides a workaround against this bug in its 'glob' module [1]. But GNU make ships a copy of glob.c from 1999 :-( Bruno [1] https://www.gnu.org/software/gnulib/manual/html_node/glob.html From MAILER-DAEMON Sun Apr 05 11:07:35 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jL6s3-0004nS-1R for mharc-bug-make@gnu.org; Sun, 05 Apr 2020 11:07:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37363) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL6s0-0004nL-TZ for bug-make@gnu.org; Sun, 05 Apr 2020 11:07:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jL6s0-0000MV-Fo; Sun, 05 Apr 2020 11:07:32 -0400 Received: from pool-98-118-0-140.bstnma.fios.verizon.net ([98.118.0.140]:55420 helo=pdslaptop.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jL6s0-0007rf-7u; Sun, 05 Apr 2020 11:07:32 -0400 Message-ID: <777c3a4349fecb3137ed5c7c9c82537c90f18d70.camel@gnu.org> Subject: Re: make-4.3: wildcard test #9 fails From: Paul Smith Reply-To: psmith@gnu.org To: Bruno Haible Cc: bug-make@gnu.org Date: Sun, 05 Apr 2020 11:07:31 -0400 In-Reply-To: <1612603.L0tUgrvugm@omega> References: <2967995.WYVNKZyvct@omega> <4b91ffed803e040b72c2fcdc96b715f532830a81.camel@gnu.org> <1612603.L0tUgrvugm@omega> Organization: GNU's Not UNIX! Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 15:07:34 -0000 On Sun, 2020-04-05 at 16:19 +0200, Bruno Haible wrote: > Hi Paul, > > > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: > > > > This is because the glob() function in the older GNU libc has a bug > > related to handling symlinks correctly. > > Gnulib provides a workaround against this bug in its 'glob' module > [1]. But GNU make ships a copy of glob.c from 1999 :-( Yes, I know. Unfortunately, attempting to pull gnulib's glob/fnmatch implementation also pulls in a bajillion other gnulib modules, and causes lots of problems for GNU make on non-POSIX systems like Windows (where we support native builds without any Cygwin/MinGW support) and VMS (obviously we have no sed/etc. tools there). I have on my list to tackle this issue but it's daunting. You may have noticed my emails to the gnulib list asking about doing things in ways that reduce the number of native tools needed for the configure step ... this is one of the main reasons why. From MAILER-DAEMON Sun Apr 05 13:44:34 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jL9Jy-0004q3-Av for mharc-bug-make@gnu.org; Sun, 05 Apr 2020 13:44:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54177) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL9Jw-0004pt-0t for bug-make@gnu.org; Sun, 05 Apr 2020 13:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL9Ju-0006lo-7t for bug-make@gnu.org; Sun, 05 Apr 2020 13:44:31 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:42129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL9Js-0006jc-B4; Sun, 05 Apr 2020 13:44:28 -0400 Received: by mail-qv1-xf41.google.com with SMTP id ca9so6331763qvb.9; Sun, 05 Apr 2020 10:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WbxW5AjX6nlsqBnxw3wjkUAVja9Sy0xz7q5BzfFK7is=; b=bocSjtbKwFMnbjjQyEYoAFer6TJ1O7JzA91Sd6QqhkM8GX2cozyieSdr+L1w0HSHC5 BfKajaG69q3kVg7zolIl15qH+S1HrgwkDJ0A3i1inPW8ZCl2dz3fOchwrtfrFp8LyCmh v3bwhwVxDNRyBTlenLA9B87kBWV91TtpRX2XoImgE9bShhLvufLdMaJsnLaqNQGaNCRc LUVzzk+xpNpLCDH0A1sSLcTyI+bP82DAieOPvRCFTJAVEfAVAX9+ymWhswqpfDL2hOqU bD9xPPIzriL4v+jiL/QWzLp+6vjKiXupQI7Snd+QFOtuQCzER1efWcZF1i+AO6g1849u x0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WbxW5AjX6nlsqBnxw3wjkUAVja9Sy0xz7q5BzfFK7is=; b=sb0AzeGDZSaGX4PVOuNW+KxMu6KcmOtq2pOIe0787mCmGrImdbczZ2mYhBMu6H4wJL syYV4Wv3O+DdcH3xBtw7dsG+eDKpfA9BEpwKtsAAb1zg2J2qyNkD6W8k/W7+cMnUA0d9 OQGIeLpf9xLVFMzXzO9pYi8hbAaI+83je88v/pc5CA2Ao8d8O9aa1Z/dLbcIn9gvVnk2 ZIGMe3wuHVcYfGIYkB7Gv4EzjbTZQv4D5QLsorQf7Qn8CDYiz8ywhu3Bf+9M67JEDi3I OAwI3obVq72Wg9JGugceJbRchfqSqsxLmiftFJDF3zqGmupOGa/NVaxuGixjXazmDY/b b4Wg== X-Gm-Message-State: AGi0PuaYlGbDBCGGz9N7i8jpfIsfqS9aiztGWdBs/JvHP2qVgi9b+AQG u0qcROrN8SUkULKEYo+vDshqRJwWUl8rPQ== X-Google-Smtp-Source: APiQypJodDfFgHdWQOa8zvglUJjBiPIkyWUYq+c8jlnsMAasO7/MHzpHN8cLRv7YYobKJBy9vzVghw== X-Received: by 2002:a05:6214:72f:: with SMTP id c15mr16954589qvz.3.1586108668058; Sun, 05 Apr 2020 10:44:28 -0700 (PDT) Received: from madrid (pool-108-30-156-180.nycmny.fios.verizon.net. [108.30.156.180]) by smtp.gmail.com with ESMTPSA id r3sm12906947qkd.3.2020.04.05.10.44.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Apr 2020 10:44:27 -0700 (PDT) Sender: j j Received: by madrid (sSMTP sendmail emulation); Sun, 05 Apr 2020 13:44:26 -0400 Date: Sun, 5 Apr 2020 13:44:26 -0400 From: Dmitry Goncharov To: Paul Smith , bruno@clisp.org, bug-make@gnu.org Subject: Re: make-4.3: wildcard test #9 fails Message-ID: <20200405174426.GA3252@madrid> References: <2967995.WYVNKZyvct@omega> <4b91ffed803e040b72c2fcdc96b715f532830a81.camel@gnu.org> <1612603.L0tUgrvugm@omega> <777c3a4349fecb3137ed5c7c9c82537c90f18d70.camel@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <777c3a4349fecb3137ed5c7c9c82537c90f18d70.camel@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::f41 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 17:44:33 -0000 > On Sun, 2020-04-05 at 16:19 +0200, Bruno Haible wrote: > > > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: On filesystems which don't populate dirent::d_type (or on old glibc) test 7 also fails. I just asked gnulib mailing list to look at a patch. https://lists.gnu.org/archive/html/bug-gnulib/2020-04/msg00008.html. On Sun, Apr 05, 2020 at 11:07:31AM -0400, Paul Smith wrote: > I have on my list to tackle this issue but it's daunting. That would be good if the fix cited above was applied before you sync with gnulib. regards, Dmitry From MAILER-DAEMON Thu Apr 09 06:58:10 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jMUss-0001tJ-Ec for mharc-bug-make@gnu.org; Thu, 09 Apr 2020 06:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41541) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMUsq-0001sz-1W for bug-make@gnu.org; Thu, 09 Apr 2020 06:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMUso-0007mn-Vy for bug-make@gnu.org; Thu, 09 Apr 2020 06:58:07 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:55574) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMUso-0007mh-Sy; Thu, 09 Apr 2020 06:58:06 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id B239F20B76; Thu, 9 Apr 2020 06:58:06 -0400 (EDT) To: "J. Hart" , Jouke Witteveen , "Paul D. Smith" , Martin Dorey , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #51974] call on multiline (define/endef) behavior not well-documented X-PHP-Originating-Script: 1001:sendmail.php From: Jouke Witteveen X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 51974 User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0 X-Apparently-From: 31.21.234.81 (Savane authenticated user jwitteveen) Message-Id: <20200409-105806.sv187603.30880@savannah.gnu.org> References: <20170909-204550.sv112510.89367@savannah.gnu.org> <20170909-205814.sv0.47068@savannah.gnu.org> <20170909-231419.sv112510.48377@savannah.gnu.org> <20170909-235640.sv112510.50241@savannah.gnu.org> <20170909-172308.sv46964.87943@savannah.gnu.org> <20170910-095406.sv260.43050@savannah.gnu.org> <20190519-194653.sv260.24732@savannah.gnu.org> In-Reply-To: <20190519-194653.sv260.24732@savannah.gnu.org> Date: Thu, 9 Apr 2020 06:58:06 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2020 10:58:09 -0000 Follow-up Comment #7, bug #51974 (project make): Either the 'new' documentation is not entirely correct, or there is a bug in the current expansion logic (or I am misunderstanding something). The documentation states: ---- 4. Expand elements of the line which appear in an immediate expansion context (see How make Reads a Makefile). 5. Scan the line for a separator character, such as ‘:’ or ‘=’, to determine whether the line is a macro assignment or a rule (see Recipe Syntax). 6. Internalize the resulting operation and read the next line. An important consequence of this is that a macro can expand to an entire rule, if it is one line long. ---- The last statement assumes that a line containing only a variable reference, such as $(myrule) presents an immediate expansion context, although it does not meet any of the stated forms of an immediate expansion context. If it were, then this should also work: myassignment = var = val $(myassignment) Step 5 of the list above would apply to the last line of this example (it expands to 'var = val'). However, make fails with a "missing separator" error. A slightly different error, "empty variable name", results from this variation: myassignment = var := val $(myassignment) _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Fri Apr 10 16:58:41 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jN0jZ-0006Ct-7B for mharc-bug-make@gnu.org; Fri, 10 Apr 2020 16:58:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42057) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jN0jW-0006Ca-3y for bug-make@gnu.org; Fri, 10 Apr 2020 16:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jN0jS-0005I7-Ds for bug-make@gnu.org; Fri, 10 Apr 2020 16:58:38 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:41896) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jN0jS-0005I0-Aq; Fri, 10 Apr 2020 16:58:34 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 344D420AE6; Fri, 10 Apr 2020 16:58:34 -0400 (EDT) To: Masahiro Yamada , Dmitry Goncharov , "Paul D. Smith" , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #56301] Mandatory/Optional include files and pattern rule with multi-targets X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 56301 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200410-205834.sv159675.68444@savannah.gnu.org> References: <20190510-163349.sv137527.29221@savannah.gnu.org> <20191226-190144.sv260.98984@savannah.gnu.org> In-Reply-To: <20191226-190144.sv260.98984@savannah.gnu.org> Date: Fri, 10 Apr 2020 16:58:34 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 20:58:39 -0000 Follow-up Comment #1, bug #56301 (project make): Here is a fix. diff --git a/src/main.c b/src/main.c index bcba2d1..5c1a7da 100644 --- a/src/main.c +++ b/src/main.c @@ -2305,6 +2305,8 @@ main (int argc, char **argv, char **envp) any_remade |= (mtime != NONEXISTENT_MTIME && mtime != makefile_mtimes[i]); makefile_status = MAKE_FAILURE; + if (!keep_going_flag) + any_failed = 1; } } else _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Fri Apr 10 16:59:45 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jN0kb-0006M9-HR for mharc-bug-make@gnu.org; Fri, 10 Apr 2020 16:59:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42145) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jN0kY-0006M2-Em for bug-make@gnu.org; Fri, 10 Apr 2020 16:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jN0kX-0005kK-I3 for bug-make@gnu.org; Fri, 10 Apr 2020 16:59:42 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:42556) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jN0kX-0005kE-FC; Fri, 10 Apr 2020 16:59:41 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 5718220AE6; Fri, 10 Apr 2020 16:59:41 -0400 (EDT) To: Masahiro Yamada , Dmitry Goncharov , "Paul D. Smith" , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #56301] Mandatory/Optional include files and pattern rule with multi-targets X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 56301 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200410-205941.sv159675.31461@savannah.gnu.org> References: <20190510-163349.sv137527.29221@savannah.gnu.org> <20191226-190144.sv260.98984@savannah.gnu.org> <20200410-205834.sv159675.68444@savannah.gnu.org> In-Reply-To: <20200410-205834.sv159675.68444@savannah.gnu.org> Date: Fri, 10 Apr 2020 16:59:41 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2020 20:59:43 -0000 Follow-up Comment #2, bug #56301 (project make): Here is a test. diff --git a/tests/scripts/features/include b/tests/scripts/features/include index 0c63c06..2281ee4 100644 --- a/tests/scripts/features/include +++ b/tests/scripts/features/include @@ -260,4 +260,13 @@ inc1:; @%s $@ && echo FOO := bar > $@ rmfiles('inc1'); } +# Stop when cannot include a makefile. +# https://savannah.gnu.org/bugs/?56301. +run_make_test(q! +all:; @echo hello +include inc_a.mk +-include inc_b.mk +%_a.mk %_b.mk:; @false +!, '', "#MAKE#: Failed to remake makefile 'inc_a.mk'.", 512); + 1; _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Sat Apr 11 08:27:04 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jNFDz-0002RR-UX for mharc-bug-make@gnu.org; Sat, 11 Apr 2020 08:27:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57985) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFDw-0002Qx-OW for bug-make@gnu.org; Sat, 11 Apr 2020 08:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFDv-0005Ak-Ia for bug-make@gnu.org; Sat, 11 Apr 2020 08:27:00 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:38848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNFDv-0005Ac-DQ; Sat, 11 Apr 2020 08:26:59 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id CE22920CB5; Sat, 11 Apr 2020 08:26:57 -0400 (EDT) To: Dmitry Goncharov , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #55242] Included Makefile not found, no rule to build it but make does not fail X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 55242 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200411-122657.sv159675.78190@savannah.gnu.org> References: <20181219-123706.sv0.28436@savannah.gnu.org> In-Reply-To: <20181219-123706.sv0.28436@savannah.gnu.org> Date: Sat, 11 Apr 2020 08:26:57 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 12:27:02 -0000 Follow-up Comment #1, bug #55242 (project make): Here is a patch against the current master (0c326a66c9eb3a3b5e4ab7892578b016b0590b1f). This patch causes make to re-execute itself to read the included makefile. diff --git a/src/remake.c b/src/remake.c index fb237c5..4dc91d8 100644 --- a/src/remake.c +++ b/src/remake.c @@ -175,24 +175,30 @@ update_goal_chain (struct goaldep *goaldeps) } else { - FILE_TIMESTAMP mtime = MTIME (file); + struct file *oldfile = file; check_renamed (file); - if (file->updated && g->changed && - mtime != file->mtime_before_update) + if (file->updated && g->changed) { - /* Updating was done. If this is a makefile and - just_print_flag or question_flag is set (meaning - -n or -q was given and this file was specified - as a command-line target), don't change STATUS. - If STATUS is changed, we will get re-exec'd, and - enter an infinite loop. */ - if (!rebuilding_makefiles - || (!just_print_flag && !question_flag)) - status = us_success; - if (rebuilding_makefiles && file->dontcare) - /* This is a default makefile; stop remaking. */ - stop = 1; + FILE_TIMESTAMP lm = oldfile->last_mtime; + FILE_TIMESTAMP mtime = + lm == UNKNOWN_MTIME || lm == NONEXISTENT_MTIME ? + f_mtime (oldfile, 0) : lm; + if (mtime != file->mtime_before_update) + { + /* Updating was done. If this is a makefile and + just_print_flag or question_flag is set (meaning + -n or -q was given and this file was specified + as a command-line target), don't change STATUS. + If STATUS is changed, we will get re-exec'd, and + enter an infinite loop. */ + if (!rebuilding_makefiles + || (!just_print_flag && !question_flag)) + status = us_success; + if (rebuilding_makefiles && file->dontcare) + /* This is a default makefile; stop remaking. */ + stop = 1; + } } } } _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Sat Apr 11 08:27:58 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jNFEs-0002br-F8 for mharc-bug-make@gnu.org; Sat, 11 Apr 2020 08:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58149) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFEq-0002be-Bb for bug-make@gnu.org; Sat, 11 Apr 2020 08:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFEp-0005LJ-1p for bug-make@gnu.org; Sat, 11 Apr 2020 08:27:56 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:39504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNFEo-0005LF-Ut; Sat, 11 Apr 2020 08:27:54 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id CFA9320CB5; Sat, 11 Apr 2020 08:27:54 -0400 (EDT) To: Dmitry Goncharov , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #55242] Included Makefile not found, no rule to build it but make does not fail X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 55242 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200411-122754.sv159675.86840@savannah.gnu.org> References: <20181219-123706.sv0.28436@savannah.gnu.org> <20200411-122657.sv159675.78190@savannah.gnu.org> In-Reply-To: <20200411-122657.sv159675.78190@savannah.gnu.org> Date: Sat, 11 Apr 2020 08:27:54 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 12:27:57 -0000 Follow-up Comment #2, bug #55242 (project make): Here is a test. diff --git a/tests/scripts/features/include b/tests/scripts/features/include index 0c63c06..f39e5ec 100644 --- a/tests/scripts/features/include +++ b/tests/scripts/features/include @@ -260,4 +260,16 @@ inc1:; @%s $@ && echo FOO := bar > $@ rmfiles('inc1'); } +unlink('b'); +unlink('a.mk'); +run_make_test(q! +all:; @echo hello=$(hello) +include a.mk +a.mk: b +b: + @echo hello=world >a.mk +!, '', 'hello=world'); +unlink('a.mk'); +unlink('b'); + 1; _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Sat Apr 11 08:29:31 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jNFGN-00031o-Nw for mharc-bug-make@gnu.org; Sat, 11 Apr 2020 08:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58289) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFGM-00031h-8D for bug-make@gnu.org; Sat, 11 Apr 2020 08:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFGL-0005bZ-Bz for bug-make@gnu.org; Sat, 11 Apr 2020 08:29:30 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:40504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNFGL-0005bV-9S; Sat, 11 Apr 2020 08:29:29 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 2D0FA20CB5; Sat, 11 Apr 2020 08:29:29 -0400 (EDT) To: Dmitry Goncharov , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #55242] Included Makefile not found, no rule to build it but make does not fail X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 55242 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200411-122929.sv159675.65596@savannah.gnu.org> References: <20181219-123706.sv0.28436@savannah.gnu.org> <20200411-122657.sv159675.78190@savannah.gnu.org> <20200411-122754.sv159675.86840@savannah.gnu.org> In-Reply-To: <20200411-122754.sv159675.86840@savannah.gnu.org> Date: Sat, 11 Apr 2020 08:29:29 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 12:29:31 -0000 Additional Item Attachment, bug #55242 (project make): File name: sv_55242_let_included_files_be_byproduct_of_unrelated_rules.diff Size:2 KB File name: sv_55242_let_included_files_be_byproduct_of_unrelated_rules_test.diff Size:0 KB _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Sat Apr 11 08:39:08 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jNFPg-0004fo-8L for mharc-bug-make@gnu.org; Sat, 11 Apr 2020 08:39:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59005) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFPe-0004fd-89 for bug-make@gnu.org; Sat, 11 Apr 2020 08:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFPc-00080q-N9 for bug-make@gnu.org; Sat, 11 Apr 2020 08:39:06 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:45512) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNFPc-00080i-C1; Sat, 11 Apr 2020 08:39:04 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 3F3DB20CB5; Sat, 11 Apr 2020 08:39:04 -0400 (EDT) To: Masahiro Yamada , Dmitry Goncharov , "Paul D. Smith" , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #56301] Mandatory/Optional include files and pattern rule with multi-targets X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 56301 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200411-123904.sv159675.53183@savannah.gnu.org> References: <20190510-163349.sv137527.29221@savannah.gnu.org> <20191226-190144.sv260.98984@savannah.gnu.org> <20200410-205834.sv159675.68444@savannah.gnu.org> <20200410-205941.sv159675.31461@savannah.gnu.org> In-Reply-To: <20200410-205941.sv159675.31461@savannah.gnu.org> Date: Sat, 11 Apr 2020 08:39:04 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 12:39:07 -0000 Follow-up Comment #3, bug #56301 (project make): These patches are against the current master (0c326a66c9eb3a3b5e4ab7892578b016b0590b1f). _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Sat Apr 11 08:42:55 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jNFTK-0005R3-Vn for mharc-bug-make@gnu.org; Sat, 11 Apr 2020 08:42:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNFTI-0005Qr-Uq for bug-make@gnu.org; Sat, 11 Apr 2020 08:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNFTH-0000jr-PB for bug-make@gnu.org; Sat, 11 Apr 2020 08:42:52 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:47140) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jNFTH-0000ji-MP; Sat, 11 Apr 2020 08:42:51 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 8887F20CB5; Sat, 11 Apr 2020 08:42:51 -0400 (EDT) To: Masahiro Yamada , Dmitry Goncharov , "Paul D. Smith" , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #56301] Mandatory/Optional include files and pattern rule with multi-targets X-PHP-Originating-Script: 1001:sendmail.php From: Dmitry Goncharov X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 56301 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 X-Apparently-From: 108.30.156.180 (Savane authenticated user dgoncharov) Message-Id: <20200411-124251.sv159675.52453@savannah.gnu.org> References: <20190510-163349.sv137527.29221@savannah.gnu.org> <20191226-190144.sv260.98984@savannah.gnu.org> <20200410-205834.sv159675.68444@savannah.gnu.org> <20200410-205941.sv159675.31461@savannah.gnu.org> <20200411-123904.sv159675.53183@savannah.gnu.org> In-Reply-To: <20200411-123904.sv159675.53183@savannah.gnu.org> Date: Sat, 11 Apr 2020 08:42:51 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Apr 2020 12:42:54 -0000 Follow-up Comment #4, bug #56301 (project make): This test is the same as the one submitted earlier, but unlinks the included makefiles. diff --git a/tests/scripts/features/include b/tests/scripts/features/include index 0c63c06..4401622 100644 --- a/tests/scripts/features/include +++ b/tests/scripts/features/include @@ -260,4 +260,15 @@ inc1:; @%s $@ && echo FOO := bar > $@ rmfiles('inc1'); } +# Stop when cannot include a makefile. +# https://savannah.gnu.org/bugs/?56301. +unlink('inc_a.mk'); +unlink('inc_b.mk'); +run_make_test(q! +all:; @echo hello +include inc_a.mk +-include inc_b.mk +%_a.mk %_b.mk:; @false +!, '', "#MAKE#: Failed to remake makefile 'inc_a.mk'.", 512); + 1; _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Tue Apr 14 08:35:17 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jOKmb-0001K1-QJ for mharc-bug-make@gnu.org; Tue, 14 Apr 2020 08:35:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34329) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOKmZ-0001GD-JO for bug-make@gnu.org; Tue, 14 Apr 2020 08:35:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOKmY-0002AG-If for bug-make@gnu.org; Tue, 14 Apr 2020 08:35:15 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:49300) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOKmY-0002AA-F9; Tue, 14 Apr 2020 08:35:14 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 4B1A921058; Tue, 14 Apr 2020 08:35:14 -0400 (EDT) To: Martin Liška , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #58174] make runs execve for a directory X-PHP-Originating-Script: 1001:sendmail.php From: Martin Liška X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 58174 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.162 Safari/537.36 X-Apparently-From: 193.86.188.206 (Savane authenticated user marxin) Message-Id: <20200414-123511.sv108124.96262@savannah.gnu.org> References: In-Reply-To: Date: Tue, 14 Apr 2020 08:35:14 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 12:35:17 -0000 URL: Summary: make runs execve for a directory Project: make Submitted by: marxin Submitted on: Tue 14 Apr 2020 12:35:11 PM UTC Severity: 3 - Normal Item Group: None Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Component Version: None Operating System: None Fixed Release: None Triage Status: None _______________________________________________________ Details: $ cd /tmp/ $ mkdir gcc $ cat Makefile foo: foo.c gcc foo.c -o foo $ export PATH=/tmp/:$PATH $ echo "int main() {}" > foo.c && make foo gcc foo.c -o foo make: gcc: Permission denied make: *** [Makefile:2: foo] Error 127 where make wrongly does: [pid 22621] execve("/tmp/gcc", ["gcc", "foo.c", "-o", "foo"], 0x5555555c1d60 /* 76 vars */) = -1 EACCES (Permission denied) $ which gcc /usr/bin/gcc _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Tue Apr 14 09:10:34 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jOLKk-0004V8-Qw for mharc-bug-make@gnu.org; Tue, 14 Apr 2020 09:10:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39967) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOLKi-0004Uz-Jt for bug-make@gnu.org; Tue, 14 Apr 2020 09:10:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOLKh-0008UL-LF for bug-make@gnu.org; Tue, 14 Apr 2020 09:10:32 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:33930) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOLKh-0008UC-IZ; Tue, 14 Apr 2020 09:10:31 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 1282421059; Tue, 14 Apr 2020 09:10:31 -0400 (EDT) To: Martin Liška , "Paul D. Smith" , boris@kolpackov.net, bug-make@gnu.org Subject: [bug #58174] make runs execve for a directory X-PHP-Originating-Script: 1001:sendmail.php From: "Paul D. Smith" X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 58174 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 X-Apparently-From: 98.118.0.140 (Savane authenticated user psmith) Message-Id: <20200414-091030.sv260.73236@savannah.gnu.org> References: <20200414-123511.sv108124.96262@savannah.gnu.org> In-Reply-To: <20200414-123511.sv108124.96262@savannah.gnu.org> Date: Tue, 14 Apr 2020 09:10:31 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 13:10:33 -0000 Update of bug #58174 (project make): Status: None => Duplicate Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #1: This is a duplicate of bug #57962 which is a bug in gnulib (that make uses for path lookup). _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Tue Apr 14 09:11:20 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jOLLU-0004ev-Jb for mharc-bug-make@gnu.org; Tue, 14 Apr 2020 09:11:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40026) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOLLS-0004eh-6v for bug-make@gnu.org; Tue, 14 Apr 2020 09:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOLLR-0000D4-Ap for bug-make@gnu.org; Tue, 14 Apr 2020 09:11:18 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:34248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOLLR-0000Cw-7i; Tue, 14 Apr 2020 09:11:17 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 1CC2621059; Tue, 14 Apr 2020 09:11:17 -0400 (EDT) To: Dmitry Goncharov , "Paul D. Smith" , Frederick Eaton , frederik@ofb.net, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #57962] make attempts to execute a directory found on PATH X-PHP-Originating-Script: 1001:sendmail.php From: "Paul D. Smith" X-Savane-Server: savannah.gnu.org:443 [209.51.188.72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 57962 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 X-Apparently-From: 98.118.0.140 (Savane authenticated user psmith) Message-Id: <20200414-091116.sv260.52600@savannah.gnu.org> References: <20200306-042440.sv99966.72741@savannah.gnu.org> <20200306-100248.sv260.78725@savannah.gnu.org> <20200306-151741.sv99966.31853@savannah.gnu.org> <20200307-034050.sv159675.85335@savannah.gnu.org> <20200307-034209.sv159675.44445@savannah.gnu.org> <20200307-034955.sv159675.80031@savannah.gnu.org> <20200307-042823.sv99966.23196@savannah.gnu.org> <20200401-235718.sv260.68295@savannah.gnu.org> <20200402-041812.sv99966.24061@savannah.gnu.org> <20200402-124404.sv159675.22125@savannah.gnu.org> <20200402-163411.sv260.80443@savannah.gnu.org> <20200402-205020.sv159675.69412@savannah.gnu.org> In-Reply-To: <20200402-205020.sv159675.69412@savannah.gnu.org> Date: Tue, 14 Apr 2020 09:11:17 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 13:11:19 -0000 Update of bug #57962 (project make): Summary: apparent regression involving PATH resolution => make attempts to execute a directory found on PATH _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Thu Apr 23 17:59:04 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jRjs6-0004c4-Qf for mharc-bug-make@gnu.org; Thu, 23 Apr 2020 17:59:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34276) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRjs5-0004bY-7U for bug-make@gnu.org; Thu, 23 Apr 2020 17:59:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRjs4-00063K-NB for bug-make@gnu.org; Thu, 23 Apr 2020 17:59:01 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:40498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jRjs4-000613-3F; Thu, 23 Apr 2020 17:59:00 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id F27DB20B0E; Thu, 23 Apr 2020 17:58:59 -0400 (EDT) To: Kevin Buettner , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #58232] FD_CLOEXEC not initialized on jobserver pipe for recursive make invocations X-PHP-Originating-Script: 1001:sendmail.php From: Kevin Buettner X-Savane-Server: savannah.gnu.org:443 [2001:470:142::72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 58232 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.113 Safari/537.36 X-Apparently-From: 2600:8800:6a80:5312:6bf2:8f2c:a033:c3ed (Savane authenticated user kevinbuettner) Message-Id: <20200423-215858.sv191661.2@savannah.gnu.org> References: In-Reply-To: Date: Thu, 23 Apr 2020 17:58:59 -0400 (EDT) X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 21:59:02 -0000 URL: Summary: FD_CLOEXEC not initialized on jobserver pipe for recursive make invocations Project: make Submitted by: kevinbuettner Submitted on: Thu 23 Apr 2020 09:58:58 PM UTC Severity: 3 - Normal Item Group: Bug Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Component Version: 4.3 Operating System: POSIX-Based Fixed Release: None Triage Status: None _______________________________________________________ Details: In make version 4.3, there are circumstances in which the jobserver pipe FDs are not closed when invoking a job that's not a recursive make invocation. This happens when invoking make from the top-level make and then starting another (non-make) job. I have a test case which causes "make -j4" to hang on 4.3, but not on 4.2.1. Download the attachment make-cloexec-bug.tgz, and do the following: [kevinb-fedora@rawhide-1 ~]$ tar xf make-cloexec-bug.tgz [kevinb-fedora@rawhide-1 ~]$ cd make-cloexec-bug [kevinb-fedora@rawhide-1 make-cloexec-bug]$ make -j4 sleep 2; echo a sleep 1; echo b make -C looper make[1]: Entering directory '/home/kevinb-fedora/make-cloexec-bug/looper' gcc -o looper looper.c ./looper In looper; do... kill -KILL 2360472 ...when done. make[1]: Leaving directory '/home/kevinb-fedora/make-cloexec-bug/looper' b a ^C [kevinb-fedora@rawhide-1 make-cloexec-bug]$ make --version GNU Make 4.3 Built for x86_64-redhat-linux-gnu Copyright (C) 1988-2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. [kevinb-fedora@rawhide-1 make-cloexec-bug]$ kill -KILL 2360472 Note that I needed to interrupt the "make -j4" invocation with Ctrl-C in order to get back to the shell. This problem occurs for me on current Fedora rawhide using make-4.3-1.fc33.x86_64, but I have also reproduced it using make built from git sources; "make --version" shows 4.3.90 for the git version. --- Here's what a successful / non-buggy run looks like when using make 4.2.1 on Fedora 31: [kevinb-fedora@f31-1 ~]$ tar xf make-cloexec-bug.tgz [kevinb-fedora@f31-1 ~]$ cd make-cloexec-bug [kevinb-fedora@f31-1 make-cloexec-bug]$ make -j4 sleep 2; echo a sleep 1; echo b make -C looper make[1]: Entering directory '/home/kevinb-fedora/make-cloexec-bug/looper' gcc -o looper looper.c ./looper In looper; do... kill -KILL 814945 ...when done. make[1]: Leaving directory '/home/kevinb-fedora/make-cloexec-bug/looper' b a [kevinb-fedora@f31-1 make-cloexec-bug]$ make --version GNU Make 4.2.1 Built for x86_64-redhat-linux-gnu Copyright (C) 1988-2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. [kevinb-fedora@f31-1 make-cloexec-bug]$ kill -KILL 814945 Note that I did NOT need to interrupt make with Ctrl-C in this run. I have a patch for this bug. I'll attach/upload it after the bug is submitted. (I want to be able to put the bug ID into the commit log.) _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Thu 23 Apr 2020 09:58:58 PM UTC Name: make-cloexec-bug.tgz Size: 559B By: kevinbuettner _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Thu Apr 23 18:04:04 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jRjwy-0005ue-7U for mharc-bug-make@gnu.org; Thu, 23 Apr 2020 18:04:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43340) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRjww-0005uR-Fs for bug-make@gnu.org; Thu, 23 Apr 2020 18:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRjwv-0006EJ-U4 for bug-make@gnu.org; Thu, 23 Apr 2020 18:04:02 -0400 Received: from frontend1.savannah.gnu.org ([209.51.188.72]:41896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jRjwv-0006Dw-IP; Thu, 23 Apr 2020 18:04:01 -0400 Received: by frontend1.savannah.gnu.org (Postfix, from userid 33) id 6A4F420B0E; Thu, 23 Apr 2020 18:04:01 -0400 (EDT) To: Kevin Buettner , psmith@gnu.org, boris@kolpackov.net, bug-make@gnu.org Subject: [bug #58232] FD_CLOEXEC not initialized on jobserver pipe for recursive make invocations X-PHP-Originating-Script: 1001:sendmail.php From: Kevin Buettner X-Savane-Server: savannah.gnu.org:443 [2001:470:142::72] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: make X-Savane-Tracker: bugs X-Savane-Item-ID: 58232 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.113 Safari/537.36 X-Apparently-From: 2600:8800:6a80:5312:6bf2:8f2c:a033:c3ed (Savane authenticated user kevinbuettner) Message-Id: <20200423-220401.sv191661.88112@savannah.gnu.org> References: <20200423-215858.sv191661.2@savannah.gnu.org> In-Reply-To: <20200423-215858.sv191661.2@savannah.gnu.org> Date: Thu, 23 Apr 2020 18:04:01 -0400 (EDT) X-Received-From: 209.51.188.72 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2020 22:04:02 -0000 Additional Item Attachment, bug #58232 (project make): File name: bug58232.patch Size:2 KB _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via Savannah https://savannah.gnu.org/ From MAILER-DAEMON Wed Apr 29 17:28:10 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jTuFW-0005Ju-CD for mharc-bug-make@gnu.org; Wed, 29 Apr 2020 17:28:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56676) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtnB-0001nG-Un for bug-make@gnu.org; Wed, 29 Apr 2020 16:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTtnA-0005Ku-ST for bug-make@gnu.org; Wed, 29 Apr 2020 16:58:53 -0400 Received: from mail-d.ads.isi.edu ([128.9.180.199]:45086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTtnA-0005KQ-5s for bug-make@gnu.org; Wed, 29 Apr 2020 16:58:52 -0400 Received: from usmdrmbx01.ads.isi.edu ([10.100.2.77]) by usmdrip04.ads.isi.edu with ESMTP; 29 Apr 2020 13:58:50 -0700 Received: from mdrprdwmbx02.ads.isi.edu (10.100.2.118) by usmdrmbx01.ads.isi.edu (10.100.2.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Wed, 29 Apr 2020 13:59:12 -0700 Received: from mdrprdwmbx02.ads.isi.edu (10.100.2.118) by mdrprdwmbx02.ads.isi.edu (10.100.2.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3; Wed, 29 Apr 2020 13:59:11 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (128.9.47.203) by mdrprdwmbx02.ads.isi.edu (10.100.2.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1847.3 via Frontend Transport; Wed, 29 Apr 2020 13:59:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RxGCRiKdj5MEx8OvCzuEFE2xDSV7vSRf4mojBivxt8aXz6MIFjDDJ7w9WAs75awZtC5MiSQM9+a8/bePyz3qNE2lrxtH85OMlA9z0HiIpy4t17qIbZdDguebptfqDXB9Go2k16jcAuBna4RpFKiWts1SdrYPO58/a2CEVMn9mDcL2B8rmmqLD9apA4g/AdSW/R1ADPLVG21IKZJRrx7HmOiICP6kHtezpkQh+wVX65uMSLb0Z+oD3StOW3Ghlomles7CcoFNPpsEaLPFtNtlZAdNFWv+jH+uLLEFX0jRYnIpki0Sn7TOw5aSkYBcIM8dGMzRiZ0/L7Hu3ZJ4fbFjJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WvuMJDZnEOO3fBJzBuVzVjSARULaBHVNm9yHIqAtsaQ=; b=ImCzX297n4U6tUfe/1cRWXxV6awmjOqcQpOjdgIJNDvMVjnB/SOPxF0A+ig/K9Kk4apSZdJGEj44yDLLU7Bp3tIAMTX5pQqj0yY8TiQ7vT1oewyyR1l6HTgqEV+VroRMzU+LMcTa2hDDlU64l/C+v3AjeIFDI4TnOhuMFmdPp8jiyIvnxPH8YxHvyWlLBBjO1lOk7s16JDZB0741tfdxaxxqco1J1b3O9Kmp5Ww6FeCknNEfOR4/xjTmzhBv1+WOHCtPRYed25l8TYwTxwoB3yQAWEzeZ7FVU9wfZdJK9uN+WT2WwDnvppliv5vSC12u/h0UDcnNBpSuvSFa2rYM/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=isi.edu; dmarc=pass action=none header.from=isi.edu; dkim=pass header.d=isi.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=USCISI.onmicrosoft.com; s=selector2-USCISI-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WvuMJDZnEOO3fBJzBuVzVjSARULaBHVNm9yHIqAtsaQ=; b=wz3k3M+19zfKacQTafxirG/K5EAUFTJdeTUzX63z2Qt82yk6/wHnGvHx3kJM1KMF3EE/PuMFMGyGKlIUhmY31WeNYOQSW95RxudGEf56ojD0hHcgop4Q+0ul+5iKSvoCct12xa2n7I7cnABTCv2W3oNtcSJBByI8qNoPHIltoDg= Received: from MW3PR16MB3788.namprd16.prod.outlook.com (2603:10b6:303:43::9) by MW3PR16MB3932.namprd16.prod.outlook.com (2603:10b6:303:4d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Wed, 29 Apr 2020 20:58:47 +0000 Received: from MW3PR16MB3788.namprd16.prod.outlook.com ([fe80::7c8d:44bd:df04:5abb]) by MW3PR16MB3788.namprd16.prod.outlook.com ([fe80::7c8d:44bd:df04:5abb%5]) with mapi id 15.20.2958.019; Wed, 29 Apr 2020 20:58:47 +0000 From: Gleb Satyukov To: "bug-make@gnu.org" Subject: Missing INSTALL instructions for GNU make 4.3 Thread-Topic: Missing INSTALL instructions for GNU make 4.3 Thread-Index: AQHWHmjSh2ZBsQ1lsUiDyfwgDqxegg== Date: Wed, 29 Apr 2020 20:58:46 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=isi.edu; x-originating-ip: [2605:e000:130a:c0d5:f989:e7e0:64dc:8bce] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a144de5e-9c4a-4d91-6bac-08d7ec801c3e x-ms-traffictypediagnostic: MW3PR16MB3932: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03883BD916 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f84Ea9aPm0q5sopAhuJ4pARHNuOrOiRdP0F7nCIFYmCrCtNvk0CYxx8gEFFomPAVt7N9KXmrcMoN+O0KUTUGDuWP0xdcldOez8HcnXCV2z6Pxn2EXjFUtSJ9YRmjU4fW2yZUC1Q630zje7r3s81HNxPbmvwdTkUrqd7T9pmK1Hj0CpmkWkYCtGmA73DkW/Y4FZ9X9irYBxQe20bHbRVfUalTZoGK8Xy13CqudMcNccbdRWTh8dxivzZpX746s4/LLKyw+MW07Ux9ADppW/lozUZgGEVOA5vSO4KCOvpK0lNpn6e+H4LRc8v9uFMkL9GkpYSdWImH6A8fTDr9gQudT6IeLO+kLVAnhdVdHcRCVfCRikCBIpFZiT7wk0AEAufvHoSqh+NR1/NMDmdrse2Dj3Jx/wAb0LmRTPLy1GDOllHEKPjJU9CC6iZO52R5HRsI x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR16MB3788.namprd16.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(39850400004)(376002)(366004)(136003)(346002)(86362001)(19627405001)(558084003)(186003)(75432002)(55016002)(66446008)(64756008)(52536014)(9686003)(76116006)(6916009)(71200400001)(66946007)(4743002)(66556008)(66476007)(7696005)(33656002)(5660300002)(6506007)(2906002)(8676002)(316002)(786003)(8936002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: vMZMyaeE+9YbO94M5wnODvpoRSFwcdSvbDQlBbUyPwHnAKmmwHl4qZI9/Bjsx9a7ecbZEQkIZ97GbtQEsv5KFrwkMck4OVkdKdm1cy7xQbQuJDDmLqSGoWFPSrRoWgFE9leLWfpMwuUOVeM+AB4csQbi4xodyhafR7stzPGaSCfPk3fddjXTGJdZQkE0SpeiKnX3OarAN/K7Rao2olfa/oFOfZp1j2JGMad5X+yzf/0cnZBjBgrs6e3wgYJGe+0zLcewSPo3ScQmudOwtt/atPAVTcL8jNARmLcdpCxdgURSMZd8Eb3AKqxibUP705rg19RfnCWcq69PBXOCkX8J77C7HC5HpFbkQrHKVUoxyQ1exW11FBx7+qzTQn+37J65PM1zeL3KnsU0AEq18n0xQI2ac7bv34LLa2kr8nco4C4MozWmA7W+2+p6n8+//71pgORpVY+FEGc1BurX7F7g8iUMjRhhxWEw5LG8L8gE0aTImT2e5cPHepMhg99mUQnnszZuP+plDsp2QpWuQyRwfmfG+acbpI2XFE8JzZ+JIsfnQrHOhsodhSpX8vQ4q5LNtDUXULwtdioluEqWTvXyzwwW7Jrm9poEADvV41rRVH3oHFfio/MpKwJROiYloAnIRwcm7zRYAgS616BfnXpGO2DrPhUtKAmS7KrwvALUNLZJEBmjnPi7NEgz1JKOxCLuJfBnK79QsuannoYWh3LdjfFGo0XkR9C1LDUYPghwxIOjFrXKRFU/jEGfeg0c3u1T+D2LF923SX6oxWzaAOOfyygiwsXVpbeeiaF+tStuOFBUUtvtswMdgy4C9Ea8zjdJsJr3/1QxQjhmEQ+njSd5sk5BQFTv9err9c18U/hwQ69fIY5HBALl/dZl0mpcpsDs x-ms-exchange-transport-forked: True Content-Type: multipart/alternative; boundary="_000_MW3PR16MB378893C6572180BD3F972424DFAD0MW3PR16MB3788namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a144de5e-9c4a-4d91-6bac-08d7ec801c3e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 20:58:46.9190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 336f97ac-2a54-469a-a939-2050bb2fc0a6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: azkkMbByQIAWYRFmk6vYOQylUJwsyaQufR6p28SHm2Uxl1aAvRF8Jk3aqHTR5bGz X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR16MB3932 X-OriginatorOrg: isi.edu Received-SPF: pass client-ip=128.9.180.199; envelope-from=gleb@isi.edu; helo=mail-d.ads.isi.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 16:58:49 X-ACL-Warn: Detected OS = ??? X-Received-From: 128.9.180.199 X-Mailman-Approved-At: Wed, 29 Apr 2020 17:28:08 -0400 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 20:58:54 -0000 --_000_MW3PR16MB378893C6572180BD3F972424DFAD0MW3PR16MB3788namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi team, The latest version of GNU make (4.3) does not contain the INSTALL instructi= ons as references in the README. Thanks, Gleb --_000_MW3PR16MB378893C6572180BD3F972424DFAD0MW3PR16MB3788namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi team,

The latest version of GNU make (4.3) does not contain the INSTALL instructions as references in the README.

Thanks,
Gleb
--_000_MW3PR16MB378893C6572180BD3F972424DFAD0MW3PR16MB3788namp_-- From MAILER-DAEMON Wed Apr 29 17:38:36 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jTuPc-0000ln-8e for mharc-bug-make@gnu.org; Wed, 29 Apr 2020 17:38:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTuND-0000bv-Kk for bug-make@gnu.org; Wed, 29 Apr 2020 17:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTuKK-0003NX-WC for bug-make@gnu.org; Wed, 29 Apr 2020 17:36:07 -0400 Received: from mail.oetec.com ([108.160.241.186]:55652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTuKJ-0003NG-VA for bug-make@gnu.org; Wed, 29 Apr 2020 17:33:08 -0400 X-oetec-MailScanner-From: dclarke@blastwave.org X-oetec-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.199, required 6, autolearn=not spam, ALL_TRUSTED -1.00, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10, DKIM_VALID_EF -0.10, URIBL_BLOCKED 0.00) X-oetec-MailScanner: Found to be clean X-oetec-MailScanner-ID: 03TLWxZO000489 X-oetec-MailScanner-Information: Please contact oetec for more information Received: from [172.16.35.3] (CPEf81d0f84cb23-CMf81d0f84cb20.cpe.net.cable.rogers.com [99.253.169.68]) (authenticated bits=0) by mail.oetec.com (8.15.2/8.15.2/Debian-8) with ESMTPSA id 03TLWxZO000489 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2020 17:33:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blastwave.org; s=default; t=1588195980; bh=EV3gue790QuiJa9Pt0ipiSizRy4YXEqCeNtc0KShZ9E=; h=Subject:To:References:From:Date:In-Reply-To:From; b=rBgLOR/vvgOalC7pjbT3n1AzmU03r4hGIkA2B3XfQn7lITqJmRVNsCmdVityXlvLe tDtRZJ9miXxIm+gUB6HHBj4v5VOvT1JrRhUrJ54tHWmqTj5Ptd7x0Ewf80ZDxUSmth OtI6xof23mafV7fU8aIRE+ad4Jh8yB88s7gIXq/w/tzf6FX07mfrKoztozo7lolzB9 eCAXXywN3Vx7gbuo82/shB2YCWt0HjdzGxcA/DN9deWii1cmQmSEhhNJwhAFGn5ebj SK952zNX7M6di471CiIABhcbZ72fLFGl9Equq2YH9UxSlWPh40L2oaLXOHAd4QRJ6C ktm2BypD5d0vw== Subject: Re: Missing INSTALL instructions for GNU make 4.3 To: bug-make@gnu.org References: From: Dennis Clarke Message-ID: <46161270-5c19-a2e5-f427-9e8b043db504@blastwave.org> Date: Wed, 29 Apr 2020 17:32:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Thunderbird/74.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=108.160.241.186; envelope-from=dclarke@blastwave.org; helo=mail.oetec.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 17:33:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 108.160.241.186 X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 21:38:35 -0000 On 2020-04-29 16:58, Gleb Satyukov wrote: > Hi team, > > The latest version of GNU make (4.3) does not contain the INSTALL instructions as references in the README. > > Thanks, > Gleb > Doesn't everyone just "make install" ? Sort of causes one to wonder about the chicken and egg scenario of a machine which has no previous "make" anywhere. That would be interesting. Probably have to fall back on pure scripts. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From MAILER-DAEMON Wed Apr 29 17:55:57 2020 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jTugP-0005FU-Fe for mharc-bug-make@gnu.org; Wed, 29 Apr 2020 17:55:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTugN-0005DM-8v for bug-make@gnu.org; Wed, 29 Apr 2020 17:55:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36490) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTugM-0001LH-JZ; Wed, 29 Apr 2020 17:55:54 -0400 Received: from pool-98-118-0-140.bstnma.fios.verizon.net ([98.118.0.140]:35162 helo=pdslaptop.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jTugK-0006RP-Te; Wed, 29 Apr 2020 17:55:53 -0400 Message-ID: <1bdaba24f9463699532cda59f93b931a1657c419.camel@gnu.org> Subject: Re: Missing INSTALL instructions for GNU make 4.3 From: Paul Smith Reply-To: psmith@gnu.org To: Dennis Clarke , bug-make@gnu.org Date: Wed, 29 Apr 2020 17:55:52 -0400 In-Reply-To: <46161270-5c19-a2e5-f427-9e8b043db504@blastwave.org> References: <46161270-5c19-a2e5-f427-9e8b043db504@blastwave.org> Organization: GNU's Not UNIX! Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: bug-make@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports and discussion for GNU make List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 21:55:55 -0000 This missing INSTALL file has been reported before. It's surely a poser because I haven't touched that package building stuff in a while. I thought automake just handled it. Clearly something changed :) On Wed, 2020-04-29 at 17:32 -0400, Dennis Clarke wrote: > Sort of causes one to wonder about the chicken and egg scenario > of a machine which has no previous "make" anywhere. That would be > interesting. Probably have to fall back on pure scripts. GNU make ships with a "build.sh" shell script that can be run (after configure) to compile make when you don't have a make program. This is discussed in the README file. There's a build_w32.bat as well, for Windows.