From MAILER-DAEMON Fri May 02 21:48:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP3o-0007kI-Dx for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:48:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP3g-0007j7-QM for bug-parted@gnu.org; Fri, 02 May 2014 21:48:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP3a-0001tV-Ns for bug-parted@gnu.org; Fri, 02 May 2014 21:48:08 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP3a-0001tR-Lc for bug-parted@gnu.org; Fri, 02 May 2014 21:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP3a-0004bk-DL for bug-parted@gnu.org; Fri, 02 May 2014 21:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16370: [PATCH] parted: don't reload partition table on every command Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16370 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16370@debbugs.gnu.org Received: via spool by 16370-submit@debbugs.gnu.org id=B16370.139908164117649 (code B ref 16370); Sat, 03 May 2014 01:48:02 +0000 Received: (at 16370) by debbugs.gnu.org; 3 May 2014 01:47:21 +0000 Received: from localhost ([127.0.0.1]:48913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP2v-0004ab-7t for submit@debbugs.gnu.org; Fri, 02 May 2014 21:47:21 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:37568 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP2t-0004aN-0U for 16370@debbugs.gnu.org; Fri, 02 May 2014 21:47:19 -0400 Received: from [72.238.67.160] ([72.238.67.160:48951] helo=[192.168.1.105]) by cdptpa-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id B7/14-20871-0AA44635; Sat, 03 May 2014 01:47:13 +0000 Message-ID: <53644AA0.8030806@ubuntu.com> Date: Fri, 02 May 2014 21:47:12 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <20140417221307.GW10077@lister.brianlane.com> <1397861706-15501-1-git-send-email-psusi@ubuntu.com> In-Reply-To: <1397861706-15501-1-git-send-email-psusi@ubuntu.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:48:15 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 04/18/2014 06:55 PM, Phillip Susi wrote: > I could have sworn I fixed that test before, but here it is > > 8<---------------------------->8 > > gpt was using a static local variable to suppress repeatedly > reporting an error if you chose to ignore it. This is incorrect as > the variable is global to all disks, and ignoring the error on one > should not suppress its reporting on another. Moving the flag to > the PedDisk object made it effectively useless because parted was > destroying the PedDisk and reloading the partition table on every > command. Just noticed I didn't Cc you on this, was that an ack on this one with the fixed test? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTZEqgAAoJEI5FoCIzSKrwmHwIAIF/g5wvbMLV/rrgYlQ5lmSM jxJYK6IFl0eOn96FtpPMUXlhNoDMlyYIEH6iX/FmhaKm59MaZ+Ueq80CuKTj878B g/ELD/YHgv18BhUqBSwFNRpP2LIvrqWnKnb1xifLwiSISo6DRJI1w78y/8waOdmX /L/wJEi4cs7R0jt5WHcNeutv/GuEBxEgsF51TlPBVLjmEMXf5aCyQ0dOefSrUIxz +qiPu64rSxglF4oZhpnf0LgrEcUgVm0MpSbqKcHBlRm6/mTDeyskr7acJB2hY3+s 1KJI47MSM8fCGZRqdFbjSTKgiSUMOykJy0/5Gtn3v6+Dmiz3NDlBtWShSRxXjq8= =NEr9 -----END PGP SIGNATURE----- From MAILER-DAEMON Fri May 02 21:52:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7h-00089L-9d for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7Y-00088E-VC for bug-parted@gnu.org; Fri, 02 May 2014 21:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7T-0003Cf-6q for bug-parted@gnu.org; Fri, 02 May 2014 21:52:08 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7T-0003CZ-3q for bug-parted@gnu.org; Fri, 02 May 2014 21:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7S-0004kC-Ej for bug-parted@gnu.org; Fri, 02 May 2014 21:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186218067 (code B ref 16231); Sat, 03 May 2014 01:52:02 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:02 +0000 Received: from localhost ([127.0.0.1]:48919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6T-0004gx-Sk for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:02 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6R-0004gZ-Fy for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:00 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 12/E6-08796-18B44635; Sat, 03 May 2014 01:50:58 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:42 -0400 Message-Id: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20140417221401.GX10077@lister.brianlane.com> References: <20140417221401.GX10077@lister.brianlane.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:15 -0000 I have refactored the loop fixes making them cleaner, and breaking them out into separate patches for easier review. Phillip Susi (9): libparted: don't detect fat and ntfs boot sectors as dos MBR libparted: remove old partitions *first* before adding new ones libparted: remove all old partitions, even if new label allows less libparted: fix loop labels to not vanish libparted: don't create partition on loop label partprobe: do not skip loop labels libparted: give correct partition device name on loop labels libparted: don't trash filesystem when writing loop label tests: test loop labels NEWS | 22 +++++++ libparted/arch/linux.c | 67 ++++++++++++-------- libparted/fs/ntfs/ntfs.c | 2 +- libparted/labels/dos.c | 29 +++++++++ libparted/labels/loop.c | 54 ++++++++--------- partprobe/partprobe.c | 4 +- tests/Makefile.am | 2 + tests/t1102-loop-label.sh | 104 ++++++++++++++++++++++++++++++++ tests/t1104-remove-and-add-partition.sh | 50 +++++++++++++++ 9 files changed, 275 insertions(+), 59 deletions(-) create mode 100644 tests/t1102-loop-label.sh create mode 100644 tests/t1104-remove-and-add-partition.sh -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7j-0008CS-Dl for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7d-00088K-AR for bug-parted@gnu.org; Fri, 02 May 2014 21:52:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7T-0003Cr-Li for bug-parted@gnu.org; Fri, 02 May 2014 21:52:13 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7T-0003Cn-HV for bug-parted@gnu.org; Fri, 02 May 2014 21:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7T-0004kK-A3 for bug-parted@gnu.org; Fri, 02 May 2014 21:52:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 2/9] libparted: remove old partitions *first* before adding new ones Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186318080 (code B ref 16231); Sat, 03 May 2014 01:52:03 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:03 +0000 Received: from localhost ([127.0.0.1]:48923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6U-0004hM-Om for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:03 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6S-0004gZ-82 for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:00 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id EA/E6-08796-28B44635; Sat, 03 May 2014 01:50:58 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:44 -0400 Message-Id: <1399081851-3558-3-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:18 -0000 "libparted: avoid disturbing partitions" put the remove of the old partition in second pass. If you simultaneously removed partitions 1 and 2, and created a new partition #1 that overlapped the previous second partition, the sync would fail because it would try to create the new, larger partition #1 before removing the old partition #2. --- libparted/arch/linux.c | 43 ++++++++++++++-------------- tests/Makefile.am | 1 + tests/t1104-remove-and-add-partition.sh | 50 +++++++++++++++++++++++++++++++++ 3 files changed, 72 insertions(+), 22 deletions(-) create mode 100644 tests/t1104-remove-and-add-partition.sh diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index 71f5034..ced06a3 100644 --- a/libparted/arch/linux.c +++ b/libparted/arch/linux.c @@ -2855,23 +2855,8 @@ _disk_sync_part_table (PedDisk* disk) && start == part->geom.start && length == part->geom.length) { - ok[i - 1] = 1; - continue; - } - } - } - for (i = 1; i <= lpn; i++) { - PedPartition *part = ped_disk_get_partition (disk, i); - if (part) { - unsigned long long length; - unsigned long long start; - /* get start and length of existing partition */ - if (get_partition_start_and_length(part, - &start, &length) - && start == part->geom.start - && length == part->geom.length) { - ok[i - 1] = 1; /* partition is unchanged, so nothing to do */ + ok[i - 1] = 1; continue; } } @@ -2890,12 +2875,26 @@ _disk_sync_part_table (PedDisk* disk) } while (n_sleep--); if (!ok[i - 1] && errnums[i - 1] == ENXIO) ok[i - 1] = 1; /* it already doesn't exist */ - if (part && ok[i - 1]) { - /* add the (possibly modified or new) partition */ - if (!add_partition (disk, part)) { - ok[i - 1] = 0; - errnums[i - 1] = errno; - } + } + for (i = 1; i <= lpn; i++) { + PedPartition *part = ped_disk_get_partition (disk, i); + if (!part) + continue; + unsigned long long length; + unsigned long long start; + /* get start and length of existing partition */ + if (get_partition_start_and_length(part, + &start, &length) + && start == part->geom.start + && length == part->geom.length) { + ok[i - 1] = 1; + /* partition is unchanged, so nothing to do */ + continue; + } + /* add the (possibly modified or new) partition */ + if (!add_partition (disk, part)) { + ok[i - 1] = 0; + errnums[i - 1] = errno; } } diff --git a/tests/Makefile.am b/tests/Makefile.am index 9100a81..e064b8f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -40,6 +40,7 @@ TESTS = \ t0501-duplicate.sh \ t1100-busy-label.sh \ t1101-busy-partition.sh \ + t1104-remove-and-add-partition.sh \ t1700-probe-fs.sh \ t2200-dos-label-recog.sh \ t2201-pc98-label-recog.sh \ diff --git a/tests/t1104-remove-and-add-partition.sh b/tests/t1104-remove-and-add-partition.sh new file mode 100644 index 0000000..61cc392 --- /dev/null +++ b/tests/t1104-remove-and-add-partition.sh @@ -0,0 +1,50 @@ +#!/bin/sh +# make sure that removing a higher numbered partition and adding a lower +# one using that space at the same time works + +# Copyright (C) 2014 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +. "${srcdir=.}/init.sh"; path_prepend_ ../parted +path_prepend_ ../partprobe +require_root_ +ss=$sector_size_ + +d1= f1= +cleanup_fn_() +{ + test -n "$d1" && losetup -d "$d1" + rm -f "$f1" +} + +f1=$(pwd)/1; d1=$(loop_setup_ "$f1") \ + || skip_ "is this partition mounted with 'nodev'?" + +require_partitionable_loop_device_ $d1 + +# create one big partition +parted -s $d1 mklabel msdos mkpart primary ext2 1m 10m || fail=1 + +# save this table +dd if=$d1 of=saved count=1 || fail=1 + +# create two small partitions +parted -s $d1 mklabel msdos mkpart primary ext2 1m 5m mkpart primary ext2 5m 10m || fail=1 + +# restore first table and make sure partprobe works +dd if=saved of=$d1 || fail=1 +partprobe $d1 || fail=1 + +Exit $fail -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:19 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7j-0008Cz-Kj for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7d-00088L-Nu for bug-parted@gnu.org; Fri, 02 May 2014 21:52:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7Y-0003ET-IS for bug-parted@gnu.org; Fri, 02 May 2014 21:52:13 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7Y-0003EP-FA for bug-parted@gnu.org; Fri, 02 May 2014 21:52:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7Y-0004lF-6r for bug-parted@gnu.org; Fri, 02 May 2014 21:52:08 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 9/9] tests: test loop labels Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908187018157 (code B ref 16231); Sat, 03 May 2014 01:52:08 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:10 +0000 Received: from localhost ([127.0.0.1]:48942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6b-0004ie-2i for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:09 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6W-0004gZ-JH for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:05 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 35/F6-08796-48B44635; Sat, 03 May 2014 01:51:00 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:51 -0400 Message-Id: <1399081851-3558-10-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:18 -0000 Verify previous fixes to loop labels. --- tests/Makefile.am | 1 + tests/t1102-loop-label.sh | 104 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 105 insertions(+) create mode 100644 tests/t1102-loop-label.sh diff --git a/tests/Makefile.am b/tests/Makefile.am index e064b8f..26226cf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -40,6 +40,7 @@ TESTS = \ t0501-duplicate.sh \ t1100-busy-label.sh \ t1101-busy-partition.sh \ + t1102-loop-label.sh \ t1104-remove-and-add-partition.sh \ t1700-probe-fs.sh \ t2200-dos-label-recog.sh \ diff --git a/tests/t1102-loop-label.sh b/tests/t1102-loop-label.sh new file mode 100644 index 0000000..f5701a3 --- /dev/null +++ b/tests/t1102-loop-label.sh @@ -0,0 +1,104 @@ +#!/bin/sh +# make sure that loop labels work correctly +# create an actual partition + +# Copyright (C) 2013 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +. "${srcdir=.}/init.sh"; path_prepend_ ../parted +path_prepend_ ../partprobe +require_root_ +require_scsi_debug_module_ +ss=$sector_size_ + +scsi_debug_setup_ sector_size=$ss dev_size_mb=90 > dev-name || + skip_ 'failed to create scsi_debug device' +dev=$(cat dev-name) + +mke2fs -F $dev +parted -s "$dev" print > out 2>&1 || fail=1 +cat < exp +Model: Linux scsi_debug (scsi) +Disk DEVICE: 94.4MB +Sector size (logical/physical): ${ss}B/${ss}B +Partition Table: loop +Disk Flags: + +Number Start End Size File system Flags + 1 0.00B 94.4MB 94.4MB ext2 + +EOF +mv out o2 && sed -e "s,$dev,DEVICE,;" o2 > out + +compare exp out || fail=1 +parted -s $dev rm 1 || fail=1 +if [ -e ${dev}1 ]; then + echo "Partition should not exist on loop device" + fail=1 +fi +partprobe $dev || fail=1 +if [ -e ${dev}1 ]; then + echo "Partition should not exist on loop device" + fail=1 +fi + +mount_point="`pwd`/mnt" + +# Be sure to unmount upon interrupt, failure, etc. +cleanup_fn_() { umount "$mount_point" > /dev/null 2>&1; } + +# create mount point dir. and mount the just-created partition on it +mkdir $mount_point || fail=1 +mount -t ext2 "${dev}" $mount_point || fail=1 + +# now that a partition is mounted, mklabel attempt must fail +parted -s "$dev" mklabel msdos > out 2>&1; test $? = 1 || fail=1 + +# create expected output file +echo "Error: Partition(s) on $dev are being used." > exp +compare exp out || fail=1 + +# make sure partition busy check works ( mklabel checks whole disk ) +parted -s "$dev" rm 1 > out 2>&1; test $? = 1 || fail=1 +# create expected output file +echo "Error: Partition $dev is being used. You must unmount it before you modify \ +it with Parted." > exp +compare exp out || fail=1 + +umount "$mount_point" + +# make sure partprobe cleans up stale partition devices +parted -s $dev mklabel msdos mkpart primary ext2 0% 100% || fail=1 +if [ ! -e ${dev}1 ]; then + echo "Partition doesn't exist on loop device" + fail=1 +fi + +mke2fs -F $dev +partprobe $dev || fail=1 +if [ -e ${dev}1 ]; then + echo "Partition should not exist on loop device" + fail=1 +fi + +# make sure new loop label removes old partitions > 1 +parted -s $dev mklabel msdos mkpart primary ext2 0% 50% mkpart primary ext2 50% 100% || fail=1 +parted -s $dev mklabel loop || fail=1 +if [ -e ${dev}2 ]; then + echo "Partition 2 not removed" + fail=1 +fi + +Exit $fail -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:28 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7s-0008Rn-BH for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7g-00089H-Us for bug-parted@gnu.org; Fri, 02 May 2014 21:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7X-0003EJ-Tz for bug-parted@gnu.org; Fri, 02 May 2014 21:52:16 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7X-0003EF-QS for bug-parted@gnu.org; Fri, 02 May 2014 21:52:07 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7X-0004l6-G4 for bug-parted@gnu.org; Fri, 02 May 2014 21:52:07 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 3/9] libparted: remove all old partitions, even if new label allows less Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186918147 (code B ref 16231); Sat, 03 May 2014 01:52:07 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:09 +0000 Received: from localhost ([127.0.0.1]:48940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6a-0004iX-Nt for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:08 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.231]:38317 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6W-0004gl-1K for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:04 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id EC/E6-08796-28B44635; Sat, 03 May 2014 01:50:59 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:45 -0400 Message-Id: <1399081851-3558-4-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:24 -0000 We were limiting partition sync operations to the lesser number allowed by the device, or the label. This meant that when creating a new label over an old label that had more partitions than the new one allows, the higher partitions would not be removed. Use the greater of the two values for the remove pass, and the lesser for the add. --- NEWS | 3 +++ libparted/arch/linux.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 1233f1c..093314b 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,9 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + libparted: remove all old partitions, even if new label does not allow + as many. + libparted: fat and ntfs boot sectors were misdetected as dos partition tables instead of being treated as a loop label. diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index ced06a3..4cbe49b 100644 --- a/libparted/arch/linux.c +++ b/libparted/arch/linux.c @@ -2823,9 +2823,10 @@ _disk_sync_part_table (PedDisk* disk) get_partition_start_and_length = _kernel_get_partition_start_and_length; } - /* lpn = largest partition number. */ + /* lpn = largest partition number. + * for remove pass, use greater of device or label limit */ if (ped_disk_get_max_supported_partition_count(disk, &lpn)) - lpn = PED_MIN(lpn, part_range); + lpn = PED_MAX(lpn, part_range); else lpn = part_range; @@ -2876,6 +2877,12 @@ _disk_sync_part_table (PedDisk* disk) if (!ok[i - 1] && errnums[i - 1] == ENXIO) ok[i - 1] = 1; /* it already doesn't exist */ } + /* lpn = largest partition number. + * for add pass, use lesser of device or label limit */ + if (ped_disk_get_max_supported_partition_count(disk, &lpn)) + lpn = PED_MIN(lpn, part_range); + else + lpn = part_range; for (i = 1; i <= lpn; i++) { PedPartition *part = ped_disk_get_partition (disk, i); if (!part) -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:28 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7s-0008SC-Fw for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7i-0008A5-0q for bug-parted@gnu.org; Fri, 02 May 2014 21:52:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7Z-0003Eo-6X for bug-parted@gnu.org; Fri, 02 May 2014 21:52:17 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7Z-0003Ei-4C for bug-parted@gnu.org; Fri, 02 May 2014 21:52:09 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7Y-0004lN-Pc for bug-parted@gnu.org; Fri, 02 May 2014 21:52:08 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 1/9] libparted: don't detect fat and ntfs boot sectors as dos MBR Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908187218169 (code B ref 16231); Sat, 03 May 2014 01:52:08 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:12 +0000 Received: from localhost ([127.0.0.1]:48944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6d-0004iy-7k for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:11 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.228]:30489 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6W-0004ge-L8 for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:09 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 39/E6-08796-28B44635; Sat, 03 May 2014 01:50:58 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:43 -0400 Message-Id: <1399081851-3558-2-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:25 -0000 fat and ntfs boot sectors are very similar to an MBR so if you had one of these filesystems on an unpartitioned disk, parted detected them as a dos partition table. Have the dos label code call the fat and ntfs filesystem probes and if they recognize the sector ( their tests are more stringent ) then don't claim it as a dos label. --- NEWS | 3 +++ libparted/fs/ntfs/ntfs.c | 2 +- libparted/labels/dos.c | 29 +++++++++++++++++++++++++++++ 3 files changed, 33 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 61a896c..1233f1c 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,9 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + libparted: fat and ntfs boot sectors were misdetected as dos + partition tables instead of being treated as a loop label. + libparted: previously if you chose to ignore the warning about the gpt thinking the disk was smaller than it appears to be on on disk, subsequent warnings on other disks would be suppressed. diff --git a/libparted/fs/ntfs/ntfs.c b/libparted/fs/ntfs/ntfs.c index 3ba2683..4c154fd 100644 --- a/libparted/fs/ntfs/ntfs.c +++ b/libparted/fs/ntfs/ntfs.c @@ -32,7 +32,7 @@ #define NTFS_SIGNATURE "NTFS" -static PedGeometry* +PedGeometry* ntfs_probe (PedGeometry* geom) { char *buf = alloca (geom->dev->sector_size); diff --git a/libparted/labels/dos.c b/libparted/labels/dos.c index eff1c03..295fcf3 100644 --- a/libparted/labels/dos.c +++ b/libparted/labels/dos.c @@ -235,12 +235,23 @@ maybe_FAT (unsigned char const *s) return true; } +PedGeometry* +fat_probe_fat16 (PedGeometry* geom); + +PedGeometry* +fat_probe_fat32 (PedGeometry* geom); + +PedGeometry* +ntfs_probe (PedGeometry* geom); + static int msdos_probe (const PedDevice *dev) { PedDiskType* disk_type; DosRawTable* part_table; int i; + PedGeometry *geom = NULL; + PedGeometry *fsgeom = NULL; PED_ASSERT (dev != NULL); @@ -257,6 +268,20 @@ msdos_probe (const PedDevice *dev) if (PED_LE16_TO_CPU (part_table->magic) != MSDOS_MAGIC) goto probe_fail; + geom = ped_geometry_new (dev, 0, dev->length); + PED_ASSERT (geom); + fsgeom = fat_probe_fat16 (geom); + if (fsgeom) + goto probe_fail; /* fat fs looks like dos mbr */ + fsgeom = fat_probe_fat32 (geom); + if (fsgeom) + goto probe_fail; /* fat fs looks like dos mbr */ + fsgeom = ntfs_probe (geom); + if (fsgeom) + goto probe_fail; /* ntfs fs looks like dos mbr */ + ped_geometry_destroy (geom); + geom = NULL; + /* If this is a FAT fs, fail here. Checking for the FAT signature * has some false positives; instead, do what the Linux kernel does * and ensure that each partition has a boot indicator that is @@ -303,6 +328,10 @@ msdos_probe (const PedDevice *dev) return 1; probe_fail: + if (geom) + ped_geometry_destroy (geom); + if (fsgeom) + ped_geometry_destroy (fsgeom); free (label); return 0; } -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:29 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7t-0008U5-7W for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7i-0008B0-T9 for bug-parted@gnu.org; Fri, 02 May 2014 21:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7W-0003Dp-DL for bug-parted@gnu.org; Fri, 02 May 2014 21:52:18 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7W-0003Di-AA for bug-parted@gnu.org; Fri, 02 May 2014 21:52:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7W-0004kq-1B for bug-parted@gnu.org; Fri, 02 May 2014 21:52:06 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 7/9] libparted: give correct partition device name on loop labels Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186718131 (code B ref 16231); Sat, 03 May 2014 01:52:05 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:07 +0000 Received: from localhost ([127.0.0.1]:48936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6Y-0004iH-PL for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:07 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6V-0004gZ-6i for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:03 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id B2/F6-08796-38B44635; Sat, 03 May 2014 01:51:00 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:49 -0400 Message-Id: <1399081851-3558-8-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:26 -0000 ped_partition_get_path() was returning "/dev/foo1" instead of "/dev/foo" on loop labels. This caused gparted to run tools like mkfs on a device node that did not actually exist. --- NEWS | 3 +++ libparted/arch/linux.c | 10 ++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index f99c6fe..c97f4eb 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,9 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + libparted: ped_partition_get_path() was returning "/dev/foo1" instead + of "/dev/foo" for loop labels. + partprobe: when called on a disk that has become a loop label, remove any partitions left over from a previous label. diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index 9ae6d64..f2e2abc 100644 --- a/libparted/arch/linux.c +++ b/libparted/arch/linux.c @@ -48,6 +48,7 @@ #include "../architecture.h" #include "dirname.h" #include "xstrtol.h" +#include "xalloc.h" #if ENABLE_NLS # include @@ -2356,6 +2357,9 @@ _device_get_part_path (PedDevice const *dev, int num) static char* linux_partition_get_path (const PedPartition* part) { + /* loop label means use the whole disk */ + if (strcmp (part->disk->type->name, "loop") == 0) + return xstrdup (part->disk->dev->path); return _device_get_part_path (part->disk->dev, part->num); } @@ -2424,6 +2428,8 @@ linux_partition_is_busy (const PedPartition* part) PED_ASSERT (part != NULL); + if (strcmp (part->disk->type->name, "loop") == 0) + return linux_is_busy (part->disk->dev); if (_partition_is_mounted (part)) return 1; if (part->type == PED_PARTITION_EXTENDED) { @@ -2546,7 +2552,7 @@ _sysfs_ull_entry_from_part(PedPartition const* part, const char *entry, unsigned long long *val) { char path[128]; - char *part_name = linux_partition_get_path(part); + char *part_name = _device_get_part_path (part->disk->dev, part->num); if (!part_name) return false; @@ -2581,7 +2587,7 @@ _kernel_get_partition_start_and_length(PedPartition const *part, PED_ASSERT(start); PED_ASSERT(length); - char *dev_name = linux_partition_get_path (part); + char *dev_name = _device_get_part_path (part->disk->dev, part->num); if (!dev_name) return false; -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:29 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7t-0008UT-EP for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7h-00089p-KQ for bug-parted@gnu.org; Fri, 02 May 2014 21:52:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7V-0003DS-2u for bug-parted@gnu.org; Fri, 02 May 2014 21:52:17 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7U-0003DA-VP for bug-parted@gnu.org; Fri, 02 May 2014 21:52:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7U-0004kZ-Gv for bug-parted@gnu.org; Fri, 02 May 2014 21:52:04 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 5/9] libparted: don't create partition on loop label Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186618117 (code B ref 16231); Sat, 03 May 2014 01:52:04 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:06 +0000 Received: from localhost ([127.0.0.1]:48930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6W-0004hn-IW for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:05 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6T-0004gZ-RF for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:02 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 8F/E6-08796-38B44635; Sat, 03 May 2014 01:50:59 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:47 -0400 Message-Id: <1399081851-3558-6-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:27 -0000 The loop label represents an unpartitioned disk, but creates a dummy partition to represent the whole disk. This dummy partition was actually being loaded into the kernel. Don't do that. --- NEWS | 4 ++++ libparted/arch/linux.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/NEWS b/NEWS index 36536e2..385a120 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,10 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + libparted: The loop label represents an unpartitioned disk, but creates + a dummy partition to represent the whole disk. This dummy partition + was actually being loaded into the kernel. Don't do that. + libparted: fix loop labels to not vanish if you don't create a filesystem, and to not return an error syncing when you do. diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index 4cbe49b..9ae6d64 100644 --- a/libparted/arch/linux.c +++ b/libparted/arch/linux.c @@ -2883,6 +2883,9 @@ _disk_sync_part_table (PedDisk* disk) lpn = PED_MIN(lpn, part_range); else lpn = part_range; + /* don't actually add partitions for loop */ + if (strcmp (disk->type->name, "loop") == 0) + lpn = 0; for (i = 1; i <= lpn; i++) { PedPartition *part = ped_disk_get_partition (disk, i); if (!part) -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:31 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7v-00006Q-75 for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7h-00089y-TU for bug-parted@gnu.org; Fri, 02 May 2014 21:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7U-0003D2-AG for bug-parted@gnu.org; Fri, 02 May 2014 21:52:17 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7U-0003Cy-6W for bug-parted@gnu.org; Fri, 02 May 2014 21:52:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7T-0004kS-TG for bug-parted@gnu.org; Fri, 02 May 2014 21:52:04 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 4/9] libparted: fix loop labels to not vanish Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186418096 (code B ref 16231); Sat, 03 May 2014 01:52:03 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:04 +0000 Received: from localhost ([127.0.0.1]:48926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6V-0004hZ-Rl for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:04 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6T-0004gZ-28 for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:01 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 2E/E6-08796-38B44635; Sat, 03 May 2014 01:50:59 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:46 -0400 Message-Id: <1399081851-3558-5-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:28 -0000 The loop label type was using the existence of a partition as a proxy for a filesystem being detected, and loop_write() would try to write a loop signature if there was no filesystem, and erase it if there was. Because of this, creating a partition without writing a filesystem to it caused loop_write to erase the loop label. There seems to be no reason to bother erasing the loop label if it is still present along with a filesystem signature, so don't bother with this, and actually check to see if a filesystem is detected in the partition rather than using the existence of a partition to decide if writing the loop signature is needed. Finally, since there is no way to preserve the existence of a partition with no filesystem in it, have loop_read() always create a partition, even if no filesystem is detected. --- NEWS | 6 ++++++ libparted/labels/loop.c | 53 ++++++++++++++++++++++--------------------------- 2 files changed, 30 insertions(+), 29 deletions(-) diff --git a/NEWS b/NEWS index 093314b..36536e2 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,9 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + libparted: fix loop labels to not vanish if you don't create + a filesystem, and to not return an error syncing when you do. + libparted: remove all old partitions, even if new label does not allow as many. @@ -110,6 +113,9 @@ GNU parted NEWS -*- outline -*- ** Changes in behavior + When creating a loop label, it automatically comes with a partition + using the whole disk. + parted -l no longer lists device-mapper devices other than dmraid whole disks. diff --git a/libparted/labels/loop.c b/libparted/labels/loop.c index ea8f007..8ebb1f4 100644 --- a/libparted/labels/loop.c +++ b/libparted/labels/loop.c @@ -80,7 +80,23 @@ loop_alloc (const PedDevice* dev) if (dev->length < 256) return NULL; - return _ped_disk_alloc ((PedDevice*)dev, &loop_disk_type); + PedDisk *disk = _ped_disk_alloc ((PedDevice*)dev, &loop_disk_type); + PED_ASSERT (disk != NULL); + PedGeometry *geom = ped_geometry_new (dev, 0, dev->length); + PED_ASSERT (geom != NULL); + PedPartition *part = ped_partition_new (disk, PED_PARTITION_NORMAL, + NULL, geom->start, geom->end); + PED_ASSERT (part != NULL); + ped_geometry_destroy (geom); + PedConstraint *constraint_any = ped_constraint_any (dev); + if (!ped_disk_add_partition (disk, part, constraint_any)) + goto error; + ped_constraint_destroy (constraint_any); + return disk; + error: + ped_constraint_destroy (constraint_any); + ped_disk_destroy (disk); + return NULL; } static PedDisk* @@ -118,18 +134,12 @@ loop_read (PedDisk* disk) int found_sig = !strncmp (buf, LOOP_SIGNATURE, strlen (LOOP_SIGNATURE)); free (buf); - - if (found_sig) { - ped_constraint_destroy (constraint_any); - return 1; - } - geom = ped_geometry_new (dev, 0, dev->length); if (!geom) goto error; fs_type = ped_file_system_probe (geom); - if (!fs_type) + if (!fs_type && !found_sig) goto error_free_geom; part = ped_partition_new (disk, PED_PARTITION_NORMAL, @@ -137,7 +147,6 @@ loop_read (PedDisk* disk) ped_geometry_destroy (geom); if (!part) goto error; - part->fs_type = fs_type; if (!ped_disk_add_partition (disk, part, constraint_any)) goto error; @@ -156,29 +165,15 @@ static int loop_write (const PedDisk* disk) { size_t buflen = disk->dev->sector_size; - char *buf = ped_malloc (buflen); - if (buf == NULL) - return 0; - - if (ped_disk_get_partition (disk, 1)) { - if (!ped_device_read (disk->dev, buf, 0, 1)) { - free (buf); - return 0; - } - if (strncmp (buf, LOOP_SIGNATURE, strlen (LOOP_SIGNATURE)) != 0) { - free (buf); - return 1; - } - memset (buf, 0, strlen (LOOP_SIGNATURE)); - return ped_device_write (disk->dev, buf, 0, 1); - } - + char *buf = alloca (buflen); + PedPartition *part = ped_disk_get_partition (disk, 1); + /* if there is already a filesystem on the disk, we don't need to write the signature */ + if (part && part->fs_type) + return 1; memset (buf, 0, buflen); strcpy (buf, LOOP_SIGNATURE); - int write_ok = ped_device_write (disk->dev, buf, 0, 1); - free (buf); - return write_ok; + return ped_device_write (disk->dev, buf, 0, 1); } #endif /* !DISCOVER_ONLY */ -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:29 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7s-0008Sy-Sk for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7i-0008Ax-SD for bug-parted@gnu.org; Fri, 02 May 2014 21:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7V-0003De-Q6 for bug-parted@gnu.org; Fri, 02 May 2014 21:52:18 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7V-0003DY-MO for bug-parted@gnu.org; Fri, 02 May 2014 21:52:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7V-0004kj-Ac for bug-parted@gnu.org; Fri, 02 May 2014 21:52:05 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 6/9] partprobe: do not skip loop labels Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186618124 (code B ref 16231); Sat, 03 May 2014 01:52:05 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:06 +0000 Received: from localhost ([127.0.0.1]:48934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6Y-0004iA-0p for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:06 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6U-0004gZ-Gq for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:02 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id C1/F6-08796-38B44635; Sat, 03 May 2014 01:50:59 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:48 -0400 Message-Id: <1399081851-3558-7-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:26 -0000 Partprobe was not syncing loop labels. This resulted it failing to remove existing partitions when switching to a loop label. --- NEWS | 3 +++ partprobe/partprobe.c | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 385a120..f99c6fe 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,9 @@ GNU parted NEWS -*- outline -*- ** Bug Fixes + partprobe: when called on a disk that has become a loop label, + remove any partitions left over from a previous label. + libparted: The loop label represents an unpartitioned disk, but creates a dummy partition to represent the whole disk. This dummy partition was actually being loaded into the kernel. Don't do that. diff --git a/partprobe/partprobe.c b/partprobe/partprobe.c index 4da4fb7..8b744b5 100644 --- a/partprobe/partprobe.c +++ b/partprobe/partprobe.c @@ -106,9 +106,7 @@ process_dev (PedDevice* dev) PedDisk* disk; disk_type = ped_disk_probe (dev); - if (disk_type && !strcmp (disk_type->name, "loop")) - return 1; - else if (!disk_type) { + if (!disk_type) { /* Partition table not found, so create dummy, empty one */ disk_type = ped_disk_type_get("msdos"); -- 1.9.1 From MAILER-DAEMON Fri May 02 21:52:30 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WgP7t-0008Ur-Uk for mharc-bug-parted@gnu.org; Fri, 02 May 2014 21:52:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7i-0008B3-Uo for bug-parted@gnu.org; Fri, 02 May 2014 21:52:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgP7X-0003E6-7C for bug-parted@gnu.org; Fri, 02 May 2014 21:52:18 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:59832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgP7X-0003E2-45 for bug-parted@gnu.org; Fri, 02 May 2014 21:52:07 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WgP7W-0004ky-MN for bug-parted@gnu.org; Fri, 02 May 2014 21:52:06 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 8/9] libparted: don't trash filesystem when writing loop label Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Sat, 03 May 2014 01:52:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16231@debbugs.gnu.org Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139908186818140 (code B ref 16231); Sat, 03 May 2014 01:52:06 +0000 Received: (at 16231) by debbugs.gnu.org; 3 May 2014 01:51:08 +0000 Received: from localhost ([127.0.0.1]:48938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6a-0004iV-5f for submit@debbugs.gnu.org; Fri, 02 May 2014 21:51:08 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:30510 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgP6W-0004gZ-16 for 16231@debbugs.gnu.org; Fri, 02 May 2014 21:51:04 -0400 Received: from [72.238.67.160] ([72.238.67.160:49064] helo=faldara.cfl.rr.com) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id F3/F6-08796-48B44635; Sat, 03 May 2014 01:51:00 +0000 From: Phillip Susi Date: Fri, 2 May 2014 21:50:50 -0400 Message-Id: <1399081851-3558-9-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2014 01:52:27 -0000 If you deleted the fake partition on a loop label, loop_write() would write the loop signature to the device, zeroing out all other bytes in the first sector. When the disk contained an ext[234] filesystem and was using 2k sectors, this would trash the super block residing in the 1-2kb part of the sector causing the disk to become unrecognized. Instead, read the existing sector and only modify the first few bytes that contain the loop label. --- libparted/labels/loop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libparted/labels/loop.c b/libparted/labels/loop.c index 8ebb1f4..98f9f23 100644 --- a/libparted/labels/loop.c +++ b/libparted/labels/loop.c @@ -170,7 +170,8 @@ loop_write (const PedDisk* disk) /* if there is already a filesystem on the disk, we don't need to write the signature */ if (part && part->fs_type) return 1; - memset (buf, 0, buflen); + if (!ped_device_read (disk->dev, buf, 0, 1)) + return 0; strcpy (buf, LOOP_SIGNATURE); return ped_device_write (disk->dev, buf, 0, 1); -- 1.9.1 From MAILER-DAEMON Wed May 07 18:50:15 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WiAfH-0003EE-00 for mharc-bug-parted@gnu.org; Wed, 07 May 2014 18:50:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiAfA-0003Bb-Fk for bug-parted@gnu.org; Wed, 07 May 2014 18:50:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiAf5-0005Xu-I9 for bug-parted@gnu.org; Wed, 07 May 2014 18:50:08 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:37584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiAf5-0005Xb-Fk for bug-parted@gnu.org; Wed, 07 May 2014 18:50:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WiAf4-00048P-TD for bug-parted@gnu.org; Wed, 07 May 2014 18:50:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Wed, 07 May 2014 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139950296415831 (code B ref 16231); Wed, 07 May 2014 22:50:02 +0000 Received: (at 16231) by debbugs.gnu.org; 7 May 2014 22:49:24 +0000 Received: from localhost ([127.0.0.1]:54935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiAeQ-00047H-Vs for submit@debbugs.gnu.org; Wed, 07 May 2014 18:49:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiAeL-000474-7G for 16231@debbugs.gnu.org; Wed, 07 May 2014 18:49:19 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s47MnFTq031465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 May 2014 18:49:15 -0400 Received: from lister.brianlane.com (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s47MnDHH019679 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 7 May 2014 18:49:15 -0400 Date: Wed, 7 May 2014 15:49:13 -0700 From: "Brian C. Lane" Message-ID: <20140507224913.GP2925@lister.brianlane.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399081851-3558-1-git-send-email-psusi@ubuntu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 22:50:13 -0000 On Fri, May 02, 2014 at 09:50:42PM -0400, Phillip Susi wrote: > I have refactored the loop fixes making them cleaner, and breaking them out > into separate patches for easier review. > > Phillip Susi (9): > libparted: don't detect fat and ntfs boot sectors as dos MBR > libparted: remove old partitions *first* before adding new ones > libparted: remove all old partitions, even if new label allows less > libparted: fix loop labels to not vanish > libparted: don't create partition on loop label > partprobe: do not skip loop labels > libparted: give correct partition device name on loop labels > libparted: don't trash filesystem when writing loop label > tests: test loop labels > > NEWS | 22 +++++++ > libparted/arch/linux.c | 67 ++++++++++++-------- > libparted/fs/ntfs/ntfs.c | 2 +- > libparted/labels/dos.c | 29 +++++++++ > libparted/labels/loop.c | 54 ++++++++--------- > partprobe/partprobe.c | 4 +- > tests/Makefile.am | 2 + > tests/t1102-loop-label.sh | 104 ++++++++++++++++++++++++++++++++ > tests/t1104-remove-and-add-partition.sh | 50 +++++++++++++++ > 9 files changed, 275 insertions(+), 59 deletions(-) > create mode 100644 tests/t1102-loop-label.sh > create mode 100644 tests/t1104-remove-and-add-partition.sh > > -- > 1.9.1 > NAK. These make a pile of the tests fail: ========================================== GNU parted 3.1: tests/test-suite.log ========================================== # TOTAL: 77 # PASS: 27 # SKIP: 35 # XFAIL: 0 # FAIL: 15 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 looks like at least one core dump in the mix. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From MAILER-DAEMON Wed May 07 21:33:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WiDD3-0000ws-4l for mharc-bug-parted@gnu.org; Wed, 07 May 2014 21:33:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiDCu-0000vP-UJ for bug-parted@gnu.org; Wed, 07 May 2014 21:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiDCo-00065U-Ru for bug-parted@gnu.org; Wed, 07 May 2014 21:33:08 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:37633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiDCo-00065O-PC for bug-parted@gnu.org; Wed, 07 May 2014 21:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WiDCo-0008Ns-0B for bug-parted@gnu.org; Wed, 07 May 2014 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 08 May 2014 01:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: "Brian C. Lane" Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139951276932206 (code B ref 16231); Thu, 08 May 2014 01:33:01 +0000 Received: (at 16231) by debbugs.gnu.org; 8 May 2014 01:32:49 +0000 Received: from localhost ([127.0.0.1]:54984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiDCa-0008NO-T4 for submit@debbugs.gnu.org; Wed, 07 May 2014 21:32:49 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:65066 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiDCZ-0008NG-0R for 16231@debbugs.gnu.org; Wed, 07 May 2014 21:32:47 -0400 Received: from [72.238.67.160] ([72.238.67.160:38065] helo=[192.168.1.102]) by cdptpa-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id A2/36-15603-DBEDA635; Thu, 08 May 2014 01:32:46 +0000 Message-ID: <536ADEBD.1080909@ubuntu.com> Date: Wed, 07 May 2014 21:32:45 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> In-Reply-To: <20140507224913.GP2925@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 01:33:15 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/07/2014 06:49 PM, Brian C. Lane wrote: > NAK. These make a pile of the tests fail: > > ========================================== GNU parted 3.1: > tests/test-suite.log ========================================== # > TOTAL: 77 # PASS: 27 # SKIP: 35 # XFAIL: 0 # FAIL: 15 # XPASS: > 0 # ERROR: 0 .. contents:: :depth: 2 > > looks like at least one core dump in the mix. Something weird is going on.. as I mentioned before, I get that odd gnulib error after the first 3 sector size passes in a make check that seems to be a bug in the build scripts, but the first three all pass: ============================================================================ Testsuite summary for GNU parted 3.1.98-c457 ============================================================================ # TOTAL: 77 # PASS: 63 # SKIP: 13 # XFAIL: 1 # FAIL: 0 # XPASS: 0 # ERROR: 0 make[1]: Leaving directory `/home/psusi/parted' GEN public-submodule-commit Stopping at 'gnulib'; script returned non-zero status. maint.mk: found non-public submodule commit make: *** [public-submodule-commit] Error 1 And then I manually run make check-recursive to get the 512 byte sector size: ============================================================================ Testsuite summary for GNU parted 3.1.98-c457 ============================================================================ # TOTAL: 77 # PASS: 75 # SKIP: 1 # XFAIL: 1 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ Can you look into why/what fails on your system? I also notice yours says version 3.1 while mine is 3.1.98-c457. Did you check out 3.1 instead of master and then not run bootstrap/configure after applying the patches? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTat69AAoJEI5FoCIzSKrw+hQH/2WyE97Vu7FADHoOo9tIl3ht bzkj2v9j9B/y0LM1dbfhUsNfOjVHFAgIpV6fVjBTS/xVFruvbGSo11WjcFsXnAGr 8PU6FW53+Sx+ELaREoJ5iLEgR37Q9cM4pbR1sGjFzAfy5yRtrGXKjee3KuEced1q N6FrbLgV2ARdTV+BHbMMy8rtjPPU1KqC/j43NlQ6jEJm19tOT08cXDReLpofzjMf 6mErkN3in9u4n5QW5M+3We2/qeA2wMV8IzKb4Xoe1/S+yXCtCJf1YYOHGyWGH3rL 6Uf5JNHY0CdEpRpfSU37lC1g0yOWTZnhXOJmpAwfCVf7fSRkp501fmHlHB5UxlU= =vd3Z -----END PGP SIGNATURE----- From MAILER-DAEMON Thu May 08 11:23:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WiQAH-000283-IF for mharc-bug-parted@gnu.org; Thu, 08 May 2014 11:23:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiQA9-0001yc-By for bug-parted@gnu.org; Thu, 08 May 2014 11:23:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiQA3-0005ok-3G for bug-parted@gnu.org; Thu, 08 May 2014 11:23:09 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:38754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiQA3-0005og-0e for bug-parted@gnu.org; Thu, 08 May 2014 11:23:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WiQA2-0007Ei-Gn for bug-parted@gnu.org; Thu, 08 May 2014 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 08 May 2014 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.139956255027768 (code B ref 16231); Thu, 08 May 2014 15:23:02 +0000 Received: (at 16231) by debbugs.gnu.org; 8 May 2014 15:22:30 +0000 Received: from localhost ([127.0.0.1]:56105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiQ9V-0007Dn-Nu for submit@debbugs.gnu.org; Thu, 08 May 2014 11:22:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58712) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WiQ9S-0007DZ-BN for 16231@debbugs.gnu.org; Thu, 08 May 2014 11:22:27 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s48FMOda021866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 May 2014 11:22:25 -0400 Received: from lister.brianlane.com (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s48FMNmw003440 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 8 May 2014 11:22:24 -0400 Date: Thu, 8 May 2014 08:22:22 -0700 From: "Brian C. Lane" Message-ID: <20140508152222.GQ2925@lister.brianlane.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536ADEBD.1080909@ubuntu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 15:23:15 -0000 On Wed, May 07, 2014 at 09:32:45PM -0400, Phillip Susi wrote: > On 05/07/2014 06:49 PM, Brian C. Lane wrote: > > NAK. These make a pile of the tests fail: > > > > ========================================== GNU parted 3.1: > > tests/test-suite.log ========================================== # > > TOTAL: 77 # PASS: 27 # SKIP: 35 # XFAIL: 0 # FAIL: 15 # XPASS: > > 0 # ERROR: 0 .. contents:: :depth: 2 > > > > looks like at least one core dump in the mix. > > Something weird is going on.. as I mentioned before, I get that odd > gnulib error after the first 3 sector size passes in a make check that > seems to be a bug in the build scripts, but the first three all pass: > > ============================================================================ > Testsuite summary for GNU parted 3.1.98-c457 > ============================================================================ > # TOTAL: 77 > # PASS: 63 > # SKIP: 13 > # XFAIL: 1 > # FAIL: 0 > # XPASS: 0 > # ERROR: 0 > > make[1]: Leaving directory `/home/psusi/parted' > GEN public-submodule-commit > Stopping at 'gnulib'; script returned non-zero status. > maint.mk: found non-public submodule commit > make: *** [public-submodule-commit] Error 1 > > And then I manually run make check-recursive to get the 512 byte > sector size: > > ============================================================================ > Testsuite summary for GNU parted 3.1.98-c457 > ============================================================================ > # TOTAL: 77 > # PASS: 75 > # SKIP: 1 > # XFAIL: 1 > # FAIL: 0 > # XPASS: 0 > # ERROR: 0 > ============================================================================ > > Can you look into why/what fails on your system? I also notice yours > says version 3.1 while mine is 3.1.98-c457. Did you check out 3.1 > instead of master and then not run bootstrap/configure after applying > the patches? That's weird (and troubling that the tests wouldn't fail the same). I applied them to my fedora-21 branch and ran them via a mockbuild as a first level test. My branch is only different from master by those few test fixup patches that I sent a few weeks ago. I'll take a deeper look at it when I get a chance, maybe not until Monday. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From MAILER-DAEMON Sat May 10 07:56:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Wj5t4-0002vW-EK for mharc-bug-parted@gnu.org; Sat, 10 May 2014 07:56:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirvj-00064z-KF for bug-parted@gnu.org; Fri, 09 May 2014 17:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wirvf-00056R-0I for bug-parted@gnu.org; Fri, 09 May 2014 17:02:07 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:39999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirve-00056N-U5 for bug-parted@gnu.org; Fri, 09 May 2014 17:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wirve-0005Rv-G6 for bug-parted@gnu.org; Fri, 09 May 2014 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17452: BUG: ./configure --prefix=/usr/local --disable-device-mapper Resent-From: "ferjulian, bruce" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Fri, 09 May 2014 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17452 X-GNU-PR-Package: parted X-GNU-PR-Keywords: To: 17452@debbugs.gnu.org X-Debbugs-Original-To: "bug-parted@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.139966931620934 (code B ref -1); Fri, 09 May 2014 21:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 May 2014 21:01:56 +0000 Received: from localhost ([127.0.0.1]:57350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WirvX-0005RX-Br for submit@debbugs.gnu.org; Fri, 09 May 2014 17:01:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59971) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wirrz-0005KE-3F for submit@debbugs.gnu.org; Fri, 09 May 2014 16:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wirrp-0003l1-2w for submit@debbugs.gnu.org; Fri, 09 May 2014 16:58:09 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:44289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirro-0003kx-Rq for submit@debbugs.gnu.org; Fri, 09 May 2014 16:58:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirrk-0004YN-HM for bug-parted@gnu.org; Fri, 09 May 2014 16:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wirrg-0003k3-7e for bug-parted@gnu.org; Fri, 09 May 2014 16:58:00 -0400 Received: from mailuogwhop.emc.com ([168.159.213.141]:38059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirrf-0003jn-VM for bug-parted@gnu.org; Fri, 09 May 2014 16:57:56 -0400 Received: from maildlpprd01.lss.emc.com (maildlpprd01.lss.emc.com [10.253.24.33]) by mailuogwprd04.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s49Kvros026637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 9 May 2014 16:57:54 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com s49Kvros026637 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1399669074; bh=yJ7JBMTGiID4kS3vxvumh1tGdMU=; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; b=QY2jUE70O5UDWnyn/wUPL6AcDTJF1kddajuX6aeT6GkTkM4TRlT1tdqm4Wg6IBfum pDl2izRpw1rA4F0mgQP24hZ4Md0aONJlsVZe9NVSWeRkSIAJx8yqfaNB1dsqMN95ou 4xhFv5g4oBKXN08sqlW3Iias7uL6JE9b5aiKfDQ4= X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com s49Kvros026637 Received: from mailusrhubprd53.lss.emc.com (mailusrhubprd53.lss.emc.com [10.106.48.18]) by maildlpprd01.lss.emc.com (RSA Interceptor) for ; Fri, 9 May 2014 16:57:47 -0400 Received: from mxhub18.corp.emc.com (mxhub18.corp.emc.com [10.254.93.47]) by mailusrhubprd53.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s49KvkJc000794 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Fri, 9 May 2014 16:57:47 -0400 Received: from mx40a.corp.emc.com ([169.254.1.174]) by mxhub18.corp.emc.com ([10.254.93.47]) with mapi; Fri, 9 May 2014 16:57:46 -0400 From: "ferjulian, bruce" Date: Fri, 9 May 2014 16:57:35 -0400 Thread-Topic: ./configure --prefix=/usr/local --disable-device-mapper Thread-Index: Ac9ryVQz3WtbOYILRHmCSc6zhbadrw== Message-ID: <1E43DA6E-0D58-46F5-96E1-1AD0B2916C01@emc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_1E43DA6E0D5846F596E11AD0B2916C01emccom_" MIME-Version: 1.0 X-Sentrion-Hostname: mailusrhubprd53.lss.emc.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Fri, 09 May 2014 17:01:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sat, 10 May 2014 07:56:17 -0400 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 21:02:12 -0000 --_000_1E43DA6E0D5846F596E11AD0B2916C01emccom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable checking linux/ext2_fs.h usability... no checking linux/ext2_fs.h presence... yes configure: WARNING: linux/ext2_fs.h: present but cannot be compiled configure: WARNING: linux/ext2_fs.h: check for missing prerequisite hea= ders? configure: WARNING: linux/ext2_fs.h: see the Autoconf documentation configure: WARNING: linux/ext2_fs.h: section "Present But Cannot Be Com= piled" configure: WARNING: linux/ext2_fs.h: proceeding with the compiler's result configure: WARNING: ## --------------------------------- ## configure: WARNING: ## Report this to bug-parted@gnu.org ## configure: WARNING: ## --------------------------------- ## checking for linux/ext2_fs.h... no checking linux/unistd.h usability... yes # uname -a Linux lhmc7073 3.0.76-0.11-default #1 SMP Fri Jun 14 08:21:43 UTC 2013 (cca= b990) x86_64 GNU/Linux # cat /etc/S*ease* SUSE Linux Enterprise Server 11 (x86_64) VERSION =3D 11 PATCHLEVEL =3D 3 ............................... Bruce Ferjulian EMC Corporation Bldg 176, 1/B-2 Hopkinton, MA 01748 Ext: ------4-4473 Tel: 508-249-4473 Cel: 978-771-4338 --_000_1E43DA6E0D5846F596E11AD0B2916C01emccom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
checking linux/ext2_f= s.h usability... no
checking linux/ext2_fs.h presence... yes
configure: WARNING: linux/ext2_fs.h: present but cannot be compiled
configure: WARNING: linux/ext2_fs.h:     check for missi= ng prerequisite headers?
configure: WARNING: linux/ext2_fs.h: see= the Autoconf documentation
configure: WARNING: linux/ext2_fs.h: =     section "Present But Cannot Be Compiled"
configure:= WARNING: linux/ext2_fs.h: proceeding with the compiler's result
= configure: WARNING:     ## --------------------------------- ##
configure: WARNING:     ## Report this to bug-parted@gnu.org ##
configure: WARN= ING:     ## --------------------------------- ##
checki= ng for linux/ext2_fs.h... no
checking linux/unistd.h usability...= yes

# uname -a
Linux lhmc7073 3.0.= 76-0.11-default #1 SMP Fri Jun 14 08:21:43 UTC 2013 (ccab990) x86_64 GNU/Li= nux

# cat /etc/S*ease*
SUSE Linux Enterp= rise Server 11 (x86_64)
VERSION =3D 11
PATCHLEVEL =3D 3=



...............................

Bru= ce Ferjulian
EMC Corporation
Bldg 176, 1/B-2
Hopkinton, MA 01748Ext: ------4-4473
Tel: 508-249-4473
Cel: 978-771-4338

= --_000_1E43DA6E0D5846F596E11AD0B2916C01emccom_-- From MAILER-DAEMON Mon May 19 09:42:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WmNpa-0005VV-BC for mharc-bug-parted@gnu.org; Mon, 19 May 2014 09:42:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmNpS-0005Ly-4a for bug-parted@gnu.org; Mon, 19 May 2014 09:42:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmNpL-0004bf-1J for bug-parted@gnu.org; Mon, 19 May 2014 09:42:09 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:54069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmNpK-0004bW-V3 for bug-parted@gnu.org; Mon, 19 May 2014 09:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WmNpK-0002GP-CE for bug-parted@gnu.org; Mon, 19 May 2014 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 19 May 2014 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: "Brian C. Lane" Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.14005068978671 (code B ref 16231); Mon, 19 May 2014 13:42:02 +0000 Received: (at 16231) by debbugs.gnu.org; 19 May 2014 13:41:37 +0000 Received: from localhost ([127.0.0.1]:52946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmNor-0002Fi-BF for submit@debbugs.gnu.org; Mon, 19 May 2014 09:41:37 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.231]:56770 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmNok-0002FN-P8 for 16231@debbugs.gnu.org; Mon, 19 May 2014 09:41:30 -0400 Received: from [67.78.168.186] ([67.78.168.186:61050] helo=[10.1.1.200]) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 73/14-11188-FF90A735; Mon, 19 May 2014 13:41:21 +0000 Message-ID: <537A09FE.5070900@ubuntu.com> Date: Mon, 19 May 2014 09:41:18 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> <20140508152222.GQ2925@lister.brianlane.com> In-Reply-To: <20140508152222.GQ2925@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 May 2014 13:42:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 5/8/2014 11:22 AM, Brian C. Lane wrote: >> Can you look into why/what fails on your system? I also notice >> yours says version 3.1 while mine is 3.1.98-c457. Did you check >> out 3.1 instead of master and then not run bootstrap/configure >> after applying the patches? > > That's weird (and troubling that the tests wouldn't fail the same). > I applied them to my fedora-21 branch and ran them via a mockbuild > as a first level test. My branch is only different from master by > those few test fixup patches that I sent a few weeks ago. > > I'll take a deeper look at it when I get a chance, maybe not until > Monday. Had a chance to look into this at all yet? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTegn+AAoJEI5FoCIzSKrwKYUH/1T9I2hJt37187MRVIj0iLKN Z+apMhVlcu6kgW6DmO2tpJQzWZg9iBW4aBSWqU8DSEq6yi2lMgPix93qCz8rFbpr gt8nU54EVzdA+9OajqziVxhnNLfdoCrIMlyIF8XmI94wa0U2ejpgaA2vaYBk5GYJ Xrgn8c9Pk2Q7bwHT53Iw0AffFiun3afuPujK842SkWNAkfx1QBB2iCu0bgYIRDML 9QTEucgz+B+fEdoeGe8KmzMt7E8EluiWzhLDfCjjqLOO3ZZcqW5RVGl1p4DlKqGU gnfTSBhTH0aF++V/GRLmr74dlYPJ00PYtxkgYQSepFsVyVHRQHTur9VLV8qvaKs= =9fY1 -----END PGP SIGNATURE----- From MAILER-DAEMON Wed May 21 20:43:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WnH6K-0004Bc-44 for mharc-bug-parted@gnu.org; Wed, 21 May 2014 20:43:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnH6C-0004BD-Kc for bug-parted@gnu.org; Wed, 21 May 2014 20:43:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnH66-0002x4-Fc for bug-parted@gnu.org; Wed, 21 May 2014 20:43:08 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:56823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnH66-0002wv-C8 for bug-parted@gnu.org; Wed, 21 May 2014 20:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WnH65-0001Yu-Vj for bug-parted@gnu.org; Wed, 21 May 2014 20:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 22 May 2014 00:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.14007193605969 (code B ref 16231); Thu, 22 May 2014 00:43:01 +0000 Received: (at 16231) by debbugs.gnu.org; 22 May 2014 00:42:40 +0000 Received: from localhost ([127.0.0.1]:55700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnH5j-0001YC-Kb for submit@debbugs.gnu.org; Wed, 21 May 2014 20:42:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60570) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnH5e-0001Xx-9K for 16231@debbugs.gnu.org; Wed, 21 May 2014 20:42:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4M0gWFL025005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 May 2014 20:42:32 -0400 Received: from lister.brianlane.com (ovpn-113-104.phx2.redhat.com [10.3.113.104]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4M0gUtE031705 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 21 May 2014 20:42:31 -0400 Date: Wed, 21 May 2014 17:42:30 -0700 From: "Brian C. Lane" Message-ID: <20140522004230.GR3330@lister.brianlane.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> <20140508152222.GQ2925@lister.brianlane.com> <537A09FE.5070900@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537A09FE.5070900@ubuntu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 00:43:15 -0000 On Mon, May 19, 2014 at 09:41:18AM -0400, Phillip Susi wrote: > On 5/8/2014 11:22 AM, Brian C. Lane wrote: > >> Can you look into why/what fails on your system? I also notice > >> yours says version 3.1 while mine is 3.1.98-c457. Did you check > >> out 3.1 instead of master and then not run bootstrap/configure > >> after applying the patches? > > > > That's weird (and troubling that the tests wouldn't fail the same). > > I applied them to my fedora-21 branch and ran them via a mockbuild > > as a first level test. My branch is only different from master by > > those few test fixup patches that I sent a few weeks ago. > > > > I'll take a deeper look at it when I get a chance, maybe not until > > Monday. > > Had a chance to look into this at all yet? > The problem is that the ntfs probe has a fixed 512b buffer and tries to read a whole sector into it. The fat probes may also have similar issues. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From MAILER-DAEMON Thu May 22 09:33:22 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WnT7a-00059k-Gz for mharc-bug-parted@gnu.org; Thu, 22 May 2014 09:33:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnT7S-00050J-4I for bug-parted@gnu.org; Thu, 22 May 2014 09:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnT7H-0005c2-P5 for bug-parted@gnu.org; Thu, 22 May 2014 09:33:14 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:57315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnT7H-0005bq-Mn for bug-parted@gnu.org; Thu, 22 May 2014 09:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WnT7G-0005EW-U7 for bug-parted@gnu.org; Thu, 22 May 2014 09:33:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 22 May 2014 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: "Brian C. Lane" Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.140076557320097 (code B ref 16231); Thu, 22 May 2014 13:33:02 +0000 Received: (at 16231) by debbugs.gnu.org; 22 May 2014 13:32:53 +0000 Received: from localhost ([127.0.0.1]:56192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnT72-0005Dy-9i for submit@debbugs.gnu.org; Thu, 22 May 2014 09:32:52 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:55517 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnT6u-0005Da-PI for 16231@debbugs.gnu.org; Thu, 22 May 2014 09:32:44 -0400 Received: from [67.78.168.186] ([67.78.168.186:57529] helo=[10.1.1.200]) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id A3/59-31957-27CFD735; Thu, 22 May 2014 13:32:34 +0000 Message-ID: <537DFC71.5080005@ubuntu.com> Date: Thu, 22 May 2014 09:32:33 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> <20140508152222.GQ2925@lister.brianlane.com> <537A09FE.5070900@ubuntu.com> <20140522004230.GR3330@lister.brianlane.com> In-Reply-To: <20140522004230.GR3330@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 13:33:20 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 5/21/2014 8:42 PM, Brian C. Lane wrote: > The problem is that the ntfs probe has a fixed 512b buffer and > tries to read a whole sector into it. The fat probes may also have > similar issues. You must be using an out of date tree; commit 80678bdd957cf4 fixed that: static PedGeometry* ntfs_probe (PedGeometry* geom) { - - char buf[512]; + char *buf = alloca (geom->dev->sector_size); + PedGeometry *newg = NULL; -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTffxxAAoJEI5FoCIzSKrwWlYH/0RnKFsvr98qEyggM65tck0C 6cWVk4v91Al5mVlu/kU9ey/6FMOj5but91oBeQHTl603tZYFE+rLWXVQ9PPBSb+h G2lGjTl6Rj4M9pjSPh59XvnLcM5Zgn9d5bP/3i4zUkkzNtgowufTpmXgFFNib58L nF++rhTxL2l+3XZb356HYiXCbRb+enf2PS4Jz2U1cKjj8s4tusI/3bzN2MZmxubH XtjNqiOnyaqOKXgz1VPQaMFe99cv07wQNkUiIO9EPIPwYbev2jr7lj/6fCfv6aIX wdI5h2xkj48qK7FRdMalIk+2Sd5PsAoScRoMSRoW6a8GlX7qeu4ONxTCTpn9BnU= =erE8 -----END PGP SIGNATURE----- From MAILER-DAEMON Thu May 22 15:02:16 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WnYFs-0003o7-1n for mharc-bug-parted@gnu.org; Thu, 22 May 2014 15:02:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnYFl-0003o1-7h for bug-parted@gnu.org; Thu, 22 May 2014 15:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnYFf-0005hu-3h for bug-parted@gnu.org; Thu, 22 May 2014 15:02:09 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:57992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnYFf-0005hp-0S for bug-parted@gnu.org; Thu, 22 May 2014 15:02:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WnYFe-0001TF-0d for bug-parted@gnu.org; Thu, 22 May 2014 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Thu, 22 May 2014 19:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Received: via spool by 16231-submit@debbugs.gnu.org id=B16231.14007853105625 (code B ref 16231); Thu, 22 May 2014 19:02:01 +0000 Received: (at 16231) by debbugs.gnu.org; 22 May 2014 19:01:50 +0000 Received: from localhost ([127.0.0.1]:56869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnYFR-0001Sf-Nz for submit@debbugs.gnu.org; Thu, 22 May 2014 15:01:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10785) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WnYFO-0001SR-5s for 16231@debbugs.gnu.org; Thu, 22 May 2014 15:01:47 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MJ1iCu018504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 May 2014 15:01:44 -0400 Received: from lister.brianlane.com (ovpn-113-104.phx2.redhat.com [10.3.113.104]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4MJ1gGo019092 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 22 May 2014 15:01:44 -0400 Date: Thu, 22 May 2014 12:01:42 -0700 From: "Brian C. Lane" Message-ID: <20140522190142.GS3330@lister.brianlane.com> References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> <20140508152222.GQ2925@lister.brianlane.com> <537A09FE.5070900@ubuntu.com> <20140522004230.GR3330@lister.brianlane.com> <537DFC71.5080005@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537DFC71.5080005@ubuntu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 19:02:15 -0000 On Thu, May 22, 2014 at 09:32:33AM -0400, Phillip Susi wrote: > On 5/21/2014 8:42 PM, Brian C. Lane wrote: > > The problem is that the ntfs probe has a fixed 512b buffer and > > tries to read a whole sector into it. The fat probes may also have > > similar issues. > > You must be using an out of date tree; commit 80678bdd957cf4 fixed that: > > static PedGeometry* > ntfs_probe (PedGeometry* geom) > { > - char buf[512]; > + char *buf = alloca (geom->dev->sector_size); > + PedGeometry *newg = NULL; > Sure enough, I was missing that one. Looks good, and passes all tests on all arches. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From MAILER-DAEMON Thu May 22 20:05:17 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Wncz7-0004Im-B1 for mharc-bug-parted@gnu.org; Thu, 22 May 2014 20:05:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wncz0-0004Ha-6G for bug-parted@gnu.org; Thu, 22 May 2014 20:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wncyu-0002ZQ-2w for bug-parted@gnu.org; Thu, 22 May 2014 20:05:10 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:58157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wncyu-0002Z1-00 for bug-parted@gnu.org; Thu, 22 May 2014 20:05:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wncyt-00037f-Cc for bug-parted@gnu.org; Thu, 22 May 2014 20:05:03 -0400 Subject: bug#16370: [PATCH] parted: don't reload partition table on every command Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-To: bug-parted@gnu.org Resent-Date: Fri, 23 May 2014 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16370 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 16370-done@debbugs.gnu.org Mail-Followup-To: 16370@debbugs.gnu.org, psusi@ubuntu.com, psusi@ubuntu.com Received: via spool by 16370-done@debbugs.gnu.org id=D16370.140080350011987 (code D ref 16370); Fri, 23 May 2014 00:05:02 +0000 Received: (at 16370-done) by debbugs.gnu.org; 23 May 2014 00:05:00 +0000 Received: from localhost ([127.0.0.1]:57032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wncyq-00037H-4o for submit@debbugs.gnu.org; Thu, 22 May 2014 20:05:00 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:12526 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wncym-000370-SP for 16370-done@debbugs.gnu.org; Thu, 22 May 2014 20:04:57 -0400 Received: from [72.238.67.160] ([72.238.67.160:39849] helo=[192.168.1.117]) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id A1/F3-31957-2A09E735; Fri, 23 May 2014 00:04:51 +0000 Message-ID: <537E90A2.5000800@ubuntu.com> Date: Thu, 22 May 2014 20:04:50 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140417221307.GW10077@lister.brianlane.com> <1397861706-15501-1-git-send-email-psusi@ubuntu.com> <53644AA0.8030806@ubuntu.com> <20140505233232.GB2925@lister.brianlane.com> In-Reply-To: <20140505233232.GB2925@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 May 2014 00:05:16 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/05/2014 07:32 PM, Brian C. Lane wrote: >> Just noticed I didn't Cc you on this, was that an ack on this one >> with the fixed test? > > Yes. Also, I'm on the lists so no need for explicit cc's Patch pushed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTfpCiAAoJEI5FoCIzSKrwTiEH+wd3HVtjF14jTTBEZzqDnSRo 278Z47xMA5/vi4IQ/gAJZBZVxYha6YcV6AOZdJliPZDoXbZZ7BkAPdMbkB4dfVLg z6QiF/N2XlgsnC/HDoTOUTQjoKTvh4ly7HcnO5Y2PbGitiTm7gWSt27y3fZio5l7 7VTQjpjQg3ro3RvUK4AfLafT1wZ+xlzNa7y6ziyW3SCefvCyjyD4mKr2W9IDtFoU E9UHb3x60Ad74BHhOu/clcKhmfK6OeBSlpBlvVryFvhmhQLurvAetQRy+3duxh0v Rh+8LBdPPVk/wibR1RmZKpcB9Z1dLX03Db/t1vM70zz4b2In4L00OvLKRq1BMww= =e8GH -----END PGP SIGNATURE----- From MAILER-DAEMON Thu May 22 20:07:18 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Wnd14-0004Td-BI for mharc-bug-parted@gnu.org; Thu, 22 May 2014 20:07:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wnd0w-0004TO-JG for bug-parted@gnu.org; Thu, 22 May 2014 20:07:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wnd0o-0003D3-UH for bug-parted@gnu.org; Thu, 22 May 2014 20:07:10 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:58164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wnd0o-0003Cz-Qs for bug-parted@gnu.org; Thu, 22 May 2014 20:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wnd0o-0003B9-Hg for bug-parted@gnu.org; Thu, 22 May 2014 20:07:02 -0400 Subject: bug#16231: [PATCH 0/9] Refactored loop fixes Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-To: bug-parted@gnu.org Resent-Date: Fri, 23 May 2014 00:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16231 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch Mail-Followup-To: 16231@debbugs.gnu.org, psusi@ubuntu.com, psusi@ubuntu.com Received: via spool by 16231-done@debbugs.gnu.org id=D16231.140080358612173 (code D ref 16231); Fri, 23 May 2014 00:07:02 +0000 Received: (at 16231-done) by debbugs.gnu.org; 23 May 2014 00:06:26 +0000 Received: from localhost ([127.0.0.1]:57039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnd0D-0003AG-Mh for submit@debbugs.gnu.org; Thu, 22 May 2014 20:06:25 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:39258 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wnd0B-0003A6-CI for 16231-done@debbugs.gnu.org; Thu, 22 May 2014 20:06:24 -0400 Received: from [72.238.67.160] ([72.238.67.160:39850] helo=[192.168.1.117]) by cdptpa-oedge03 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id E7/00-04269-CF09E735; Fri, 23 May 2014 00:06:22 +0000 Message-ID: <537E90FC.3020308@ubuntu.com> Date: Thu, 22 May 2014 20:06:20 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 References: <20140417221401.GX10077@lister.brianlane.com> <1399081851-3558-1-git-send-email-psusi@ubuntu.com> <20140507224913.GP2925@lister.brianlane.com> <536ADEBD.1080909@ubuntu.com> <20140508152222.GQ2925@lister.brianlane.com> <537A09FE.5070900@ubuntu.com> <20140522004230.GR3330@lister.brianlane.com> <537DFC71.5080005@ubuntu.com> <20140522190142.GS3330@lister.brianlane.com> In-Reply-To: <20140522190142.GS3330@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 Cc: 16231-done@debbugs.gnu.org X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 May 2014 00:07:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/22/2014 03:01 PM, Brian C. Lane wrote: > Sure enough, I was missing that one. Looks good, and passes all > tests on all arches. Patches pushed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTfpD8AAoJEI5FoCIzSKrwyYcH/A8ofwpaDKB+9sL4h/eV+Ako lNBT4qRMwS3DecOkUrhvr9xbs+qYQztqHPkyAeB/6jdbGpNZY1TgarqmOu42zU8d nq0cHZFFfnbRm7yL7Sr3aw4rl/dtFMPiCqU6TjsGEFLOWg0nIapoHUhVhLGCpTCY b5ShqxdRaTrMjj00BvyKDwPwGdsMfEXkwMfcKx8W/eG2VJnOOXHBOZVV8edJF7Ew T+LSbzMxqlRt7GCcgrZTl5Ooya5jRfp6bsqKS3ihYwfLzp9w9TMw6ozxNZEkffgV 79PVmHJMUeXKeKvwGHjhhKFUSim4oAy/HYDgO4/I12++eRJZjEe7O7k5DruPbTU= =cN6b -----END PGP SIGNATURE----- From MAILER-DAEMON Sun May 25 23:24:04 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WolW8-0006mp-Qa for mharc-bug-parted@gnu.org; Sun, 25 May 2014 23:24:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WolW7-0006mS-3C for bug-parted@gnu.org; Sun, 25 May 2014 23:24:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WolW6-0001bt-Ak for bug-parted@gnu.org; Sun, 25 May 2014 23:24:03 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:32995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WolW6-0001bo-85 for bug-parted@gnu.org; Sun, 25 May 2014 23:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WolW6-0006Ia-0i for bug-parted@gnu.org; Sun, 25 May 2014 23:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17593: [PATCH] tests: avoid false-positive failure due to symlink Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 26 May 2014 03:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17593 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 17593@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140107462224174 (code B ref -1); Mon, 26 May 2014 03:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 03:23:42 +0000 Received: from localhost ([127.0.0.1]:60105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WolVl-0006Hp-Fh for submit@debbugs.gnu.org; Sun, 25 May 2014 23:23:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41875) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WolVi-0006HN-Q4 for submit@debbugs.gnu.org; Sun, 25 May 2014 23:23:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WolVd-0001a2-1a for submit@debbugs.gnu.org; Sun, 25 May 2014 23:23:33 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:33047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WolVc-0001Zy-VB for submit@debbugs.gnu.org; Sun, 25 May 2014 23:23:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WolVc-0006m8-8n for bug-parted@gnu.org; Sun, 25 May 2014 23:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WolVb-0001Zj-DO for bug-parted@gnu.org; Sun, 25 May 2014 23:23:32 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:37292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WolVb-0001ZY-6p for bug-parted@gnu.org; Sun, 25 May 2014 23:23:31 -0400 Received: by mail-we0-f174.google.com with SMTP id k48so7303396wev.5 for ; Sun, 25 May 2014 20:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=f0F22f2rgE1+7sZxBecydtAvGNFd2RyNx0FvkmNDMog=; b=Zml/XaJg00x23RceNHNv+1Lo1Z48FFrGUBcBaRlA7XBLTAZFGE+VY5C7QMVzPZC2Mo QNub5TmnD5Qe4E3nIRNuTyX+1Z7uxp0Amy+MAOmOiJ5GyNO0UP6svidk6Amhx29Xg+WB 12TCr65xgbRe7onh2SjhuKIRmPak00Qw6eTMZzqmBGYgOFZ51zLI/ccZdgYAP4iBZr6W 566oQ/i7oj+KvOGhzAlYpmqj7CDl48dIRv/K0MQZfZs8nMVWe2ToT02sn0LSdJRHBUsG 39drJw48PgtJsS4tXuuWvyQ6wz4CJM68KjYpOlZfhMqYfrTpvwERE09GwwPXvS8yajBT 4gpA== X-Received: by 10.194.190.42 with SMTP id gn10mr25886198wjc.9.1401074610419; Sun, 25 May 2014 20:23:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Sun, 25 May 2014 20:23:10 -0700 (PDT) From: Jim Meyering Date: Sun, 25 May 2014 20:23:10 -0700 X-Google-Sender-Auth: iOwbzbCX-I6L4ll8oyI3QQhHIno Message-ID: Content-Type: multipart/mixed; boundary=047d7bb70882755c8a04fa451aef X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 03:24:03 -0000 --047d7bb70882755c8a04fa451aef Content-Type: text/plain; charset=ISO-8859-1 Without this patch, I would see a spurious failure in this test: --047d7bb70882755c8a04fa451aef Content-Type: application/octet-stream; name="0001-tests-avoid-false-positive-failure-due-to-symlink.patch" Content-Disposition: attachment; filename="0001-tests-avoid-false-positive-failure-due-to-symlink.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvn7mp5l0 RnJvbSA0YzMyYzU3NzYxOTBjOTQwM2YyZWU5NGFmOTBkZmIzOTZiODk0ODljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCAyNSBNYXkgMjAxNCAxNjo1MjowNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHRlc3RzOiBh dm9pZCBmYWxzZS1wb3NpdGl2ZSBmYWlsdXJlIGR1ZSB0byBzeW1saW5rCgoqIHRlc3RzL3Q2MDAw LWRtLnNoIChzYW5pdGl6ZSk6IEhlbHBlciBmdW5jdGlvbi4KQmVmb3JlIHRoaXMgY2hhbmdlLCB0 aGlzIHRlc3Qgd291bGQgZmFpbCBkdWUgdG8gZGlmZmVyZW5jZSBiZXR3ZWVuCmFic29sdXRlIG5h bWUgYW5kIHN5bWxpbmstaW5jbHVkaW5nIG5hbWVzIGluICJwYXJ0ZWQgcHJpbnQiIG91dHB1dAot LS0KIHRlc3RzL3Q2MDAwLWRtLnNoIHwgMTAgKysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDgg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0cy90NjAwMC1k bS5zaCBiL3Rlc3RzL3Q2MDAwLWRtLnNoCmluZGV4IGMzMDFkZWUuLjU5NzA4NGIgMTAwNzU1Ci0t LSBhL3Rlc3RzL3Q2MDAwLWRtLnNoCisrKyBiL3Rlc3RzL3Q2MDAwLWRtLnNoCkBAIC00Nyw2ICs0 NywxMiBAQCBmMT0kKHB3ZCkvMTsgZDE9JChsb29wX3NldHVwXyAiJGYxIikgXAogZjI9JChwd2Qp LzIgJiYgZDI9JChsb29wX3NldHVwXyAiJGYyIikgfHwgZmFpbD0xCiBmMz0kKHB3ZCkvMyAmJiBk Mz0kKGxvb3Bfc2V0dXBfICIkZjMiKSB8fCBmYWlsPTEKIAorIyBJbiB0aGUgb3V0cHV0IG9mIHBh cnRlZCdzIHByaW50IC1zIGNvbW1hbmQsCisjIHJlcGxhY2UgKHBvc3NpYmx5IHZhcnlpbmcpICRk ZXYgbmFtZSB3aXRoICcuLi4nLgorc2FuaXRpemUoKSB7CisgIHNlZCAncyxeRGlzayAuKjogXChb MC05XVswLTldKlwpLERpc2sgLi4uOiBcMSw7cy8gKiQvLycgIiRAIgorfQorCiAjIFRoaXMgbG9v cCB1c2VkIHRvIGluY2x1ZGUgIm11bHRpcGF0aCIsIGJ1dCBsdm0yIGNoYW5nZWQKICMgaW4gc3Vj aCBhIHdheSB0aGF0IHRoYXQgbm8gbG9uZ2VyIHdvcmtzIHdpdGggbG9vcCBkZXZpY2VzLgogIyBG SVhNRTogdXNlIHR3byBzY3NpX2RlYnVnIGRldmljZXMgaW5zdGVhZC4KQEAgLTcyLDEyICs3OCwx MiBAQCBmb3IgdHlwZSBpbiBsaW5lYXIgOyBkbwogICBjb21wYXJlIC9kZXYvbnVsbCBvdXQgfHwg ZmFpbD0xCiAKICAgcGFydGVkIC1zICIkZGV2IiBwcmludCA+IG91dCAyPiYxIHx8IGZhaWw9MQot ICBzZWQgJ3MvICQvLycgb3V0ID4gayAmJiBtdiBrIG91dCB8fCBmYWlsPTEgIyBSZW1vdmUgdHJh aWxpbmcgYmxhbmsuCisgIHNhbml0aXplIG91dCA+IGsgJiYgbXYgayBvdXQgfHwgZmFpbD0xCiAK ICAgIyBDcmVhdGUgZXhwZWN0ZWQgb3V0cHV0IGZpbGUuCiAgIGNhdCA8PEVPRiA+PiBleHAgfHwg ZmFpbD0xCiBNb2RlbDogTGludXggZGV2aWNlLW1hcHBlciAoJHR5cGUpIChkbSkKLURpc2sgJGRl djogNTI0a0IKK0Rpc2sgLi4uOiA1MjRrQgogU2VjdG9yIHNpemUgKGxvZ2ljYWwvcGh5c2ljYWwp OiA1MTJCLzUxMkIKIFBhcnRpdGlvbiBUYWJsZTogbXNkb3MKIERpc2sgRmxhZ3M6Ci0tIAoxLjku MC5yYzMuOS5nZTI2NWYxZgoK --047d7bb70882755c8a04fa451aef-- From MAILER-DAEMON Sun May 25 23:33:04 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Woleq-000139-TU for mharc-bug-parted@gnu.org; Sun, 25 May 2014 23:33:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Woleq-000133-0Z for bug-parted@gnu.org; Sun, 25 May 2014 23:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wolep-0003yC-0j for bug-parted@gnu.org; Sun, 25 May 2014 23:33:03 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:33007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Woleo-0003y7-Tq for bug-parted@gnu.org; Sun, 25 May 2014 23:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Woleo-0006bK-EI for bug-parted@gnu.org; Sun, 25 May 2014 23:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17594: [PATCH] gnulib: update submodule to latest Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 26 May 2014 03:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17594 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 17594@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140107515625328 (code B ref -1); Mon, 26 May 2014 03:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 03:32:36 +0000 Received: from localhost ([127.0.0.1]:60117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoleO-0006aS-8k for submit@debbugs.gnu.org; Sun, 25 May 2014 23:32:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42614) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoleL-0006aC-T1 for submit@debbugs.gnu.org; Sun, 25 May 2014 23:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoleF-0003uQ-W6 for submit@debbugs.gnu.org; Sun, 25 May 2014 23:32:28 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:57467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoleF-0003uM-Sq for submit@debbugs.gnu.org; Sun, 25 May 2014 23:32:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoleF-00012S-03 for bug-parted@gnu.org; Sun, 25 May 2014 23:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoleE-0003u9-4x for bug-parted@gnu.org; Sun, 25 May 2014 23:32:26 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:58176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoleD-0003u4-TC for bug-parted@gnu.org; Sun, 25 May 2014 23:32:26 -0400 Received: by mail-wi0-f174.google.com with SMTP id r20so3516531wiv.7 for ; Sun, 25 May 2014 20:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=dQ5ArrvOba3FTLaXfjMiZrZ+AmpqNV+dILSRGkvFP2g=; b=IC7ZiZbEigWOjHML3f0JWYpxOOmrRkwTyTxS0d7VFLHTUFdAf7N0X9buK4sxZHgtKP I0yrt/a6MKG7SZ/iXwo765O6Ek8lbon1T0FElUgRJZhnpMFZPHJgvWhABZP+YKp3nt7c 1QscBhugCjNhJXl+SpCAWuIeIusanqv869LWb36uZGbidx7OE3kt0xe4xb7u8HwlhhdZ NddgGgDzkqRGmpyp0mKvLqztlPaGYEE1j81oE07JGfV43SU6YQldzbYe0nRWtHa9snGY oGCcj05/pUTKqaPprCtOv17d5wG7S4NxJswHsA+A+w4YEWgJyukaWriP9t05hpiWZIFb 7B7A== X-Received: by 10.180.36.212 with SMTP id s20mr23686374wij.18.1401075145047; Sun, 25 May 2014 20:32:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Sun, 25 May 2014 20:32:04 -0700 (PDT) From: Jim Meyering Date: Sun, 25 May 2014 20:32:04 -0700 X-Google-Sender-Auth: mPUxgn2PFQF_pZAIRtLPOcpf37s Message-ID: Content-Type: multipart/mixed; boundary=e89a8f6473c553929704fa453ae1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 03:33:04 -0000 --e89a8f6473c553929704fa453ae1 Content-Type: text/plain; charset=ISO-8859-1 FYI, I've just applied this: --e89a8f6473c553929704fa453ae1 Content-Type: application/octet-stream; name="0001-gnulib-update-submodule-to-latest.patch" Content-Disposition: attachment; filename="0001-gnulib-update-submodule-to-latest.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvn7y1gs0 RnJvbSBhMTlkZmRlNjU4YTM3MDRhMzNhOGE4MjlhMGQ3OTc2ZmEwZGMwNWQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCAyNSBNYXkgMjAxNCAxNToyODo1NiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGdudWxpYjog dXBkYXRlIHN1Ym1vZHVsZSB0byBsYXRlc3QKCiogZ251bGliOiBVcGRhdGUgbW9kdWxlIHRvIGxh dGVzdC4KKiBib290c3RyYXA6IFVwZGF0ZSBmcm9tIGdudWxpYi4KLS0tCiBib290c3RyYXAgfCAx MiArKysrKysrKysrLS0KIGdudWxpYiAgICB8ICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDExIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYm9vdHN0cmFwIGIvYm9v dHN0cmFwCmluZGV4IGUzMWQxN2QuLmNlOTBiYzQgMTAwNzU1Ci0tLSBhL2Jvb3RzdHJhcAorKysg Yi9ib290c3RyYXAKQEAgLTEsMTAgKzEsMTAgQEAKICMhIC9iaW4vc2gKICMgUHJpbnQgYSB2ZXJz aW9uIHN0cmluZy4KLXNjcmlwdHZlcnNpb249MjAxMy0wOC0xNS4yMjsgIyBVVEMKK3NjcmlwdHZl cnNpb249MjAxMy0xMi0wNS4yMzsgIyBVVEMKIAogIyBCb290c3RyYXAgdGhpcyBwYWNrYWdlIGZy b20gY2hlY2tlZC1vdXQgc291cmNlcy4KIAotIyBDb3B5cmlnaHQgKEMpIDIwMDMtMjAxMyBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKyMgQ29weXJpZ2h0IChDKSAyMDAzLTIwMTQgRnJl ZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAKICMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29m dHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKICMgaXQgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkKQEAgLTU1MSw2ICs1NTEsMTQgQEAgaWYgISBwcmludGYgIiRidWlsZHJlcSIgfCBjaGVja192 ZXJzaW9uczsgdGhlbgogICBmaQogZmkKIAorIyBXYXJuIHRoZSB1c2VyIGlmIGF1dG9tNHRlIGFw cGVhcnMgdG8gYmUgYnJva2VuOyB0aGlzIGNhdXNlcyBrbm93bgorIyBpc3N1ZXMgd2l0aCBhdCBs ZWFzdCBnZXR0ZXh0IDAuMTguMy4KK3Byb2JlPSQoZWNobyAnbTRfcXVvdGUoW2hpXSknIHwgYXV0 b200dGUgLWwgTTRzdWdhciAtdCAnbTRfcXVvdGU6JCUnIC0pCitpZiB0ZXN0ICJ4JHByb2JlIiAh PSB4aGk7IHRoZW4KKyAgd2Fybl8gIldBUk5JTkc6IHlvdXIgYXV0b200dGUgd3JhcHBlciBlYXRz IHN0ZGluOyIKKyAgd2Fybl8gImlmIGJvb3RzdHJhcCBmYWlscywgY29uc2lkZXIgdXBncmFkaW5n IHlvdXIgYXV0b3Rvb2xzIgorZmkKKwogZWNobyAiJDA6IEJvb3RzdHJhcHBpbmcgZnJvbSBjaGVj a2VkLW91dCAkcGFja2FnZSBzb3VyY2VzLi4uIgogCiAjIFNlZSBpZiB3ZSBjYW4gdXNlIGdudWxp YidzIGdpdC1tZXJnZS1jaGFuZ2Vsb2cgbWVyZ2UgZHJpdmVyLgpkaWZmIC0tZ2l0IGEvZ251bGli IGIvZ251bGliCmluZGV4IDE2NGViZmUuLjk4Y2EyYzAgMTYwMDAwCi0tLSBhL2dudWxpYgorKysg Yi9nbnVsaWIKQEAgLTEgKzEgQEAKLVN1YnByb2plY3QgY29tbWl0IDE2NGViZmU2MTJkODQ2MGMx NWQ3YWNmMTkyN2ZhZWY2OTQzNTcxYjYKK1N1YnByb2plY3QgY29tbWl0IDk4Y2EyYzA2M2NmZTAx OWI2NzNmZDBjZTgxNDQ4YzkxOWU5Yzk4OWMKLS0gCjEuOS4wLnJjMy45LmdlMjY1ZjFmCgo= --e89a8f6473c553929704fa453ae1-- From MAILER-DAEMON Sun May 25 23:38:04 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Woljg-0002cj-Lj for mharc-bug-parted@gnu.org; Sun, 25 May 2014 23:38:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wolje-0002cY-PB for bug-parted@gnu.org; Sun, 25 May 2014 23:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wolje-0005IJ-5K for bug-parted@gnu.org; Sun, 25 May 2014 23:38:02 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:33012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wolje-0005IF-0p for bug-parted@gnu.org; Sun, 25 May 2014 23:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Woljd-0006lp-On for bug-parted@gnu.org; Sun, 25 May 2014 23:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17595: [PATCH] maint: remove doubled word: s/on on/on/ Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 26 May 2014 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17595 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 17595@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140107544625962 (code B ref -1); Mon, 26 May 2014 03:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 03:37:26 +0000 Received: from localhost ([127.0.0.1]:60122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wolj4-0006ke-0M for submit@debbugs.gnu.org; Sun, 25 May 2014 23:37:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42973) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wolj1-0006kK-Nu for submit@debbugs.gnu.org; Sun, 25 May 2014 23:37:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Woliw-0005DN-4u for submit@debbugs.gnu.org; Sun, 25 May 2014 23:37:18 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:39588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Woliw-0005DJ-1Q for submit@debbugs.gnu.org; Sun, 25 May 2014 23:37:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Woliv-0002b7-Bj for bug-parted@gnu.org; Sun, 25 May 2014 23:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Woliu-0005CG-NL for bug-parted@gnu.org; Sun, 25 May 2014 23:37:17 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:54276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Woliu-0005CA-Gh for bug-parted@gnu.org; Sun, 25 May 2014 23:37:16 -0400 Received: by mail-wi0-f176.google.com with SMTP id n15so3493632wiw.15 for ; Sun, 25 May 2014 20:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=IAaKySTjaSx1Q50KB6xFxDFCxuzUptb6PqYxmBQyzVU=; b=YE6QDTv2jAZqsuzE5NrgCT23ILtJHkN1RpFRPktf+sptrg3weXM5c/9F6ufPCkrwvr QB2ZK73n15ILL59G5Ar4vgC+cVHpJwAYVXbfHBnD5zww1JOzwLohnJoxdDOAKFdL1bXI lPIqP8GmI0luphGqMHDyHoburEwUWXgWoocNk/4qykePok+xoEeDEoCm4G0Vxnu5/VTt YMpxzM8iPF88mwTvAhrbmyyh/9Rpw6quWC55d0mbycdHPhIw9ZnIzJNlbDbCwPpchDUS Zl5JvN5l0h2fIeM4ke6eSoGeO6nfnANyKFCbHvJ+PSLcZmKIYr12hj1b6knFU7em165r YiGQ== X-Received: by 10.194.242.66 with SMTP id wo2mr25766529wjc.37.1401075435530; Sun, 25 May 2014 20:37:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Sun, 25 May 2014 20:36:54 -0700 (PDT) From: Jim Meyering Date: Sun, 25 May 2014 20:36:54 -0700 X-Google-Sender-Auth: P0MUVfkvhW9MEkwDrA5C3MkuYbY Message-ID: Content-Type: multipart/mixed; boundary=089e013d13baa3835804fa454bd3 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 03:38:03 -0000 --089e013d13baa3835804fa454bd3 Content-Type: text/plain; charset=ISO-8859-1 FYI: --089e013d13baa3835804fa454bd3 Content-Type: application/octet-stream; name="0001-maint-remove-doubled-word-s-on-on-on.patch" Content-Disposition: attachment; filename="0001-maint-remove-doubled-word-s-on-on-on.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvn84gb50 RnJvbSAyY2EwZGJlOTMzNjM5Mjk5MTg3NDczMDQxY2I3ZmM1ZGViMTdkMDk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCAyNSBNYXkgMjAxNCAyMDozNToyNyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIG1haW50OiBy ZW1vdmUgZG91YmxlZCB3b3JkOiBzL29uIG9uL29uLwoKKiBORVdTOiBSZW1vdmUgZG91YmxlZC13 b3JkIGRldGVjdGVkIGJ5ICJtYWtlIHN5bnRheC1jaGVjayIuCi0tLQogTkVXUyB8IDIgKy0KIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L05FV1MgYi9ORVdTCmluZGV4IDk4NmRhOGYuLjNkMjM3ZmEgMTAwNjQ0Ci0tLSBhL05FV1MKKysr IGIvTkVXUwpAQCAtNTIsNyArNTIsNyBAQCBHTlUgcGFydGVkIE5FV1MgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAtKi0gb3V0bGluZSAtKi0KCiAgIGxpYnBhcnRlZDogcHJldmlv dXNseSBpZiB5b3UgY2hvc2UgdG8gaWdub3JlIHRoZSB3YXJuaW5nIGFib3V0CiAgIHRoZSBncHQg dGhpbmtpbmcgdGhlIGRpc2sgd2FzIHNtYWxsZXIgdGhhbiBpdCBhcHBlYXJzIHRvIGJlIG9uCi0g IG9uIGRpc2ssIHN1YnNlcXVlbnQgd2FybmluZ3Mgb24gb3RoZXIgZGlza3Mgd291bGQgYmUgc3Vw cHJlc3NlZC4KKyAgZGlzaywgc3Vic2VxdWVudCB3YXJuaW5ncyBvbiBvdGhlciBkaXNrcyB3b3Vs ZCBiZSBzdXBwcmVzc2VkLgogICBOb3cgcGFydGVkIHdpbGwgd2FybiBvbmNlIHBlciBkaXNrLgoK ICAgRml4IGZpbGVzeXN0ZW0gZGV0ZWN0aW9uIG9uIG5vbiA1MTIgYnl0ZSBzZWN0b3Igc2l6ZXMK LS0gCjIuMC4wLnJjMwoK --089e013d13baa3835804fa454bd3-- From MAILER-DAEMON Mon May 26 00:32:05 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WomZx-0002rR-TP for mharc-bug-parted@gnu.org; Mon, 26 May 2014 00:32:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WomZv-0002rL-Gg for bug-parted@gnu.org; Mon, 26 May 2014 00:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WomZu-0003vg-Re for bug-parted@gnu.org; Mon, 26 May 2014 00:32:03 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:33029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WomZu-0003vc-O2 for bug-parted@gnu.org; Mon, 26 May 2014 00:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WomZu-000064-6f for bug-parted@gnu.org; Mon, 26 May 2014 00:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17596: [PATCH] maint: fix "make syntax-check" nits Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 26 May 2014 04:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17596 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 17596@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.140107866732748 (code B ref -1); Mon, 26 May 2014 04:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 04:31:07 +0000 Received: from localhost ([127.0.0.1]:60139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WomZ0-0008W6-7k for submit@debbugs.gnu.org; Mon, 26 May 2014 00:31:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49720) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WomYx-0008Va-14 for submit@debbugs.gnu.org; Mon, 26 May 2014 00:31:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WomYr-0003bD-1y for submit@debbugs.gnu.org; Mon, 26 May 2014 00:30:57 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:37135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WomYq-0003b8-Uh for submit@debbugs.gnu.org; Mon, 26 May 2014 00:30:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WomYq-0002nh-7I for bug-parted@gnu.org; Mon, 26 May 2014 00:30:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WomYp-0003ap-KL for bug-parted@gnu.org; Mon, 26 May 2014 00:30:56 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:60513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WomYp-0003al-9n for bug-parted@gnu.org; Mon, 26 May 2014 00:30:55 -0400 Received: by mail-we0-f172.google.com with SMTP id k48so7526388wev.31 for ; Sun, 25 May 2014 21:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=E+9s5waMNklb0HC6QnyFNJEVEOUMasanow75moYy7jE=; b=twZVrQLG8xgigOiWOl+jCNwXcr8XY3FB/pLRxwxarHMrVr2E9V1BfqO81LR0X76rsT w6FJR73yizuR2zyXUmqghqEcnqaxJZuoisqHoJYpFr6/fnbH9D3wgX5O62App4KiLQ8V uHoWUUVOHd7bBvGZhx13LQ3beoI3dhPjyKoaazTqWOV7YhqawyClgDxTGdIh8gSAW2qT kxDLf5N+zq8HfCzlBrKiOC0qwtndieqEMjdPYyJxyHjQmwoBG520dg4lRX0OQUmcoXUB gXg7xJvpz5O4DfbIqLmQXFGfD+23W4jbQkhy4RoyK3nHZ9ja9dYADhT5EMhF+QLZ7vcE QWIg== X-Received: by 10.180.36.212 with SMTP id s20mr24003384wij.18.1401078654292; Sun, 25 May 2014 21:30:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Sun, 25 May 2014 21:30:34 -0700 (PDT) From: Jim Meyering Date: Sun, 25 May 2014 21:30:34 -0700 X-Google-Sender-Auth: Pyy9NPPQ_YaQgN4VH6NBN17SBmk Message-ID: Content-Type: multipart/mixed; boundary=e89a8f6473c57e96be04fa460bd6 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 04:32:04 -0000 --e89a8f6473c57e96be04fa460bd6 Content-Type: text/plain; charset=ISO-8859-1 "make syntax-check" detected various minor problems. This patch fixes them. They're all trivial, but I will wait for an ACK. --e89a8f6473c57e96be04fa460bd6 Content-Type: application/octet-stream; name="0001-maint-fix-make-syntax-check-nits.patch" Content-Disposition: attachment; filename="0001-maint-fix-make-syntax-check-nits.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hvna17jg0 RnJvbSA2NzRiMTA0YzcwOGYzMzFlYThmNTkxYzIxNDQ0YjdhNmJkNjdiOTBmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCAyNSBNYXkgMjAxNCAyMToxNjo0NCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIG1haW50OiBm aXggIm1ha2Ugc3ludGF4LWNoZWNrIiBuaXRzCgoqIGRvYy9wYXJ0ZWQudGV4aTogVXBkYXRlIGNv cHlyaWdodCB5ZWFyIHRvIDIwMTQuCiogdGVzdHMvZ3B0LWhlYWRlci1tb3ZlLnB5OiBSZW1vdmUg ZW1wdHkgbGluZSBhdCBFT0YuCiogdGVzdHMvdDAyODEtZ3B0LWdyb3cuc2g6IENvcnJlY3QgcmV2 ZXJzZWQgYXJncyB0byBjb21wYXJlLgoqIHRlc3RzL3QwMjgyLWdwdC1tb3ZlLWJhY2t1cC5zaDog TGlrZXdpc2UuCiogbGlicGFydGVkL2xhYmVscy9ncHQuYyAoZ3B0X3BhcnRpdGlvbl9zZXRfbmFt ZSk6IENoYW5nZSAiQ2FuIG5vdCIKdG8gImZhaWxlZCB0byIgaW4gZGlhZ25vc3RpYy4KKGdwdF9w YXJ0aXRpb25fZ2V0X25hbWUpOiBMaWtld2lzZS4KKiB0ZXN0cy90MTEwMi1sb29wLWxhYmVsLnNo IChkZXYpOiBSZW1vdmUgdHJhaWxpbmcgc3BhY2UgaW4KaGVyZSBkb2N1bWVudCB0aGF0IGNyZWF0 ZXMgZXhwZWN0ZWQgb3V0cHV0LCBhbmQgc3RyaXAgdGhhdApzYW1lIHRyYWlsaW5nIHNwYWNlIGZy b20gYWN0dWFsIG91dHB1dC4KKiBsaWJwYXJ0ZWQvZnMvamZzL2pmcy5jOiBEbyBub3QgY2FzdCBh bGxvY2EgcmV0dXJuIHZhbHVlLgoqIGxpYnBhcnRlZC9mcy9yZWlzZXJmcy9yZWlzZXJmcy5jOiBM aWtld2lzZS4KKiBsaWJwYXJ0ZWQvZnMveGZzL3hmcy5jOiBMaWtld2lzZS4KLS0tCiBkb2MvcGFy dGVkLnRleGkgICAgICAgICAgICAgICAgICB8IDIgKy0KIGxpYnBhcnRlZC9mcy9qZnMvamZzLmMg ICAgICAgICAgIHwgMiArLQogbGlicGFydGVkL2ZzL3JlaXNlcmZzL3JlaXNlcmZzLmMgfCAzICst LQogbGlicGFydGVkL2ZzL3hmcy94ZnMuYyAgICAgICAgICAgfCAyICstCiBsaWJwYXJ0ZWQvbGFi ZWxzL2dwdC5jICAgICAgICAgICB8IDQgKystLQogdGVzdHMvZ3B0LWhlYWRlci1tb3ZlLnB5ICAg ICAgICAgfCAxIC0KIHRlc3RzL3QwMjgxLWdwdC1ncm93LnNoICAgICAgICAgIHwgMiArLQogdGVz dHMvdDAyODItZ3B0LW1vdmUtYmFja3VwLnNoICAgfCAyICstCiB0ZXN0cy90MTEwMi1sb29wLWxh YmVsLnNoICAgICAgICB8IDQgKystLQogOSBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp LCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvcGFydGVkLnRleGkgYi9kb2MvcGFy dGVkLnRleGkKaW5kZXggOTdjZTIwMy4uMmI2ZjdmOCAxMDA2NDQKLS0tIGEvZG9jL3BhcnRlZC50 ZXhpCisrKyBiL2RvYy9wYXJ0ZWQudGV4aQpAQCAtMTQsNyArMTQsNyBAQCBhbmQgbWFuaXB1bGF0 aW5nIHBhcnRpdGlvbiB0YWJsZXMuCiBAaWZub3R0ZXggQGMgdGV4aTJwZGYgZG9uJ3QgdW5kZXJz dGFuZCBjb3B5aW5nIGFuZCBpbnNlcnRjb3B5aW5nID8/PwogQGMgbW9kaWZpY2F0aW9ucyBtdXN0 IGFsc28gYmUgZG9uZSBpbiB0aGUgdGl0bGVwYWdlCiBAY29weWluZwotQ29weXJpZ2h0IEBjb3B5 cmlnaHR7fSAxOTk5LTIwMTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCitDb3B5cmln aHQgQGNvcHlyaWdodHt9IDE5OTktMjAxNCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4K CiBQZXJtaXNzaW9uIGlzIGdyYW50ZWQgdG8gY29weSwgZGlzdHJpYnV0ZSBhbmQvb3IgbW9kaWZ5 IHRoaXMgZG9jdW1lbnQKIHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEZyZWUgRG9jdW1lbnRh dGlvbiBMaWNlbnNlLCBWZXJzaW9uIDEuMyBvcgpkaWZmIC0tZ2l0IGEvbGlicGFydGVkL2ZzL2pm cy9qZnMuYyBiL2xpYnBhcnRlZC9mcy9qZnMvamZzLmMKaW5kZXggYzI3MTI4NS4uYmUyYjk0ZiAx MDA2NDQKLS0tIGEvbGlicGFydGVkL2ZzL2pmcy9qZnMuYworKysgYi9saWJwYXJ0ZWQvZnMvamZz L2pmcy5jCkBAIC0zNyw3ICszNyw3IEBACiBzdGF0aWMgUGVkR2VvbWV0cnkqCiBqZnNfcHJvYmUg KFBlZEdlb21ldHJ5KiBnZW9tKQogewotCXN0cnVjdCBzdXBlcmJsb2NrICpzYiA9IChzdHJ1Y3Qg c3VwZXJibG9jayAqKWFsbG9jYSAoZ2VvbS0+ZGV2LT5zZWN0b3Jfc2l6ZSk7CisJc3RydWN0IHN1 cGVyYmxvY2sgKnNiID0gYWxsb2NhIChnZW9tLT5kZXYtPnNlY3Rvcl9zaXplKTsKCiAJaWYgKGdl b20tPmxlbmd0aCAqIGdlb20tPmRldi0+c2VjdG9yX3NpemUgPCBKRlNfU1VQRVJfT0ZGU0VUKQog CQlyZXR1cm4gTlVMTDsKZGlmZiAtLWdpdCBhL2xpYnBhcnRlZC9mcy9yZWlzZXJmcy9yZWlzZXJm cy5jIGIvbGlicGFydGVkL2ZzL3JlaXNlcmZzL3JlaXNlcmZzLmMKaW5kZXggODM4YjJmYi4uMmZm M2M1MSAxMDA2NDQKLS0tIGEvbGlicGFydGVkL2ZzL3JlaXNlcmZzL3JlaXNlcmZzLmMKKysrIGIv bGlicGFydGVkL2ZzL3JlaXNlcmZzL3JlaXNlcmZzLmMKQEAgLTU3LDggKzU3LDcgQEAgc3RhdGlj IFBlZEdlb21ldHJ5ICpyZWlzZXJmc19wcm9iZShQZWRHZW9tZXRyeSAqZ2VvbSkKIAlpbnQgaTsK CiAJUEVEX0FTU0VSVChnZW9tICE9IE5VTEwpOwotCXJlaXNlcmZzX3N1cGVyX2Jsb2NrX3QgKnNi ID0KLQkJKHJlaXNlcmZzX3N1cGVyX2Jsb2NrX3QgKilhbGxvY2EgKGdlb20tPmRldi0+c2VjdG9y X3NpemUpOworCXJlaXNlcmZzX3N1cGVyX2Jsb2NrX3QgKnNiID0gYWxsb2NhIChnZW9tLT5kZXYt PnNlY3Rvcl9zaXplKTsKCiAJZm9yIChpID0gMDsgcmVpc2VyZnNfc3VwZXJfb2Zmc2V0W2ldICE9 IC0xOyBpKyspIHsKIAkJaWYgKHJlaXNlcmZzX3N1cGVyX29mZnNldFtpXSA+PSBnZW9tLT5sZW5n dGgpCmRpZmYgLS1naXQgYS9saWJwYXJ0ZWQvZnMveGZzL3hmcy5jIGIvbGlicGFydGVkL2ZzL3hm cy94ZnMuYwppbmRleCBkNDE0NGY4Li4yYTQ3YTRjIDEwMDY0NAotLS0gYS9saWJwYXJ0ZWQvZnMv eGZzL3hmcy5jCisrKyBiL2xpYnBhcnRlZC9mcy94ZnMveGZzLmMKQEAgLTM4LDcgKzM4LDcgQEAg eGZzX3Byb2JlIChQZWRHZW9tZXRyeSogZ2VvbSkKIHsKIAlQZWRTZWN0b3IJYmxvY2tfc2l6ZTsK IAlQZWRTZWN0b3IJYmxvY2tfY291bnQ7Ci0Jc3RydWN0IHhmc19zYgkqc2IgPSAoc3RydWN0IHhm c19zYiAqKWFsbG9jYSAoZ2VvbS0+ZGV2LT5zZWN0b3Jfc2l6ZSk7CisJc3RydWN0IHhmc19zYgkq c2IgPSBhbGxvY2EgKGdlb20tPmRldi0+c2VjdG9yX3NpemUpOwoKIAlpZiAoZ2VvbS0+bGVuZ3Ro IDwgWEZTX1NCX0RBRERSICsgMSkKIAkJcmV0dXJuIE5VTEw7CmRpZmYgLS1naXQgYS9saWJwYXJ0 ZWQvbGFiZWxzL2dwdC5jIGIvbGlicGFydGVkL2xhYmVscy9ncHQuYwppbmRleCA3NmJmN2U3Li4y YTA4YTUwIDEwMDY0NAotLS0gYS9saWJwYXJ0ZWQvbGFiZWxzL2dwdC5jCisrKyBiL2xpYnBhcnRl ZC9sYWJlbHMvZ3B0LmMKQEAgLTE4OTYsNyArMTg5Niw3IEBAIGdwdF9wYXJ0aXRpb25fc2V0X25h bWUgKFBlZFBhcnRpdGlvbiAqcGFydCwgY29uc3QgY2hhciAqbmFtZSkKICBlcnI6CiAgIHBlZF9l eGNlcHRpb25fdGhyb3cgKFBFRF9FWENFUFRJT05fV0FSTklORywKICAgICAgICAgICAgICAgICAg ICAgICAgUEVEX0VYQ0VQVElPTl9JR05PUkUsCi0gICAgICAgICAgICAgICAgICAgICAgIF8oIkNh biBub3QgdHJhbnNsYXRlIHBhcnRpdGlvbiBuYW1lIikpOworICAgICAgICAgICAgICAgICAgICAg ICBfKCJmYWlsZWQgdG8gdHJhbnNsYXRlIHBhcnRpdGlvbiBuYW1lIikpOwogICBpY29udl9jbG9z ZSAoY29udik7CiB9CgpAQCAtMTkyMyw3ICsxOTIzLDcgQEAgZ3B0X3BhcnRpdGlvbl9nZXRfbmFt ZSAoY29uc3QgUGVkUGFydGl0aW9uICpwYXJ0KQogICAgIGVycjoKICAgICAgIHBlZF9leGNlcHRp b25fdGhyb3cgKFBFRF9FWENFUFRJT05fV0FSTklORywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFBFRF9FWENFUFRJT05fSUdOT1JFLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgXygi Q2FuIG5vdCB0cmFuc2xhdGUgcGFydGl0aW9uIG5hbWUiKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICBfKCJmYWlsZWQgdG8gdHJhbnNsYXRlIHBhcnRpdGlvbiBuYW1lIikpOwogICAgICAg aWNvbnZfY2xvc2UgKGNvbnYpOwogICAgICAgcmV0dXJuICIiOwogICAgIH0KZGlmZiAtLWdpdCBh L3Rlc3RzL2dwdC1oZWFkZXItbW92ZS5weSBiL3Rlc3RzL2dwdC1oZWFkZXItbW92ZS5weQppbmRl eCA5NzdmZWJiLi44YmVlNmJiIDEwMDY0NAotLS0gYS90ZXN0cy9ncHQtaGVhZGVyLW1vdmUucHkK KysrIGIvdGVzdHMvZ3B0LWhlYWRlci1tb3ZlLnB5CkBAIC0zNyw0ICszNywzIEBAIGZpbGUuc2Vl ayg1MTIqKGFsdGxiYS0zMikpCiBmaWxlLndyaXRlKGJhY2t1cCkKIGZpbGUud3JpdGUoZ3B0aGVh ZGVyKQogZmlsZS53cml0ZSgiXDAiICogKDUxMiAqIDMzKSkKLQpkaWZmIC0tZ2l0IGEvdGVzdHMv dDAyODEtZ3B0LWdyb3cuc2ggYi90ZXN0cy90MDI4MS1ncHQtZ3Jvdy5zaAppbmRleCAwY2VmMTM4 Li4yMjliNmJkIDEwMDY0NAotLS0gYS90ZXN0cy90MDI4MS1ncHQtZ3Jvdy5zaAorKysgYi90ZXN0 cy90MDI4MS1ncHQtZ3Jvdy5zaApAQCAtOTUsNiArOTUsNiBAQCBjb21wYXJlIGV4cCBvdXQgfHwg ZmFpbD0xCgogcGFydGVkIC1zICRkZXYgcHJpbnQgPiBlcnIgMj4mMSB8fCBmYWlsPTEKIGdyZXAg V2FybmluZzogZXJyID4gayA7IG12IGsgZXJyCi1jb21wYXJlIGVyciAvZGV2L251bGwgfHwgZmFp bD0xCitjb21wYXJlIC9kZXYvbnVsbCBlcnIgfHwgZmFpbD0xCgogRXhpdCAkZmFpbApkaWZmIC0t Z2l0IGEvdGVzdHMvdDAyODItZ3B0LW1vdmUtYmFja3VwLnNoIGIvdGVzdHMvdDAyODItZ3B0LW1v dmUtYmFja3VwLnNoCmluZGV4IDFhMjk2YWQuLmM3NzZiODAgMTAwNjQ0Ci0tLSBhL3Rlc3RzL3Qw MjgyLWdwdC1tb3ZlLWJhY2t1cC5zaAorKysgYi90ZXN0cy90MDI4Mi1ncHQtbW92ZS1iYWNrdXAu c2gKQEAgLTk1LDYgKzk1LDYgQEAgY29tcGFyZSBleHAgb3V0IHx8IGZhaWw9MQoKIHBhcnRlZCAt cyAkZGV2IHByaW50ID4gZXJyIDI+JjEgfHwgZmFpbD0xCiBncmVwIEVycm9yOiBlcnIgPiBrIDsg bXYgayBlcnIKLWNvbXBhcmUgZXJyIC9kZXYvbnVsbCB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9u dWxsIGVyciB8fCBmYWlsPTEKCiBFeGl0ICRmYWlsCmRpZmYgLS1naXQgYS90ZXN0cy90MTEwMi1s b29wLWxhYmVsLnNoIGIvdGVzdHMvdDExMDItbG9vcC1sYWJlbC5zaAppbmRleCBmNTcwMWEzLi4w YzQxZjZhIDEwMDY0NAotLS0gYS90ZXN0cy90MTEwMi1sb29wLWxhYmVsLnNoCisrKyBiL3Rlc3Rz L3QxMTAyLWxvb3AtbGFiZWwuc2gKQEAgLTM0LDEzICszNCwxMyBAQCBNb2RlbDogTGludXggc2Nz aV9kZWJ1ZyAoc2NzaSkKIERpc2sgREVWSUNFOiA5NC40TUIKIFNlY3RvciBzaXplIChsb2dpY2Fs L3BoeXNpY2FsKTogJHtzc31CLyR7c3N9QgogUGFydGl0aW9uIFRhYmxlOiBsb29wCi1EaXNrIEZs YWdzOiAKK0Rpc2sgRmxhZ3M6CgogTnVtYmVyICBTdGFydCAgRW5kICAgICBTaXplICAgIEZpbGUg c3lzdGVtICBGbGFncwogIDEgICAgICAwLjAwQiAgOTQuNE1CICA5NC40TUIgIGV4dDIKCiBFT0YK LW12IG91dCBvMiAmJiBzZWQgLWUgInMsJGRldixERVZJQ0UsOyIgbzIgPiBvdXQKK212IG91dCBv MiAmJiBzZWQgLWUgInMsJGRldixERVZJQ0UsO3MvICAqJC8vIiBvMiA+IG91dAoKIGNvbXBhcmUg ZXhwIG91dCB8fCBmYWlsPTEKIHBhcnRlZCAtcyAkZGV2IHJtIDEgfHwgZmFpbD0xCi0tIAoyLjAu MC5yYzMKCg== --e89a8f6473c57e96be04fa460bd6-- From MAILER-DAEMON Mon May 26 00:39:06 2014 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Womgk-0004QI-1e for mharc-bug-parted@gnu.org; Mon, 26 May 2014 00:39:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Womgh-0004Oz-I3 for bug-parted@gnu.org; Mon, 26 May 2014 00:39:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Womgg-0005ej-Q4 for bug-parted@gnu.org; Mon, 26 May 2014 00:39:03 -0400 Received: from debbugs.gnu.org ([140.186.70.43]:33035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Womgg-0005ee-Ma for bug-parted@gnu.org; Mon, 26 May 2014 00:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Womgg-0000Lt-AS for bug-parted@gnu.org; Mon, 26 May 2014 00:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#17597: FYI, I've run "make update-copyright" Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Mon, 26 May 2014 04:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17597 X-GNU-PR-Package: parted X-GNU-PR-Keywords: To: 17597@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14010790941245 (code B ref -1); Mon, 26 May 2014 04:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2014 04:38:14 +0000 Received: from localhost ([127.0.0.1]:60145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Womft-0000K0-Mm for submit@debbugs.gnu.org; Mon, 26 May 2014 00:38:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51058) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Womfq-0000Jc-8i for submit@debbugs.gnu.org; Mon, 26 May 2014 00:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Womfk-0005YL-8J for submit@debbugs.gnu.org; Mon, 26 May 2014 00:38:04 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:49455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Womfk-0005YF-56 for submit@debbugs.gnu.org; Mon, 26 May 2014 00:38:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Womfj-0004Mi-CU for bug-parted@gnu.org; Mon, 26 May 2014 00:38:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Womfi-0005Xo-Jf for bug-parted@gnu.org; Mon, 26 May 2014 00:38:03 -0400 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:64270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Womfi-0005Xf-DF for bug-parted@gnu.org; Mon, 26 May 2014 00:38:02 -0400 Received: by mail-we0-f169.google.com with SMTP id u56so7522470wes.14 for ; Sun, 25 May 2014 21:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=GeCBlTlHmdfpL99Fhd1L25Jv3spopE3FcMDumHkpmw4=; b=Xsy4476weh1Ppfp7cK+A+ztzYutCLOoLgJ/zaBfr1zLCMDIn9X6zE6VWzp14IagpvA f+wjchmmZKk+BTXdiUzQjdSLbfS/7BvW0Y8Xixbs5xNXVBWTFHk/Kaf4WqMkHjhuMKyV j+SlyPq+7NHc6Ttas5W0gbVZAyVOg+g1R67EQrPFFjooWGbWRwNOgKeF7ercOT+hS5cH HHTXfWc4b84CNUN+Bzku8ZnH9sYcd3YRitsu+gx6U9oUxMnZpo5M0oCFRQZXJTlnDqgQ s6owlzcAutvZoDELGTZQpcvDkVlI/xofxkW1KG/I3pFuAIF8Ou4U2X3vTWy3GAXg9FyS Lz3A== X-Received: by 10.194.242.66 with SMTP id wo2mr26122542wjc.37.1401079081581; Sun, 25 May 2014 21:38:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.81.102 with HTTP; Sun, 25 May 2014 21:37:41 -0700 (PDT) From: Jim Meyering Date: Sun, 25 May 2014 21:37:41 -0700 X-Google-Sender-Auth: Fs0867tMAL5c9kRRjCcyPxE-hRU Message-ID: Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-parted@gnu.org List-Id: Bug reports for the GNU Parted disk partition editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 04:39:04 -0000 The out of date copyright dates are annoying to me, because i have a write hook that asks me if I want to update them any time I change a file with one. As such, I have the policy of never doing that during any other commit (it'd introduce an unrelated diff that would make back-porting or cherry-picking harder, and increases risk of conflict), so instead perform a mass-copyright-update once per year, usually in the first few days of January. This time, I'm a few months late. I've just pushed it.