From MAILER-DAEMON Mon Jul 05 14:19:46 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BhY48-0004b5-NE for mharc-lwip-devel@gnu.org; Mon, 05 Jul 2004 14:19:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BhY46-0004aO-MU for lwip-devel@nongnu.org; Mon, 05 Jul 2004 14:19:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BhY44-0004ZN-W7 for lwip-devel@nongnu.org; Mon, 05 Jul 2004 14:19:42 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhY44-0004ZI-Si for lwip-devel@nongnu.org; Mon, 05 Jul 2004 14:19:40 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BhY24-0006Ro-46 for lwip-devel@nongnu.org; Mon, 05 Jul 2004 14:17:36 -0400 X-Sasl-enc: M7kN+LDEnwWIl4VXEKwixA 1089051408 Received: from [192.168.0.100] (t-indiv3-100.athome.tue.nl [131.155.240.100]) by www.fastmail.fm (Postfix) with ESMTP id 96CEFC0EF40 for ; Mon, 5 Jul 2004 14:16:48 -0400 (EDT) Message-ID: <40E99B10.40709@mailcan.com> Date: Mon, 05 Jul 2004 20:16:48 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel@nongnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [lwip-devel] tcp_timer_needed() caller? X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jul 2004 18:19:42 -0000 Hello, I am sniffing in the api layer of lwIP but found little documentation there. Who is the intended caller of void tcp_timer_needed(void) ? Regards, Leon. From MAILER-DAEMON Mon Jul 05 22:16:54 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BhfVt-0005EA-T3 for mharc-lwip-devel@gnu.org; Mon, 05 Jul 2004 22:16:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BhfVs-0005CX-8j for lwip-devel@nongnu.org; Mon, 05 Jul 2004 22:16:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BhfVr-0005BN-4U for lwip-devel@nongnu.org; Mon, 05 Jul 2004 22:16:51 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhfVr-0005BJ-0d for lwip-devel@nongnu.org; Mon, 05 Jul 2004 22:16:51 -0400 Received: from [199.185.220.240] (helo=priv-edtnes84.telusplanet.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BhfTm-0007Yq-Ge for lwip-devel@nongnu.org; Mon, 05 Jul 2004 22:14:42 -0400 Received: from power-box.telusplanet.net ([161.184.130.134]) by priv-edtnes84.telusplanet.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040706021440.NJZU18643.priv-edtnes84.telusplanet.net@power-box.telusplanet.net> for ; Mon, 5 Jul 2004 20:14:40 -0600 Message-Id: <6.1.1.1.2.20040705201002.0207faa0@pop.telusplanet.net> X-Sender: mbobowik@pop.telusplanet.net X-Mailer: QUALCOMM Windows Eudora Version 6.1.1.1 Date: Mon, 05 Jul 2004 20:14:44 -0600 To: lwip-devel From: Michael Broughton Subject: Re: [lwip-devel] tcp_timer_needed() caller? In-Reply-To: <40E99B10.40709@mailcan.com> References: <40E99B10.40709@mailcan.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2004 02:16:52 -0000 tcp.c: tcp_listen() tcp.c: tcp_connect() tcp_in.c: tcp_listen_input() tcp_in.c: tcp_process() make sure you take a look at TCP_REG() in tcp.h, first. Mike At 12:16 PM 05/07/2004, you wrote: >Hello, > >I am sniffing in the api layer of lwIP but found little documentation there. > >Who is the intended caller of void tcp_timer_needed(void) ? > >Regards, > >Leon. > > >_______________________________________________ >lwip-devel mailing list >lwip-devel@nongnu.org >http://lists.nongnu.org/mailman/listinfo/lwip-devel From MAILER-DAEMON Tue Jul 06 02:24:54 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BhjNu-0004VG-14 for mharc-lwip-devel@gnu.org; Tue, 06 Jul 2004 02:24:54 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BhjNs-0004UR-IW for lwip-devel@nongnu.org; Tue, 06 Jul 2004 02:24:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BhjNp-0004TX-KA for lwip-devel@nongnu.org; Tue, 06 Jul 2004 02:24:51 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhjNp-0004TG-Ha for lwip-devel@nongnu.org; Tue, 06 Jul 2004 02:24:49 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BhjLS-0004SS-2f for lwip-devel@nongnu.org; Tue, 06 Jul 2004 02:22:22 -0400 X-Sasl-enc: 0QyAxzPlPgr2qYzG0jeO2Q 1089094941 Received: from [192.168.0.100] (t-indiv3-100.athome.tue.nl [131.155.240.100]) by www.fastmail.fm (Postfix) with ESMTP id 60F9FC10F8D for ; Tue, 6 Jul 2004 02:22:20 -0400 (EDT) Message-ID: <40EA451C.4@mailcan.com> Date: Tue, 06 Jul 2004 08:22:20 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel Subject: Re: [lwip-devel] tcp_timer_needed() caller? References: <40E99B10.40709@mailcan.com> <6.1.1.1.2.20040705201002.0207faa0@pop.telusplanet.net> In-Reply-To: <6.1.1.1.2.20040705201002.0207faa0@pop.telusplanet.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2004 06:24:52 -0000 Hello Michael, Michael Broughton wrote: > make sure you take a look at TCP_REG() in tcp.h, first. > Mike Thanks, seems I was searching in *.c files only. Regards, Leon. From MAILER-DAEMON Tue Jul 06 19:45:07 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BhzcZ-0003GT-Oi for mharc-lwip-devel@gnu.org; Tue, 06 Jul 2004 19:45:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BhzcX-0003G7-BS for lwip-devel@nongnu.org; Tue, 06 Jul 2004 19:45:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BhzcU-0003Ff-PU for lwip-devel@nongnu.org; Tue, 06 Jul 2004 19:45:04 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhzcU-0003Fb-Bv for lwip-devel@nongnu.org; Tue, 06 Jul 2004 19:45:02 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BhzZz-00059g-4T for lwip-devel@nongnu.org; Tue, 06 Jul 2004 19:42:27 -0400 X-Sasl-enc: eD1SyuAxRApCtLYleKPp0g 1089157344 Received: from [192.168.0.100] (t-indiv3-100.athome.tue.nl [131.155.240.100]) by www.fastmail.fm (Postfix) with ESMTP id D9F6FC0F1BF for ; Tue, 6 Jul 2004 19:42:22 -0400 (EDT) Message-ID: <40EB38E0.5080802@mailcan.com> Date: Wed, 07 Jul 2004 01:42:24 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel@nongnu.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: [lwip-devel] RFC: etharp and dhcp timers in tcpip.c X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2004 23:45:05 -0000 Hello, the wrapper api (in the src/api/ directory) and mainly tcpip.c currently instantiates a thread for running the time-out driven TCP state machine. How about generalizing this thread for *all* lwIP timeouts, i.e. adding DHCP timeouts and ARP timeouts? Currently, developers have to implement their own mechanisms to drive those timers, even when including the lwIP /src/api code, which often leads to confusion or race conditions when not properly implemented. I would suggest renaming tcpip.c to lwip_thread.c and add calls to DHCP and ARP timers. Regards, Leon. From MAILER-DAEMON Wed Jul 07 01:41:38 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bi5Ba-0006K6-8J for mharc-lwip-devel@gnu.org; Wed, 07 Jul 2004 01:41:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bi5BZ-0006Jp-FT for lwip-devel@nongnu.org; Wed, 07 Jul 2004 01:41:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bi5BX-0006Ip-R2 for lwip-devel@nongnu.org; Wed, 07 Jul 2004 01:41:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bi5BX-0006Im-OW for lwip-devel@nongnu.org; Wed, 07 Jul 2004 01:41:35 -0400 Received: from [194.105.28.94] (helo=iv.ro) by monty-python.gnu.org with smtp (Exim 4.34) id 1Bi59B-0000h5-S0 for lwip-devel@nongnu.org; Wed, 07 Jul 2004 01:39:10 -0400 Received: (qmail 29850 invoked from network); 6 Jul 2004 05:14:18 -0000 Received: from unknown (HELO cow) (192.168.1.4) by iv.ro with SMTP; 6 Jul 2004 05:14:18 -0000 Date: Wed, 7 Jul 2004 08:36:55 +0300 From: Jani Monoses To: lwip-devel Subject: Re: [lwip-devel] RFC: etharp and dhcp timers in tcpip.c Message-Id: <20040707083655.7e4390e1.jani@iv.ro> In-Reply-To: <40EB38E0.5080802@mailcan.com> References: <40EB38E0.5080802@mailcan.com> X-Mailer: Sylpheed version 0.9.11 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2004 05:41:37 -0000 > I would suggest renaming tcpip.c to lwip_thread.c and add calls to > DHCP and ARP timers. > I agree.But those who don't use the thread API will have to do it themselves if the timer routines are removed from etharp and dhcp. From MAILER-DAEMON Wed Jul 07 02:11:14 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bi5eE-0007NK-6T for mharc-lwip-devel@gnu.org; Wed, 07 Jul 2004 02:11:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bi5eC-0007M5-4k for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:11:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bi5eA-0007L7-Jy for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:11:11 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bi5e9-0007Ku-Jc for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:11:10 -0400 Received: from [212.202.234.99] (helo=ntmail1.datus.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bi5bt-0005TQ-U8 for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:08:50 -0400 Received: by ntmail1.datus.com with Internet Mail Service (5.5.2653.19) id <3M2VDG3H>; Wed, 7 Jul 2004 08:09:02 +0200 Message-ID: <956069990CA4D811BD7A00D0B7B9FE9C410072@ntmail1.datus.com> From: "Zschocke, Florian" To: 'lwip-devel' Subject: RE: [lwip-devel] RFC: etharp and dhcp timers in tcpip.c Date: Wed, 7 Jul 2004 08:09:01 +0200 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2004 06:11:12 -0000 Jani Monoses wrote on Wednesday, July 07, 2004 7:37 AM: > I agree.But those who don't use the thread API will have to do > it themselves if the timer routines are removed from etharp and > dhcp. If you do that remember to put those calls into #ifdef DHCP blocks. Not everybody uses DHCP or ARP from lwIP. Florian From MAILER-DAEMON Wed Jul 07 02:21:41 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bi5oI-00029J-Vj for mharc-lwip-devel@gnu.org; Wed, 07 Jul 2004 02:21:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bi5oH-00028t-94 for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:21:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bi5oF-000287-Oy for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:21:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bi5oF-000284-Lt for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:21:35 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bi5lo-000744-Ol for lwip-devel@nongnu.org; Wed, 07 Jul 2004 02:19:04 -0400 X-Sasl-enc: 5XlrPQ3utDawzcHnQZ7lgA 1089181144 Received: from [192.168.0.100] (t-indiv3-100.athome.tue.nl [131.155.240.100]) by www.fastmail.fm (Postfix) with ESMTP id E1F75C103B5 for ; Wed, 7 Jul 2004 02:19:03 -0400 (EDT) Message-ID: <40EB95D6.90204@mailcan.com> Date: Wed, 07 Jul 2004 08:19:02 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel Subject: Re: [lwip-devel] RFC: etharp and dhcp timers in tcpip.c References: <40EB38E0.5080802@mailcan.com> <20040707083655.7e4390e1.jani@iv.ro> In-Reply-To: <20040707083655.7e4390e1.jani@iv.ro> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2004 06:21:37 -0000 Hello Jani, Jani Monoses wrote: >>I would suggest renaming tcpip.c to lwip_thread.c and add calls to >>DHCP and ARP timers. >> >> >> > >I agree.But those who don't use the thread API will have to do it themselves >if the timer routines are removed from etharp and dhcp. > > The timer routines in ARP and DHCP are "timer handlers" so they remain in the code. And yes, if you do not use the thread API, you have to call those timer handlers directly, repeatedly after the correct interval for each timer. Regards, Leon. From MAILER-DAEMON Mon Jul 19 07:08:56 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BmW0u-0006S2-HD for mharc-lwip-devel@gnu.org; Mon, 19 Jul 2004 07:08:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BmW0s-0006Rm-6M for lwip-devel@nongnu.org; Mon, 19 Jul 2004 07:08:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BmW0q-0006Ra-Kf for lwip-devel@nongnu.org; Mon, 19 Jul 2004 07:08:53 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BmW0q-0006RX-1N for lwip-devel@nongnu.org; Mon, 19 Jul 2004 07:08:52 -0400 Received: from [217.154.131.4] (helo=mailhost1.mistral.co.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BmVxu-0008WS-1a for lwip-devel@nongnu.org; Mon, 19 Jul 2004 07:05:50 -0400 Received: from angela1.data-uncertain.co.uk (adsl-195-184-237-106.mistral-uk.net [195.184.237.106]) by mailhost1.mistral.co.uk (Postfix) with ESMTP id 42FF7478B6B for ; Mon, 19 Jul 2004 11:57:26 +0100 (BST) From: Craig Graham Organization: Access Devices To: lwip-devel@nongnu.org Date: Mon, 19 Jul 2004 12:12:27 +0100 User-Agent: KMail/1.6 MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <200407191212.27691.craig-lwip@data-uncertain.co.uk> Subject: [lwip-devel] Mods to the LWIP BSD Socket's emulation layer.. X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 11:08:54 -0000 I just started looking at LWIP a couple of weeks ago, and was wondering how= =20 I'd go about submitting mods to the codebase? Bit of background - the firm I work for supports Open Source software to th= e=20 extent that they're happy for mods/improvements made by us to be released=20 back to the community. We used uCIP in one of our products previously, and = as=20 part of that development I added the UDP and DHCP protocol support in uCIP. Anyway, uCIP is old news and I've suggested LWIP might be suitable=20 replacement, as a test of that I've just ported LWIP to our in-house RTOS. During that I noticed a couple of things that needed attention in the BSD=20 socket's API emulation. The first is a simple bugfix to the handling of =46IONREAD in sockets.c - if a previous read didn't use up the contents of = an=20 entire netbuf, the lastdata field will still hold data and this amount of=20 data wasn't being included in the amount returned by FIONREAD. 1322c1325,1326 < =2D-- > =A0 u16_t l; > 1335c1339,1344 < =A0 =A0 *((u16_t*)argp) =3D sock->conn->recv_avail; =2D-- > =A0 =A0 l=3Dsock->conn->recv_avail; > =A0 =A0 if(sock->lastdata) > =A0 =A0 { > =A0 =A0 =A0 l+=3Dnetbuf_len(sock->lastdata)-sock->lastoffset; > =A0 =A0 } > =A0 =A0 *((u16_t*)argp) =3D l; The second is a more of a feature enhancement, and is a bit in-depth to pos= t=20 on a mailing list (adds non-blocking support to lwip_connect(), controlled = by=20 the FIONBLOCK flag). What's the formal procedure for submitting stuff like= =20 this? Laters, Craig. From MAILER-DAEMON Mon Jul 19 16:49:21 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bmf4b-0002bM-P8 for mharc-lwip-devel@gnu.org; Mon, 19 Jul 2004 16:49:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bmf4Z-0002aa-RK for lwip-devel@nongnu.org; Mon, 19 Jul 2004 16:49:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bmf4X-0002a0-8o for lwip-devel@nongnu.org; Mon, 19 Jul 2004 16:49:19 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bmf4X-0002ZO-6V for lwip-devel@nongnu.org; Mon, 19 Jul 2004 16:49:17 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bmf0J-0005KE-Qa for lwip-devel@nongnu.org; Mon, 19 Jul 2004 16:44:55 -0400 X-Sasl-enc: KmdvkzWA9tN/xSasnWOuJw 1090269892 Received: from [192.168.0.100] (b76251.upc-b.chello.nl [212.83.76.251]) by www.fastmail.fm (Postfix) with ESMTP id BE420C1254F for ; Mon, 19 Jul 2004 16:44:52 -0400 (EDT) Message-ID: <40FC32CB.8070506@mailcan.com> Date: Mon, 19 Jul 2004 22:44:59 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel Subject: Re: [lwip-devel] Mods to the LWIP BSD Socket's emulation layer.. References: <200407191212.27691.craig-lwip@data-uncertain.co.uk> In-Reply-To: <200407191212.27691.craig-lwip@data-uncertain.co.uk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 20:49:20 -0000 Hello Graig, Craig Graham wrote: >the FIONBLOCK flag). What's the formal procedure for submitting stuff like >this? > > Patches can be submitted via Savannah, but easiest for everyone is asking for CVS access here. Developers that tend to improve the overall code base can get CVS commit access, provided that they discuss disruptive changes on the lwip-devel mailing list first. First step would be to sign up on Savannah, and get your SSH keys uploaded and tested, then mailing us your Savannah ID. Regards, Leon Woestenberg. From MAILER-DAEMON Tue Jul 20 10:35:34 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BmviQ-0000ar-E5 for mharc-lwip-devel@gnu.org; Tue, 20 Jul 2004 10:35:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BmviP-0000ag-EG for lwip-devel@nongnu.org; Tue, 20 Jul 2004 10:35:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BmviO-0000aU-L2 for lwip-devel@nongnu.org; Tue, 20 Jul 2004 10:35:33 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BmviO-0000aK-Gc for lwip-devel@nongnu.org; Tue, 20 Jul 2004 10:35:32 -0400 Received: from [62.253.198.201] (helo=mail.TANDBERGTV.COM) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BmvfX-0000JI-5P for lwip-devel@nongnu.org; Tue, 20 Jul 2004 10:32:35 -0400 Received: from consignia.TANDBERGTV.COM (unverified [172.17.253.77]) by mail.TANDBERGTV.COM (Content Technologies SMTPRS 4.3.14) with ESMTP id for ; Tue, 20 Jul 2004 15:32:33 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Tue, 20 Jul 2004 15:32:33 +0100 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: etharp oddity Thread-Index: AcRuZkMBN1os/dlWEdivmwAGWxBqmQ== From: "Mountifield, Tony" To: "lwip-devel" Subject: [lwip-devel] etharp oddity X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2004 14:35:33 -0000 I've just resumed working on lwip after a break of almost 3 months, and hav= e updated my sources to CVS HEAD as of yesterday. =20 It seems on my lwip system that every outbound packet causes an ARP request= for the recipient, even though the ARP table contains the recipient's info= rmation already. =20 Looking at etharp.c, in the function etharp_output(), unicast packets get p= assed onto etharp_query(), with either their own IP address or that of the = default gateway. etharp_query() causes an ARP request to *always* be sent, = for *every* packet, before it even checks the ARP table! This doesn't seem = right. =20 I would have thought the desired behaviour is to only send an ARP query if = there is no matching entry in the Stable state. Comments? =20 Cheers Tony --=20 Tony Mountifield Contractor @ Tandberg TV Strategic Park, ext 3390 Tel: 023 8057 3390 =20 ***************************************************************************= ******** This email, its content and any attachments is PRIVATE AND CONFIDENTIAL to TANDBERG Television. If received in error please notify the sender and destroy the original message and attachments. www.tandbergtv.com ***************************************************************************= ******** From MAILER-DAEMON Tue Jul 20 16:04:47 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bn0r1-00024v-2N for mharc-lwip-devel@gnu.org; Tue, 20 Jul 2004 16:04:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bn0qz-00024W-S6 for lwip-devel@nongnu.org; Tue, 20 Jul 2004 16:04:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bn0qz-00024K-9S for lwip-devel@nongnu.org; Tue, 20 Jul 2004 16:04:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bn0qz-00024A-3q for lwip-devel@nongnu.org; Tue, 20 Jul 2004 16:04:45 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bn0nt-0003gk-Ic for lwip-devel@nongnu.org; Tue, 20 Jul 2004 16:01:33 -0400 Received: from server2.messagingengine.com (server2.internal [10.202.2.133]) by mail.messagingengine.com (Postfix) with ESMTP id 4A03AC12869 for ; Tue, 20 Jul 2004 16:01:31 -0400 (EDT) Received: by server2.messagingengine.com (Postfix, from userid 99) id AAAD282882; Tue, 20 Jul 2004 16:01:31 -0400 (EDT) Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.4 (F2.72; T1.001; A1.62; B3.01; Q3.01) References: Subject: Re: [lwip-devel] etharp oddity In-Reply-To: To: "lwip-devel" Date: Tue, 20 Jul 2004 22:01:31 +0200 From: "Leon Woestenberg" X-Sasl-Enc: YrTtbwkK0jEtbPzFyX85aQ 1090353691 Message-Id: <1090353691.19578.200741968@webmail.messagingengine.com> X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2004 20:04:46 -0000 Hello Tony, On Tue, 20 Jul 2004 15:32:33 +0100, "Mountifield, Tony" said: > It seems on my lwip system that every outbound packet causes an ARP > request for the recipient, even though the ARP table contains the > recipient's information already. > Will look into this. etharp.c now features a packet queue and this has caused some bugs. Some have been fixed, and thanks for this bug report. Regards, Leon Woestenberg. From MAILER-DAEMON Tue Jul 20 19:21:12 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bn3v6-0005rS-KG for mharc-lwip-devel@gnu.org; Tue, 20 Jul 2004 19:21:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bn3v5-0005qh-2u for lwip-devel@nongnu.org; Tue, 20 Jul 2004 19:21:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bn3v2-0005pQ-0H for lwip-devel@nongnu.org; Tue, 20 Jul 2004 19:21:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bn3v1-0005pK-UT for lwip-devel@nongnu.org; Tue, 20 Jul 2004 19:21:07 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bn3rv-0006LM-RQ for lwip-devel@nongnu.org; Tue, 20 Jul 2004 19:17:56 -0400 X-Sasl-enc: MRbkOK8tWBXytDPP8K+Klw 1090365472 Received: from [192.168.0.100] (b76251.upc-b.chello.nl [212.83.76.251]) by www.fastmail.fm (Postfix) with ESMTP id 75EF2C123F6 for ; Tue, 20 Jul 2004 19:17:52 -0400 (EDT) Message-ID: <40FDA829.9040507@mailcan.com> Date: Wed, 21 Jul 2004 01:18:01 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel Subject: Re: [lwip-devel] etharp oddity References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2004 23:21:11 -0000 Tony, Mountifield, Tony wrote: >Looking at etharp.c, in the function etharp_output(), unicast packets get passed onto etharp_query(), with either their own IP address or that of the default gateway. etharp_query() causes an ARP request to *always* be sent, for *every* packet, before it even checks the ARP table! This doesn't seem right. > > > I found that the bug was introduced due to the dual functionality in etharp_query(): it both sends out ARP requests as well as queues packets on the entry. Thanks for reporting. I have changed the behaviour as follows. Note that calling etharp_query() with a NULL packet, will still send out an ARP request, even when already stable. This is to forcefully check against a known IP address. See CVS HEAD for the change. JavaDoc copy below. Regards, Leon. /** * Send an ARP request for the given IP address and/or queue a packet. * * If the IP address was not yet in the cache, a pending ARP cache entry * is added and an ARP request is sent for the given address. The packet * is queued on this entry. * * If the IP address was already pending in the cache, a new ARP request * is sent for the given address. The packet is queued on this entry. * * If the IP address was already stable in the cache, and a packet is * given, it is directly sent and no ARP request is sent out. * * If the IP address was already stable in the cache, and no packet is * given, an ARP request is sent out. * * @param netif The lwIP network interface on which ipaddr * must be queried for. * @param ipaddr The IP address to be resolved. * @param q If non-NULL, a pbuf that must be delivered to the IP address. * q is not freed by this function. * * @return * - ERR_BUF Could not make room for Ethernet header. * - ERR_MEM Hardware address unknown, and no more ARP entries available * to query for address or queue the packet. * - ERR_MEM Could not queue packet due to memory shortage. * - ERR_RTE No route to destination (no gateway to external networks). * - ERR_ARG Non-unicast address given, those will not appear in ARP cache. * */ From MAILER-DAEMON Wed Jul 21 06:01:19 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BnDuZ-0008Np-CN for mharc-lwip-devel@gnu.org; Wed, 21 Jul 2004 06:01:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnDuX-0008NJ-9S for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:01:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnDuU-0008LA-86 for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:01:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnDuT-0008KI-Tt for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:01:14 -0400 Received: from [62.253.198.201] (helo=mail.TANDBERGTV.COM) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnDrL-00084G-Ev for lwip-devel@nongnu.org; Wed, 21 Jul 2004 05:57:59 -0400 Received: from consignia.TANDBERGTV.COM (unverified [172.17.253.77]) by mail.TANDBERGTV.COM (Content Technologies SMTPRS 4.3.14) with ESMTP id for ; Wed, 21 Jul 2004 10:57:59 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Wed, 21 Jul 2004 10:57:57 +0100 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: inet_ntoa() Thread-Index: AcRvCRDPN1otJ9lWEdivmwAGWxBqmQ== From: "Mountifield, Tony" To: "lwip-devel" Subject: [lwip-devel] inet_ntoa() X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2004 10:01:17 -0000 Leon, =20 I've been committing a few pretty trivial changes this morning, mainly to d= o with types and casts, and was just about to do an update to inet_ntoa() i= n inet.c when I noticed that they partially undo changes you made not too l= ong ago, in versions 1.18 and 1.15.2.3. So I thought I'd raise it here firs= t. I'm also aware of bug #8864, although I'm not sure whether any of your c= hanges were to address that. I believe my suggestion would not (re-)introdu= ce that bug, and may fix it if it still outstanding. =20 There is currently a bit of confusion between char and u8_t, which causes w= arnings with compilers that treat char as signed (the C standard says it is= implementation dependent whether plain chars are signed or unsigned). I wa= nted to change the types so that u8_t is used to extract the bytes from the= address, but plain char is used for the output string and the characters i= n it, to match the return type of the function. Here is my proposed diff, t= hat I haven't committed yet: =20 Index: src/core/inet.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/lwip/lwip/src/core/inet.c,v retrieving revision 1.18 diff -u -r1.18 inet.c --- src/core/inet.c 28 Apr 2004 23:18:57 -0000 1.18 +++ src/core/inet.c 21 Jul 2004 09:39:29 -0000 @@ -302,17 +302,17 @@ */ char *inet_ntoa(struct in_addr addr) { - static u8_t str[16]; + static char str[16]; u32_t s_addr =3D addr.s_addr; - u8_t inv[3]; - u8_t *rp; + char inv[3]; + char *rp; u8_t *ap; u8_t rem; u8_t n; u8_t i; =20 rp =3D str; - ap =3D (char *)&s_addr; + ap =3D (u8_t *)&s_addr; for(n =3D 0; n < 4; n++) { i =3D 0; do { Cheers, Tony (softins) --=20 Tony Mountifield Contractor @ Tandberg TV Strategic Park, ext 3390 Tel: 023 8057 3390 =20 ***************************************************************************= ******** This email, its content and any attachments is PRIVATE AND CONFIDENTIAL to TANDBERG Television. If received in error please notify the sender and destroy the original message and attachments. www.tandbergtv.com ***************************************************************************= ******** From MAILER-DAEMON Wed Jul 21 06:22:00 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BnEEZ-00060C-WF for mharc-lwip-devel@gnu.org; Wed, 21 Jul 2004 06:22:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnEEX-0005zv-Eh for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:21:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnEEW-0005zU-Du for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:21:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnEEW-0005zD-2d for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:21:56 -0400 Received: from [62.253.198.201] (helo=mail.TANDBERGTV.COM) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnEBU-0002PS-Uv for lwip-devel@nongnu.org; Wed, 21 Jul 2004 06:18:49 -0400 Received: from consignia.TANDBERGTV.COM (unverified [172.17.253.77]) by mail.TANDBERGTV.COM (Content Technologies SMTPRS 4.3.14) with ESMTP id for ; Wed, 21 Jul 2004 11:18:30 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [lwip-devel] etharp oddity Date: Wed, 21 Jul 2004 11:18:29 +0100 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [lwip-devel] etharp oddity Thread-Index: AcRu9lmmN0F+WXfnQheck85vmlXw9AAFU8eg From: "Mountifield, Tony" To: "lwip-devel" X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2004 10:21:57 -0000 Hi Leon, > I found that the bug was introduced due to the dual functionality in=20 > etharp_query(): it both sends out ARP requests as well as=20 > queues packets on the entry. Thanks for reporting. >=20 > I have changed the behaviour as follows. Note that calling=20 > etharp_query() with a NULL packet, will still send out an ARP=20 > request, even when already stable. This > is to forcefully check against a known IP address. >=20 > See CVS HEAD for the change. JavaDoc copy below. Many thanks - I've now tried it and it has resolved the issue. Cheers, Tony --=20 Tony Mountifield Contractor @ Tandberg TV Strategic Park, ext 3390 Tel: 023 8057 3390 ***************************************************************************= ******** This email, its content and any attachments is PRIVATE AND CONFIDENTIAL to TANDBERG Television. If received in error please notify the sender and destroy the original message and attachments. www.tandbergtv.com ***************************************************************************= ******** From MAILER-DAEMON Wed Jul 21 07:15:20 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BnF4B-0003JC-UT for mharc-lwip-devel@gnu.org; Wed, 21 Jul 2004 07:15:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnF4A-0003J6-1Q for lwip-devel@nongnu.org; Wed, 21 Jul 2004 07:15:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnF48-0003Iu-Bj for lwip-devel@nongnu.org; Wed, 21 Jul 2004 07:15:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnF48-0003Ir-96 for lwip-devel@nongnu.org; Wed, 21 Jul 2004 07:15:16 -0400 Received: from [217.154.131.4] (helo=mailhost1.mistral.co.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnF10-0000vr-Tj for lwip-devel@nongnu.org; Wed, 21 Jul 2004 07:12:03 -0400 Received: from angela1.data-uncertain.co.uk (adsl-195-184-237-106.mistral-uk.net [195.184.237.106]) by mailhost1.mistral.co.uk (Postfix) with ESMTP id 88CBA47A382 for ; Wed, 21 Jul 2004 12:10:56 +0100 (BST) From: Craig Graham Organization: Access Devices To: "lwip-devel" Date: Wed, 21 Jul 2004 12:26:21 +0100 User-Agent: KMail/1.6 MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200407211226.21658.craig-lwip@data-uncertain.co.uk> Subject: [lwip-devel] DHCP Improvement X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2004 11:15:18 -0000 This patch add's DNS server query to the lwip DHCP implementation (so you can get the DNS server address' at the same time as your IP address). The DNS server's for an interface can then be accessed via: netif->dhcp->dns_count == number of DNS server's discovered (0 - 2) netif->dhcp->offered_dns_addr[0] == primary DNS server netif->dhcp->offered_dns_addr[1] == secondary DNS server Laters, Craig. --- ./orig/lwip-0.7.2/src/include/lwip/dhcp.h 2003-12-28 02:38:51.000000000 +0000 +++ ./lwip-0.7.2/src/include/lwip/dhcp.h 2004-07-20 15:15:47.000000000 +0100 @@ -43,6 +43,8 @@ struct ip_addr offered_sn_mask; struct ip_addr offered_gw_addr; struct ip_addr offered_bc_addr; + u32_t dns_count; //++cg[20/7/2004]: Number of DNS server address' discovered + struct ip_addr offered_dns_addr[2]; //++cg[20/7/2004]: DNS server address' u32_t offered_t0_lease; /* lease period (in seconds) */ u32_t offered_t1_renew; /* recommended renew time (usually 50% of lease period) */ u32_t offered_t2_rebind; /* recommended rebind time (usually 66% of lease period) */ @@ -175,6 +177,8 @@ #define DHCP_OPTION_PAD 0 #define DHCP_OPTION_SUBNET_MASK 1 /* RFC 2132 3.3 */ #define DHCP_OPTION_ROUTER 3 +#define DHCP_OPTION_DNS_SERVER 6 --- ./orig/lwip-0.7.2/src/core/dhcp.c 2004-04-23 16:36:18.000000000 +0100 +++ ./lwip-0.7.2/src/core/dhcp.c 2004-07-20 15:23:03.000000000 +0100 @@ -231,10 +237,12 @@ dhcp_option(dhcp, DHCP_OPTION_SERVER_ID, 4); dhcp_option_long(dhcp, ntohl(dhcp->server_ip_addr.addr)); - dhcp_option(dhcp, DHCP_OPTION_PARAMETER_REQUEST_LIST, 3); + dhcp_option(dhcp, DHCP_OPTION_PARAMETER_REQUEST_LIST, 4); dhcp_option_byte(dhcp, DHCP_OPTION_SUBNET_MASK); dhcp_option_byte(dhcp, DHCP_OPTION_ROUTER); dhcp_option_byte(dhcp, DHCP_OPTION_BROADCAST); + //++cg[20/7/2004]: Request DNS server address from DHCP server + dhcp_option_byte(dhcp, DHCP_OPTION_DNS_SERVER); dhcp_option_trailer(dhcp); /* shrink the pbuf to the actual content length */ @@ -480,6 +488,24 @@ if (option_ptr != NULL) { dhcp->offered_bc_addr.addr = htonl(dhcp_get_option_long(&option_ptr[2])); } + + //++cg[20/7/2004]: handle DHCP server + option_ptr = dhcp_get_option_ptr(dhcp, DHCP_OPTION_DNS_SERVER); + if (option_ptr != NULL) { + int n; + dhcp->dns_count=dhcp_get_option_byte(&option_ptr[1]); + if(dhcp->dns_count>2) + dhcp->dns_count=2; + printf("dhcp: got %lu DNS server address'\n",dhcp->dns_count); + for(n=0; ndns_count; n++) + { + struct in_addr inA; + dhcp->offered_dns_addr[n].addr = htonl(dhcp_get_option_long(&option_ptr[2+(n<<2)])); + inA.s_addr=dhcp->offered_dns_addr[n].addr; + printf("dhcp: dns[%d] = %s\n",n,inet_ntoa(inA)); + } + } + } /** @@ -695,10 +721,12 @@ dhcp_option(dhcp, DHCP_OPTION_MAX_MSG_SIZE, DHCP_OPTION_MAX_MSG_SIZE_LEN); dhcp_option_short(dhcp, 576); - dhcp_option(dhcp, DHCP_OPTION_PARAMETER_REQUEST_LIST, 3); + dhcp_option(dhcp, DHCP_OPTION_PARAMETER_REQUEST_LIST, 4); dhcp_option_byte(dhcp, DHCP_OPTION_SUBNET_MASK); dhcp_option_byte(dhcp, DHCP_OPTION_ROUTER); dhcp_option_byte(dhcp, DHCP_OPTION_BROADCAST); + //++cg[20/7/2004]: Request DNS server address from DHCP server + dhcp_option_byte(dhcp, DHCP_OPTION_DNS_SERVER); dhcp_option_trailer(dhcp); From MAILER-DAEMON Wed Jul 21 14:03:56 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1BnLRc-0007V2-LJ for mharc-lwip-devel@gnu.org; Wed, 21 Jul 2004 14:03:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnLRZ-0007Ux-4h for lwip-devel@nongnu.org; Wed, 21 Jul 2004 14:03:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnLRY-0007Uk-HB for lwip-devel@nongnu.org; Wed, 21 Jul 2004 14:03:52 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnLRY-0007Uh-Ea for lwip-devel@nongnu.org; Wed, 21 Jul 2004 14:03:52 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnLOa-00069x-Po for lwip-devel@nongnu.org; Wed, 21 Jul 2004 14:00:48 -0400 X-Sasl-enc: +Aw1DI1jCaatusnqtC7P4g 1090432846 Received: from [192.168.0.100] (b76251.upc-b.chello.nl [212.83.76.251]) by www.fastmail.fm (Postfix) with ESMTP id 999E9C12AE4 for ; Wed, 21 Jul 2004 14:00:46 -0400 (EDT) Message-ID: <40FEAF58.8000705@mailcan.com> Date: Wed, 21 Jul 2004 20:00:56 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel Subject: Re: [lwip-devel] inet_ntoa() References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2004 18:03:53 -0000 Hello Tony, > >There is currently a bit of confusion between char and u8_t, which causes warnings with compilers that treat char as signed (the C > u8_t is meant to be an unsigned char, and some of the "bugs fixed" by people were actually errs in the platform dependent "cc.h" where u8_t was simply said to be a "char" instead of an unsigned char. >standard says it is implementation dependent whether plain chars are signed or unsigned). I wanted to change the types so that u8_t is used to extract the bytes from the address, but plain char is used for the output string and the characters in it, to match the return type of the function. Here is my proposed diff, that I haven't committed yet: > > > Looks a sane change, so please commit. Regards, Leon. From MAILER-DAEMON Thu Jul 22 18:28:11 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bnm2t-0001jB-Bj for mharc-lwip-devel@gnu.org; Thu, 22 Jul 2004 18:28:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bnm2p-0001gr-Mm for lwip-devel@nongnu.org; Thu, 22 Jul 2004 18:28:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bnm2n-0001gG-QA for lwip-devel@nongnu.org; Thu, 22 Jul 2004 18:28:06 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bnm2n-0001gD-JG for lwip-devel@nongnu.org; Thu, 22 Jul 2004 18:28:05 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bnlzo-0004M1-VJ for lwip-devel@nongnu.org; Thu, 22 Jul 2004 18:25:01 -0400 X-Sasl-enc: hSkhaRCA61CADwkA9r4jIw 1090535098 Received: from [192.168.0.100] (b76251.upc-b.chello.nl [212.83.76.251]) by www.fastmail.fm (Postfix) with ESMTP id D9FC0C12A82 for ; Thu, 22 Jul 2004 18:24:56 -0400 (EDT) Message-ID: <41003EC3.5020304@mailcan.com> Date: Fri, 23 Jul 2004 00:25:07 +0200 From: Leon Woestenberg User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: lwip-devel@nongnu.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: [lwip-devel] HEADS UP: Branching off 1.0.x X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2004 22:28:08 -0000 Hello all, I am about to start the lwIP 1.0.x release branch from HEAD. I have tagged the current HEAD with a "STABLE-1_0_0" tag to indicate the proposed root of the branch. If there are reasons why I shouldn't do so, speak up. Otherwise, expect a branch "STABLE-1_0" to appear next week. Regards, Leon. From MAILER-DAEMON Fri Jul 23 04:06:40 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bnv4h-0004kC-VF for mharc-lwip-devel@gnu.org; Fri, 23 Jul 2004 04:06:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bnv4e-0004k6-Hh for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:06:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bnv4c-0004ju-Cq for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:06:35 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bnv4c-0004jm-4w for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:06:34 -0400 Received: from [131.111.8.135] (helo=ppsw-5.csi.cam.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bnv1g-0005mO-AT for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:03:32 -0400 Received: from kirin.eng.cam.ac.uk ([129.169.98.86]:57138) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:465) with esmtp (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.34) id 1Bnv1b-0000zX-HE for lwip-devel@nongnu.org; Fri, 23 Jul 2004 09:03:27 +0100 Subject: Re: [lwip-devel] HEADS UP: Branching off 1.0.x From: "K.J. Mansley" To: lwip-devel In-Reply-To: <41003EC3.5020304@mailcan.com> References: <41003EC3.5020304@mailcan.com> Content-Type: text/plain Organization: Message-Id: <1090569807.947.1.camel@kirin.eng.cam.ac.uk> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 23 Jul 2004 09:03:27 +0100 Content-Transfer-Encoding: 7bit X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ X-Cam-AntiVirus: No virus found X-Cam-SpamDetails: scanned, SpamAssassin (score=0, FROM_CRSID -0.87, FROM_ENDS_IN_NUMS 0.87) X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2004 08:06:37 -0000 On Thu, 2004-07-22 at 23:25, Leon Woestenberg wrote: > Hello all, > > I am about to start the lwIP 1.0.x release branch from HEAD. > > I have tagged the current HEAD with a "STABLE-1_0_0" tag to > indicate the proposed root of the branch. > > If there are reasons why I shouldn't do so, speak up. Otherwise, > expect a branch "STABLE-1_0" to appear next week. It would be nice to get the bug that Karl Jeacle raised yesterday, and the change to tcp_close() sorted before the release is made, but doesn't really matter. I was intending to sort those out today. Kieran From MAILER-DAEMON Fri Jul 23 04:55:10 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bnvpe-0000Fk-IB for mharc-lwip-devel@gnu.org; Fri, 23 Jul 2004 04:55:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bnvpc-0000F0-Pi for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:55:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnvpZ-0000Dn-8I for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:55:06 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnvpY-0000Dd-V0 for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:55:05 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bnvmf-0003US-43 for lwip-devel@nongnu.org; Fri, 23 Jul 2004 04:52:05 -0400 X-Sasl-enc: zfx5MLv1ChUCfilK5//uMA 1090572724 Received: from [10.1.0.26] (cp100353-a.tilbu1.nb.home.nl [217.121.63.140]) by www.fastmail.fm (Postfix) with ESMTP id 14781C12708 for ; Fri, 23 Jul 2004 04:52:03 -0400 (EDT) Subject: Re: [lwip-devel] HEADS UP: Branching off 1.0.x From: Leon Woestenberg To: lwip-devel In-Reply-To: <1090569807.947.1.camel@kirin.eng.cam.ac.uk> References: <41003EC3.5020304@mailcan.com> <1090569807.947.1.camel@kirin.eng.cam.ac.uk> Content-Type: text/plain Message-Id: <1090572725.4025.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Fri, 23 Jul 2004 10:52:06 +0200 Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2004 08:55:09 -0000 Hello Kieran, On Fri, 2004-07-23 at 10:03, K.J. Mansley wrote: > On Thu, 2004-07-22 at 23:25, Leon Woestenberg wrote: > > I have tagged the current HEAD with a "STABLE-1_0_0" tag to > > indicate the proposed root of the branch. > > > > If there are reasons why I shouldn't do so, speak up. Otherwise, > > expect a branch "STABLE-1_0" to appear next week. > > It would be nice to get the bug that Karl Jeacle raised yesterday, and > the change to tcp_close() sorted before the release is made, but doesn't > really matter. I was intending to sort those out today. > Sure, I'll wait for that to be sorted, then move the tag, then branch. Don't rush it, I have little time myself :-) Regards, Leon. From MAILER-DAEMON Tue Jul 27 19:01:34 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bpawv-0000tJ-R0 for mharc-lwip-devel@gnu.org; Tue, 27 Jul 2004 19:01:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BoYOS-00053e-9F for lwip-devel@nongnu.org; Sat, 24 Jul 2004 22:05:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BoYOP-00053E-DG for lwip-devel@nongnu.org; Sat, 24 Jul 2004 22:05:39 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BoYOP-00052x-C7 for lwip-devel@nongnu.org; Sat, 24 Jul 2004 22:05:37 -0400 Received: from [61.140.60.52] (helo=21cn.com) by monty-python.gnu.org with smtp (Exim 4.34) id 1BoYKu-0000fX-C0 for lwip-devel@nongnu.org; Sat, 24 Jul 2004 22:02:00 -0400 Received: from emperor([127.0.0.1]) by 21cn.com(AIMC 2.9.5.6) with SMTP id jm041035390; Sun, 25 Jul 2004 10:03:28 +0800 Received: from emperor([218.66.59.169]) by 21cn.com(AIMC 2.9.5.4) with SMTP id AISP action; Sun, 25 Jul 2004 10:03:27 +0800 Date: Sun, 25 Jul 2004 10:04:31 +0800 From: "xcb" To: "lwip-devel" X-mailer: Foxmail 5.0 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 X-AIMC-AUTH: xcbman X-AIMC-MAILFROM: xcbman@21cn.com Message-ID: X-Mailman-Approved-At: Tue, 27 Jul 2004 19:01:32 -0400 Subject: [lwip-devel] lwip in win32 X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jul 2004 02:05:40 -0000 bHdpcC1kZXZlbDoNCglpIGNhbnQgZG93bmxvYWQgdGhlIGZpbGVzIGluIHdlYjpodHRwOi8vcHJv ZmYuY3Jvd3Byb2R1Y3Rpb25zLmRlL2x3aXBkZXYuaHRtbA0KICAgIGkgd2FudCB0byBnZXQgbHdp cC0wLjUuMy13aW4zMi56aXAgLHdobyBjYW4gc2VuZCBpdCB0byBtZSAsdGhhbmtzLg0KICAgIERv ZXMgc29tZW9uZSBjYW4gc2hvdyBtZSBhIHRvdGFsIHZlcnNpb24gYXJjaCBmaWxlcyB0aGF0IGNh biB1c2UgaW4gd2luMzIgPz8/DQogICAgVG8gdXNlIEJTRCBzb2NrZXQgbXVzdCB1c2Ugc2VtIGlu IHN5c2FyY2guYyxhbmQgdG8gdXNlIHBwcCBtdXN0IHVzZSBzZXJpYWwgaW4gc2lvLmMNCglpIGRv bnQga25vdyBob3cgdG8gd3JpdGUgaXQgaW4gd2luMzIscGxlYXNlIHNob3cgbWUgYSBzYW1wbGUu DQoJDQoNCg0KoaGhoaGhoaGhoaGhoaGhoXhjYm1hbkAyMWNuLmNvbQ0KoaGhoaGhoaGhoaGhoaGh oaGhoaEyMDA0LTA3LTI1DQo= From MAILER-DAEMON Thu Jul 29 05:47:47 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bq7Vr-00031B-4f for mharc-lwip-devel@gnu.org; Thu, 29 Jul 2004 05:47:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bq7Vp-000312-UF for lwip-devel@nongnu.org; Thu, 29 Jul 2004 05:47:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bq7Vo-00030i-8x for lwip-devel@nongnu.org; Thu, 29 Jul 2004 05:47:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bq7Vo-00030Y-3b for lwip-devel@nongnu.org; Thu, 29 Jul 2004 05:47:44 -0400 Received: from [131.111.8.138] (helo=ppsw-8.csi.cam.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bq7SJ-0000sy-E1 for lwip-devel@nongnu.org; Thu, 29 Jul 2004 05:44:07 -0400 Received: from kirin.eng.cam.ac.uk ([129.169.98.86]:39874) by ppsw-8.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:465) with esmtp (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.34) id 1Bq7SF-0002sL-R2 for lwip-devel@nongnu.org; Thu, 29 Jul 2004 10:44:03 +0100 From: "K.J. Mansley" To: lwip-devel@nongnu.org Content-Type: text/plain Organization: Message-Id: <1091094243.22438.20.camel@kirin.eng.cam.ac.uk> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 29 Jul 2004 10:44:03 +0100 Content-Transfer-Encoding: 7bit X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ X-Cam-AntiVirus: No virus found X-Cam-SpamDetails: scanned, SpamAssassin (score=0, FROM_CRSID -0.87, FROM_ENDS_IN_NUMS 0.87) Subject: [lwip-devel] 1.0 release and FAQ X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2004 09:47:46 -0000 Leon (and others), I have something that resembles some SACK functionality, and the changes to retransmission that Sam Jansen suggested, but don't want to commit these before you have made the 1.0 release. If you let me know when it is safe to do so, and which CVS branch I should use, I'd be very grateful. Once they're in they'll need a bit of testing as I don't have a setup at the moment that can exercise those bits of code. Also, do we have a facility whereby I can document the deficiencies in the SACK implementation? It's not really appropriate for the source, as I would intend it to be an answer to the question "Does lwIP support SACK?" that might be asked by someone investigating lwIP for the first time. I guess it might be appropriate for us to start a FAQ, and put things like this in it. Any thoughts on this? Thanks Kieran From MAILER-DAEMON Thu Jul 29 06:34:19 2004 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Bq8Et-00044z-Rt for mharc-lwip-devel@gnu.org; Thu, 29 Jul 2004 06:34:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bq8Er-00043X-Ih for lwip-devel@nongnu.org; Thu, 29 Jul 2004 06:34:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bq8Eo-0003yH-NQ for lwip-devel@nongnu.org; Thu, 29 Jul 2004 06:34:17 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bq8Eo-0003yC-LS for lwip-devel@nongnu.org; Thu, 29 Jul 2004 06:34:14 -0400 Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1Bq8BZ-0006xb-AN for lwip-devel@nongnu.org; Thu, 29 Jul 2004 06:30:53 -0400 Received: from [66.111.4.26] (helo=out2.smtp.messagingengine.com) by mx20.gnu.org with esmtp (Exim 4.34) id 1Bq88t-0004o2-HO for lwip-devel@nongnu.org; Thu, 29 Jul 2004 06:28:07 -0400 X-Sasl-enc: eY9YRr/B67/2iqGCBloCLg 1091096835 Received: from [10.1.0.26] (cp100353-a.tilbu1.nb.home.nl [217.121.63.140]) by www.fastmail.fm (Postfix) with ESMTP id 66727C12D16 for ; Thu, 29 Jul 2004 06:27:10 -0400 (EDT) Subject: Re: [lwip-devel] 1.0 release and FAQ From: Leon Woestenberg To: lwip-devel In-Reply-To: <1091094243.22438.20.camel@kirin.eng.cam.ac.uk> References: <1091094243.22438.20.camel@kirin.eng.cam.ac.uk> Content-Type: text/plain Message-Id: <1091096830.4026.57.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Thu, 29 Jul 2004 12:27:10 +0200 Content-Transfer-Encoding: 7bit X-BeenThere: lwip-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: lwip-devel List-Id: lwip-devel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2004 10:34:18 -0000 Hello Kieran, On Thu, 2004-07-29 at 11:44, K.J. Mansley wrote: > Leon (and others), > > I have something that resembles some SACK functionality, and the changes > to retransmission that Sam Jansen suggested, but don't want to commit > these before you have made the 1.0 release. > I have already tagged the 1.0 release branch point, so just go ahead and commit to HEAD. Its safe out there. > Also, do we have a facility whereby I can document the deficiencies in > the SACK implementation? It's not really appropriate for the source, as > I would intend it to be an answer to the question "Does lwIP support > SACK?" that might be asked by someone investigating lwIP for the first > time. I guess it might be appropriate for us to start a FAQ, and put > things like this in it. Any thoughts on this? > Two options I see: 1. We would use the JavaDoc @file attribute and write implementation information in full wording there (so tcp.c in this case). We then really need to add an automated way to create the JavaDoc extracted web page. ( I even forgot where the old one is hosted on Savannah... ) 2. Add a doc/faq.txt. I think the latter is easiest in the short term. Regards, Leon.