Re: [AUCTeX-devel] Integrating support for some viewers

[Arash Esbati]

Hi Mosè, hi Ikumi,

Mosè Giordano <address@hidden> writes:

> 2016-04-10 10:20 GMT+02:00 Ikumi Keita <address@hidden>:
>> Hi AUCTeX developers,
>>
>> Some time ago, support for various viewers were added to tex.el.  Part
>> of those changes were already present in tex-jp.el, so support for some
>> viewers are devided between the two files now.
>>
>> How about integrating support for viewers common to the two files into
>> tex.el?  Take a look at the attached patch, please.
>
> Thanks for your patch, looks good to me.

Just out of curiosity: Is there a particular reason why the remainder in
tex-jp.el, namely:

--8<---------------cut here---------------start------------->8---
(unless (get 'TeX-view-program-list 'saved-value)
  (setq TeX-view-program-list
       (cond
        ;; http://oku.edu.mie-u.ac.jp/~okumura/texwiki/?AUCTeX
        ((eq system-type 'windows-nt)
         '(("TeXworks" "TeXworks %o" "texworks")
           ("MuPDF" "mupdf %o" "mupdf")))
        ((eq system-type 'darwin)
         '(("TeXShop" "open -a TeXShop.app %o" "open")
           ("TeXworks" "open -a TeXworks.app %o" "open")
           ("PictPrinter" "open -a PictPrinter.app %d" "open")
           ("Mxdvi" "open -a Mxdvi.app %d" "open")))
        (t
         (setcar (cadr (assoc "xdvi" TeX-view-program-list-builtin))
                 "%(xdvi) -unique")
         '(("TeXworks" "texworks %o" "texworks")
           ("MuPDF" "mupdf %o" "mupdf"))))))
--8<---------------cut here---------------end--------------->8---

shouldn't move into tex.el as well?

Best, Arash