Re: [AUCTeX-devel] A patch to fix auctex.texi

[Mosè Giordano]

Hi Arash,

2016-06-29 9:43 GMT+02:00 Arash Esbati <address@hidden>:
> Hi Mosè,
>
> Mosè Giordano <address@hidden> writes:
>
>> 2016-06-28 18:08 GMT+02:00 安宅 正之 <address@hidden>:
>>> Hi, Tassilo
>>>
>>> I failed to makeinfo around L2600 in doc/auctex.texi
>>> because @AUCTeX missed braces `{}',
>>> which was introduced by you on 2016-05-27.
>>>
>>> I would like to fix this issue if you don't mind it.
>>> A patch is attached.
>>
>> Patch installed, thank you!
>
> I tried to build the documentation with
>
>   pdftex auctex.texi
>
> with texinfo.tex version 2016-06-18.21 and pdftex says:
>
>   ./macros.texi
>   ! Undefined control sequence.
>   l.67 \toks0\expandafter{\commondummies
>
> This is due to change 7189 in texinfo.texi
>
>   http://svn.savannah.gnu.org/viewvc?view=rev&root=texinfo&revision=7189
>
> which renames commondummies to definedummies.  pdftex chokes on AUCTeX's
> macros.texi:
>
>   \toks0\expandafter{\commondummies
>     \def\TeX#1{TeX#1}%
>     \def\LaTeX#1{LaTeX#1}\def\previewlatex#1{preview-latex#1}}
>
> This patch cures the issue:
>
> diff --git a/doc/macros.texi b/doc/macros.texi
> index fdf37a0..e8feed3 100644
> --- a/doc/macros.texi
> +++ b/doc/macros.texi
> @@ -64,10 +64,10 @@ font-latex
>    \def\TeX#1{TeX#1}%
>    \def\LaTeX#1{LaTeX#1}\def\previewlatex#1{preview-latex#1}}
>  \xdef\indexnofonts{\the\toks0}
> -\toks0\expandafter{\commondummies
> +\toks0\expandafter{\definedummies
>    \def\TeX#1{TeX#1}%
>    \def\LaTeX#1{LaTeX#1}\def\previewlatex#1{preview-latex#1}}
> -\xdef\commondummies{\the\toks0}
> +\xdef\definedummies{\the\toks0}
>  \ifx\acronym\undefined \gdef\acronym#1{{\smallcaps \lowercase{#1}}} \fi
>  \ifx\env\undefined \global\let\env=\code \fi
>  \ifx\option\undefined \global\let\option=\samp \fi
>
> Should I apply it?  It will probably break for older texinfo.tex
> versions.

Thank for the report.  I would use a conditional to test which command
is defined, see for example http://www.tex.ac.uk/FAQ-isdef.html

Bye,
Mosè