[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[AUCTeX-devel] [gmane.emacs.auctex.diffs] GNU AUCTeX branch, master, upd

From: Arash Esbati
Subject: [AUCTeX-devel] [gmane.emacs.auctex.diffs] GNU AUCTeX branch, master, updated. a16a5107845aee83e6e52dd6d8cfbbe90bd6303d
Date: Thu, 10 May 2018 14:10:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3

Hi Keita,

I think this patch will not work as expected.  `cl-caddr' is a function
and not a macro[1].  Thus, `eval-when-compile' will not expand
`cl-caddr' at compile-time and you get a dependency at run-time.  Until
now, AUCTeX policy was to be independent from other packages at
run-time.  I would be open to discuss if we want to change this.

--8<---------------cut here---------------start------------->8---
commit a16a5107845aee83e6e52dd6d8cfbbe90bd6303d
Author: Ikumi Keita <address@hidden>
Date:   Thu May 10 17:54:53 2018 +0900

    Replace another cl function with cl-lib
    * style/pstricks.el (eval-when-compile): Require cl-lib.
    (LaTeX-pst-cleanup): Replace `caddr' with `cl-caddr'.

diff --git a/style/pstricks.el b/style/pstricks.el
index e14b55b..9762b68 100644
--- a/style/pstricks.el
+++ b/style/pstricks.el
@@ -1,6 +1,7 @@
 ;;; pstricks.el --- AUCTeX style for the `pstricks' package.
-;; Copyright (C) 2007, 2009, 2013-2015 Free Software Foundation, Inc.
+;; Copyright (C) 2007, 2009, 2013-2015,
+;;               2018  Free Software Foundation, Inc.
 ;; Author: Holger Sparr <address@hidden>
 ;; Maintainer: address@hidden
@@ -60,6 +61,9 @@
 ;;; Code:
+  (require 'cl-lib))
 ;;; General Functions
 (defun TeX-arg-compl-list (list &optional prompt hist)
@@ -681,7 +685,7 @@ package PNAME"
        (cond ((string= type "object")
               (setq TeX-auto-symbol
                     (cons (list (nth 1 list)
-                                (caddr (assoc (nth 2 list)
+                                (cl-caddr (assoc (nth 2 list)
              ((string= type "fontdot")
--8<---------------cut here---------------end--------------->8---

Best, Arash


reply via email to

[Prev in Thread] Current Thread [Next in Thread]