[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wrong-type-argument stringp nil

From: Ikumi Keita
Subject: Re: wrong-type-argument stringp nil
Date: Thu, 21 Jan 2021 13:40:46 +0900

Hi Tassilo,

>>>>> Tassilo Horn <> writes:
> Ok, I've pushed two commits to master, each one fixing one spot
> introducing duplicate entries.

> modified   latex.el
> @@ -6217,8 +6217,9 @@ function would return non-nil and `(match-string 1)' 
> would return
>                      (cons (concat "\\" (nth 0 x)) (nth 1 x)))
>                    LaTeX-section-list)))
> -  (set (make-local-variable 'TeX-auto-full-regexp-list)
> -       (append LaTeX-auto-regexp-list plain-TeX-auto-regexp-list))
> +  (setq-local TeX-auto-full-regexp-list
> +              (delete-dups (append LaTeX-auto-regexp-list
> +                                   plain-TeX-auto-regexp-list)))

As discussed previously[1], `delete-dups'+`append' can be dangerous as
they may truncate list variable inadvertently. Though I think this
particular case is unlikely to suffer from such truncation, I'd propse
to install the attached defensive code. What do you think about this?

Ikumi Keita


Attachment: 0001-Prevent-inadvertent-destruction-of-list-variable.patch
Description: proposed fix

reply via email to

[Prev in Thread] Current Thread [Next in Thread]