bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: Silent make check -C examples


From: Akim Demaille
Subject: Re: FYI: Silent make check -C examples
Date: Fri, 14 Oct 2005 08:10:48 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

>>> "Paul" == Paul Eggert <address@hidden> writes:

 >> I don't see the connection.  Aren't you confused with set +x?

 > Yes I was, sorry.

 > I was confused because the ChangeLog entry talks only about being
 > quiet, and yet the patch removed the "set +e".  Shouldn't the removal
 > of "set +e" have been logged as well?

Well, it was stray and should not have been there.  I tend to drop
insignificant things from the ChangeLog.

 > Or perhaps the "set +e" should have been kept?  Presumably it was
 > there for a reason.  

I can see no good reason why I had put this set +e.  Set -e is a fine
person, but +e is not :)

I have checked in the following.

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * examples/calc++/test: Use set -x only when VERBOSE.

Index: examples/calc++/test
===================================================================
RCS file: /cvsroot/bison/bison/examples/calc++/test,v
retrieving revision 1.3
diff -u -u -r1.3 test
--- examples/calc++/test 10 Oct 2005 11:41:27 -0000 1.3
+++ examples/calc++/test 14 Oct 2005 06:10:36 -0000
@@ -2,6 +2,7 @@
 
 test -z "$VERBOSE" && {
    exec > /dev/null 2>&1
+   set -x
 }
 
 cat >input <<EOF
@@ -21,8 +22,6 @@
 EOF
 ./calc++ input
 
-set -x
-echo toto
 cat >input <<EOF
 toto := 1
 toto





reply via email to

[Prev in Thread] Current Thread [Next in Thread]