[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/11] build: include <config.h> from lib/yyerror.c

From: Akim Demaille
Subject: Re: [PATCH 06/11] build: include <config.h> from lib/yyerror.c
Date: Mon, 23 Jan 2012 11:04:29 +0100

Le 18 janv. 2012 à 16:18, Jim Meyering a écrit :

> Akim Demaille wrote:
>> Le 18 janv. 2012 à 11:30, Jim Meyering a écrit :
>>> From: Jim Meyering <address@hidden>
>>> * lib/yyerror.c: Include <config.h>.
>> I suppose this is to get #define fprintf and such?
> Right, and maybe even "const" on some crufty old systems.

Actually we have a problem here, and I don't know what
is the best means to address it (the problem is not new, it's
just more visible now).

yyerror.c is not used to compile bison, but liby, which
is there to please POSIX Yacc:

> # The Yacc compatibility library.
> EXTRA_LIBRARIES = lib/liby.a
> lib_liby_a_SOURCES = lib/main.c lib/yyerror.c

If I link liby again libbison, it goes from 6k to 864k.
What would you recommend?  I am personally in favor of
#undef fprintf in yyerror.c.  Or maybe there is a simple
means to cherry-pick what liby needs from gnulib?

This problem exists for real.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]