[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] do not ignore errors like ENOSPC, EIO when writing to stdout

From: Jim Meyering
Subject: Re: [PATCH] do not ignore errors like ENOSPC, EIO when writing to stdout
Date: Tue, 31 Jan 2012 10:03:21 +0100

Akim Demaille wrote:
> Le 30 janv. 2012 à 11:43, Jim Meyering a écrit :
>> Hi Akim,
>> So are these soft diagnostics important enough that their loss
>> (due to failed write-to-stderr) would merit inducing a nonzero
>> exit status?  Hey! I know... exit (0.5) :-)
> Don't use literals, prefer (EXIT_SUCCESS + EXIT_FAILURE)/2 :).
>> But seriously, I suppose a patch (maybe even a new gnulib module --
>> I haven't looked) would be welcome solely on principle.  Probably via
>> an atexit-callable function very similar to close_stdout.
> Actually close_stdout already does it.  You pushed it :)


> commit 7193a969abceafecf878f3efdcf996203e4a4daa
> Author: Jim Meyering <address@hidden>
> Date:   Fri Oct 6 13:59:10 2006 +0000
>>    if (close_stream (stderr) != 0)
>>      _exit (exit_failure);

Glad that's resolved.

> I confess I am a bit puzzled by the tendency in gnulib to document
> in the implementation file instead of the header.  Why is that?

>From a maintenance perspective, some of us find it a lot easier to
keep code and comments in sync when they reside in the same file.
Bruno prefers to do it the other way, so on this front,
gnulib is regrettably, not consistent.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]