[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] maint: simplify parse-gram.y

From: Akim Demaille
Subject: Re: [PATCH 2/3] maint: simplify parse-gram.y
Date: Wed, 9 May 2012 10:02:16 +0200

Le 6 mai 2012 à 11:27, Jim Meyering a écrit :

> Akim Demaille wrote:
>> Le 6 mai 2012 à 09:31, Jim Meyering a écrit :
>>> Pushed.
>> FTR, I have installed this.  Your regen step did not
>> use xmemdup0 for some reason, so the generated code
>> works, but breaks on the next regeneration.
> Ahh... my bad.  I merely rebased the 2nd of those 3 commits.
> I should have manually ensured that those files were regenerated.

And I guess the git rebase has restored younger mtimes
to the generated files after you modified the source one.

> I'm not used to having generated files under version control.
> IMHO, the fact that I ran "make distcheck" (and it did not
> regenerate those .[ch] files) means that there is room for
> improvement.
> What do you think about making "make distcheck" ensure that using
> the just-built bison induces no significant change in parse-gram.c?

Why not.  I kinda like the current setting, which avoids commits
which just change minor things (say the version of the bison
version that was used) in the generated files by leaving this in
the hands of the maintainers.  So if we find a means to avoid
gratuitous commits, I'm fine with this.

Bison uses itself to compile itself, via the test wrapper in
tests/.  We could extend it to ignore such minor differences.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]