[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use locale-indep. c_is* functions for parsing, not isspace,
Re: [PATCH] use locale-indep. c_is* functions for parsing, not isspace, isprint etc
Fri, 31 Aug 2012 17:40:12 +0200
Le 5 août 2012 à 13:37, Jim Meyering a écrit :
> Hi Akim,
> On bison's master, building on Fedora 17 with gcc version 4.8.0 20120803
> failed due to a missing declaration of isspace in parse-gram.y.
> It's best when parsing, to avoid using isspace and the other is*
> macros, because they use locale-dependent tables. Do you want a
> grammar to be accepted in one locale and rejected in another?
> Or worse: to succeed but generate a parser with subtly different semantics?
You are right, I was very naive.
> There was one other use of isspace in scan-gram.l, along with
> a use of isprint. This switches all of them to use gnulib's
> locale-independent c_-prefixed functions:
This is much better. Yet the error is in maint too, and I'm not
sure there won't be a Bison 2.6.3. Could you install it there?
I will merge eventually. If you don't have time or if it not
going smoothly, please just let me know!
(Shouldn't some gnulib's syntax-check apply here? Yes, some
isprint etc. are valid, but the warning can be disabled in that