bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Building and testing Bison 3.0.2 with MinGW [3/5]


From: Akim Demaille
Subject: Re: Building and testing Bison 3.0.2 with MinGW [3/5]
Date: Sat, 17 Jan 2015 18:11:50 +0100

Hi Eli!

> Le 17 janv. 2015 à 10:39, Eli Zaretskii <address@hidden> a écrit :
> 
>>> Or maybe the tests should do something else than LC_ALL=C to disable
>>>> internationalization?
>>> 
>>> The only thing that will work on Windows is to call 'setlocale' with
>>> LC_ALL=C, but I don't see how you can do that since Bison is a
>>> program, not a library.
>>> 
>>> What is the problem with my suggested fix?  If you don't like it in
>>> main.c, we could make it a function in some Windows-specific source
>>> file.
>> 
>> Yes, I'm trying to avoid any #ifdef in the code,
>> and to hide everything in the library.  In this case,
>> I'd prefer something in src/system.h than in src/main.c.
> 
> I can work on a patch like that, if you'd like me to.

That would be great, thanks!

>> Or a lib/setlocale.c, indeed.
> 
> That's gnulib, isn't it?  If we make the change there, the next time
> you update from gnulib, those changes will be obliterated.

We don't have any lib/setlocale.c afaict.  And lib/ is not
pure gnulib, some bits are specific to Bison.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]