[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dd PATCH: add conv=direct
From: |
Paul Jarc |
Subject: |
Re: dd PATCH: add conv=direct |
Date: |
Thu, 08 Apr 2004 15:51:11 -0400 |
User-agent: |
Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) |
Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> 2004-04-08 Jim Meyering <address@hidden>
>>
>> * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
>
> Doesn't that fix generate worse code in the usual case, since it
> causes two conditional branches instead of one?
I think it's unnecessary anyway - if old_flags is -1, then the
conditional jumps to error() before looking at new_flags at all.
paul
- Re: dd PATCH: add conv=direct, (continued)
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Valdis . Kletnieks, 2004/04/08
- Re: dd PATCH: add conv=direct, Bruce Allen, 2004/04/08
- Re: dd PATCH: add conv=direct, Paul Eggert, 2004/04/08
- Re: dd PATCH: add conv=direct, Jim Meyering, 2004/04/08
- Re: dd PATCH: add conv=direct, Paul Eggert, 2004/04/08
- Re: dd PATCH: add conv=direct,
Paul Jarc <=
- Re: dd PATCH: add conv=direct, Jim Meyering, 2004/04/08
- Re: dd PATCH: add conv=direct, Philippe Troin, 2004/04/08
- dd patch to remove noctty, Paul Eggert, 2004/04/08
- Re: dd patch to remove noctty, Jim Meyering, 2004/04/08
- Message not available
- Re: dd PATCH: add conv=direct, Paul Eggert, 2004/04/19
- Re: dd PATCH: add conv=direct, James Antill, 2004/04/20
- Re: dd PATCH: add conv=direct, Anton Blanchard, 2004/04/10
- Re: dd PATCH: add conv=direct, Wim Coekaerts, 2004/04/10
- Re: dd PATCH: add conv=direct, Jim Meyering, 2004/04/10
- Message not available
- Message not available
- Message not available
- coreutils patch to align buffers better, Paul Eggert, 2004/04/13