bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: fixed bug and leaks in remove.c on coreutils trunk


From: Jim Meyering
Subject: FYI: fixed bug and leaks in remove.c on coreutils trunk
Date: Tue, 04 Jul 2006 00:07:38 +0200

In case some application is using coreutils' revamped src/remove.c
(only on the trunk) in a context where small leaks triggered by unusual
conditions can make a difference, here's an FYI:

2006-07-03  Jim Meyering  <address@hidden>

        Plug another unusual leak.
        (AD_mark_helper): Free malloc'd filename if hash_insert says
        that string is already in the hash table.

        The dev/inode of the topmost directory in each hierarchy were not
        being recorded.
        * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
        (AD_push): Call it from here instead.

        Fix two small leaks.
        * src/remove.c (AD_stack_clear): New function.
        (rm_1): Use it.
        (AD_pop_and_chdir): Free *prev_dir just before longjmp.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]